summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2019-09-05loplugin:constmethod in cuiNoel Grandin41-92/+93
Change-Id: I06ffacbb02f3e9088e9c1a51e0e3e0d65d356f62 Reviewed-on: https://gerrit.libreoffice.org/78602 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-05loplugin:constmethod in chart2Noel Grandin22-31/+31
Change-Id: Ib97571b3750bd832d0d69a1530e6c8589134c633 Reviewed-on: https://gerrit.libreoffice.org/78601 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-05MSForms: Reorder categories in menuAron Budea1-9/+9
so it matches MSO's order: content controls, legacy form controls, ActiveX controls Change-Id: I348e49fe9118c397c18812a79c23aa89ab635a70 Reviewed-on: https://gerrit.libreoffice.org/78619 Tested-by: Jenkins Reviewed-by: Aron Budea <aron.budea@collabora.com>
2019-09-05tdf#127066 Font size of Calc input bar aligned to UI font sizeThorsten Wagner1-3/+0
Change-Id: I1f1aa4195c4b4be8987b0686d3f157ecea3fecce Reviewed-on: https://gerrit.libreoffice.org/78140 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-09-05tdf#125610: Revert "tdf#125088 Make button text white for blue buttons on macOS"Xisco Faulí1-10/+0
This reverts commit 89775fd396e413daaf0e71710211075450bdc0ed. Change-Id: I0ddbd454e53bcd442fdf2330661136e041c7d260 Reviewed-on: https://gerrit.libreoffice.org/78605 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-09-04Related: rhbz#1648281 improve fontconfig fallback for emojisCaolán McNamara1-1/+8
disregard text language for emoji and tag with und-zsye to get fontconfig to give us the default emoji font Change-Id: I8f94b0c41dea3204c9db77b96ad8f0d98bae2239 Reviewed-on: https://gerrit.libreoffice.org/78600 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-04Do not exclude Unicode noncharacters from rtl_convertUnicodeToTextStephan Bergmann11-50/+110
For one, that broke round-tripping with e.g. UTF-8 (see the test case added to Test::testComplex in sal/qa/rtl/textenc/rtl_textcvt.cxx) which did not treat noncharacters as invalid. For another, <https://unicode.org/faq/private_use.html#nonchar7> is meanwhile quite clear on the matter: "Q: Are noncharacters prohibited in interchange? "A: This question has led to some controversy, because the Unicode Standard has been somewhat ambiguous about the status of noncharacters. The formal wording of the definition of 'noncharacter' in the standard has always indicated that noncharacters 'should never be interchanged.' That led some people to assume that the definition actually meant 'shall not be interchanged' and that therefore the presence of a noncharacter in any Unicode string immediately rendered that string malformed according to the standard. But the intended use of noncharacters requires the ability to exchange them in a limited context, at least across APIs and even through data files and other means of 'interchange', so that they can be processed as intended. The choice of the word 'should' in the original definition was deliberate, and indicated that one should not try to interchange noncharacters precisely because their interpretation is strictly internal to whatever implementation uses them, so they have no publicly interchangeable semantics. But other informative wording in the text of the core specification and in the character names list was differently and more strongly worded, leading to contradictory interpretations. "Given this ambiguity of intent, in 2013 the UTC issued Corrigendum #9, which deleted the phrase 'and that should never be interchanged' from the definition of noncharacters, to make it clear that prohibition from interchange is not part of the formal definition of noncharacters. Corrigendum #9 has been incorporated into the core specification for Unicode 7.0. "Q: Are noncharacters invalid in Unicode strings and UTFs? "A: Absolutely not. Noncharacters do not cause a Unicode string to be ill-formed in any UTF. This can be seen explicitly in the table above, where every noncharacter code point has a well-formed representation in UTF-32, in UTF-16, and in UTF-8. An implementation which converts noncharacter code points between one UTF representation and another must preserve these values correctly. The fact that they are called 'noncharacters' and are not intended for open interchange does not mean that they are somehow illegal or invalid code points which make strings containing them invalid." Change-Id: I4fcc0156e3d2fd305a7c7bb0c7b3dbef846c9e64 Reviewed-on: https://gerrit.libreoffice.org/78598 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-04tdf#101977 change tracking: add 'Accept/Reject and jump to next' commandsGabor Kelemen7-2/+85
to Track Changes toolbar by creating the new Writer UNO command .uno:RejectTrackedChangeToNext and .uno:AcceptTrackedChangeToNext. Note: This feature is similar to what Word does by default. Change-Id: Ic5d7f5663217c605ccbee2f16b49e76522f911e6 Reviewed-on: https://gerrit.libreoffice.org/76719 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-09-04tdf#127189 FreeType <= 2.8 will fail to render stretched horizontal brace...Caolán McNamara3-0/+47
glyphs in starmath at a fairly low stretch ratio. The failure will set CAIRO_STATUS_FREETYPE_ERROR on the surface which cannot be cleared, so all further painting to the surface fails. This appears fixed in 2.9 with https://git.savannah.gnu.org/cgit/freetype/freetype2.git/commit/?id=91015cb41d8f56777f93394f5a60914bc0c0f330 "Improve complex rendering at high ppem" Change-Id: I8cbf8347ccd29beda4057b14f2e68678f6030bf4 Reviewed-on: https://gerrit.libreoffice.org/78587 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-04tdf#127304 Chart: fix rotation of multilevel axis labelsBalazs Varga3-5/+28
If the first level of horizontal category axis labels is rotated vertically, then the other levels should not be rotated. Regression from commit: 23c0b3e13f88d6d71d528777d4f86f50c0766672 (tdf#107074 uncommenting createLabels for the axis fixes the issue) Change-Id: Ia1978fdc345fa154cff2ea03d2a94475f73398a6 Reviewed-on: https://gerrit.libreoffice.org/78557 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-09-04[API CHANGE] rtl_convertTextToUnicode behavior upon erroneous inputStephan Bergmann14-32/+204
<http://udk.openoffice.org/cpp/man/spec/textconversion.html> specifies that FLAGS_UNDEFINED_ERROR, FLAGS_MBUNDEFINED_ERROR, and FLAGS_INVALID_ERROR: "Read past the [erroneous] code in the input buffer [...]" But actual behavior of rtl_convertTextToUnicode for the various rtl_TextEncoding values has been inconsistent. Some erroneous input (mostly single-byte UNDEFINED and INVALID ones) has not been consumed at all, some (multi-byte MBUNDEFINED and INVALID) has been consumed partly, and some has been consumed fully as required. However, at least since 8dd4265b9ddbd7786b6237676909eae5b540da0e "CWS-TOOLING: integrate CWS hb18", Custom8BitToUnicode in sw/source/filter/ww8/ww8par.cxx appears to rely on the broken behavior of not consuming erroneous input. (It reads the chunk of valid input with e.g. some RTL_TEXTENCODING_MS_125x that happens to exhibit the broken behavior of not consuming erroneous input, then wants to try to re-read the erroneous input with RTL_TEXTENCODING_MS_1252. For example, opening sw/qa/core/data/ww8/pass/forcepoint50-grfanchor-1.doc triggers that code. For whatever reason, the am_faksas.dot attached to <https://bz.apache.org/ooo/show_bug.cgi?id=9240#c1> "Do not show lithuanian letter 'Š'" appears to not, or at least no longer, trigger that code.) Therefore, it would be useful to have a mode in which rtl_convertTextToUnicode does not consume erroneous input. (And I plan on doing changes in sal/osl/unx/file* that would benefit from that behavior, too.) But changing rtl_convertTextToUnicode to generally not consume erroneous input would not be feasible: If calls do not set RTL_TEXTTOUNICODE_FLAGS_FLUSH, part of an erroneous input can already have been consumed by a previous call, so the current call cannot undo that. But a change that looks like it can work is to change the behavior only if RTL_TEXTTOUNICODE_FLAGS_FLUSH is set. In that case we can at least not consume the part of an erroneous input that has not yet been consumed by a previous call (which would necessarily have been done with RTL_TEXTTOUNICODE_FLAGS_FLUSH unset). The expecation is that code that relies on the don't-consume behavior will do only single calls with RTL_TEXTTOUNICODE_FLAGS_FLUSH set (so reliably not consume the complete erroneous input), while other code (which might do calls in a loop) will not care whether erroneous input has been consumed, anyway. This can be considered a mild form of behavioral API CHANGE (but note that the old implementation didn't exhibit the requested behavior anyway). So all implementations of rtl_convertTextToUnicode for the various rtl_TextEncoding values have been adapted to the new behavior. The only exceptions are ImplDummyToUnicode (sal/textenc/textcvt.cxx), which is a special case anyway used by RTL_TEXTENCODING_DONTKNOW, and two out of three places (marked with a "TODO" each) in ImplUTF7ToUnicode (sal/textenc/tcvtutf7.cxx), where it is hard to retrofit the expected behaivor, and RTL_TEXTENCODING_UTF7 is probably not relevant for the use cases relying on the don't-consume--behavior, anyway. Whether a similar change should be done for rtl_convertUnicodeToText can be examined later. Change-Id: I1ac2c4cfd99e2a0eca219f9a3855ef110b254855 Reviewed-on: https://gerrit.libreoffice.org/78584 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-04Fix typo in bug IDStephan Bergmann1-1/+1
The comment had been added with e38e3fc6c0ba5cef622f7412a573bd96c2476ca2 "#i9240# During 8bit conversion fallback to 1252 if a character is undefined in our source charset. Word appears to do this" (i.e., mentioning i9240 instead of i9241), and <https://bz.apache.org/ooo/show_bug.cgi?id=9240> "Do not show lithuanian letter 'Š'" looks more relevant here than <https://bz.apache.org/ooo/show_bug.cgi?id=9241> "The compound words �FAKSIMILINIS PRANE�IMAS� have to be Align Centered Horizontally." Change-Id: Idb1f50891cd01a96aee4ab19bb606b74a9050e1c Reviewed-on: https://gerrit.libreoffice.org/78583 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-04tdf#127116 DOCX export: fix hyperlink to bookmark target with spacesTünde Tóth5-2/+21
Conversion of spaces to underline characters was only in bookmark names, but not in the URLs using these bookmark names. Change-Id: Idb0d9945c79139d8a935ffcf6a3b29a9298c2270 Reviewed-on: https://gerrit.libreoffice.org/78267 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-09-04tdf#95848 writerfilter: DOCX import: fix mapping of w:abstractNumMichael Stahl9-8/+86
The problem is that the bugdoc has multiple w:num numbering definitions that refer to the same w:abstractNum abstract numbering definition. Apparently (and i can't find this documented anywhere) w:abstractNum corresponds to a SwList in Writer, i.e. all w:num that refer to the same w:abstractNum share the same numbering tree, but they may have different numbering properties via w:lvlOverride. So i think this should be imported as a single SwList per w:abstractNum, and every use of w:lvlOverride should create a new SwNumRule, but still share the same SwList; the previous situation was a SwNumRule + SwList per w:num element. This implements simply a SwNumRule per w:num (regardless of w:lvlOverride) because that was easy; the AbstractListDef class gets a member to store the ListId of the created SwList when any of its associated w:num / ListDef is used first, and the non-first ones get this ListId set to force them into the same SwList. Unfortunately it turns out the export has the same SwNumRule->w:abstractNum problem, which remains to be fixed. Change-Id: I92ce989afd15f24e36b6be6ccaf67ba3e0128963 Reviewed-on: https://gerrit.libreoffice.org/78556 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-09-04tdf#125330 Disable Filter and Change Table buttonsKelemen Gábor1-0/+3
in the Select Address List dialog if there are no entries Change-Id: Iaff60bd0e031884bf1032cf656260353f48ce60d Reviewed-on: https://gerrit.libreoffice.org/77025 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-09-04reduce Primitive2DContainer copyingNoel Grandin11-20/+22
Change-Id: I418b17034c1949ddda1de7025821ca51f4cdb018 Reviewed-on: https://gerrit.libreoffice.org/78579 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-04tdf#118314 Code clean up on imestatuswindowSzabolcs Toth35-1179/+13
Change-Id: I8bc5a73a91f28fcfd22ef716e9cf87d53997b1ad Reviewed-on: https://gerrit.libreoffice.org/77337 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: László Németh <nemeth@numbertext.org>
2019-09-04tdf#93476 Sort Macro library list after creating/importing a macroAndreas Heinisch2-8/+9
Only set the widget as sorted in the ctor, it remains sorted Change-Id: I96897cf5512e91192c69874ca857a967b09a1490 Reviewed-on: https://gerrit.libreoffice.org/76866 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-09-04tdf#127110 XLSX export: fix bad view positionLászló Németh2-2/+5
Update SheetView attribute topLeftCell only in the case of embedded OLE sheets. Regression from commit 3707e2a7b8b05617b0afb75374f866c967593861 "tdf#122624 XLSX OLE in DOCX: export view positions". Change-Id: I9ea57ff1531d710bff34df12fb7e0bb1e3edbea5 Reviewed-on: https://gerrit.libreoffice.org/78570 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-09-04loplugin:constmethod in filterNoel Grandin13-28/+28
Change-Id: Ib337c45c0ee7de881313b000bf2f8d816fd17884 Reviewed-on: https://gerrit.libreoffice.org/78565 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-04loplugin:constmethod in formulaNoel Grandin10-28/+28
Change-Id: Iae40405e7805b7c7ce3ce7f4b3653094fd49f396 Reviewed-on: https://gerrit.libreoffice.org/78564 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-03Make Noto Color Emoji font work on LinuxKhaled Hosny4-32/+34
Noto Color Emoji is a bitmap color font, Cairo knows how to scale such fonts and FontConfig will identify them as scalable but not outline fonts, so change the FontConfig checks to checks for scalability. Make sft.cxx:doOpenTTFont() accept non-outline fonts, the text will not show in PDF but that is not worse than the status quo. Change-Id: I756c718296d2c43e3165cd2f07b11bbb981318d3 Reviewed-on: https://gerrit.libreoffice.org/78218 Tested-by: Jenkins Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2019-09-03Ensure that VCL builder entry points use proper function typeMike Kaganski18-16/+66
This removes duplicating typedefs from NotebookBarAddonsMerger, and removes dependency of include/vcl/builder.hxx on include/vcl/NotebookBarAddonsMerger.hxx. Change-Id: Ica5787c934d1b8ce21623f28ce155337637fdf54 Reviewed-on: https://gerrit.libreoffice.org/78549 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-09-03Missing includeMike Kaganski1-0/+2
Change-Id: If9bd77b2bfcdddb1d131ad16481e83fa970af4a8 Reviewed-on: https://gerrit.libreoffice.org/78576 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-09-0366537 was an issuezilla bugCaolán McNamara1-1/+1
Change-Id: I17f55b445823a62f2396c4d5a30041c55bd87494 Reviewed-on: https://gerrit.libreoffice.org/78563 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-03Fix typoAndrea Gelmini3-3/+3
Change-Id: I63b774a1c8f64c2f736202ed73acfe2fe2718591 Reviewed-on: https://gerrit.libreoffice.org/78572 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-09-03Fix handling of invalid bytes >= 0x80 in ImplUTF7ToUnicodeStephan Bergmann2-7/+31
Change-Id: I08838f9ae34a31712d7269ddaaee3fe59ece2178 Reviewed-on: https://gerrit.libreoffice.org/78562 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-03tdf#127093 mysqlc: set NO_AUTO_VALUE_ON_ZEROTamas Bunth1-1/+2
Without setting this sql_mode, NULL or 0 inserted to an auto-incremented column of a prepared statement would cause that to be auto generated. Setting NO_AUTO_VALUE_ON_ZERO allows us to copy/paste auto-incremented columns which may contain zero values as well. Change-Id: I9602746371c75c82c99ff63240025e8cfb03776a Reviewed-on: https://gerrit.libreoffice.org/78560 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2019-09-03Revert "tdf#127093, tdf#127092 Fix pasting autoincremented"Tamas Bunth2-9/+0
This reverts commit fa177231cd20bf3c3f4bb9b50f6646da139c6766. Change-Id: Ia0c2d83c840c0ff8981b721766a6a1df810f971d Reviewed-on: https://gerrit.libreoffice.org/78559 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2019-09-03Missing includeMike Kaganski1-0/+1
Change-Id: I2d45d55c30914953f7478071ce3320d9974ca497 Reviewed-on: https://gerrit.libreoffice.org/78571 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-09-03tdf#127272 Writer crash issue resolveSumit Chauhan1-7/+4
Change-Id: Ibbdc10cc11170b8d8d55c42e6626d064ce4ef702 Reviewed-on: https://gerrit.libreoffice.org/78427 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2019-09-03tdf#127277 Move Insert->QR code menu item to Insert->Object->QR codeRoman Kuznetsov5-5/+5
Change-Id: I3c0a1d53768e9235aa34f6c6b33333367d03f19d Reviewed-on: https://gerrit.libreoffice.org/78535 Tested-by: Jenkins Reviewed-by: Roman Kuznetsov <antilibreoffice@gmail.com>
2019-09-03Omission from commit fd67c89e52441387dffab1c788007271e717571bMike Kaganski1-1/+1
Change-Id: I979f2fea73379519d1707d28bdfccffdd977e5a2 Reviewed-on: https://gerrit.libreoffice.org/78551 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-09-03Missing includeMike Kaganski1-0/+1
Change-Id: Id92ee3b4c1099d51117de5fb09359777b4b354f4 Reviewed-on: https://gerrit.libreoffice.org/78566 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-09-03offapi: add 2 undocumented ParagraphProperties from CWS sw301bf04Michael Stahl1-0/+16
These exist since OOo 3.0.1 but were never documented; at least the ListLabelString looks generally useful. Append them instead of inserting them before OutlineLevel because the compare tool complains about the changed order. Change-Id: Ie70272913de3cc6df34295e68235651f0fa0f7e4 Reviewed-on: https://gerrit.libreoffice.org/78555 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-09-03Fix typosAndrea Gelmini1-1/+1
Change-Id: I5e93f59ad4b21f6e28be3481940cae406be6ae2d Reviewed-on: https://gerrit.libreoffice.org/77631 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-09-03Silence -fsanitize=object-size in --enable-optimized buildsStephan Bergmann3-3/+76
<http://clang.llvm.org/docs/UndefinedBehaviorSanitizer.html#available-checks> (as of recent LLVM trunk towards LLVM 10) states: "-fsanitize=object-size: An attempt to potentially use bytes which the optimizer can determine are not part of the object being accessed. This will also detect some types of undefined behavior that may not directly access memory, but are provably incorrect given the size of the objects involved, such as invalid downcasts and calling methods on invalid pointers. These checks are made in terms of __builtin_object_size, and consequently may be able to detect more problems at higher optimization levels." A `make check screenshot` with --enabled-optimized runs into two such issues that were not diagnosed with --disable-optimized, in both cases because a struct with an "idiomatic trailing dynamic array member" (statically declared to be an array of size 1) is allocated without any space for that array member, as the dynamic array size is 0 in the specific case: * For > [CUT] sc_ucalc > cppu/source/uno/copy.hxx:46:19: runtime error: member access within address 0x6020001aaa70 with insufficient space for an object of type 'uno_Sequence' (aka '_sal_Sequence') > 0x6020001aaa70: note: pointer points here > 2b 00 80 6a be be be be be be be be 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > ^ > #0 in cppu::allocSeq(int, int) at cppu/source/uno/copy.hxx:46:19 (instdir/program/libuno_cppu.so.3 +0x41f03f) > #1 in uno_type_sequence_reference2One at cppu/source/uno/sequence.cxx:813:20 (instdir/program/libuno_cppu.so.3 +0x41f03f) [...] the call to pNew = allocSeq( 0, 0 ); in uno_type_sequence_reference2One is inlined, so sal_uInt32 nSize = calcSeqMemSize( nElementSize, nElements ); in allocSeq is known to be too small. * For > testSignatureLineODF::TestBody finished in: 2044ms > engine-gpg.c:302:6: runtime error: member access within address 0x604001f24f10 with insufficient space for an object of type 'struct arg_and_data_s' > 0x604001f24f10: note: pointer points here > 6e 01 00 26 be be be be be be be be be be be be be be be be be be be be be be be be be be be be > ^ > #0 in add_data at workdir/UnpackedTarball/gpgmepp/src/engine-gpg.c:302:6 (instdir/program/libgpgme.so.11 +0x120c2b) [...] > make[1]: *** [solenv/gbuild/CppunitTest.mk:114: workdir/CppunitTest/xmlsecurity_signing.test] Error 1 the a = malloc (sizeof *a - 1); is apparently detected to be too small only with optimization enabled. In both cases, the solution is to operate on the too-small dynamically allocated object via a reinterpret_cast'ed pointer to some newly introduced "struct prefix" type. Change-Id: Ie814db1d00a439bb9189474b91d729e538e81984 Reviewed-on: https://gerrit.libreoffice.org/78548 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-03loplugin:constmethod in basicNoel Grandin30-96/+96
Change-Id: Ib2056ab8437e163c7ae42e3ab7a4a3f8b6cb80a2 Reviewed-on: https://gerrit.libreoffice.org/78547 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-03Resolves: tdf#127120 double selection in B&N dialogCaolán McNamara2-7/+27
because the list wants to ensure that at least one thing is selected and the multiselect is implemented with two events of deselect-all followed by select. post a user event on getting either deselect or select and process it once when the dust has settled Change-Id: I553bf23d7a8c4625a8706fb2df4b169d91b7ad32 Reviewed-on: https://gerrit.libreoffice.org/78541 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-03Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' - tdf#127287 Layer dialogue help button / page Change-Id: Ia4675e6ec73ae886ee3957266c4ec04c583eb3c1 Reviewed-on: https://gerrit.libreoffice.org/78418 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-09-03loplugin:constmethod in xmloffNoel Grandin31-61/+61
Change-Id: I79ff1001a3ac8fde10de1ab391772e2bfeb6a314 Reviewed-on: https://gerrit.libreoffice.org/78546 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-03indicate that SmEditAccessible is editableCaolán McNamara2-4/+5
and use TEXT_FRAME like calc and other similar users of of an EditEngine as a frame do. Change-Id: I9d73362aa44273f87b283fcfc508d27abb50cb40 Reviewed-on: https://gerrit.libreoffice.org/78420 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-03Resolves: tdf#127168 dismiss menu before executing sortCaolán McNamara1-1/+2
so any error dialog which are parented to the calc window are not hidden by the menu which is destined to be dismissed after the sort anyway Change-Id: I7c49737231901de0e61c290fe161d37809d68424 Reviewed-on: https://gerrit.libreoffice.org/78539 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-03Parent reference should be const in VCL builder entry pointsMike Kaganski17-31/+30
Change-Id: I2331e19f5e23e0dde8edd22befc7287515adf37e Reviewed-on: https://gerrit.libreoffice.org/78536 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-03Resolves: tdf#126911 make structure box expandableCaolán McNamara3-1/+8
Change-Id: Iaf0676b4889dc643d468af758ca0be9b609618c3 Reviewed-on: https://gerrit.libreoffice.org/78537 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-09-03loplugin:constmethod in svxNoel Grandin68-123/+123
Change-Id: I6ae7c04479e3ea8ecd7535c33224a5e7095b64bb Reviewed-on: https://gerrit.libreoffice.org/78396 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-03Fix typosAndrea Gelmini9-11/+11
Change-Id: I71bacf86938af2b89a706c435c4f72a194ec8343 Reviewed-on: https://gerrit.libreoffice.org/78417 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-09-03Fix typosAndrea Gelmini8-9/+9
Change-Id: I7eacff7dd5bf1e8ae70d2bca0bc852b8a45eeeec Reviewed-on: https://gerrit.libreoffice.org/78428 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-09-03Resolves: tdf#126935 a11y for hosted EditEngineCaolán McNamara14-174/+1437
move it to svx so we can reuse the a11y code in svx for EditEngines hosted in shapes to provide a11y for EditEngines hosted in a native widget Change-Id: I4068c413cdb8ddb0d0ef899774fbe9f65e1bdc60 Reviewed-on: https://gerrit.libreoffice.org/78407 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-03tdf#39593 Drop OToolBoxWindowItem::isWindowItemArkadiy Illarionov1-35/+13
Replace with comphelper::getUnoTunnelImplementation. Also use isUnoTunnelId(). Change-Id: I1cf42a483a5c2c9734e4c1f8dd3ba76fd9c7f5e6 Reviewed-on: https://gerrit.libreoffice.org/78429 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-27 14:34:55 +0000