summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2022-04-13Update remaining DevGuide wiki links.Ilmari Lauhakangas16-222/+222
My Kate editor decided to do some whitespace cleanup, but maybe it's fine as the main changes are not targeting functional bits anyway. Change-Id: I5292e77e43055f94a6256a7f72d49fd59287d194 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132928 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2022-04-13sd theme: add UNO API for shape fill color effectsMiklos Vajna4-0/+44
XColorItem::maThemeColor already provided the document model for this. Change-Id: Iefbd0aeaa37a813bb4c86386801e0116e8fae40d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132933 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-04-13vcl: move X11 drawing that uses cairo into X11CairoSalGraphicsImplTomaž Vajngerl9-367/+394
If cairo is available we override drawPolyPolygon and drawPolyLine with an implementation that uses cairo to draw instead of X11. This override was previously done in X11SalGraphics, but as we want to have all the drawing in backends (SalGraphicsImpl children) this also needs to be moved to one. In this case we can just derive X11SalGraphicsImpl and implement specifics there. As there is some common stuff now betwee X11SalGraphics and X11SalGraphicsImpl, also add X11Common, which includes those. Change-Id: Id1e0c5227506e03d3dd0f937e4ef50d69b17bb22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132827 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-04-12don't ignore GetDefPattern() in ScHorizontalAttrIteratorLuboš Luňák3-40/+65
As said in the previous commit, the default pattern is the default style that can be edited by the user, so it's principially incorrect to simply ignore it. If needed for performance, then it needs to be done explicitly. This change currently should not affect anything, as ScHorizontalAttrIterator is used only in tests. Change-Id: I31f153d427cdfd6e98a4d7a3584cfa89676d4c33 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132912 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-04-12don't artificially clamp attribute iterators rangeLuboš Luňák7-71/+6
Even ScDocument::GetDefPattern() can be modified by the user (it's the default style that can be edited), so it's conceptually incorrect to ignore it while iterating, and clamping to allocated columns is also no longer needed. If this makes some code slow, then that needs explicit handling in that code or some other way of speeding things up. Change-Id: I4a7c7fef0a8625b559bbce4580df19a5e9ed92a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132911 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-04-12don't FormatDoc() a whole long text if not necessary (tdf#144515)Luboš Luňák6-1/+38
The testcase has a very long text in a cell that is really high enough to hold only one line of text, yet EditEngine formats and wraps the entire string. Which can be expensive because of calling into text layout to find out width of a text portion, and this is done repeatedly for the yet-unformatted text, so pretty much O(N^2). For top-aligned text it's enough to format only as much as will fit and ignore the rest, so implement that and add EditEngine::EnableSkipOutsideFormat() to enable the optimization. Change-Id: Ida87a1843737a368798ba2b3e60eedc99ee0f611 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132932 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-04-12treat Calc cells that don't fit as top-aligned rather than bottomLuboš Luňák1-0/+5
For cells it normally looks better to align them to the bottom, but if the content doesn't fit, it looks better to align to top, because that shows the start rather than the end of the content, and it also logically goes together with the clip mark shown to the right of it. Change-Id: Iac51e9e59d5ab9f5c89374a3e638a4a572f8b1fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132931 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-04-12Remove need for OPropertyAccessor default ctorStephan Bergmann2-4/+4
Change-Id: Ia5ae4e28aa880600ce80bd284cde5183c49e4b40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132929 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-12gtk4: GtkCellRendererPixbuf no longer takes a surfaceCaolán McNamara2-10/+33
so use our own replacement when we want to continue to use a cairo_surface Change-Id: I4a1a0e7f5a86d27a4290cf71c0719ea017be3f0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132930 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-12ofz#46352 TimeoutCaolán McNamara1-2/+2
Change-Id: I4544c9c15ec26fb1c27ec0f28ef956320d06a149 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132900 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-12[loplugin:stringview] pass a 'std::string_view'Caolán McNamara1-1/+1
Change-Id: If2e355729f051cd5be517fb05e8909844a24c7f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132927 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-12gtk4: add a surface_cell_rendererCaolán McNamara5-0/+275
to bridge our continuing usage of cairo and gtk4 GtkComboBox cell renderers without dropping any existing hidpi wins Change-Id: If5244766c13dd5d82445cb626ef4096e3c6ea244 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132926 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-12resave with latest gladeCaolán McNamara2-169/+175
Change-Id: Ib84f706deccc1f71810abc97a4208d5106826235 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132901 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-12ofz#46632 Direct-leakCaolán McNamara1-0/+9
Change-Id: I01fe4ae8907fb95708d54a39d1cc78d89b4d6e64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132893 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-12gtk4: cairo_gobject_surface_get_type() needs to be called at least onceCaolán McNamara1-0/+14
before "CairoSurface" can be resolved to its type, this worked in gtk3 because there was some fallback code which guessed what function name was needed to call to get it, but that's not present in gtk4 Change-Id: I85a957ecd37e0e7a572578e8273152fbb19dac3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132920 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-12UI Workaround for tdf#146653: change localized Source Han {Sans,Serif} CN...Kevin Suo1-12/+12
...to Source Han Sans CN Normal and Source Han Serif CN Medium for Simplified Chinese UI, so that the font shown is not bold. Tranditional Chinese and Japanese settings are not touched. It is up to the zh-TW and JA l10n team to decide whether to apply the same change. This does not resolve the bug itself, but makes the UI usable when the system has Source Han Sans CN or Source Han Serif CN fonts installed, so that the default font used is normal weight rather than bold. Change-Id: I52753448d886854d92ba8a26d8b03bf42522735f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128798 Tested-by: Jenkins Reviewed-by: Franklin Weng <franklin@goodhorse.idv.tw> Reviewed-by: Eike Rathke <erack@redhat.com>
2022-04-12odk: update DevGuide wiki links and correct history in footerIlmari Lauhakangas6-27/+21
Change-Id: I95c78d1346d354b755aeecaa1e6c9d789be0b693 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132905 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2022-04-12compress row height calculation (tdf#148492)Luboš Luňák1-1/+7
Change-Id: I42346472485f00bd64d08d2e2d0aef0ec02423f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132897 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-04-12bail out of the loop when the item is foundLuboš Luňák1-4/+3
Change-Id: If0816f38eeeb3330738ab40bc8a72f1e14575c33 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132904 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-04-12Fix unoidl-read invocationStephan Bergmann1-1/+1
...that had inadvertently been missing from bb64cd2884beb03a2d578ada10abdb3e0df22778 "Add unoidl-read to the SDK" Change-Id: I4003e1dede9c8d6caf036534f4c3d0e59a24da14 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132903 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-12Recheck modules [uU]* with IWYUGabor Kelemen108-170/+48
See tdf#42949 for motivation Change-Id: If710445176681de8e0a0b6c65f58ecaca19dbccf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132768 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-04-12ofz#46639 TimeoutCaolán McNamara1-0/+7
Change-Id: I04f61749104bd21fa53edefd57a737d85c1d4faa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132898 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-12ofz#46638 Integer-overflowCaolán McNamara1-1/+4
Change-Id: Iaf3a6d1b5db1428a4cdfa440ac3484d115a491cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132896 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-12drop unused width variableCaolán McNamara1-9/+9
Change-Id: I836234f86c01300d1a55e901699fee840efb37dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132895 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-12ofz#46352 assert on bad string offsetCaolán McNamara1-1/+1
Change-Id: I60123fd0460b8038f08582a0bcbf2307af321df1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132899 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-12tdf#148423: subsequent_filters_test2: Add unittestXisco Fauli2-0/+19
Change-Id: If630a0e0fe6370212c9d54a58b1b84dbe8b2dc64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132892 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-04-12tdf#148115 Qt handle tooltips via event loopJan-Marek Glogowski4-3/+29
Instead of calling QToolTip::showText directly from LO, this defers showing the tooltip to the QEvent processing, which takes the tooltip timeouts into account. So tooltips are shown with a slight delay, therefore they happen less fast on mouse move, reducing / avoiding artifacts of fast changing windows. This unfortunately comes with yet an other hack in the area of our fake popup windows... New handling is based on the code of the Qt Tool Tips example. Change-Id: I42634ad36dd12171c30f52f07a02a88d3c48a718 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132841 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2022-04-12use gb_DEBUGINFO_FLAGS consistently in gbuild ExternalProject'sLuboš Luňák48-71/+86
A number of them didn't use it at all, others had it hand-written in various ways. Change-Id: Iaf86325f9cdc032926bac917dc3eef4e34661544 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132818 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-04-12ofz: Use-of-uninitialized-valueCaolán McNamara1-1/+1
Change-Id: I87cfad2da9b90bc4487dc4deb2fda5bb31a6b763 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132888 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-12include OutputDevice MapMode in SalLayoutGlyphsCache key (tdf#148400)Luboš Luňák8-1/+46
The mapmode also affects the layout of the glyphs. Change-Id: I9492bc4d3d9e991ef8ab5dc30ce424e44cbc79f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132822 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-04-12loplugin:stringview more o3tl conversionNoel Grandin87-163/+252
look for call sequences that can use string_view and the new o3tl functions in o3tl/string_view.hxx Also add a few more wrappers to said #include file Change-Id: I05d8752cc67a7b55b0b57e8eed803bd06bfcd9ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132840 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-04-12tdf#148491 Qt reconnect the QMenuBar close buttonJan-Marek Glogowski1-0/+6
When the QMenuBar of a QMainWindow is replaced, an existing corner widget is preserved / transferred, but its connections are still severed; a bit unexpected... The documentation for QMenuBar::setCornerWidget is not really clear what is happening, but the code has this nice comment: "// Reparent corner widgets before we delete the old menu". At least there is no need to explicitly delete the button. Still we must reconnect an existing button on each SetFrame. Regression from commit 9c4ef8ce3183e27ca174475cf4a8d15cc0368f60 ("tdf#145954 Qt unshare QMenubar usage"). Change-Id: I13c31734e665b78231a08cd76ca6305122e08879 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132836 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-04-12use cairo_font_face_t* instead of void* + castingCaolán McNamara1-8/+8
Change-Id: If3f5883790e4eee4dd4c519074b02d9cc2eda86c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132889 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-04-12Pick better type for a variableStephan Bergmann1-2/+3
Change-Id: I30916b188c7f8de06aec0719e79aa134a3250aef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132890 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-12tdf#148380 docx export: support CREATEDATE without formatJustin Luth3-3/+12
When CREATEDATE is given as a field command without the optional format string, then export was treating it as bWriteExpand (aka ww::eUNKNOWN) and just dumped out the field name. Instead, accept an empty string as a valid number format in order to maintain it as a field. In order to do this, we have to also turn off write-expand for fixed fields, since import always treats CREATEDATE as FIXED. The other existing example is writerfilter/qa/cppunittests/dmapper/data/create-date-preserve.docx DOC: not yet importing as FIXED RTF: seems to just ignore bWriteExpand and does the right thing anyway. Change-Id: If0aef38f6730f55b5fa1be6a62e0b6a0b4871658 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132662 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-04-12tdf#143148 Use pragma once instead of include guardsShady Mohamed2-8/+2
Change-Id: I6262d64edcff4e73f2b148e98a62ee8d4b0d3294 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132839 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2022-04-12Delete tempfile when doneStephan Bergmann1-1/+2
Change-Id: Ide7acab1ab8eae760f9818248ce44d07ca92a6f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132884 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-04-12libwebp is a C library, set CFLAGS and not CXXFLAGSLuboš Luňák1-1/+1
Change-Id: I79da4dcc61f50634dc8812dc5bf382053c170a9a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132817 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-04-12CppunitTest_sw_ooxmlexport8: avoid mustTestImportOf()Miklos Vajna1-10/+2
Can use CPPUNIT_TEST_FIXTURE() instead. See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd (CppunitTest_sw_rtfimport: convert one testcase to use CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation. Change-Id: I92e2c25121a543747471e4066b55ddaf87a7a88b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132874 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-04-12sw content controls: add initial DOCX exportMiklos Vajna5-0/+95
Wrap the text portions inside the content control inside <w:sdtContent> and <w:sdt>. Also map the (so far) single property of it to <w:showingPlcHdr>. This is just initial export for inline text content controls, more properties are to be added in follow-up commits. Change-Id: I21e085496b4c79114b158656c5611aff8ffdd08a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132875 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-04-12tdf#147876 Fix crash when cancelling Dialog import dlgSamuel Mehrbrodt1-1/+1
Regression from 9a55b97e980bbf2a0ce12841f6168f1f7545ac96 Change-Id: I3fc35981a0cb81e5b59236ec3b07450aec10541a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132737 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2022-04-12vcl: use auto delegate for X11SalGraphics and remove duplicatesTomaž Vajngerl3-314/+15
X11SalGraphics can derive from SalGraphicsAutoDelegateToImpl to remove many calls to the mxImpl, which can instead be done by the auto delegator. Change-Id: I7add2e824eb1be01f8d278e5af8a378a34b32671 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132826 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-04-12sw: document SwXMeta::ImplMiklos Vajna1-3/+7
It already had some comments, but turn it into markup that is picked up by doxygen + mention the locking aspect. Change-Id: I6d9dba02f5be2e6f262733dfc124f09e29ba47eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132838 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-04-12unit test: use temp copy in testInvalidEntrySave()Dennis Francis1-4/+26
Use a temporary copy of the source file to run this test otherwise it will execute a .uno:Save on the original document in the git tree! Change-Id: I673aad64453e72a9140efcad2b0ff9c0ceabc038 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132854 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-04-12tdf#56363 - UI test fails if the selected font is not presentAndreas Heinisch1-3/+4
Change-Id: Ic8ff99464b435169460d678590896decc91f5152 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132712 Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2022-04-11lok: run autofilter without timersSzymon Kłos1-2/+9
so we are sure we will get correct position Change-Id: Idd218e19b8b3f3d6da67e325472e11b5661bc3b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130725 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mert Tumer <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131123 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131512 Tested-by: Jenkins
2022-04-11tdf#148395: sw: Add UItestXisco Fauli2-1/+50
Change-Id: Id0e49ba6f0834dc85a26f4d9064dfe029a50fa35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132837 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-04-11lok: fix formulabar renderingSzymon Kłos2-2/+2
While forwardporting it was not taken into account that no pixel/logic conversion is needed. regression in: commit cf5b0d5972b02809e9b7f35780885445242b3f12 Author: Szymon Kłos <szymon.klos@collabora.com> Date: Mon Jan 17 13:11:19 2022 +0100 RTL: lok: render correctly interim windows Change-Id: Ic6716bf9335d4a9297e3e5edfeb161702b846efb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132424 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mert Tumer <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132809 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-04-11lok: use JsonWriter for annotations notificationSzymon Kłos1-28/+27
This will unify received objects in LOK. boost::property_tree used "string" for number values we expect them to be a "number" type. Change-Id: Ie90d7e2dd98bb371fc09878dcc6e96f4cdf73f3b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132054 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Dennis Francis <dennis.francis@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132808 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-04-11tdf#148481 Map RefHand cursor to Qt::PointingHandJan-Marek Glogowski1-1/+1
Change-Id: I79c7008655f22737f92a4a6430f1380e81c1c386 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132833 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>