summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2017-10-27external/curl: Work around clang-cl not knowing /FDStephan Bergmann2-0/+17
("IDE Minimal Rebuild", according to <https://msdn.microsoft.com/en-us/library/6ce2bkt7.aspx>) Change-Id: I1b549c50bea4285bc6c89302f757f2e7e0bf1784
2017-10-27drop stray debugging remnantsCaolán McNamara2-7/+0
Change-Id: I2684583643716103995c34de10b9eade91d8263b
2017-10-27Remove part of clang-cl workaround that is no longer neededStephan Bergmann2-6/+0
...after ColorSharedPtr is gone Change-Id: Id147e544e3b82577f4b7dbb5987472469782165f
2017-10-27Adapt loplugin:includeform to Windows \ path separatorStephan Bergmann3-13/+35
This can also call loplugin::isSamePathname with two paths that both contain backslashes, so finally make it (and hasPathnamePrefix) symmetric in which arguments my contain backslashes. Change-Id: I0465988d9d41e21c5660cbdbd1558543860ae1ad
2017-10-27tdf#113026: disable mpBoxLegend when legend not visibleXisco Fauli1-0/+1
Change-Id: Idc297808e1d95aecfd42e91a2aa7b99523ac7fb8 Reviewed-on: https://gerrit.libreoffice.org/43924 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
2017-10-27ofz#2947 check for input stream endEike Rathke1-1/+13
Change-Id: I48d43a358e9a8e37a3c862c310a2e4b2e756f536 Reviewed-on: https://gerrit.libreoffice.org/43937 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-10-27revert small part of previous commitNoel Grandin1-3/+2
not necessary after all Change-Id: I050ed0cc140969f2d32839f3a7841b240fd0efd0
2017-10-27extract some common code for checking if a functions address was takenNoel Grandin4-106/+138
Change-Id: I292b4e9bf17c83f83ff43ac4c5870d33092d0c71
2017-10-27-Werror=unused-functionStephan Bergmann1-67/+0
Change-Id: I2858c6cb74b96ffe6a799dc2ab02cbbe1c56abc7
2017-10-27ODP: export TextPreRotateAngleSzymon Kłos5-1/+28
Change-Id: I13eb005195ebbdee5016bf279cba423e388723a0 Reviewed-on: https://gerrit.libreoffice.org/43910 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2017-10-27use std::unique_ptr in SwUndoTransliterateNoel Grandin2-5/+3
Change-Id: I4c3480104cbec53a395bd11702949984fca452a0 Reviewed-on: https://gerrit.libreoffice.org/43899 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-27ofz#3830 Integer-overflowCaolán McNamara1-1/+6
Change-Id: Ia58552034aba32e9ecf00745d0cadc1e323c3c41 Reviewed-on: https://gerrit.libreoffice.org/43933 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-27...and one more fix for DbusIpcThread,Stephan Bergmann1-23/+4
switching back to a "Close" message-to-self without a response (as it had been before dc3ff192f3f048059cf149f416d0b237eb33b014 "Avoid further unwanted interference of DbusIpcThread::execute/close"). Especially on a first start of LO (where it restarts after creating the UserInstallation), it had been observed that DbusIpcThread::close was blocked waiting on a reply in dbus_connection_send_with_reply_and_block while DbusIpcThread::enable had already successfully (i.e., without emitting any of the SAL_WARNs) proceeded past sending the reply and was blocked on closeDone_.wait(). However that can happen---it should be clear by now that I don't understand anything at all about DBus. :( Change-Id: Id5f368a60b2d8dd8b7074308ac1ad6b6545131ff
2017-10-27emfio: don't reinvent read_uInt16s_ToOUStringMichael Stahl1-12/+1
Change-Id: Ib12923762b5dd4d255c89a5acc54fdc5678a58ed
2017-10-27remove GetSwapFloat nonsense from all 3 EMF readersMichael Stahl4-69/+0
SvStream::ReadFloat already does that, and SvStream is initialised to SvStreamEndian::LITTLE by default. Change-Id: I5859e43014533bcebef9d4b8f0678c516193b92e
2017-10-27use std::unique_ptr in SwLayouterNoel Grandin2-20/+12
Change-Id: I5e43710da971957af9953930dea7e103644d3f17 Reviewed-on: https://gerrit.libreoffice.org/43898 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-27ofz#3819 Integer-overflowCaolán McNamara2-2/+12
Change-Id: Ic45692152b039c0ee2f5659d7739c3a2517c5e83 Reviewed-on: https://gerrit.libreoffice.org/43876 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-27ofz#3826 Divide-by-zeroCaolán McNamara1-1/+1
with fLeftStart == 1.0 (is allowed, see comment at mfCut) the whole BezierSegment is needed and does not need to be cut at all so best would be to add it to 'while' loop, after that the 'rest' will be added anyways so, add 'fLeftStart < 1.0' or 'fLeftStart != 1.0' (since limited to [0.0 .. 1.0]) to the while in line 120 should do it Change-Id: Ida87e06247d169482df26e665985753e634e149e Reviewed-on: https://gerrit.libreoffice.org/43935 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-27ofz#3834 Divide-by-zeroCaolán McNamara1-0/+6
Change-Id: I654152b964c6228efeb8b7cc7203064338fd1dd6 Reviewed-on: https://gerrit.libreoffice.org/43934 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-27use std::unique_ptr in DocumentRedlineManagerNoel Grandin2-4/+2
Change-Id: Iba073b3a251827fefaba790e33dfc7c01b0b2154 Reviewed-on: https://gerrit.libreoffice.org/43897 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-27Better fix for CppunitTest_servicesStephan Bergmann3-5/+23
...than 25313923b08018bd837cfe3fc99a5e141602cafc "Fix CppunitTest_services for constructor-based implementations..." (which this commit reverts again). My claim that "the 'factory' would be the object itself" is nonsense, it would rather be an ImplementationWrapper (but one that was freshly created for each ServiceManager::createContentEnumeration). Change-Id: I85c683cff6f9ba78d0f8567a53f8fcbc56fe55cf
2017-10-27loplugin:constantparam was not always using canonical location for functionNoel Grandin1-5/+4
Change-Id: I8a15da534ba2cf9968cba0ee1f1bb74d7e3a0d54
2017-10-27no need to build the parent tree twiceNoel Grandin2-21/+8
lets just use the built in parents stuff Change-Id: I7bb705acfcd6c8c18168676b0cdb13c26ba5b95a
2017-10-27rename loplugin::Plugin::parentStmtNoel Grandin12-24/+24
to getParentStmt and rename parentFunctionDecl to getParentFunctionDecl, so I don't keep using accidentally naming my variables the same as the functions. Change-Id: I66f9452458c8b439e5132191ac5219fb6d420708
2017-10-27Updated coreCaolán McNamara1-0/+0
Project: help 4df523054a84cbade8cf2aff4f72400baca9ca55 Related: tdf#113455 update help to 'disable' the spinbuttons for special case now that there's a checkbox for the special 'clear' state rather than special empty spin button hackery to store this state Change-Id: I72756336a6c7fe68aec7efcf53e7b8dfb4c3d8d1
2017-10-27hwp fuzzing timeoutCaolán McNamara1-7/+8
Change-Id: I88656c558dfe1ef6e701ba54633bfe251bc4e279 Reviewed-on: https://gerrit.libreoffice.org/43884 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-27coverity#1420315 Unchecked dynamic_castCaolán McNamara1-3/+3
Change-Id: Ie522a0691ce269a4cc090057ddb54d8d0b1fa5e6 Reviewed-on: https://gerrit.libreoffice.org/43918 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-27support stock text in checkboxes and radiobuttonsCaolán McNamara1-0/+11
Change-Id: I03b2e125736b7f8a7127174a7a837760f76f8249 Reviewed-on: https://gerrit.libreoffice.org/43893 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-27Resolves: tdf#113455 Impossible to clear width/height in pagesCaolán McNamara5-77/+110
Change-Id: I88f80d417108822ceeb73c07cb49892925a2e57f Reviewed-on: https://gerrit.libreoffice.org/43891 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-27coverity#1420317 Unchecked dynamic_castCaolán McNamara1-2/+2
Change-Id: I33d065780ece2aab5f5a07d0dfd5493005a22b33 Reviewed-on: https://gerrit.libreoffice.org/43917 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-27ofz#3813 Integer-overflowCaolán McNamara1-1/+8
Change-Id: Ibc14583137aae0d46e501927e602a510339abe38 Reviewed-on: https://gerrit.libreoffice.org/43872 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-27ofz#3812 Divide-by-zeroCaolán McNamara1-3/+6
Change-Id: I1a278302b995137d3e73620c003534498a59ba14 Reviewed-on: https://gerrit.libreoffice.org/43870 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-27ofz#3811 Integer-overflowCaolán McNamara1-27/+22
Change-Id: Ia08ac1ae46d4af6df7b0a590752e17a6d9a6836e Reviewed-on: https://gerrit.libreoffice.org/43869 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-27tdf#113422 Crash in: ScPreview::MouseMove(MouseEvent const &)Noel Grandin1-1/+2
regression from commit 0ad8447d3199e1c1d1f7d6ddabc9b4cded99c2d6 dyncolcontainer: convert nRight to std::vector Change-Id: I9cdf80115a2be73ec2b30fd875a904de3333fddf Reviewed-on: https://gerrit.libreoffice.org/43905 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-27sw: clean up temporary debug code in frmpaintMiklos Vajna1-10/+0
Change-Id: I1bdb332e40a2cf612b249dafa7620f700af19833 Reviewed-on: https://gerrit.libreoffice.org/43927 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-10-27loplugin:finalclasses in scNoel Grandin29-160/+101
Change-Id: I83438eaf2c1045a9212a63ed9fd8b3371e9b06aa Reviewed-on: https://gerrit.libreoffice.org/43896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-27Revert "use rtl::Reference in SwChartDataSequence"Noel Grandin1-2/+6
This reverts commit cdd4b528a4d200aa322891373c80e2bc8e6cd16c. The manual acquire()/release() is necessary to prevent a double-delete if the exception is thrown Change-Id: I5acc0840befba3981e13b084b8d347f8a2766e70 Reviewed-on: https://gerrit.libreoffice.org/43889 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-27VisualStudioIntegrationGenerator: honor defines' valuesMike Kaganski2-2/+24
Before this, -D_WIN32_WINNT=0x0601 used to land to VS project simply as _WIN32_WINNT (without value). Change-Id: I68ebdc24c3181c5d9e046280756e4cefee3de46c Reviewed-on: https://gerrit.libreoffice.org/43928 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-10-27Replace lists by vectors in filtask (ucb)Julien Nabet2-91/+67
Change-Id: I5b4359727ebf58bc121325d490e63f2c919dd7ab Reviewed-on: https://gerrit.libreoffice.org/43921 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-27Fix typosAndrea Gelmini2-2/+2
Change-Id: I96f64b7c259f04a67684bb699ea3cc43b68e40fa Reviewed-on: https://gerrit.libreoffice.org/43913 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-27Replace list by vector in ucbstore (ucb)Julien Nabet1-8/+3
Change-Id: I1ff394ecd1fe805d671d666d8bc2522c33c40b50 Reviewed-on: https://gerrit.libreoffice.org/43922 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-27Implement LocaleData2, XLocaleData5, LocaleDataItem2, tdf#81671Eike Rathke3-4/+52
Change-Id: Idba5a30bc44c7b2bd951f954ea3bfd048b022660 Reviewed-on: https://gerrit.libreoffice.org/43920 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-10-26fix windows packagingThorsten Behrens3-4/+3
Change-Id: Id9e306877125b66f908d24048d236c55483330d0 Reviewed-on: https://gerrit.libreoffice.org/43916 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-10-26gbuild-to-ide: handle -U undefs correctlyMike Kaganski2-2/+12
Previously, defines string like this: -DDBG_UTIL -DNOMINMAX -D_DLL -UNOMINMAX would produce this defines list: DBG_UTIL;NOMINMAX;_DLL -UNOMINMAX where last "define" is incorrect; proper list should be DBG_UTIL;_DLL so that the undef'ed element would be properly eliminated from the result. This patch takes care of this. Change-Id: Ia66a1d6d0a6e0bbfd0022b22285b005609871336 Reviewed-on: https://gerrit.libreoffice.org/43923 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-10-26RepositoryExternal.mk: fix inverted gpg conditionMichael Stahl1-1/+1
(regression from 16598d526e9cc79698152daa5acc1e2718da933c) Change-Id: Ic621979926a9629aa8d8fb95a80957850ae0661b
2017-10-26Avoid undefined left shift of signed integerStephan Bergmann1-3/+3
...after 022b1b2a40fcaf8d201081dead44c1d3346d1972 "tdf#96505 Get rid of cargo cult long integer literals" Change-Id: I9e5cc9d63c2eddd1ad766c2f6b01a9ff49a09bfd
2017-10-26vcl: make MapMode constructor explicitMichael Stahl339-656/+670
Insert constructor everywhere, except a couple places that apparently want to compare GetMapUnit(). Change-Id: I1910deb60562e5e949203435e827057f70a3f988
2017-10-26vcl: print MapModeMichael Stahl1-0/+10
Change-Id: I3d4f15cd4929b553673f1a1d8950b6c9082a0cdc
2017-10-26tools: print some FractionsMichael Stahl1-0/+9
Change-Id: Idc4668cba7412d0b4a3e486a8629c7f95a701091
2017-10-26configure: JDK 1.3 won't workMichael Stahl1-1/+1
Change-Id: Ibd26816cb00b3b8b2514aca536906b689c8cbd5e