Age | Commit message (Collapse) | Author | Files | Lines |
|
otherwise it overrides the outer GdiMetaFiles efforts to position the
origin and the text is rendered off-canvas in this scenario
Change-Id: If81692dce81fb6f00d5051228e1de13cdcae1770
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148136
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Iabf1d4a672aa508c5143f12169678278186ddd47
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148139
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
it already has 123 tests
Change-Id: If9630e89b17cb68b23a0567b5a6cca33f4f32f92
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148135
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
I added the qualification at the last minute,
in imitation of other properties which according
to coverity scans could actually hit the qualifier.
Well, as Seth's testing shows, very often there is no
such oldvalue (for example on the default paragraph style),
and so this should not prevent us from setting something.
I can imagine that editEng paragraphs could issue an exception
if we try to set this property. However, in the testing I did
(against a comment's paragraph) this tab page did
not come up.
Change-Id: I0fcc45d100b01716b87316c1bbb9f69eb7c577f3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148129
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
|
|
> warn:vcl.builder:3976130:3976130:vcl/source/window/builder.cxx:480: DBG_UNHANDLED_EXCEPTION in VclBuilder
> when: Unable to read .ui file exception: com.sun.star.container.NoSuchElementException message: "file:///.../instdir/share/config/soffice.cfg/sfx/ui/tabbar.ui at /home/sbergman/lo/core/xmlreader/source/xmlreader.cxx:67"
> warn:sfx.view:3976130:3976130:sfx2/source/view/frmload.cxx:495: DBG_UNHANDLED_EXCEPTION in impl_handleCaughtError_nothrow exception: com.sun.star.container.NoSuchElementException message: "file:///.../instdir/share/config/soffice.cfg/sfx/ui/tabbar.ui at xmlreader/source/xmlreader.cxx:67"
Change-Id: Ie46f6c39f5d6cc4942d71c61bb5349ffe8f6a695
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148121
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
revert this part of:
commit 32dc2d14287a4210589c33dbd62c6e36e095aa6e
Author: Caolán McNamara <caolanm@redhat.com>
Date: Fri Mar 18 19:50:12 2022 +0000
ofz#45583 detect some invalid scale cases at import time
Change-Id: Ib80eda465d5b9d975a5b30974241d9f824c6741d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148130
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
As described in the original commit to address tdf#152073
("Glitch rendering line numbers in Basic IDE editor (kf5 only)"),
the fact that the KDE Breeze style's frame border is partly
transparent was causing artifacts in the Basic IDE:
commit 6f4b8b7cfe2907b7da46eec6951a0e09b836a6de
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Tue Jan 31 16:08:53 2023 +0100
tdf#152073 qt: Draw background when drawing frame
For native drawing of a frame (border), use
the window background color as default color.
As mentioned in commit f39f21d92ec83c3a5062f29dd26214fc83012c06
("tdf#138010 (IV) VclScrolledWindow: Use actual border width"),
the Qt/KDE Breeze style uses a frame width of 2, with the
actual 1 pixel border being surrounded by a 1 pixel
padding/margin.
Transparent background did not ensure that the 1 pixel
padding/margin is repainted and could thus result
in artifacts from what was painted to that location
previously (s. the Basic IDE editor example from
tdf#152073).
[...]
However, there are cases when a transparent background
is actually wanted, like in the print dialog (tdf#153895).
Therefore, revert the original commit mentioned above
and explicitly set a background color for the border windows
of the involved windows in the Basic IDE instead, which is
in line with the alternative already mentioned in the above commit
("An alternative might be to explicitly draw the
background further up the call stack, [...]."), but enables
transparency in the qt5/qt6/kf5-specific drawing for
the frame again.
Change-Id: Ifb4deb80c6ae245ec630a4fdc23f675e5587836c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148117
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Change-Id: I79328b4f26eeb01bfda0502657bf0d47f3699fdb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148123
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Disable since 7bb87abc0cc7b "fix upDown bar export to OOXML
We should not really export it as this leads to wrong import into MSO."
Change-Id: Ifcbb1200177b3cbd4966971c67d692c41e26827f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148128
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: I4ae3b23c616fc2ea40a5fdf8640bf5db0bb371ae
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148122
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Iddda2d30dce37fd90ce8c1834666f2baf8bd7fb3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148116
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
|
|
This suite is large enough so that avoiding the
declaration/registration/definition of each test manually saves a lot of
space.
Change-Id: I43d896e1bd9c70198fc43185da2e1016fc7586c9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148119
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: Ibd3b9a76b700a5efbf7855454714646daf612d13
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147675
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
This suite is large enough so that avoiding the
declaration/registration/definition of each test manually saves a lot of
space.
Change-Id: If59a6843dccad1e0cebbdbab05fdddbfdf778584
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147468
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Reuse existing mechanism to handle chart file names in tests.
See https://lists.freedesktop.org/archives/libreoffice/2023-February/089995.html
and 5f7861e6ce212f47420533aed302fa4b5510557d
"fix chart export tests correctly
we have a static counter that increments chart export file names. So
only the first exported file gets the file name chart1.xml and all the
following charts are incremented by one even if they are in a different
file."
Also add an assert to warn developers only 1 chart is allow per sample
document when parsing them.
Adapt a few tests to follow this rule and change file document
from testMultipleChart.docx to testExternalData.docx because
the name was misleading
Change-Id: Id7282049796f2b05492ab70b50c80065a99439be
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148065
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
This test should fail if oox/source/export/chartexport.cxx:970
is commented out
The reason is that the assert should have been
CPPUNIT_ASSERT(xmlXPathNodeSetGetLength(pXmlNodes));
instead.
Anyway, simplify it and just use assertXPath
Change-Id: Ie7ec10a70f7b447f92735d5c5b28d1074a9e4f98
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148118
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
In this patch, all the instances of sal_uLong in sw/source/ui/fldui/
folder are changed to better types.
The variable m_nOldFormat is changed to the type sal_uInt32 in fldfunc.hxx
as we have m_nOldFormat = GetCurField()->GetFormat() in fldfunc.cxx file
and GetFormat() return sal_uInt32. Also, the data type of variable nFormat
is changed from to sal_uInt32 as there is a conditional operation with the
sal_uInt32 output. This is also the case for other changed files.
The variable nFormat is changed to sal_uInt32 in files fldref.cxx and
fldvar.cxx.
Change-Id: I57ac03e48d4f0eecc96cfdbc19e92e00148f07d6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147881
Tested-by: Hossein <hossein@libreoffice.org>
Reviewed-by: Hossein <hossein@libreoffice.org>
|
|
no need to allocate separately where the contained class is only one
pointer big
Change-Id: Ibd31ff94c6fae6683d2784173057290dd547954e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148087
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
no need to allocate separately where the contained class is only one
pointer big
Change-Id: If5fac0b0e20f80bffebc8611791d07888cbec1e5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148089
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Iabbb29877c8dd2f7115b7466e9560e6296a894e5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146046
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
|
|
for wayland. If the popover window is the application window, contrain
it within the application window so it won't be cut off off screen,
because gtk under wayland just puts it when it wants to be regardless of
screen bounds.
Leave dialog hosted ones alone, like format, watermark, which are likely
presented in the middle of the screen and are too small to constrain the
popover inside.
Change-Id: Ibdc0749613a3b587414e88be7d0aea81c637f31a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148091
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
no need to allocate separately where the contained class is only one
pointer big
Change-Id: Iae64ad45ccd9b6f2cf3f463c4c17ae7f70db6a8e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148088
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I8b0083203daf7ae5b6c0e769d052f29c7294584f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148114
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
it is only one pointer big
Change-Id: I7c8c99c4dad4289e2f073d73e8b3703ee5c8e64e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148090
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
This stops run-time evaluation of the last char-run properties
on the paragraph - which were then applied to the numbering
character itself. This was done to imitate MS Word's ability
to format the CR itself - which similarly affected the numbering.
This awful hack has been slowly evicted as RES_PARATR_LIST_AUTOFMT
was created and rolled out to DOCX in 6.4, DOC in 7.5,
and now RTF in 7.5.1.
A change made in 7.2 (also made temporarily in 6.4 development)
looked not only at the start == end char run,
but also any run going past it/up to the end.
Although the 7.2 change helped some documents, it hurt others.
It can now be eliminated completely since RES_PARATR_LIST_AUTOFMT
handles that situation at import time.
Since this is a run-time layout adjustment, removing it should
have no impact on export. Any effect made to MS Format -> ODT
is likely incorrect as seen by various bug reports
like tdf#146168 and tdf#150613.
In the worst case, it would only be a few recent (7.2 - 7.5)
DOC -> ODT or RTF -> ODT migrations that will "look different".
Chalk those up to implementation errors that need to be corrected.
Change-Id: I4ae76008ffcbc5f19580b6ddca08197b7074e12c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148014
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
The constants are now of type sal_uInt8 as all of them are small and
will not exceed the limit. Also, they are not going to change after that
in the code.
Change-Id: I81d144bffe5c381f9280a4c364462e33b3a9a8b5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146721
Tested-by: Hossein <hossein@libreoffice.org>
Reviewed-by: Hossein <hossein@libreoffice.org>
|
|
The problem was that the follow frame's top was the 2nd page's top,
because we ignore the vertical offset for follow fly frames.
Ignoring the original offset is fine, but follow frames are still inside
the body frame in Word, so their offset is effectively the header / top
margin area.
Fix the problem by improving how nRelPosY is tweaked for follow fly
frames: an additional positive offset is wanted when the rel orient is
page.
With this, this bugdoc now renders perfectly.
Change-Id: Iec4b85339a7b4b69944d25eb2e06a6e3f977f093
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148086
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
it is only one pointer big
Change-Id: I116bd3713dab8568de56bb32c1ddbb83a1827f6f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148085
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
it is only one word big
Change-Id: I8b5fec4f44fcdeb2c22c00db2323e7427b11d209
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148084
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ifc16a5c7137776c8375d83afb031999023a7424a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148083
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Was missed in d0cacf09a1105d89bf3df84b18623d790e3aeb82
Change-Id: I43c1c9b595a8fc8e2982027093695556e182074e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148081
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
|
|
- assert IsFlySplitAllowed() in SwFrame::GetNextFlyLeaf(), since the
only caller is SwFrame::GetLeaf(), and it only checks this
- extend the conditions where we reject a candidate, make sure that a
master fly anchored in the body can't have a follow fly anchored in a
footer
- with this, the bugdoc is now of 2 pages, but still the position of the
follow is incorrect
Change-Id: Ibb02fe9cf741eecd60103179abcb44cee14e924d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148082
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
(see the comments at
<https://gerrit.libreoffice.org/c/core/+/146634/7#message-5164bcbdb4efa4711f001ce05b670b592392d853>
"test: Use css::awt::XExtentdedToolkit::addTopWindowListener()" for how this
caused an issue in the wild)
Change-Id: Id5ec77885db45d039aedc7e13d714aaa96572e91
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148076
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
It's an update and the name was not set. One has to dispatch
.uno:UpdateBookmark to see this in action, which does something if the
cursor is inside an exiting bookmark.
Change-Id: Ib9c54a28c5410cc001468952cfd8577a9412d664
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148073
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: Iab518e2cb994372b5d601c5cd569f07531499804
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148056
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I8aeb0d5ec44a938e58475368a3bf4ae60034042d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148057
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Iba2bee0feeea7cd176c178ae20e6dfce1fe4af19
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148055
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
I think the UI is working fine, but now LO is doing
things that it never used to do, so not all interactions
are working properly - so hide the ability for now.
Specifically, when changing the list level in a style,
it is not being applied to the existing paragraphs.
It only applies when the style is removed and re-added.
Change-Id: I092ac0e5ec7bf296d1f3b62b75d4f7209db00045
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148066
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
|
|
In order for this to be at all useful,
we need to be slightly confusing to the user
by equating both of Outline Level's "Body Text" and "1"
with List Level 1.
So, while outline levels can be "turned off" with "Body Text",
a user cannot "turn off" a list level,
even though the listbox has the choice "same as outline level".
The way to turn off the list is to pick "No List"
in the other list box.
That situation (Outline = Body Text, ListLevel = 1)
is the default situation, and so if we don't make that
connection, then the whole intention of STRONGLY
advocating for keeping the two values in sync will be lost.
Note that both selecting "No list" or changing list level
in a style does not have immediate effect. It only applies
when the style is assigned, not modified.
(I assume this is because of internal auto-styles
which are not being updated when the underlying style changes?)
[Because of this "strangeness" a follow-up commit
will make this an experimental feature.]
Change-Id: Ib6a47b3265ccf71f45a43ce6f10b780b995c231d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148027
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
|
|
it already has 121 tests
Change-Id: I7d7726b9f1c65d3f719517ab1a568cd888b2833b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148042
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
and
cid#1521558 Division or modulo by float zero
Change-Id: I42a82f294950ea22a2557f76d4589b06b50d9d46
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148071
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Initially there is 1 line and the edit is vertically centered in the
toolbar
Later, if expanded then the vertical position of the edit will remain at
that initial position, so when calculating the overall size of the
expanded toolbar we have to include that initial offset in order to not
make the edit overlap the RESIZE_HOTSPOT_HEIGHT area so that dragging to
resize is still possible.
Change-Id: Ic99e1cf4f3b1ca53c5d6feaa50d8bfac030f8124
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148069
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
and drop the never can be hit throw
Change-Id: I74c92f1ff50ef0f3f6f78a53057f121a3665ec3e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148072
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
and
cid#1521561 Dereference before null check
and drop pointless null check
Change-Id: I2e99733eb5f1861bb02f6d8ec7a44ace4ded16cd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148070
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Also removed the "_14" from the yes/no icons
Change-Id: Ic43219fe0e4555416b78831d45f9edc8060f73cc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148063
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
(regression from commit db115bec9254417ef7a3faf687478fe5424ab378)
Change-Id: Ib4865ad1423f0dafb20b376a9d00eaf450b8f271
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148049
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Tested-by: Jenkins
|
|
While RFC 2616 "Hypertext Transfer Protocol -- HTTP/1.1" defined
> http_URL = "http:" "//" host [ ":" port ] [ abs_path [ "?" query ]]
RFC 7230 "Hypertext Transfer Protocol (HTTP/1.1): Message Syntax and Routing"
defines
> http-URI = "http:" "//" authority path-abempty [ "?" query ]
> [ "#" fragment ]
Change-Id: I83b1baa404d28bf3b28b1db812f8930bbc1aaf90
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148064
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I267f3655dcc41613db9de4952beceb34dffefbac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148061
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I2bf478ea4f0d1a35def2455ec1e6480170c9f1ec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148047
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
...as requested at
<https://github.com/flathub/org.libreoffice.LibreOffice/issues/213> "Can Skia be
reenabled in the Flatpak build?" and implemented on Flathub for now with
<https://github.com/flathub/org.libreoffice.LibreOffice/commit/372d036e9113b6080780669ad44fc11a172356ed>
"Re-enable Skia". (This partially reverts
9d88f11de57bcbeb29fa6f1299d5d0867c1a75a4 "Flatpak: Upgrade to 21.08 runtime,
disable Skia".)
Change-Id: I50039d431fd3e6ba4c0d859d71e42e744433806b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148054
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|