summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2018-10-29Simplify conditions a bitMike Kaganski1-6/+6
bOn is implied when nCount is > 0 Change-Id: I77939668445603a22ae9ea56a7d272ca650c5c1c Reviewed-on: https://gerrit.libreoffice.org/62499 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-29tdf#120735 sw: clear the font cache text glyphs when layout finishedMiklos Vajna1-0/+4
The motivation for remembering the text glyphs was to avoid repeated layout calls during one sw layout run, this still preserves that optimization. Approximate numbers for memory usage after importing the bugdoc finished: - old: 401MB - new 366MB (91% of baseline) Change-Id: Ie960c606a8246c9c696745b2dcc9a49c3c570c07 Reviewed-on: https://gerrit.libreoffice.org/62496 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-10-29sw: prefix members of SwExtraPainterMiklos Vajna1-71/+71
Change-Id: I90a2f05d40f79c005bec6b4bdb42cc6603521a80 Reviewed-on: https://gerrit.libreoffice.org/62495 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-10-29tdf#120691 Migrate tables which contain spacesTamas Bunth1-0/+18
Change-Id: I115d765bc781a926189605990e91c8e47f24d474 Reviewed-on: https://gerrit.libreoffice.org/62403 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-10-29loplugin:shouldreturnboolNoel Grandin2-4/+2
return value is ignored by call site, so just drop it Change-Id: Ibba9b6b898d3277a44ccf864ba302d97282bffff Reviewed-on: https://gerrit.libreoffice.org/62494 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-29tdf#42949 Fix IWYU warnings in sc/source/ui/inc/[f-p]*Gabor Kelemen54-112/+60
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ie40401e8706dda219b8578d180983811114cabed Reviewed-on: https://gerrit.libreoffice.org/62208 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-29Use copied test docs in sw/qa/uitest/findReplace/findReplace.py, tooStephan Bergmann1-4/+3
No idea why this was initially commented out in 80d1ac7d55c22de20edeec30f8f56e09f8455f8d "uitest findReplace; tdf#116242; tdf#98417; tdf#39022". Change-Id: Ic1357118080bc117158bf23cd7bb14038a19169e Reviewed-on: https://gerrit.libreoffice.org/62493 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-29xmlsignaturehelper: fix comments, no changeTomaž Vajngerl1-19/+7
Change-Id: Ibfdf92712264ad37aafed53db0fe8e8c4fea4699 Reviewed-on: https://gerrit.libreoffice.org/61913 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-10-29xmlsecurity: UNO interface to create cert. and private keyTomaž Vajngerl2-0/+49
new XCertificateCreator interface which can be used to create a certificate and a associated private key, both in DER format Change-Id: I24caf053f1f2b7357a836047b88b4ce418470eac Reviewed-on: https://gerrit.libreoffice.org/61912 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-10-29Compensate for `set -u` when LO_ELFCHECK_WHITELIST is unsetStephan Bergmann1-1/+1
...as happens e.g. in <https://ci.libreoffice.org/job/lo_daily_update_gandalf/515/>. (Regression introduced with d157e510252636d3519c71415c20dfd113d40960 "check-elf-dynamic-objects: allow extending the whitelist via env-var".) Change-Id: I93097d0bb7781b1bfac818872f40bbe38c5f5fea
2018-10-29tdf#120874 Don't show menubar in other windows when one is closedSamuel Mehrbrodt2-1/+38
Change-Id: Id0b1af277bd7ec367525663ec6d478d67cde0a40 Reviewed-on: https://gerrit.libreoffice.org/62431 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-29Notebookbar: add context-Printpreview to calc tabbed NBandreas kainz2-0/+18
Change-Id: I9b63a515c407692f5632cb5e1f391593cfd68736 Reviewed-on: https://gerrit.libreoffice.org/62433 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-29Avoid SvxSearchController::StateChanged during SvxSearchDialog sub-dialogStephan Bergmann3-6/+24
UITest_findReplace occasionally fails (esp. in slowly-executing builds like the ASan+UBSan one, e.g., <https://ci.libreoffice.org/job/lo_ubsan/1084/>) because the "Find" edit is re-filled with old content while the "Format..." sub-dialog is executing: The SfxBindings::NextJob timer fires from the main thread's Application::Yield, calls SvxSearchController::StateChanged -> SvxSearchDialog::SetItem_Impl -> SvxSearchDialog::Init_Impl, which goes into the > else if (!aSearchStrings.empty()) > { > bool bAttributes = > ( ( pSearchList && pSearchList->Count() ) || > ( pReplaceList && pReplaceList->Count() ) ); > > if ( bSetSearch && !bAttributes ) > m_pSearchLB->SetText(aSearchStrings[0]); code re-filling the "Find" edit (despite it having been cleared programatically), because bAttributes is false because the "Format..." sub- dialog has not yet completed, so pSearchList has not yet been filled (as is done by the handle_format_dlg code in test_find_writer in sw/qa/uitest/findReplace/findReplace.py). (This issue can be triggered rather reliably by adding a sleep > @@ -94,6 +94,7 @@ class findReplace(UITestCase): > xSizeFont.executeAction("BACKSPACE", tuple()) > xSizeFont.executeAction("TYPE", mkPropertyValues({"TEXT":"16"})) #set font size 16 > xOkBtn = dialog.getChild("ok") > + time.sleep(1) > self.ui_test.close_dialog_through_button(xOkBtn) > > self.ui_test.execute_blocking_action(format.executeAction, args=('CLICK', ()), to sw/qa/uitest/findReplace/findReplace.py.) So suppress executing SvxSearchController::StateChanged -> SvxSearchDialog::SetItem_Impl while an SvxSearchDialog sub-dialog is in progress. The open TODO question is whether those state changes should be saved and executed once the sub-dialog has been executed, or whether it is OK to just throw them away (as happens now). Change-Id: I20fb8c8d88c3d3fe8b604718bb289a7421471aa7 Reviewed-on: https://gerrit.libreoffice.org/62489 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-29Drop unused headerGabor Kelemen2-72/+0
Found while cleaning up unotools with IWYU The same OStreamSection class is is implemented in comphelper about since 2c23e6959a2dfd45d904308e5c7dfe456408a652 (this was in 2000!) Change-Id: I464ece9ff84536d5332caa0f285856d3fe358e5b Reviewed-on: https://gerrit.libreoffice.org/62470 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-29lokit: test for the new signing API functionsTomaž Vajngerl3-31/+45
Change-Id: I3ab2f3986955eb82451704fc2386b64f208da554 Reviewed-on: https://gerrit.libreoffice.org/61782 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-10-29xmlsecurity: prevent seg. fault if there is no private keyTomaž Vajngerl1-5/+12
Change-Id: I8c6917c63bbdcf0d9bb2eb1c89745186feb263f8 Reviewed-on: https://gerrit.libreoffice.org/61781 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2018-10-29tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski17-332/+263
Change-Id: I0516dc68cf7d451eafc044be8e50a66d2bddf15f Reviewed-on: https://gerrit.libreoffice.org/62484 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-29tdf#108954 docxexport: only emit section if diff from currentJustin Luth2-1/+4
For the very last paragraph, if a header or footer was defined in the section, then a dummy section was always being added, but that should only happen if the section is different from the current one. If they are the same, then the pageDesc will be created anyway, so a dummy isn't needed to prevent it from getting lost. Change-Id: I5e3a53e2810622c7232aa23575740bd775c5a595 Reviewed-on: https://gerrit.libreoffice.org/62430 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-10-29Resolves: tdf#120988 mismatch of in/out locale formattingCaolán McNamara1-11/+7
Change-Id: I9def43c111adc877aeec9f1990f5dd76fabdbf8f Reviewed-on: https://gerrit.libreoffice.org/62485 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-28tdf#120782: fix crash when dragging column...Julien Nabet1-2/+2
from datasource to spreadsheet See bt here: https://bugs.documentfoundation.org/attachment.cgi?id=146108 See related bugtrackers. Change-Id: I2343e1468460b4e8036ce16060471763d344630a Reviewed-on: https://gerrit.libreoffice.org/62482 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-28finish context menuesandreas kainz3-4/+9
Change-Id: Ib3344432a3fcf47a3c9704cc9603376e4754cb8f Reviewed-on: https://gerrit.libreoffice.org/62480 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-28lokit: add funct. to insert, sign and verify signatureTomaž Vajngerl8-1/+304
A lot of signing code paths trigger a GUI dialog (to select the certificate for example) which aren't acceptable when triggering through the LOKit. This code paths needed to be duplicated and reworked to not trigger any GUI action. Change-Id: I2f0d6038fb1bcd00adcdf86e432f9df8858cc21c Reviewed-on: https://gerrit.libreoffice.org/61780 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-10-28drop unnecessary requires lib="LibreOffice"Caolán McNamara13-13/+0
Change-Id: I5444e5076ca69e8f6f8d28e36f4e744721cf43ef Reviewed-on: https://gerrit.libreoffice.org/62445 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-28update old 'interface-requires' comments to <requires> tagCaolán McNamara105-140/+141
Change-Id: If7533650ae543f9d43a3a50fdfc137141fa64586 Reviewed-on: https://gerrit.libreoffice.org/62444 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-28ofz#11125 pass param len aroundCaolán McNamara2-11/+38
Change-Id: I4b382271df21c58de0e102af6e0b07a88a1d9610 Reviewed-on: https://gerrit.libreoffice.org/62443 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-28tdf#120703 PVS: V547 Fix activation of launched process' windowMike Kaganski1-14/+35
V547 Expression 'procHandle != nullptr' is always false. The code was nonsensical overall. First, the launched process handle was never returned by ShellExecuteExW, because SEE_MASK_NOCLOSEPROCESS wasn't used, so GetProcessId couldn't succeed. Then, nullptr window handle was passed to GetWindowThreadProcessId, thus never returning a meaningful result. This reimplements this to find the launched process' main window by first waiting for process idle (up to 1-second delay is possible), then enumerating all the top-level windows and checking their process. Change-Id: I5fb4c04147b3f9414e27650a023f7844523c18bd Reviewed-on: https://gerrit.libreoffice.org/62478 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-28Fix Sidebar docking key regressionJim Raykowski1-13/+17
Add back Ctrl+Shift+F10 undocking/docking handling. This regression was introduced by me in tdf#115434 Fix key press misbehaviors in sidebar. Change-Id: I29a563b2eb96be8a6b346454fddc1605dbc4aba6 Reviewed-on: https://gerrit.libreoffice.org/62268 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2018-10-28Update git submodulesAdolfo Jayme Barrientos1-0/+0
* Update helpcontent2 from branch 'master' - The Bibliography Database window no longer has an Insert menu Change-Id: I07f85db5cd175c9941408c91ec68c70efcdba3da - Grammar Change-Id: I3d3bc317afd35bce5c941144417b7222e9063ae8
2018-10-28check-elf-dynamic-objects: allow extending the whitelist via env-varChristian Lohmaier1-1/+3
to allow working on packaging with epm without a baseline setup... Change-Id: I9ab737cd52adf51c9eb23a4bc67f09c0ac06647e Reviewed-on: https://gerrit.libreoffice.org/62454 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-10-28sw toolbars sync context toolbars between different appsandreas kainz18-223/+390
Change-Id: Ib70cbcb392391c732f9d15a26722cf0dbdb8a56f Reviewed-on: https://gerrit.libreoffice.org/62477 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-28Fix typoAndrea Gelmini1-1/+1
Change-Id: I05f36d03acaabb92b212b8fc3ef30850e1179935 Reviewed-on: https://gerrit.libreoffice.org/62467 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-10-28tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski9-293/+249
Change-Id: Iaa1a1811b638aadfe6b06b3465a182cb675031b5 Reviewed-on: https://gerrit.libreoffice.org/62476 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-28tdf#119410 Menubar sw: combine mirror and rotateandreas kainz6-42/+30
Change-Id: Id71b22d81f6aee26239f7311031fc63523c7dec5 Reviewed-on: https://gerrit.libreoffice.org/62473 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-28elementary: Refix for tdf#119731, update presentation/slide related icons, ↵Rizal Muttaqin296-882/+1195
add envelope, etc Change-Id: Iae01c3e889ea38034332fc29e4cc397941930ac1 Reviewed-on: https://gerrit.libreoffice.org/62466 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-28Fix typoAndrea Gelmini1-1/+1
Change-Id: I66a262953665cdb201bb06ddb3dc4bcd751119ed Reviewed-on: https://gerrit.libreoffice.org/62468 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-28tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski5-83/+65
Change-Id: I2b2ea62ff4ed3e16cd4fa2a5e588d001d21121cb Reviewed-on: https://gerrit.libreoffice.org/62465 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-28svx: remove newly unused XFillExchangeDataMichael Stahl10-201/+0
Change-Id: I0260504ba108421e82ad50f9680dda9a05710678 Reviewed-on: https://gerrit.libreoffice.org/62456 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-10-28tdf#119235 svx,sd: fix drag&drop from ColorBarMichael Stahl5-39/+52
This was using the SfxPoolItem serialisation of XATTR_FILL* items, where only XFillColorItem and XFillStyleItem were actually used; the binary serialisation was removed without being aware of this feature. Fix this by using uno::Any instead, rather than reviving the binary serialisation. Also change the clipboard format strings, just to be safe. (regression from 97b889b8b2b2554ce33fd6b3f0359fc18f39832d) Change-Id: I1828621a9aae606a1ca47835eef608062efe64a0 Reviewed-on: https://gerrit.libreoffice.org/62455 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de>
2018-10-28tdf#115296 extend vertical FrameBorders for joined FramesArmin Le Grand1-2/+18
This feature was lost on my changes for FrameBorder primitive creation. It was calculated/applied formally in lcl_PaintLeftRightLine Change-Id: Ie44619a4c4e44ff4584533685cb21882c323742e Reviewed-on: https://gerrit.libreoffice.org/62451 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-10-28tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski6-160/+112
Change-Id: I1e5098e11f1e5e2f7c5518ea05c57512f58b585b Reviewed-on: https://gerrit.libreoffice.org/62464 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-28tdf#119773 update sd table context menuandreas kainz4-99/+61
Change-Id: Ib85e6a3be4f2771b9772751d6526e8f278bb0a40 Reviewed-on: https://gerrit.libreoffice.org/62240 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-28contect menu sw drawtext remove OpenHyperlinkOnCursorandreas kainz5-5/+0
Change-Id: I4fd53ea430e04f89e14efa20d98faa5dfbc8cda9 Reviewed-on: https://gerrit.libreoffice.org/62447 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-28tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski2-36/+24
Change-Id: Ieb48a5fd29f78d2e39e1d91448f3ce973aff93d9 Reviewed-on: https://gerrit.libreoffice.org/62463 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-28tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski1-54/+49
Fixed the logic broken since commit 5d64757c7a5df2d3cb9b36d18f44932df15e5b3f with what seems to be the original idea. Change-Id: I1a25cfb27d7d9a1af4e024c2989ea4959014455f Reviewed-on: https://gerrit.libreoffice.org/62462 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-28tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski21-134/+58
Change-Id: Ic92cc594979cac2edac04a085957398672a5dfcc Reviewed-on: https://gerrit.libreoffice.org/62450 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-28Fix typosAndrea Gelmini2-2/+2
Change-Id: I4a718b73adcfa0871b94dde92c047593640350a4 Reviewed-on: https://gerrit.libreoffice.org/62458 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-10-28tdf#120703 PVS: V547 Expression '!pTmp' is always trueMike Kaganski1-10/+5
Change-Id: Ia31961d65592ebd2718446eaa931aab785b8ba65 Reviewed-on: https://gerrit.libreoffice.org/62457 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-28tdf#119209: Windows share has inappropriate server suggestionXisco Fauli2-1/+8
Follow the same logic as HostDetailsContainer Change-Id: I3de8b2fc07b9caef6b4d20ab89242137d738c522 Reviewed-on: https://gerrit.libreoffice.org/60732 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-27tdf#42982: added description on RuntimeExceptionIzabela Bakollari1-7/+11
Change-Id: I4d76117d4cbef19a8c68fecb882fcaef4c97efba Reviewed-on: https://gerrit.libreoffice.org/62434 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins
2018-10-27tdf#120376 sd: fix duplicated styles on copy/pasteMichael Stahl1-2/+3
Unfortunately the comparison was inverted, so a style is copied iff it already exists, which is clearly the reviewer's fault... (regression from 57db6e24b5ad43d447c30e44a112c74c7e75b46b) Change-Id: I3425982feb08e980eca9243cc16120897b65a70f Reviewed-on: https://gerrit.libreoffice.org/62436 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-26 03:59:21 +0000