summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2023-03-05Fix rtl::createUriCharClass argument (C++20)Stephan Bergmann1-2/+2
Change-Id: Ifb4d8a430adc19d51d07af3ca2aff66a7983224a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148283 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-03-05tdf#153465 Simplify Sukapura's light variant to make easier forRizal Muttaqin8704-6031/+7664
generating dark variant Change-Id: I7d4d961b970be3ccdc261505b5ad4ab7ae982a6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148017 Tested-by: Rizal Muttaqin <rizmut@libreoffice.org> Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2023-03-05Reword extended tips for caption heading numberingOlivier Hallot1-3/+7
Change-Id: I15e0e0e069218d0f123639768b4fb80f23b4b7c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148181 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-03-05tdf#152459: fallback to language-only when looking for grammar checkerMike Kaganski2-19/+44
LanguageTool registers itself for languages like "en-US", "es-AR", "de-DE"; but also for generic "en", "es", "de". When the requested language, like "fr-CH" or "es-PH", is not found in the registered grammar checkers, the fallback strings will be attempted. Change-Id: Id460db8d378f246ea98191d22bdb3537fd1aee1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148201 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-03-05Bump Glade release for captionoptions.uiOlivier Hallot1-89/+86
No change in contents, just internal Glade refactoring Change-Id: I3d84cd581240bb87a21d1ff42c5dc127d982364b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148180 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-03-05Update git submodulesJuan C Sanz1-0/+0
* Update helpcontent2 from branch 'master' to cac1b0946ef184d11028d3f4f6e767f3e454ffd2 - tdf#153940 New Help page for Firebird external connection * New help page by Juan C. Sanz * Connection Help pages refactoring by ohallot. Change-Id: I344644473985df809d2bc31be42b8a21467771f9 Signed-off-by: Olivier Hallot <olivier.hallot@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148203 Tested-by: Jenkins
2023-03-05remove unused BaseMutex in SwMailTransferableNoel Grandin4-18/+9
Change-Id: Ib079e354433905b25aa44a64779e0c54701858ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148253 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-05tdf#153180: PngImageWriter add support for gray alpha colortypeSarper Akdemir2-9/+79
8 bit grayscale images can have alpha accompanying it, and PNG supports 2 channel gray-alpha images. libpng supports this with the use of colortype PNG_COLOR_TYPE_GRAY_ALPHA. This patch adds support for writing GRAY_ALPHA colorType PNG images. This is done by expanding what was in place for ScanlineFormat::N24BitTcRgb with alpha PNG_COLOR_TYPE_RGBA. Change-Id: I80d462d784f91529eb9371c6bdb029c78f32f81e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146138 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-03-05No need to use a clearable guard hereMike Kaganski1-1/+1
Change-Id: I34a3aba881ae3591130fb3a0d7ae9eb768f615bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148267 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-03-05Swap instead of copy-assignmentMike Kaganski1-1/+1
Change-Id: I5f54dad94cde60dd299f3db22c19a3565a2524a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148268 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-03-05Fix typoAndrea Gelmini1-1/+1
Change-Id: I511583f0b8ce586fe9e6c3096597f0410c55b9fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148263 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-03-05Fix typoAndrea Gelmini1-1/+1
Change-Id: Iddc3e2a28eb638f52a0560925bdeffddb20d3a86 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148264 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-03-05Fix typoAndrea Gelmini1-1/+1
Change-Id: I5b58180d4d048155b927156be1fb6fb22f0e657c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148265 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-03-05Fix typoAndrea Gelmini1-1/+1
Change-Id: I1392e8e20e42b13a28b13bd611eedccf7b9c088f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148262 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-03-05Update git submodulesStanislav Horacek1-0/+0
* Update helpcontent2 from branch 'master' to 793e57c7e3ee1d20e7fcd199dc35af133539b6fa - line break is actually CR+LF, not LF+CR Change-Id: I22aa8c3f50b4ea35c6f48d8e1baed1df73c46d69 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148212 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-03-05make NbcRotate abstract as it's implementation is noopTomaž Vajngerl6-39/+16
During testing the NbcRotate function on SdrObject it turned out the the function is essentially a noop, because it uses normal equality to test the values of a double, which are a product of sin and cos functions (to determine the 90 degree angles). So because of this the input rectangle was never modified - noop. Because of this we can just remove the impl. of the function and declare it abstract, so that the actual implementations define a valid function to rotate. There were some subclasses that didn't override the NbcRotate so they used the one implementation in SdrObject. These subclasses now override the function and in the implementation we call assert(false), which is never called during a test run. It seems we never rotate those objects. Change-Id: I1b1a45a8e96ed2d061f9b9f80c5fdaa5a84d4c05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148266 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-03-05Resolves tdf#153344 - Resize View Mode icon in statusbar to 16pxHeiko Tietze222-67/+68
Also removed the "_10x22/24" from the icons Space between icons now generated per code Change-Id: I061ccc9d46f3a6c8c6d2cbc6acedfa9fc33e472a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148163 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2023-03-05svx: make SdrObject abstract by making CloneSdrObject pure virtualTomaž Vajngerl4-8/+17
This change makes SdrObject an abstract class that can't be as we don't want it to be instantiated. With this the ClonseSdrObject became a pure virtual function. With this change also the SwFlyDrawObj needs a implementation of the CloneSdrFunction, which was previously provided by SdrObject. Change-Id: I2efb8c1e6fac12b17ce497285067029d7da1c1fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148239 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-03-05svx: add test for RotatePointTomaž Vajngerl1-0/+33
Change-Id: I62182fa02843d428d1b745c55ab695450ec4940a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148235 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-03-05svx: SdrRectObj move, rotate testsTomaž Vajngerl1-0/+87
Change-Id: I448f82d87be34c58d0abf4f6a0c1e6192567b807 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148234 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-03-05svx: remove unneeded rectangle initsTomaž Vajngerl1-6/+3
Change-Id: If430eace7e82ff52bb10c83b5f66148e2d9ade13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148248 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-03-04Rename to GetRankNumberArray() because that is what it doesEike Rathke2-3/+3
Change-Id: Iee170972769ea8366a7dfa3edd098a9342a2268f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148260 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-03-04Comment that LARGE()/SMALL() rank svDoubleRef can not be hit in array modeEike Rathke1-0/+6
Change-Id: I8df18b3164941cbf7f58317c2effec05ac0cb492 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148255 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-03-04A bit more of refactoringMike Kaganski2-134/+131
Change-Id: I43dde0375674c4078658a2179108edb5187d2cfc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148257 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-03-04crashtesting: frequent assert on export to docxCaolán McNamara4-14/+19
this is the same problem for docx as fixed for rtf with commit 811dfd7f2706f56119a1943e08d9bce73b0d2203 Date: Tue Feb 28 15:48:30 2023 +0100 sw: RTF export: fix assert on fdo37077-1.rtf so merge this duplicate code together and use the fixed version. Change-Id: I6a97d94a6cdaf488228a0a89088a3e14ca7e1749 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148256 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-04check GetShellXisco Fauli5-16/+34
it might return nullptr Change-Id: I65b43d69f4757b6c331582ca2e256cdea01377af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148194 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-04jsdialog: sort enabled UI files by namePranam Lashkari1-13/+13
this helps avoid repeating them Change-Id: Iaa1d73ca1e396c18a0486ca89cb3b0a26571569d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148241 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-03-04JSDialog: implemented jsdialog support for the toggle buttonsPranam Lashkari7-53/+88
Change-Id: I21408f7344f7e100373c368036f81503302b93ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148240 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-03-04tdf#153606 - Add MacOS Icon ShadowGaldam11-1/+1
Added a shadow to the new MacOS icon Change-Id: I644ae1e63055bbc5fd8f6ade6f5aaed7290831c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148238 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-03-04Set useragent for requests to LanguageTool serverMike Kaganski1-0/+13
Use the same string that is used in CurlSession Change-Id: Ia383f2490cf484715f429df09ec80603ca3f9387 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148251 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-03-04Restructure and deduplicate the codeMike Kaganski2-135/+97
Change-Id: Ib8701cbfbe0a025e19c34f0b52e0f67bf728f636 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148250 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-03-04MCGR: ColorSteps handling moved to toolingArmin Le Grand (allotropia)12-167/+264
Due to the fact that handling of a vector GradientSteps will get used more often with ongoing changes I moved some handling to tooling, see sortAndCorrectColorSteps. That method sorts and corrects a vector of ColorSteps so that only valid entreis remain in a sorted order, for details please refer to the docu at function definition. I took the occasion to rearrange that to work on the single provided vector which is better for speed & ressources. Also changed the ColorStep constructor to not automatically correct constructed entries: While that is formally correct, it moves an invalid entry to 0.0 or 1.0, thus creating additional wrong Start/EndColor entries. Those may then 'overlay' the correct entry when corrections are applied to the vector of entries which leads to getting the wanted Start/EndColor to be factically deleted, what is an error. Also rearranged FillGradientAttribute to now work initially with ColorSteps, no longer requires the Start/EndColor, also adapted all usages. This securely allows start/end and in-between single-color sections in gradients. Also needed to re-formulate GradientRect & GradientElliptical ::appendTransformationsAndColors method for correct 2D mapping(s) - always incrementing from the start to end conflicts with the adaption of the start value for the inner loop mainly because increment is at start of inner loop (pre-increment). Corrected errors from clang plugin, but also some wrong initialiations for basegfx::ColorSteps. Change-Id: I292592ed9abcfa591f68a680479f4fcdda46cbeb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148196 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2023-03-04tdf#153617: percent-encode the text sent to LanguageTool API.Mike Kaganski1-6/+20
Change-Id: I0bb55c70f5602444440fca6e3c13b3d75418e49d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148236 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-03-04Update git submodulesSeth Chaiklin1-0/+0
* Update helpcontent2 from branch 'master' to 29aa6b53e0e674e5ccb75515ed7a45a4be8324d3 - tdf#153549 Chapter -> Heading swriter/guide/indices_enter.xhp swriter/guide/indices_userdef.xhp - refactor <h1>,<h2>,<relatedtopics> - remove irrelevant paragraph Change-Id: I2f6961ee8afebc681e4722dc4755c4bf76cdd6d1 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148220 Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Tested-by: Jenkins
2023-03-04Update git submodulesSeth Chaiklin1-0/+0
* Update helpcontent2 from branch 'master' to 8a84febe0937a59a893cf3c08c310233c1339bfa - tdf#137281, tdf#153549 clarify use of heading and chapter Change-Id: If022346a4c705cedaf2d50c9efb9e46f5b3ea620 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/148219 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2023-03-04tdf#141319 - Special Characters Dialog: mark empty/unused cellsAndreas Heinisch2-0/+24
Change-Id: I123aef9f9763b2ae88c4b4f6748b69f9d9c394af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148051 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2023-03-04svx: change Poly2Rect to return a rectangle, also clean-up the codeTomaž Vajngerl5-37/+56
There is no need to pass the rectangle by reference and to change it inside the function, better to return a new instance. Also clean-up the code of Poly2Rect and rename the function to svx::polygonToRectangle. Change-Id: I25e77c8abd12e2075939f55e06f40343ac23ca97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148211 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-03-04svx: SdrTextObj maRect - use getter and add funcs. for manipulationTomaž Vajngerl17-330/+416
Change-Id: I0a416fa2ac470650c2ef430dbb91bf8d5a8013cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148210 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-03-04Related tdf#153344 - Resize Selection Mode icon in statusbar to 16pxHeiko Tietze151-46/+46
Also removed the "_10x22" from the icons Change-Id: Iccdd5b784f43f1588aa1b5e72d01dd220209cc21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148120 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2023-03-04tdf#153803 qt: Let Qt style draw combobox popup bordersMichael Weghorn1-2/+8
... and listbox popup borders as well. Declare suppport for native drawing of focus for pushbuttons, since the Qt-based VCL plugins take care of drawing focus for controls. As far as I can see, there is no need to actually implement drawing of focus separately for the Qt-based VCL plugins, though, since that is already handled by the `ControlState::FOCUSED` state when drawing the entire control. Support for this is what `ComboBox::ImplInit` and `ListBox::ImplInit` check and if it's not supported, they enable double buffering for the window (which would have the result that the `pWin` in `ImplDrawFrame` in vcl/source/window/decoview.cxx would be nullptr and thus no native drawing of the frame would happen), s.a. commit d4714b0fdb81e6e561ae526cc517ecc9a40a603e Date: Mon Jun 17 17:02:54 2019 +0200 tdf#101978 vcl combobox/listbox floating window: avoid flicker With this in place, the border in the popup windows for listboxes and comboboxes are drawn by the Qt style. Yet another way to achieve this would be to support drawing `ControlPart::ListboxWindow` for `ControlType::Listbox`, so that the other rendering path in `ImplSmallBorderWindowView::DrawWindow` is taken, but that is currently complicated by the fact that bounding and content rect are not really used consequently there, so that would have to be cleaned up first, s.a. the commit message in commit 5c96e813bed3293605f8d746f188cc051d1e5949 Date: Thu Feb 2 15:27:37 2023 +0000 tdf#150451 Fix borders in Editbox controls (kf5) for more details. Change-Id: I8cd2396e7075a475e53e016acbb16d6fb54bad2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148160 Tested-by: Jenkins Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
2023-03-04tdf#153948: LanguageTool: cache the prepared requestMike Kaganski2-18/+20
So that when the same text is re-checked using different settings (e.g., language), the cached result is not used. Change-Id: Ic4ed63c6835f9d3935f1b9541c80822bb52313c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148200 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-03-04jsdialog: enable chart wizardSzymon Kłos3-2/+22
Change-Id: I7d6f4b4e6022507a57224ad40785f5f4f4537ea8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148215 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-03-04jsdialog: handle weld_widget_for_responseSzymon Kłos3-2/+56
Change-Id: I3b8d3911ff93bd26f8bdfb498b547fd335c3db8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148113 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-03-04jsdialog: correct structure for RoadmapWizardSzymon Kłos3-1/+75
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com> Change-Id: Id9837c208653311608bf39d6066cbf1345efc565 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148214 Tested-by: Jenkins
2023-03-04sc: remove protect cell tab from cell format dialogPranam Lashkari1-1/+6
Change-Id: I33a32ca756263426abb4dcb733139baf58221554 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147897 Tested-by: Jenkins Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2023-03-04Resolves: tdf#153924 handle non-numeric and error values in rank arrayEike Rathke1-12/+32
... of LARGE()/SMALL() instead of yielding error value for all result elements. Fallout from commit e4c2d0bb57ab8ea8f5c400d103d01376b8140f22 CommitDate: Fri Nov 30 22:14:17 2018 +0100 i#32345 Support a matrix of rank argument for LARGE()/SMALL() that in ScInterpreter::GetTopNumberArray() required the entire rank array would have to be numeric, which with an empty cell or string it isn't. Change-Id: Ieaa1a68bb8f98614119550b1442665b6fbb4817a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148178 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-03-04Reword extended tips for optcaptionpage.uiOlivier Hallot1-7/+22
Change-Id: I455cb963d6e6aa0107f70492c175e5cbc449f445 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148193 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-03-03Bump glade version for optcaptiopage.uiOlivier Hallot1-164/+164
Change-Id: I00b6c1e8b4628ec8fa643b9e9b9c03d403a3b576 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148192 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-03-03jsdialog: add wrapper for weld:AssistantSzymon Kłos2-0/+71
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com> Change-Id: I82d045cbcc7fc4682c251ac51b19b3bd33f813f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148190 Tested-by: Jenkins
2023-03-03lok: macro: VBA message dialogs was causing assertion failureMarco Cecchetti12-17/+62
Get VBA MsgBox and VBA Runtime Script Error dialogs to be displayed correctly without causing an assertion failure. Provided a solution that allows VBA MsgBox to be executed in a not-async way so that the VBA script is paused until the message box is closed. Change-Id: Ica7d0d343a0ea4b6a163c1c43572f18a5779a0ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147243 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147321 Tested-by: Jenkins
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-24 07:03:32 +0000