Age | Commit message (Collapse) | Author | Files | Lines |
|
<https://github.com/llvm/llvm-project/commit/aee49255074fd4ef38d97e6e70cbfbf2f9fd0fa7>
"Recommit: Compress formatting of array type names (int [4] -> int[4])"
Change-Id: I911934a778fddde0d0022f2e2601d1f9c371fe69
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124142
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
> oox/qa/unit/drawingml.cxx:162:testPresetAdjustValue::TestBody
> equality assertion failed
> - Expected: 1
> - Actual : 0
Change-Id: I3ff0707db485dce1e43c14b8d1a5828da8e14923
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124139
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
...from aa2064c5c5f23f6f4b7bc44e12345b37f66995bc "Improve
loplugin:stringliteralvar", similar to 8b32a3edad52f8ac5e5f0f49b4f4e80954c2fd25
"Fix stack-use-after-scope" (though this case doesn't appear to have caused any
actual issues).
(After manual inspection, there appear to be no further missing `static` at
least in aa2064c5c5f23f6f4b7bc44e12345b37f66995bc "Improve
loplugin:stringliteralvar".)
Change-Id: I2b3d0d8d2af1d65f0c5bef8a858107020a620974
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124137
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Previously, pElementId (old name) was either nullptr or a pointer to
OUString created from sPlaceholderTag literal. In the methods that
consumed it, it was checked for being nullptr. Now, this is checked
with if the aElementId (new name) is empty or not.
If the variable is an empty string, it implies that it should not
be used.
Change-Id: I560fd479f428341c834ee99b0f8a34e95862e3e0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123439
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
With on-the-fly LanguageTag the fuzzy fallbacks for a few
languages aren't needed anymore. Proper fallbacks should be
obtained when needed, like when configuring default locales, or
configured values used after.
Change-Id: I8b85b8099e085508435036ac846db6c3e516dc23
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124127
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
|
|
Change-Id: I0cbf8ce355b460b2f7ea73c8fae653641c980979
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124129
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
Returns a range expressed in A1-style as defined by its coordinates
If only one pair of coordinates is given, the range will embrace only a single cell
Arguments:
Row1 : the row number of the first coordinate
Column1 : the column number of the first coordinates
Row2 : optional, the row number of the second coordinate
Column2 : optional, the column number of the second coordinates
SheetName: Default = the current sheet. If present, the sheet must exist
Is complementary to the Offset() method to compute ranges easily
Available both from Basic and Python user scripts
Change-Id: Ib9323441bbd579beb867329c8b0930653462d00e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124093
Tested-by: Jenkins
Tested-by: Jean-Pierre Ledure <jp@ledure.be>
Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
|
|
Change-Id: If497954b4e70e0a4dbd7268a25727a2478b95184
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124018
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
...during CppunitTest_svl_qa_cppunit, after
df42cb6552b20372f62b5a361709670db80e4ed4 "Optimize assignment from
OUStringLiteral to OUString",
> ==918==ERROR: AddressSanitizer: stack-use-after-scope on address 0x2b2e203b5900 at pc 0x2b2e1b9004f8 bp 0x7ffc06726270 sp 0x7ffc06726268
> READ of size 4 at 0x2b2e203b5900 thread T0
> #0 0x2b2e1b9004f7 in void rtl::str::release<_rtl_uString>(_rtl_uString*) /sal/rtl/strtmpl.hxx:1064:9
> #1 0x2b2e1b8d916c in rtl_uString_release /sal/rtl/ustring.cxx:1785:12
> #2 0x2b2e36263ec5 in rtl::OUString::~OUString() /include/rtl/ustring.hxx:493:9
> #3 0x2b2e3622c5ff in (anonymous namespace)::Test::testTdf103060() /svl/qa/unit/svl.cxx:553:1
[...]
> [2304, 2320) 'EXPECTED_G3' (line 550) <== Memory access at offset 2304 is inside this variable
(<https://ci.libreoffice.org/job/lo_ubsan/2176/>).
(aa2064c5c5f23f6f4b7bc44e12345b37f66995bc "Improve loplugin:stringliteralvar"
had failed to introduce those OUStringLiteral variables as static.)
Change-Id: I59168979fcc4b055d17d1d4f315577eef1027505
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124134
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
$ gcc -dumpversion
7
$ gcc -dumpfullversion
7.5.0
Change-Id: If4f528b3ea732e405507d7563e743ba48e96f523
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124094
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
* Replacing std::unique_ptr<char[]> with std::vector<char>
* The data bytes are read into the vector internal storage
* Modification of the internal storage of the vector using the
pointer returned by data() is allowed by the standard
C++ Standard, revision n4830, section 2.3.11.4 Data [vector.data]
Returns: A pointer such that [data(), data() + size()) is a valid
range. For a non-emptyvector, data() == addressof(front()).
https://github.com/cplusplus/draft/blob/main/papers/n4835.pdf
* It could be replaced with std::string when data is not modified
Example: 6c13e5a92ed4b6a10458cd5d5741ddb3d816df4e
* std::vector<char> is useful when working with C functions that
get "char *" for writing data. In this case, std::string is not
usable, because data() method for it returns "const char *".
Change-Id: Ife6013b16a1803c3ad7b0c64aa0cb4c8cf4373ed
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123764
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
* Remove unncessary C-style cast from DocumentLoader.cxx
* Remove trailing whitespaces from Makefile
Change-Id: I7cff589353d3e40301cf45ce0a76e0c75beddf13
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124115
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
and make the setting for each category persist
Change-Id: I3ca41cb860734d31fd93d0d30b37c0301bc2f7dc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123960
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
|
|
Most likely was an oversight when using LANGUAGE_ENGLISH as other
LANGUAGE_FRENCH and LANGUAGE_GERMAN are locales already.
Change-Id: Ie16395340cef9939a5397e3d10d6df6b13ac8d99
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124124
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
|
|
Change-Id: I6eeb4e2213aa5dcbae94ec7c3a14a18a986f9975
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124121
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ic60242072a0ba7037cd8094ae98633b038c6f1eb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124120
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
* Update translations from branch 'master'
to 26c743b6e210606f1d10d34439d2073ca2140ed6
- Update Slovenian translation
Change-Id: Ic92f48c0e8b021b0e7c1a8fb01b553bb739df2f0
|
|
Change-Id: Id95cab7b70a9f97dadadb8d0cff64674ec3711b7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124119
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
code was perturbed by
commit 5f9ffc31cd1b5433c354c7d39ce1d80fa0e57fc8
Author: Noel Grandin <noel.grandin@collabora.co.uk>
Date: Tue Oct 19 09:08:35 2021 +0200
introduce SwNodeOffset strong typedef
so coverity has seen in afresh
Change-Id: I200f8f40e193f8725ccc1fa5fbb06e3d182bec67
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124118
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I3847647221cf365146c8a5f418e65e3e5798303c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124117
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
* Update helpcontent2 from branch 'master'
to 2592de88d4e0f7c15526f08c3abab1475d697f70
- tdf#132643 Translate German section IDs
Change-Id: Ib2c5e06d6f23c7897a69a0613035a593ee3701d5
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124112
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
* Update helpcontent2 from branch 'master'
to e4fb1b1412a0f1cf7626feca09881f6f630f45d2
- tdf#132643 Translate German section IDs
Change-Id: I96c6d66f3d030e2881ddff0f0f35833f65b85cc4
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124111
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
* Update helpcontent2 from branch 'master'
to 005ab5fa0c87135a3e5b8f7150c67d1c47ed490b
- tdf#132643 Translate German section IDs
Change-Id: I51c35619cc80d3c7e0dce3ea805e5afc486c8daf
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124110
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
* Update helpcontent2 from branch 'master'
to b425e5428d61fb534a6fc02e948f7b246aaaec8f
- tdf#132643 Translate German section IDs
Change-Id: Ib099bf8474d272cbf10fad79c80b5164b5d11717
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124109
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
* Update helpcontent2 from branch 'master'
to 1d2f50f0de3075da42af1725f0061180c7ce89c0
- tdf#132643 Translate German section IDs
Change-Id: I3dc05a302194a7eff7e0776776c309afabbc731f
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124108
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
* Update helpcontent2 from branch 'master'
to 21500a71de051f1a2046e97c7cbd1f344bb82431
- tdf#132643 Translate German section IDs
Change-Id: I59cec2f60abf1251edfc865932ace953008c57d4
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124107
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
* Update helpcontent2 from branch 'master'
to 6422afb3a6ac4ce1d5d0658f24f9cfd3d19e7d07
- tdf#132643 Translate German section IDs
Change-Id: I3bc212d560b2838daca117bf29d5bce0293ffcb5
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124106
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
* Update helpcontent2 from branch 'master'
to bee3e08d0957c12c92934fd46d3c1ae40f564911
- tdf#132643 Translate German section IDs
Remove unused.
Change-Id: Ifddc735398087a7fbd39136a9bcbf5fda5c457f0
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124105
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
* Update helpcontent2 from branch 'master'
to 9ae706191bf26ed27da4fc8ddd9ceee8c49af848
- tdf#132643 Translate German section IDs
Change-Id: I9b32ddd9a754764d3798fadeb9c323dd1694aace
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124103
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
* Update helpcontent2 from branch 'master'
to 49c732f50cc787aa1c713934a4002d5cc4186cb2
- tdf#132643 Translate German section IDs
Change-Id: Icc84282d95c3003577bec75d130099d027d2545b
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124104
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
Change-Id: I9300b4e6eb9ee3ff2b9bfd32efdf0c8ceedc9d3c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124113
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
|
|
Some LOK messages may get called very often, such as updates about
cursor position. And since only the last one matters, they get
generated every time, which costs some time, and then later except
for one they get all discard again from CallbackFlushHandler queue,
which again costs time.
Change the model to instead only set an 'updated' flag, and
CallbackFlushHandler will request the actual message payload only
before flushing.
This commit changes LOK_CALLBACK_INVALIDATE_VISIBLE_CURSOR and
LOK_CALLBACK_INVALIDATE_VIEW_CURSOR to work this way.
Change-Id: I376be63176c0b4b5cb492fbf529c21ed01b35481
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124083
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
Change-Id: I1fa2eaec67bd5e85d09d4d662deede34d3388176
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124016
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
On DOCX import we do not need to provide prefix, suffix and included
levels: these values are calculated in SvxNumberFormat out from list
format. Moreover these values are incorrect and do not correspond
not to DOCX data nor to internal writer representation of list level.
Change-Id: I91ec9de679e67056ba3746f2e1a0bd923532d76c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124090
Tested-by: Jenkins
Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
|
|
This allows e.g. to use the function with valarrays, that don't have
own begin/end, but has std::begin/end overloads.
Change-Id: I4559180e30040ed5d42805170a02a53280fce9ba
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124015
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: I784fbc3b39a645c7984aa836cc32980343ddd1f5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124095
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
* Update helpcontent2 from branch 'master'
to fb9c746f6aaae147aa16b1f2b682e01d07003d03
- tdf#145232 get_bookmark.xsl: Use normalize-space()
normalize-space() trims whitespace from the start and end of a
string and collapses multiple spaces inside a string into a
single space.
This will prevent newlines in strings from breaking
our generated bookmarks.js.
Change-Id: I2a420cfd9fe13ee063151af79cb51b0ae49f5a0d
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/124056
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
File import was making an exception for "float value 0"
if the accompanying text had no resemblance to the value 0,
but that only applied to GENERAL number format.
It should apply to any language's default number format.
REGRESSION warning: as we can see, this has been handled
inconsistently in the past. But from the coding exception to overcome
losing text to a zero (and the huge number of duplicate bugs)
the best choice seems to be ignore the spec that says that
a number value overrides the text value - at least in
the case where the number value is zero.
Change-Id: I701e72c6a5dad42c7799ab501255a4859adf61d4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124080
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
|
|
Change-Id: I78f0d443365e23501b43fe0f1d9e32d503c1e9f4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124085
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
|
|
Change-Id: Iaba882b1bd000a068cfaa207c743be038d5db434
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124087
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
The other variable members should also be prefixed
but I don't have an IDE to do it easily
Change-Id: Ifce210a4de89ed4d7f05126e33555da231553283
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124089
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I948c8b38f0df86f30f9c5af56aea5103c82c661c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123966
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
|
|
Change-Id: Ib3815aee68fdeb8f5eef465d01c51c66378fcd1a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124086
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
* Update helpcontent2 from branch 'master'
to 2c0d02652166d4baf168f233459df09138ddc268
- Fix typo
Change-Id: I49852f6b601817fa179306896a1d0b263a8ec4bc
|
|
The tests were previously drawing squares in the middle, however,
now the tests draws rectangle taking offset from the middle.
Change-Id: I26a4af997feac9ced443d7c9b4e3541ea2ba868a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120076
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
only insert the bounds we are interested in
takes load time from 1m51 to 1min39 for me
Change-Id: I5a267ae3cf3fe7691481f83b591b02d939931c07
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124074
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I8ae578350e911c69eeabbb3af41aaf9801b4ffee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124073
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
And also: "vcl.opengl.qt5" -> "vcl.opengl.qt"
Change-Id: I86f8a34cb8c1303a81ffbf40c801ba628f3fa0d4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124065
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
It's used for the qt6 VCL plugin as well.
Change-Id: I3f57258c2c8e3c12532d79b44f24105a30590675
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124064
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
since it needs 2 allocations instead of one
This reverts commit 43a9bf11203ed92096af34ab828501e0218832c7 .
Change-Id: I1d8553d9c31f663dd990146e6d375bbbaf32fb27
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124072
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|