summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2020-06-04deb#961473 set A4 in extras/source/shellnew templatesRene Engelhard3-0/+0
it's far more used in the world than "US Letter" Change-Id: I7dbbefc9bde543967e1f3039890bbff91fc1459c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95258 Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: René Engelhard <rene@debian.org> Tested-by: René Engelhard <rene@debian.org>
2020-06-04drop unused inline methodCaolán McNamara1-1/+0
Change-Id: Ie0a861106341f8a838b19eff405a99c6f234e93f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95500 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-04sd: disable LOKitSearchTest that test PDF search if no PDFiumTomaž Vajngerl1-0/+16
enclose the tests with HAVE_FEATURE_PDFIUM Change-Id: I1ce97fe090cef2cc2ab2f25fd1d2698bcaf28222 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95463 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-04xmloff: ODF export: fix crash on tdf125455-2.odtMichael Stahl1-11/+14
FillBitmapMode is a very funny property that is stored as 2 items XFillBmpTileItem XATTR_FILLBMP_TILE and XFillBmpStretchItem XATTR_FILLBMP_STRETCH and the XPropertySet implementations for it are a bit inconsistent, e.g. sd uses .GetItem<XFillBmpStretchItem> which searches the parent and requires both items to be present, but sw uses GetItemState(XATTR_FILLBMP_STRETCH, false) which does not check the parent and one item is enough. Let's just not export the attribute in case the property isn't defined. (regression from 4d4404b79bf051de79f587bdafd82cc0addfc636) Change-Id: I13c2e91c3e4eb15ebec508f679ba49614f493a11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95501 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-06-04Revert "Resolves tdf#127401 - Chinese locale pointing to wrong hub forward ↵Heiko Tietze1-4/+1
address" This reverts commit 2788cc07e9d0d078b53a7280d524175c03c51e12. Reason for revert: <INSERT REASONING HERE> Change-Id: I47277e7344d5533cc09a3fd6637a0780b36fe739 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95427 Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-06-04Update git submodulesIlia Sheshukov1-0/+0
* Update dictionaries from branch 'master' to 12e591abdbc5565e5018ed9b8fbe6d635ade87d7 - Converted Russian dictionaries from KOI8-R to UTF-8 Change-Id: Id2ecf90b5bb0adb5c620916aec3527c4ef851237 Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/95515 Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-06-04Upcoming loplugin:elidestringvar: hwpfilterStephan Bergmann1-2/+1
Change-Id: I7c9a8fe33d06236f66c201267650fcbea29dc43c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95478 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-04Change FIXME to plain comment, there apparently is nothing to do about it hereTor Lillqvist1-2/+3
Change-Id: I81e50e7e604e8ef17ba0d369e8987f4c840f8361
2020-06-04Upcoming loplugin:elidestringvar: i18npoolStephan Bergmann3-11/+4
Change-Id: I5644ca7f2ef1b251ce1c262d3001ca48f2ed9edd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95482 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-04Bin two leftover spurious writes to std::cerrTor Lillqvist1-2/+0
Change-Id: I89601e3682a5f8eca81b45af62e5aa50c481bc84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95502 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-06-04tdf#128502: Add a FIXME commentTor Lillqvist1-1/+3
The view id concept is badly broken. Way too many wild assumptions that the "current" view is the one we expect here and there. For instance here. Change-Id: Icf36808b2c09f0b3fd8070deecf175ba7f52b5f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95508 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-06-04Upcoming loplugin:elidestringvar: javaunohelperStephan Bergmann1-2/+1
Change-Id: Ia81a0f0b804eb41235e310deac5818731397fdd8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95492 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-04Upcoming loplugin:elidestringvar: i18nlangtagStephan Bergmann1-16/+8
Change-Id: I8f910117c7b8a71fdf9c324ea3202b091ee3c046 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95479 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-04Remnant CoInitialize commentJulien Nabet1-1/+1
Change-Id: I33b328e4b2c85a6260d068ce5d9504dfdb201f89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95495 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-06-04disable dbaccess_hsqldb test on macosNoel Grandin1-0/+3
fails 50% of the time with a core dump, and we have no way of debugging that Change-Id: Ieda3a241a964327d3c70a6f519a032980ce312ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95487 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-04tdf#132137 Rename Default Style to Default Drawing Style in Draw and Impress.Srijan Bhatia1-1/+1
Change-Id: I130bd0e070a3449753cc76a8f7e6352c8b7a1bba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95403 Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-06-04Adapt documentationStephan Bergmann1-4/+3
...to 43aef04d77aafb9d055957642e62b559231f3711 "Reliably wait for soffice to terminate" Change-Id: Ieb0702196cd5f95d382a0f18c4bca1b01182d006 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95483 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-04Upcoming loplugin:elidestringvar: frameworkStephan Bergmann7-23/+10
Change-Id: I5a786316e9fa6dab0166c435c6a1ac9e5d8014a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95466 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-04vcl: disable VectorGraphicSearchTest if we don't have PDFiumTomaž Vajngerl1-0/+6
enclose with HAVE_FEATURE_PDFIUM Change-Id: I46f8d6b19c46dbdf313b6192dddf85741ceb301f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95462 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-04Upcoming loplugin:elidestringvar: cuiStephan Bergmann6-21/+6
Change-Id: I48c4f69a1fb2e4591eab81c2b0019d7d7d43947b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95395 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-04Print out the guessed executable name that is actually passed to the debuggerStephan Bergmann2-8/+8
...to avoid confusion, when the log reads e.g. [...] > It looks like /home/tdf/lode/jenkins/workspace/lo_tb_master_linux_dbg/instdir/program/soffice.bin generated /home/tdf/lode/jenkins/workspace/lo_tb_master_linux_dbg/workdir/UITest/calc_demo/done.core/core.10572 [...] > Core was generated by `/home/tdf/lode/jenkins/workspace/lo_tb_master_linux_dbg/instdir/program/python.'. [...] (<https://ci.libreoffice.org/job/lo_tb_master_linux_dbg/29831/>). Change-Id: I59f544c6739329620064315c2a54c21e29865b68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95480 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-04tdf#101211 follow-up: move cursor to start of next/prev pg UNO functionsJim Raykowski1-24/+28
This is a follow-up patch that fixes the cursor not moving to the start of the page when multiple pages are visible. The cursor move behavior is; if the cursor is visible, the page number the cursor is visible on is used as the reference. If the cursor is not visible, the page number of the first visible page is used as the reference. Change-Id: Ibdfaa763bf7283e46d8c68270dfa6b5f0012ca0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95476 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2020-06-04make triangle largerCaolán McNamara1-1/+1
Change-Id: I7fce58507b039c080b5b6ffd423fb85f87ad077a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95446 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-04sw: handle SurroundTextWrapSmall when replacing compat optionsMiklos Vajna1-1/+1
This was added in commit 8f8b31abd02876c3601e343b8b3274754f8a61b6 (compatibility setting for MS Word wrapping text in less space (bnc#822908), 2013-08-06), it's off by default and on for old DOC/DOCX/RTF documents. See tdf#124790 for motivation. Change-Id: I786ea1de3feae25775055a2fb50c688ef6a6cd52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95453 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-06-04Upcoming loplugin:elidestringvar: formsStephan Bergmann1-2/+1
Change-Id: Ic95f4dc57dd19654e2dace60883c0c6f1d14b9ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95464 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-04Resolves tdf#127401 - Chinese locale pointing to wrong hub forward addressHeiko Tietze1-1/+4
zh is replaced by zh-cn for donation and whatsnew commands Change-Id: Ibd56e94983882bd9090d176cb42ae0a7a1f88065 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95450 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-06-04tdf#130804 sw: fix bookmark portions in line containing only as-char flyMichael Stahl1-1/+5
There were 2 problems: * due to the first bookmark portion, the line got an additional 55 twips of its descent added to its height in SwLineLayout::CalcLine(). * when called from SwTextFrame::CalcHeightOfLastLine(), SwLineLayout::MaxAscentDescent() is supposed to ignore FlyInCnt portions, but it didn't ignore the bookmark portion which had the same height, hence the resulting line spacing was 855 instead of 0 and the upper margin of the next paragraph increased similarly. (regression from 4ce8120f1e53f7b81e653b01d141643013bc69ab) Change-Id: I52b154a48c5d712b7e3e323d2e3e08f37bf1afd1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95438 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-06-04loplugin:simplifypointertobool improve (2)Noel Grandin55-112/+110
to look for the x.get() == null pattern, which can be simplified to !x Change-Id: I0eddf93257ab53ab31949961d7c33ac2dd7288ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95400 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-04Upcoming loplugin:elidestringvar: fpickerStephan Bergmann1-3/+1
Change-Id: I4591cbe91e58a7c1014f9862cca63180800a3f45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95465 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-04Upcoming loplugin:elidestringvar: filterStephan Bergmann3-244/+120
Change-Id: Ic88f3ca8dffa416966734370ef01f8814eacdd05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95433 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-04Use lokCallbackTypeToString to show value symbolicallyTor Lillqvist1-1/+1
Change-Id: Idb685e2807cc62bbaca117f5cf85fdda622caae8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95467 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-06-04sd: allow to change the search string between searchesTomaž Vajngerl1-5/+11
Before this was missing, so even with a different search string, it still searched using the old string, which was a bug. Change-Id: I1655cb421e216e30ae593aabd3ead3a2d5c06299 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95461 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-04vcl: VectorGraphicSearch - support changing search stringTomaž Vajngerl3-29/+86
Initial implementation only allowed to set the search string once. This change allows to change the search string and still retain the last position of a found string, so the search continues from this positon forward or backwards. This mimicks how we search through the GUI (which is the main use for this functionallity anyway). Change-Id: I8a7aee4b6b6525f483f105feaa1f83c4a0ad9594 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95460 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-04sd: add support to search backwards in PDF searchTomaž Vajngerl2-5/+120
Change-Id: I2c7f75d16a430dcfa892d28fb6b4f64118705ad2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95459 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-04sd: add test to search inside PDF in multiple pagesTomaž Vajngerl1-0/+92
Change-Id: I246508a22a4e324bae1bb10c6e292790c04da4c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95458 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-04sd: rename testSearchInMixedObject(2) to more descriptive nameTomaž Vajngerl1-6/+6
testSearchInMixedObject -> testSearchIn2MixedObjects testSearchInMixedObject2 -> testSearchIn6MixedObjects Change-Id: Ifba20df38fd33bb86b072ba79085d123c914f916 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95457 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-04sd: PDF search - reset mpVectorGraphicSearch at more placesTomaž Vajngerl1-22/+23
and simplify the case when the search doesn't find a match in the vector graphic. Change-Id: I3e086e8e36f8a578711eed6d4dcca65c0c4c6268 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95456 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-04sd: Add another test of searching with mixed objectsTomaž Vajngerl2-1/+178
This is to make sure that we switch between different objects during the search correctly. Change-Id: I18aa5b251cbaadd3a9cb15a04ec1a1e5f267d2e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95455 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-04sd: fix issue when PDF search doesn't send a search result + testTomaž Vajngerl3-1/+87
This fixes the issue when PDF search doesn't send the search result, because of premature exit. Also add test which reproduces this issue and tests the behavior of searching in multiple objects. Change-Id: I3a676eeac36bde88c67e90a49583444b8595a346 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95454 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-03Improve COM library management in ADOJulien Nabet2-5/+17
Change-Id: I99a1c61068fec743847181b43f3d9278c85e95e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95174 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-06-03Upcoming loplugin:elidestringvar: extensionsStephan Bergmann4-30/+15
Change-Id: I318eebbdc79c503b10570061a298eb76d6555540 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95402 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-03Upcoming loplugin:elidestringvar: drawinglayerStephan Bergmann1-4/+2
Change-Id: Ic4f4a2d2d6d04b317a00c3c1b7eb005229c81bd5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95398 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-03Upcoming loplugin:elidestringvar: editengStephan Bergmann4-36/+18
Change-Id: Ia14a1391cbc40b98d24e37c3a54b16871441fc78 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95399 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-03vcl: use HAVE_FEATURE_PDFIUM in VectorGraphicSearch impl.Tomaž Vajngerl1-0/+45
Change-Id: Id6c30e8f1c5bdb0481b0c7d4680554e3e8caa323 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95393 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-03fix ubsan in SharedStringPoolNoel Grandin2-3/+8
with a slightly dodgy fix. regression from commit 3581f1d71ae0d431ba28c0f3b7b263ff6212ce7b optimize SharedStringPool::purge() and fix tests It's not ideal - we no longer have a way of purging uppercase keys that are longer in use. But that doesn't cost much memory, because we are sharing those strings. We could potentially identify them with extra book-keeping in either intern() or purge(), but since this class is performance-sensitive, best just to sacrifice some space in the map. Change-Id: I85a469448f5b36b1b6889da60280edd56bbcb083 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95432 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-03uitest: tdf96432.py: assert changes in chartXisco Fauli1-6/+11
Change-Id: I7b3a93e049fc96f1f2221e64468eafdd9dc7d78c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95442 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-03skip unselectable entriesCaolán McNamara1-1/+1
Change-Id: I55b7d64f84e2a5b7ab2e1ee8ce6a2f22440b9cfe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95445 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-03cui: extract signature line SVG template into a fileMiklos Vajna5-178/+63
It's much easier to inspect/edit the template this way. Change-Id: I797143871058bcc4715ca13e10b8d16b428dd10e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95405 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-06-03vcl: VectorGraphicSearch - move SearchContext into ImplementationTomaž Vajngerl2-39/+40
Change-Id: I3bbf085fd8b8b66a56e364168c1e70b4ce986467 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95392 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-03Fix typosAndrea Gelmini2-2/+2
Change-Id: I111334adcf8b9b9553c585ab9669cf2cbdb909cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95444 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
generated by cgit v1.2.3 (git 2.39.1) at 2024-12-03 20:47:33 +0000