summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2024-10-29cid#1607341 silence Data race conditionCaolán McNamara1-1/+1
clarify that the same mutex is held for writing and reading to maUsedLines Change-Id: Ifabe8006cc1eac3cf05e9d5c4e907e79f22c3de7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175802 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-29sd: lokit: add notes to presentation infoHenry Castro1-0/+21
Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I1293a392749b6cff75be02236fb570f8faeb2446 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174613 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175757 Tested-by: Jenkins
2024-10-29Related tdf#162262 - Move "Summary below data" UI tests toBalazs Varga2-109/+132
separate file. Follow up commit: 26c08356d1b2a963efdca570979cb04388371400 (tdf#162262 sc add "Summary below data" option for Subtotal dialog) Change-Id: I8e76fe2585993e79454f6079485f191e970e8f5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175786 Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Tested-by: Jenkins
2024-10-29tdf#130857 qt weld: Declare support for "Switch to override" dialogMichael Weghorn1-0/+1
Add .ui file of the "You are switching to the overwrite mode" dialog that gets shown when pressing the Insert key in Writer to list of files supported by QtInstanceBuilder, so that native Qt widgets are used for that dialog now when using the qt5/qt6 VCL plugins, unless environment variable SAL_VCL_QT_NO_WELDED_WIDGETS=1 is set. Change-Id: Ib4f83af6d83e46a5bf1a816ffe7d1d494bc0b9d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175792 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-10-29tdf#130857 cui: Move checkbox out of button boxMichael Weghorn1-17/+18
In the "You are switching to the overwrite mode" dialog that gets shown when pressing the Insert key in Writer, move the "Do not show again" checkbox above the button box with the "No" and "Yes" buttons instead of having it inside of the button box. This aligns this with how it's done elsewhere, e.g. in the "LibreOfficeDev Help Not Installed" dialog (sfx2/uiconfig/ui/helpmanual.ui) that gets shown when pressing F1 without local help installed. It also prevents an issue with this case of a checkbox with quite some text inside a button box resulting in overlapping UI elements for the native Qt version of the dialog (once this gets enabled in QtInstanceBuilder::IsUIFileSupported). Change-Id: I005da330cca5a8d6ee468477472e0382c288b022 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175791 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-29tdf#130857 qt weld: Implement QtInstanceImage::set_from_icon_nameMichael Weghorn1-2/+2
This will get used e.g. by the "You are switching to the overwrite mode" dialog that gets shown when pressing the Insert key in Writer. Change-Id: Icea593ad65d643b647408c29482d64b9084d4cd3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175790 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-29Missing initialization of ScTable::mbTotalsRowBelowStephan Bergmann1-0/+1
...introduced in 26c08356d1b2a963efdca570979cb04388371400 "tdf#162262 sc add "Summary below data" option for Subtotal dialog" Follow up commit: 26c08356d1b2a963efdca570979cb04388371400 (tdf#162262 sc add "Summary below data" option for Subtotal dialog) Change-Id: I9d8e12fc24e6e42f6ee28c4879ddcff497b88c18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175793 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-10-29tdf#162692 partial take back of tdf#160252Armin Le Grand (allotropia)1-1/+4
to no longer make the wrong data appear when a CF gets changed on one tab. For more info, see text in task. Change-Id: I7bf582eb9a2fe59b9a4b3d280639661c3aa7e608 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175779 Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> Tested-by: Jenkins
2024-10-29treat divs as requiring a new block/paraCaolán McNamara3-7/+22
but consider inserting a paragraph as fulfilling that requirement, and only insert a new para if content shows up before a new para does. Change-Id: I7455575a77a1f3b176ed8d5b16a7e5a688ba9dbc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174507 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 0287036fa4ae6d709aedc6b721329251fa6f412f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175754 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-10-29fix enabled-mergelibs-more buildJuergen Funk1-2/+2
ErrCode::toString is needed by desktop/source/app/ unit tests now Change-Id: Ie7a9e67aca763c958d08f3826bca5df4e0d828f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175769 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-10-29UnoApiTest: check mxComponent right after loadingXisco Fauli11-30/+6
Change-Id: Ia834d19a5af999440f7d5847aeeae863daacd952 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175784 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-10-29tdf#42982 Improve UNO API error reportingOromidayo Owolabi1-8/+8
Add more information to UNO API error reporting in AccessibleDocument.cxx. Change-Id: I411df5c5e3eb69fcc045c92453aa3c37111145f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175331 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org> Tested-by: Hossein <hossein@libreoffice.org>
2024-10-29tdf#161152 vcl: Set CUPS "sides" option for duplex modeMichael Weghorn1-0/+12
When the PPD "Duplex" option is set in a print job, also set the CUPS "sides" option documented at [1], section "Printing On Both Sides of the Paper". This is apparently required for at least some Brother printers where the "Duplex" PPD option is not evaluated during the print process. [1] https://www.cups.org/doc/options.html Change-Id: Ib280c3c65eaf7bf74b611f0ce921eda51b1ebe19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175782 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-29Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' to c600ec0146bca18fdcd998879dc0a520fb436eff - Tweaks for text function for navigation Change-Id: I1bc8d9ab8c73d94264c5774bd37cae2a9b54950e Reviewed-on: https://gerrit.libreoffice.org/c/help/+/175785 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-10-29Allow replies with rich text content from command argumentsCaolán McNamara3-11/+30
Change-Id: I46d200048bdfef767882e94c7544f40f2e0b3c8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174593 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 3eae55420d1d8daee6efad456f651a9ff189723b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175752 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
2024-10-29tdf#130857 VclBuilder: Move extractResizable to BuilderBaseMichael Weghorn2-13/+14
Turn this local helper function into a static method in the BuilderBase class, for reuse in QtBuilder in an upcoming commit. Change-Id: Iee5d5c061c8b1bad3fefb7398111ad6815fc4c6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175776 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-29tdf#130857 qt weld: Set widget tooltip defined in .ui fileMichael Weghorn1-0/+1
If a tooltip is defined for a widget in a .ui file, set that tooltip using QWidget::setToolTip. This e.g. makes the tooltip for the copy button in the "Help" -> "About" dialog shown as "Copy all version information in English" when hovering over the button with the mouse. Change-Id: Ida22b3fb8b3626474d4377aac6c51d9f7c7ba2ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175775 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-29tdf#130857 VclBuilder: Move extractTooltipText to BuilderBaseMichael Weghorn2-14/+15
Turn this local helper function into a static method in the BuilderBase class, for reuse in QtBuilder in an upcoming commit. Change-Id: Ib1129801bc7315b1745d1b2690d59747c8db7ed6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175774 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-29tdf#130857 aboutdialog.ui: Define grid children in orderMichael Weghorn1-141/+141
Reorder children of the top-level grid in the .ui file so that the order matches the visual appearance, which makes sure that tab focus order with the Qt-based VCL plugins is correct as well the "Help" -> "About LibreOffice(Dev)" dialog. dialog. See commit 02692566ad9fc7c3484f8581ffa0004cd4e43987 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Thu Oct 24 17:43:35 2024 +0200 tdf#130857 optnewdictionarydialog.ui: Define focusable widgets in order for more background. Change-Id: I069fc7c290d2c98180345d350504068a2dc19d40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175773 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-29tdf#130857 qt weld: Declare support for "About LO" dialogMichael Weghorn1-0/+1
Add .ui file of the "Help" -> "About LibreOffice(Dev)" dialog to list of files supported by QtInstanceBuilder, so that native Qt widgets are used for that dialog now when using the qt5/qt6 VCL plugins, unless environment variable SAL_VCL_QT_NO_WELDED_WIDGETS=1 is set. Change-Id: I57c83517e9f7cea16931107206f25f6a9013429c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175772 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-29Update git submodulesPierre F1-0/+0
* Update helpcontent2 from branch 'master' to 7b7ddc4bf507d27578f3bf17fd28dc40b95d6586 - tdf#143846 split CODE() + CONCATENATE() Change-Id: Ic190564f4e7a7884900766cee26322f5ab7dfec9 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/175607 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Jenkins
2024-10-29update creditsChristian Lohmaier1-1350/+1419
Change-Id: I2d29266078124f3b28c45cf60145e0f6e6bebe4c
2024-10-29workaround loplugin:cppunitassertequalsNoel Grandin1-1/+1
There is no operator<< for SfxPoolItem, so a straightforward convert to CPPUNIT_ASSERT_EQUAL is not possible. /home/noel/libo/sw/qa/extras/tiledrendering/tiledrendering.cxx:2725:5: error: rather call CPPUNIT_ASSERT_EQUAL when comparing 'const SfxPoolItem' and 'SvxWeightItem' (or rewrite as an explicit operator == call when the operator itself is the topic) [loplugin:cppunitassertequals] 2725 | CPPUNIT_ASSERT(*pPoolItem == aBoldWeightItem); // a bold | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. Change-Id: Ia92779d54d252245e1d3b8e32c574e4226342f36 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175771 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2024-10-29Fix typoAndrea Gelmini1-2/+2
Change-Id: Icff1da2ae4dc70c699f48116b9e4658edb5c3000 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175763 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2024-10-29tdf#140226 use StaticWhichCastOromidayo Owolabi2-41/+41
Replace static_casts informed by .Which() for SfxPoolItems with StaticWhichCasts where appropriate in htmlctxt.cxx and docxattributeoutput.cxx Change-Id: I0a905c9e92cf39396bab0620ed35b201f8e6a8c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175515 Reviewed-by: Hossein <hossein@libreoffice.org> Tested-by: Jenkins
2024-10-29cid#1556968 COPY_INSTEAD_OF_MOVECaolán McNamara2-2/+2
and cid#1557514 COPY_INSTEAD_OF_MOVE Change-Id: Ie419092ef6c00039a8799bf208fd998001c108ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175738 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-29test: Merge SwAccessibleTestBase and AccessibleTestBaseXisco Fauli10-232/+161
Change-Id: Ic62bd287406326f4c3d3e0702850fe0337f17686 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175762 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-10-29UnoApiTest: rename load to loadFromURL and use it everywhereXisco Fauli176-343/+274
Change-Id: Ie67eebec74f783fa0c29acfb23bb83bc582812b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175724 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2024-10-29Simplify a bitMike Kaganski1-1/+1
Change-Id: Ia0225e6053112a88db3641ba653e2af7cc702f86 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175749 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2024-10-29tdf#130857 qt weld: Set button image set in .ui fileMichael Weghorn3-4/+29
Implement logic to set the image for a button, as specified via the "image" property for the "GtkButton" object in the .ui file. Similar to how VclBuilder::makeObject does it, extract an icon name and load an image using that one for "GtkImage" obejcts. Add another static `toQPixmap` variant that takes an Image parameter and use that one for conversion. For buttons, if the "image" property is set, get the corresponding QLabel object, get the pixmap from that one and set an icon in the button from that. With this in place, when opening the "Help" -> "About LibreOfficeDev" dialog in a WIP branch adding "cui/ui/aboutdialog.ui" to the list of .ui files in QtInstanceBuilder::IsUIFileSupported, the button to copy the version information now shows the corresponding icon when using the qt6 VCL plugin. Change-Id: If87866d7ab935cbc4162fb513074eefda22c981a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175761 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2024-10-29tdf#130857 Move loadThemeImage from FixedImage to BuilderBaseMichael Weghorn4-10/+11
This static helper method is currently only used by VclBuilder. Move it to the BuilderBase class, for reuse by QtBuilder in an upcoming commit. Change-Id: I229bc98e0de2dbe0788f07c7f4ff5e5426203de9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175740 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-10-29tdf#130857 VclBuilder: Move extractIconName to BuilderBaseMichael Weghorn2-26/+28
Turn this helper function into a static method in the BuilderBase class, for reuse in QtBuilder in an upcoming commit. Change-Id: I1e3318f22d83ddef4e7bf6269c7142f307ec6d1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175739 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2024-10-29tdf#143148 Use #pragma once instead of include guardsMuluh MG Godson6-26/+7
Change-Id: Ib779717653f17fdb83319d65313ae1a0ffc8fd3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175768 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-10-29Update git submodulesTheppitak Karoonboonyanan1-0/+0
* Update dictionaries from branch 'master' to d375e51d98ce78857dc71f5a26b75058592d833d - tdf#163657 Adjust Thai spell check dictionary LibThai word list, a source of the Thai spell check dictionary, includes some common misspelled words for its word segmentation function to still work with documents in real life. But such entries should not be included in the spell check dictionary. * th_TH/th_TH.dic: - Remove entries from LibThai's tdict-spell.txt - Fix spellings of some related entries (ซิลิกอนเวเฟอร์ -> ซิลิคอนเวเฟอร์, ปรากฎการณ์ธรรมชาติ -> ปรากฏการณ์ธรรมชาติ) - Add the updated spelling for "ทุกกฏ". Still accept the old spelling "ทุกฏ". Change-Id: I792bd67a4a2cea85554442e30c952889898bbbac Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/175732 Reviewed-by: Vernon, Stuart Foote <vsfoote@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-10-28cid#1608231 silence Overflowed constantCaolán McNamara1-4/+4
Change-Id: Idf24a404d332b5a63f8ae7ec7f133a7f3c74c97c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175730 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-28cid#1608044 silence Overflowed constantCaolán McNamara1-0/+2
Change-Id: I779a2354374279477fd330784d3ce5e4345fa83b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175729 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-28cid#1607898 silence Overflowed constantCaolán McNamara1-3/+3
Change-Id: Ief9b09c5db8ef687c50ab12894d59056be85e8b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175728 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-28crashtesting: crash on loading ooo71160-2.docCaolán McNamara1-0/+2
since: commit 2d6addb180ad30383f4aaec198c22ccbf936fa87 CommitDate: Mon Oct 21 15:16:57 2024 +0200 tdf#163486 sw: PVS: identical sub-expressions Change-Id: I601a72a8a39f3591d1110f65a027e89923befaca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175702 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-10-28Fix unresponsive mouse moved events in Writer on macOSPatrick Luby1-1/+1
On macOS, when Writer is in a background task such as initial layout and spellchecking, mouse moved events appear to be unresponsive due to the fact that AquaSalInstance::AnyInput() returns false when flags include VclInputFlags::MOUSE even though there are native mouse moved events waiting to be dispatched. In contrast, on Windows WinSalInstance::AnyInput() will return true so make macOS behave the same as Windows and return true if there are any queued native mouse moved events. Change-Id: I4b3cf66f2fb0357c0eebaf869da0bdcdbb8f8516 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175725 Tested-by: Jenkins Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
2024-10-28tdf#162510 - Consider pinned items for the scroll bar in the start centerAndreas Heinisch1-67/+72
Change-Id: If753ab1ea0df0bc7938532f6e614b94252fa3f9b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175681 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2024-10-28don't use iterateItemSurrogates for EE_FEATURE_FIELDNoel Grandin6-38/+148
Change-Id: I96cd1728e2358d4ea49275952726aae85e6f52a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175726 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-10-28cid#1606943 Overflowed constantNoel Grandin1-0/+1
Change-Id: If097a933e8d856e4528313cd351959ceb9041b27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175718 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-10-28Set the native tracking area in -[SalFrameView updateTrackingAreas]Patrick Luby3-14/+37
NSTrackingArea has an immutable rectangle so it cannot grow when the SalFrameView's window is resized. So, whenever the SalFrameView's bounds change, remove the old NSTrackingArea and add a new one with the SalFrameView's current bounds. Change-Id: I70a5be7fbe6dd6b5f4f2ed4878dd12a36ab3622b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175708 Reviewed-by: Patrick Luby <guibomacdev@gmail.com> Tested-by: Jenkins
2024-10-28make quotes warning clearer for conditional format dialogPranam Lashkari1-1/+1
Change-Id: I70fcc98962c46be32352fad72d5717fa685b881e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175133 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit d3bc1970fa9bd7acf7a6d0a2e1dba756cfc70e86) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175618 Reviewed-by: Pranam Lashkari <lpranam@collabora.com> Tested-by: Jenkins
2024-10-28tdf#163467 svx: calculate fill color with transparencyPranam Lashkari1-7/+35
calculate absolutely visible color based on transparency against the doc background TODO: calculate this color based on the object in the background to increase visibility more Change-Id: I56076c29f10c58c6ee13e1358da92a4685ea01e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175621 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit f8c87d617fc684e8e204a17cbd119c179a7e86e3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175616 Tested-by: Jenkins Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2024-10-28cid#1607622 Overflowed constantNoel Grandin1-0/+3
Change-Id: Ibc60439cd74d00b574d58df89058be625957dd02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175720 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-10-28cid#1606790 Overflowed constantNoel Grandin1-2/+4
Change-Id: I2fbfefb47abb752bba609f2373c237ef39bd4e2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175717 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-10-28Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' to 0568f35bf55b1b028875f84a2108bc209c630eab - Fix Alt text of image + refactor Change-Id: I64832f28bccbf93f9786e1685d645294bd3811bf Reviewed-on: https://gerrit.libreoffice.org/c/help/+/175619 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2024-10-28tdf#162262 sc add "Summary below data" option for Subtotal dialogBalazs Varga23-97/+346
With this option we can set where the summary rows should appear, above or below the datas when we create a new Subtotal area. The default option is "True" (which means the summary rows are below the datas) when we create a new subtotal area. Unless if we already have one subtotal area on the same sheet, in that case the sheet level property, "TotalsRowBelow" contains where should the summary rows be for the new Subtotal's. TODO: add new ODF xml attribute for Summary below Change-Id: Icf86c85041d75c24919cb528846d5bb2b517ca78 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175556 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2024-10-28tdf#130857 qt weld: Don't expect packing props on implicit gridMichael Weghorn1-4/+6
When the "left-attach" or "top-attach" packing properties are not set in QtBuilder::applyGridPackingProperties, just skip processing, but don't trigger an assert. While these packing properties should be set for every child of a "GtkGrid" object in .ui files, there's also the special case of QMessageBox, which uses a QGridLayout for its layout whereas the .ui file for a "GtkMessageDialog" uses a "GtkBox" instead. (See the special handling for "GtkBox" in QtBuilder::makeObject, where the QMessageBox's existing layout is used instead of setting another one.) Therefore, gracefully handle the case where the properties are not set. Without this, the "Save Document?" dialog triggered the assert since commit 3e28b4f0c97d011cf4222941f019ce05fe6b0313 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Fri Oct 25 21:21:25 2024 +0200 tdf#130857 qt weld: Simplify QtBuilder::applyGridPackingProperties Change-Id: I03bc9799c142563ffbf0fa3eadb58bc63e6e23f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175722 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-28 09:20:15 +0000