summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2018-01-25Remove stdlib.h from sal/config.hStephan Bergmann9-2/+19
This reverts 5da3337c007e0572028283d70bad43e9a29d45c1 "readded include stdlib.h, because of missing NULL definition in many headers, #100000, #101685", which is no longer relevant. Change-Id: I544ed9a7afbf7b611bc481b8d50acca3193d93de Reviewed-on: https://gerrit.libreoffice.org/48131 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-25lo_kde5filepicker: cleanup main and add version and help optionsMilian Wolff1-2/+17
This way users can figure out what this tool is about. Most notably, you can run it now with `-h, --help` as one would expect. Change-Id: If8dd3142bdcc96d2962a2647b2187d75666b9394 Reviewed-on: https://gerrit.libreoffice.org/48592 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-01-25Properly restore size of KDE5 file picker dialogMilian Wolff1-1/+0
The event filter we installed prevented the show event from reaching the KDEPlatformFileDialogHelper::show method. This prevented the dialog from being restored to the size chosen by the user previously. Change-Id: I7af457f19f59d27bd104f8f70d9f4767da6641ee Reviewed-on: https://gerrit.libreoffice.org/48591 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-01-25Properly quit the lo_kde5filepicker on Quit commandMilian Wolff2-24/+29
Quitting the event loop is not enough, we also have to get out of the readCommands loop. Return false for this scenario. Also exit the command when an unhandled command comes in, we cannot really recover the stream from this anyways. Change-Id: I7d58724ea0364565e476516d5645cb436ce1d461 Reviewed-on: https://gerrit.libreoffice.org/48590 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-01-25put a ceiling on various fuzzer input sizesCaolán McNamara45-10/+100
Change-Id: I7a53859377e6228542be50fd26af6b0d6701384c
2018-01-25ofz: cache animation size to avoid timeoutCaolán McNamara1-8/+9
Change-Id: Iede591487782a941a9915123b83537ddadd1b4c5 Reviewed-on: https://gerrit.libreoffice.org/48629 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-25Change TimeSeparator for locale la_VA, lld_IT and vec_IT.Winfried Donkers3-30/+30
Change-Id: I0afc3a08a31216efdbddc389dc23f0b04bc92b37 Reviewed-on: https://gerrit.libreoffice.org/48619 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-01-25ofz#5379 TimeoutCaolán McNamara1-1/+1
Change-Id: I876ed253c61a13faae2b31c43fa595b3612cd082 Reviewed-on: https://gerrit.libreoffice.org/48610 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-25clamp normal page sizes as well as notepagesCaolán McNamara1-4/+6
max multiplication is about 4.4 based on SvxMSDffManager::SetModel nMapMul/nMapDiv Change-Id: I97bc6ad76bb43fb46aa521bf852decfdd17883e7 Reviewed-on: https://gerrit.libreoffice.org/48612 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-25sw: try to limit rowspan/colspan attributes a bitMichael Stahl2-0/+49
Not sure what would be a reasonable maximum, but this should at least limit fuzzing to 64k cells at a time. Change-Id: I03c8f828be7ca2d5caeb1f318b55e25ab3f528ef Reviewed-on: https://gerrit.libreoffice.org/48589 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-25tdf#105226 follow up: change time separator for locale it_IT.Winfried Donkers1-10/+10
Change-Id: If994f615b4a9b976086546a80357b75e93952528 Reviewed-on: https://gerrit.libreoffice.org/48615 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2018-01-25Fix incorrect AM/PM symbols in locale it_CH and vec_IT.Winfried Donkers2-4/+4
Follow up of tdf#105226. Change-Id: I31816a36e427338034a30492f2a7ac7f2d0fddd2 Reviewed-on: https://gerrit.libreoffice.org/48616 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-01-25CheckLinkFormulaNeedingCheck() for .xlsx conditional format expressionsEike Rathke1-0/+2
Change-Id: I31ede1a23223a798141a0891deeabd8cf88fff58
2018-01-25tdf#105910 Allow defaults to be used as parameters for RTF control words.ekuiitr3-1833/+1833
[MS-RTF] specifies in "Conventions of an RTF Reader" section ("Change Formatting Property" action), that if a control word requires a parameter, and it isn't specified, then a control-word- specific default value is used. This patch implements the said rule. [MS-RTF]: https://www.microsoft.com/download/details.aspx?id=10725 Change-Id: Ic0b76bf16b01c65e1b89c243698fd46fd6426d90 Reviewed-on: https://gerrit.libreoffice.org/48375 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-01-25tdf#112356 Add help button in watermark dialogOlivier Hallot1-2/+17
Part of documenting the watermark feature of writer Change-Id: I6376a583f02367c0e87fbd62e3bd449633a4dc5d Reviewed-on: https://gerrit.libreoffice.org/48618 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-01-25more GetRegisteredIn obsoleted by StopListeningAll()Bjoern Michaelsen7-21/+20
Change-Id: I7d69a5112e03cec1b8ebdc389940557b4dbd1117 Reviewed-on: https://gerrit.libreoffice.org/48550 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2018-01-25Remove SwEndNoteInfo::ReleaseCollectionBjoern Michaelsen2-5/+4
- obsoleted by SwClient::EndListeningAll() Change-Id: Id086a42e778b7630c44af4a6ddf2a23d77538c2b Reviewed-on: https://gerrit.libreoffice.org/48549 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2018-01-25introduce SwClient::EndListeningAll()Bjoern Michaelsen34-107/+63
- this is to reduce the use of GetRegisterdIn(), which should be an implementation detail - remove SwTOXMark::DeRegister() which did the same for a part of the class tree - remove SwUndoSetFlyFormat::DeRegisterFromFormat(), same - remove doubletracking FrameDeleteWatch::m_bDeleted, just check GetRegisteredIn() Change-Id: Id9364076759446ee5ff1898683c3ca700c1014c9 Reviewed-on: https://gerrit.libreoffice.org/48548 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2018-01-25sw: fix some bug in SwTOXBaseSection::UpdatePageNum()Michael Stahl1-3/+2
Looking at UpdatePageNum_ it's fairly obvious that the 2 vectors aNums and aDescs have to be in sync, but aNums is cleared after each iteration while aDescs is not. Change-Id: I41d8a8df5c4c3ae51aa5ea89c21b01651af5651c
2018-01-25sw: de-pointerise local variable in SwTOXBaseSection::UpdatePageNum()Michael Stahl1-6/+3
Change-Id: I24fcde19ae94cc5a278da6d88e72ce6a57a64951
2018-01-25sw: convert SwDoc::mpDBManager to unique_ptrMichael Stahl3-17/+19
Very odd things are happening in dbmgr.cxx to override this member, so add a 2nd member that points to the DBManager that is actually used. Change-Id: If5d4ea1e4951a0406fddcb71302c53ee7b37a34e
2018-01-25Fix Index::getIndexWeight for empty inputStephan Bergmann1-1/+1
...which triggers the assertion `index >= 0 && static_cast<sal_uInt32>(index) < static_cast<sal_uInt32>(getLength())' in rtl::OUString::operator[] at include/rtl/ustring.hxx:669 (see below for a reproducer). I am not sure whether the case of `startPos == rIndexEntry.getLength()` should really go into the following for loop inspecting `tables`, with a somewhat random `code` of U+0000 (or some other value even?), or should rather be handled explicitly in some other way. Reproducer in an empty Writer document: "Insert - Table of Contents and Index - Bibliography Entry...": "Insert Bibliography Entry" dialog: "ARJ00", "Insert", "AVV00", "Insert", "Close"; "Insert - Table of Contents and Index - Table of Contents, Index or Bibliography...": "Table of Contents, Index or Bibliography" dialog: "Type - Type and Title - Type: Bibliography", "Entries - Sort by - Content", "Entries - Sort Keys - 1: Address", "OK": assert fires Change-Id: I2c9fad2c37bfa7a3509c197e678311fb45cb991a Reviewed-on: https://gerrit.libreoffice.org/48564 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2018-01-25iOS, update intro screenjan Iversen1-0/+0
Update to intro.png used for version 6 Change-Id: Ieeb71854eb98eb3f1be815ea15fecce424a5eba9
2018-01-25iOS, removed unused librariesjan Iversen1-36/+0
libz, libiconv etc are now hidden in loKit.dylib Change-Id: I64e7be0c3ad2087f8c13bcc99d693087e4c6732b
2018-01-25tdf#114519 Update cell content on sidebar number format changeJim Raykowski1-0/+1
In Calc, when the cursor is flashing in a cell (input mode) and the sidebar Number Format panel 'Select a category of contents' drop down selection is changed the cell contents does not update on selection change. This patch ends cell input mode on 'Select a category of contents' drop down change allowing cell to be updated to the selected number format. Change-Id: Ia1f46499ada2cfbcc82bd5babb6cf56ae0d6259c Reviewed-on: https://gerrit.libreoffice.org/46883 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2018-01-25tdf#45904 Move _SheetCell Java tests to C++Jens Carl8-40/+294
Change-Id: I5d698303a901ee103fdd4ffdea34809142afa0e5 Reviewed-on: https://gerrit.libreoffice.org/48463 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-25tdf#89605 Now preview appear on rightKshitij Pathania1-1/+1
Change-Id: I51a98eb94e47c94fdb95702c4dc3fd7173d8fb58 Reviewed-on: https://gerrit.libreoffice.org/48536 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-01-25iOS, simplified dylib buildjan Iversen3-71/+33
Change-Id: Icea9a5e4796dda288fafcd478a769fa7087baab2
2018-01-25iOS, corrected directory creation.jan Iversen1-24/+31
the setup mk did not always create the needed directories. and corrected typo Change-Id: I58a40a67d91101504b7802a1fc73105df68a4ca4
2018-01-25fpicker: Respect the PrepareExecute() resultPranav Kant1-1/+2
Change-Id: I351eaa76da01656638de5f04eb376e5b16102b4a
2018-01-25drop GetPageSize no-op functionCaolán McNamara2-8/+2
which used to have some commented out stuff which considered changing the size, but was all removed ages ago Change-Id: Iff62a71e9b7d31acb16016b5e72d168327111ce7 Reviewed-on: https://gerrit.libreoffice.org/48583 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-25Adapt odd USHRT_MAX/4 limit in FIELD_PROP_PROP_SEQ handlerStephan Bergmann1-1/+4
The code was added with 8ff71b59a7f714835e1faa2781b34b4c5b811a84 "TextField and FieldMaster 'Bibliography' completed", but, according to private communication with Oliver, that specific values was chosen rather randomly. Still, other parts of the code assume m_SortKeyArr to be indexed by sal_uInt16, so use SAL_MAX_UINT16 here to ensure the array is not getting to big causing overflow in those other places. Change-Id: I18ed75ed7c88b04e174a82194ae7d93a5f7f7c76 Reviewed-on: https://gerrit.libreoffice.org/48443 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-25tdf#115227 svtools: suppress UNO notifications for color selectorsMiklos Vajna4-16/+61
This is nominally a regression from commit 43bc3031483d172eccd72c3804e2d4fc2ef37de4 (unify color selectors, 2016-10-28), but that just changed the Writer color picker to behave the same way as the Impress one. The Impress one started to emit these events with daeed90f4586eb9533041fb89bee163a5193596c (re-base on ALv2 code. Includes:, 2012-11-15), to fix i#118707, improving accessibility. That means either the focus changes and then accessibility is happy or the focus does not change and then the UNO API client only gets events when the user actually switches to an other window. Fix the problem with suppressing UNO-level notifications for the problematic events, by moving the existing VclListenerLock to a public header and using it at two more places in svtools. This should address not just color selectors, but in general other toolbar menus / popup windows. Change-Id: If427708c5b9fe4fa49cb8f00ec04b32cb28eb391 Reviewed-on: https://gerrit.libreoffice.org/48570 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-25Fix typosAndrea Gelmini2-2/+2
Change-Id: I31741b4f42fcc7e58d383e204f3e305b9de1a4c4 Reviewed-on: https://gerrit.libreoffice.org/48248 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-25Don't preset SwAuthorityField::m_SortKeyArr with three empty elementsStephan Bergmann1-1/+0
This appears to be a mistake introduced with 0be2a98cc04ee26f605a6f6e7efbdee325560a91 "Convert V_DECL_PTRARR_DEL(SortKeyArr) to boost::ptr_vector", where the original svl/svarray.hxx-based SortKeyArr ctor had a parameter specifying the initial capacity. But the mistake was apparently harmless as uses of SwAuthorityField appear to always fill m_SortKeyArr via SwAuthorityFieldType::PutValue or SwAuthorityFieldType::SetSortKeys (which both first clear m_SortKeyArr) before accessing m_SortKeyArr otherwise (as observed when playing around with Writer "Insert - Table of Contents and Index - Table of Contents, Index or Bibliography...", and in the "Table of Contents, Index or Bibliography" dialog doing "Type - Type and Title - Type: Bibliography", "Entries - Sort by - Content", "Entries - Sort Keys - 1: Address", etc.). Change-Id: I0901b3b790f8390e743d5802116f13e7261e83eb Reviewed-on: https://gerrit.libreoffice.org/48563 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-25tdf#115129 Add function on double click in Customize DialogJim Raykowski2-0/+9
Change-Id: I21a7f8b4fc05d55d1539a3fd148e5870899b1596 Reviewed-on: https://gerrit.libreoffice.org/48555 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-01-25CheckLinkFormulaNeedingCheck() for .ods conditional format expressionsEike Rathke1-0/+6
Change-Id: I45eb1ab5efa0ec9da2663f20427d2474ce300826
2018-01-25Prepare CheckLinkFormulaNeedingCheck() to use either RPN or tokenized codeEike Rathke1-2/+15
Conditional format formulas aren't finally compiled until needed so the check will have to operate on the tokenized expression instead of RPN code. Change-Id: I68837e9bd33f125ab47b10b1a6fa18175abd1627
2018-01-25tdf115103: find data source if sDataSource/sCommand are emptyAron Budea1-7/+14
In several functions data source was only found if sDataSource and sCommand corresponded to what was set in fields. In imported DOC(X) files these aren't set. Now use the data source even if field's sDataSource/sCommand are empty (similarly to SwDBManager::IsDataSourceOpen(...)). Change-Id: I9563cb56e700e7fd033100cb200f41f074669020 Reviewed-on: https://gerrit.libreoffice.org/48285 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Aron Budea <aron.budea@collabora.com>
2018-01-25ofz#4849 Direct leakCaolán McNamara1-5/+12
Change-Id: If9b7f6de42d99c76165aec775b8cde2505df0c62 Reviewed-on: https://gerrit.libreoffice.org/48561 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-25Correct comment for this testTamás Zolnai1-1/+1
Change-Id: If83cdc11398fa8360c7d4702a208203d213d5718
2018-01-25loplugin:useuniqueptr in OInputCompStreamNoel Grandin2-4/+3
Change-Id: I49fb71aa4319f6ac245885535e8afe855113e162 Reviewed-on: https://gerrit.libreoffice.org/48557 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-25loplugin:unused-returns in basegfx..cppcanvasNoel Grandin32-123/+68
Change-Id: I32dc8c92871c8349651d2f4204a332d387e6e1b2 Reviewed-on: https://gerrit.libreoffice.org/48428 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-25ooxmlimport: support inherited listidJustin Luth5-46/+74
This is prep work for tdf#95377. This unit test avoids the unique chapter-numbering style (from the heading paragraph styles) and just has a basic, user-created style inheriting from Default. Also unique about this unit test is that the numbering is specified by the "Default Style" which takes a rather unique code path and exposes even more problems. We already know the listId through a recursive function, and GetCurrentNumberingRules only looks at the current style which isn't good enough. Moved that modified function into DomainMapper_Impl since I will need it there for bug 95377. Additionally, ensure that directly applied paragraph properties are not overwritten. That also meant changing the order, so that paraStyle properties are directly applied to the paragraph before applying RightMargin and friends. Change-Id: I5c1fb71d64727be9d9105f287150daf4e0ff413d Reviewed-on: https://gerrit.libreoffice.org/48457 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-01-25loplugin:useuniqueptr in ContentResultSetWrapperNoel Grandin2-13/+10
Change-Id: I798e5b06a5b2f9377f22a86f7b630ffdc20e10c6 Reviewed-on: https://gerrit.libreoffice.org/48559 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-25loplugin:useuniqueptr in SAXEventKeeperImplNoel Grandin2-14/+14
Change-Id: I1bb683dc8d492db73c2f2cc07c67b4dcb75bc1fb Reviewed-on: https://gerrit.libreoffice.org/48558 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-25tdf#115180: take table base width into accountMike Kaganski4-1/+19
Change-Id: I4238e6c757499e289193efa3498fb1e68d5f3e9c Reviewed-on: https://gerrit.libreoffice.org/48501 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-01-25Updated coreIlmari Lauhakangas1-0/+0
Project: help 67a993c05d19976f5ed347b16584d29d6866a870 Module names must stay uppercase due to DbPAR=MODULE Change-Id: I10cea1b204b20d482abec6a8f66d5cfee6cf6dfe Reviewed-on: https://gerrit.libreoffice.org/48509 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-01-25sw: uninitialised DocumentRedlineManager::bHideLinineTooltipsMichael Stahl2-12/+13
(regression from 86e3f95cff4d3dad48d64e50e0c4b05034fa7064) Change-Id: I48db6f070d7cf5ef0071952ad34822f75d472a21
2018-01-25Undo "check for boost/process/child.hpp in configure.ac if --enable-gtk3-kde5"Milian Wolff1-4/+0
This reverts commit c7a1320593191e8359aa64d8e262948da085d358. It's no longer required since we ported away from boost.:process Change-Id: I53c5b994c3ba2801823ba0d6ab25f43223db1476 Reviewed-on: https://gerrit.libreoffice.org/48491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-22 10:40:29 +0000