summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2022-09-20vcl: Add PhysicalFontFace::GetName()Khaled Hosny6-52/+80
Change-Id: I91cc7bd0b9c9ce8d59a31d17a354fb3f2be29499 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140219 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@aliftype.com>
2022-09-20tdf#150990 ODT export: fix zero layout size of scale/scale imagesMiklos Vajna2-2/+47
The bugdoc has a broken image where both axis are set to a relative size of 255%, which means "keep aspect", and the expectation is that only one axis uses this to match the size of the other axis. The problem was that commit b578fa08a25a83abccad2386e12b707586fffb26 (ODT export: fix fallback svg:width/height for text frames with relative sizes, 2022-03-16) assumed that only one axis uses "scale", so we always get a non-zero layout size. Fix the problem by only using the layout size when exactly one axis uses the "scale" percentage, which is the expected the case. This way we just keep the aspect ratio of broken documents, then the UI will in practice ignore the scale request of the width. Change-Id: I2dbd6bb92f912f6185422fd301b99b284a66ef74 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140218 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-09-20tdf#150613 sw: better DOC import of paragraph marker formattingJustin Luth5-3/+34
Following the lead of LO 6.4 commit 5ba30f588d6e41a13d68b1461345fca7a7ca61ac. This fixes a LO 7.2 regression from tdf#108518. This patch depends on tdf#117994 being fixed in order for ww8export3's testTdf108518_CRnumformatting to round-trip. The problem here is that Word allows formatting the paragraph end marker, and applies the same formatting to the generated numbering string; Writer has no such marker thing. On m_xCtrlStck, the rPos is pointing to the end of the paragraph. GetStackAttr looks for char properties that are still m_bOpen or else where the Point (Mark is the Start, Point is the End) is greater than aPos. Well, at the end of the paragraph I don't think there can be any empty (point==mark) hints in .DOC, so this should only pick up properties that are spilling over onto the CR - just like we want. Change-Id: I06cab075f102d40f93d33fedf5ae0ce8e165e9fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139329 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-09-20tdf#150604 related: fix logic used in determining inclusion ofJim Raykowski1-12/+12
a separator in the Navigator content tree context menu In commit fbc9c8e3759ab79fce457565cd725c5a5353186e, https:// gerrit.libreoffice.org/c/core/+/139628, made to include the content type name in the 'Delete' menu item in the content type content entry context menu, I mistakenly used logical OR'ing where logical AND'ing should be used to determine if a 'Delete' menu item is present, which is used in determining wheather menu item separator, 'Separator2', is included. Change-Id: I4a49895db9e39a0a2feedac8ec3d3440945e8abd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140211 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-20simplify usage of TempFile in swNoel Grandin2-45/+40
TempFile already handles the stream. And not touching the URL means we stay on the fast path for temp files. Change-Id: I7e5f1cb7c83fc78d392c6874154563b64dd4a672 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140203 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-20sw content controls: add a11y description for PDF exportMiklos Vajna6-0/+100
Acrobat Reader shows these descriptions on mouse hovering on a form widget. Change-Id: I8614222e46c992baca8a57b13a948f88973e8911 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140215 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-09-20simplify usage of TempFile in scNoel Grandin2-14/+16
TempFile already handles the stream. And not touching the URL means we stay on the fast path for temp files. Change-Id: I15f51b75d3bb8ed53d617fce373237f685d45e00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140204 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-20an implicit intersection requires a svDoubleVectorRefLuboš Luňák1-1/+2
This was claiming e.g. =TTEST(A1:A10,B1:B10,1,2) had implicit intersections because the 3rd and 4th arguments were found to be implicit intersections. Change-Id: I9cba7e63330dd170ef0ea1ab03d33a653000e669 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140189 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-09-20correct handling of 'nested' in opencl vectorsLuboš Luňák1-8/+8
The 'nested' arguments means the value is used inside a loop, which already implicitly does range checking. Change-Id: I71ccbded2f9d623f58d11f11316aab28385f1614 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140193 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-09-20reduce opencl copy&paste in op_statistical.cxx (svDoubleVectorRef pair)Luboš Luňák4-1252/+318
Change-Id: I92daab29290c9d72f7531b25950c7f52084cc0bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140192 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-09-20reduce opencl copy&paste when handling a pair of svDoubleVectorRefLuboš Luňák3-321/+170
Some functions run one loop iterating two svDoubleVectorRef. Change-Id: I849becd7863a1740277e6da9625bc7daad4b5274 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140191 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-09-20external/fontconfig: Avoid UBSan invalid-null-argumentStephan Bergmann2-0/+14
...as seen when CppunitTest_services is run while instdir/share/fonts/ happens to still be unpopulated (which is otherwise not an issue for that test), > fcdir.c:268:11: runtime error: null pointer passed as argument 1, which is declared to never be null > /usr/include/stdlib.h:852:30: note: nonnull attribute specified here > #0 in FcDirScanConfig at workdir/UnpackedTarball/fontconfig/src/fcdir.c:268:5 > #1 in FcDirCacheScan at workdir/UnpackedTarball/fontconfig/src/fcdir.c:354:10 > #2 in FcDirCacheRead at workdir/UnpackedTarball/fontconfig/src/fcdir.c:462:10 > #3 in FcConfigAddDirList at workdir/UnpackedTarball/fontconfig/src/fccfg.c:537:10 > #4 in FcConfigAppFontAddDir at workdir/UnpackedTarball/fontconfig/src/fccfg.c:2912:10 > #5 in psp::PrintFontManager::addFontconfigDir(rtl::OString const&) at vcl/unx/generic/fontmanager/fontconfig.cxx:748:20 > #6 in psp::PrintFontManager::initialize() at vcl/unx/generic/fontmanager/fontmanager.cxx:711:17 > #7 in GenericUnixSalData::InitPrintFontManager() at vcl/unx/generic/app/gendata.cxx:51:26 > #8 in GenericUnixSalData::GetPrintFontManager() at vcl/inc/unx/gendata.hxx:88:13 > #9 in psp::PrintFontManager::get() at vcl/unx/generic/fontmanager/fontmanager.cxx:108:23 > #10 in GenPspGraphics::GetDevFontListHelper(vcl::font::PhysicalFontCollection*) at vcl/unx/generic/print/genpspgraphics.cxx:264:35 > #11 in FreeTypeTextRenderImpl::GetDevFontList(vcl::font::PhysicalFontCollection*) at vcl/unx/generic/gdi/freetypetextrender.cxx:110:5 > #12 in SvpSalGraphics::GetDevFontList(vcl::font::PhysicalFontCollection*) at vcl/headless/svptext.cxx:51:23 > #13 in OutputDevice::ImplInitFontList() const at vcl/source/outdev/font.cxx:651:17 > #14 in OutputDevice::GetDefaultFont(DefaultFontType, o3tl::strong_int<unsigned short, LanguageTypeTag>, GetDefaultFontFlags, OutputDevice const*) at vcl/source/outdev/font.cxx:532:22 > #15 in SwStdFontConfig::GetDefaultFor(unsigned short, o3tl::strong_int<unsigned short, LanguageTypeTag>) at sw/source/uibase/config/fontcfg.cxx:245:23 > #16 in SwStdFontConfig::SwStdFontConfig() at sw/source/uibase/config/fontcfg.cxx:91:30 > #17 in SwModule::SwModule(SfxObjectFactory*, SfxObjectFactory*, SfxObjectFactory*) at sw/source/uibase/app/swmodule.cxx:150:32 > #18 in std::__detail::_MakeUniq<SwModule>::__single_object std::make_unique<SwModule, SfxObjectFactory*&, SfxObjectFactory*&, SfxObjectFactory*&>(SfxObjectFactory*&, SfxObjectFactory*&, SfxObjectFactory*&) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/13.0.0/../../../../include/c++/13.0.0/bits/unique_ptr.h:1076:34 > #19 in SwDLL::SwDLL() at sw/source/uibase/app/swdll.cxx:98:26 > #20 in (anonymous namespace)::SwDLLInstance::SwDLLInstance() at sw/source/uibase/app/swdll.cxx:57:212 > #21 in rtl::Static<(anonymous namespace)::SwDLLInstance, (anonymous namespace)::theSwDLLInstance>::get() at include/rtl/instance.hxx:399:18 > #22 in SwGlobals::ensure() at sw/source/uibase/app/swdll.cxx:70:9 > #23 in SwXAutoTextContainer_get_implementation at sw/source/uibase/uno/unoatxt.cxx:1015:5 Change-Id: Ic0d246e6012b3cd2c9a9deb63c2af7258f31f0d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140214 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-09-20error handling in openCL FORECAST(), MIRR() and SERIESSUM()Luboš Luňák3-4/+16
Change-Id: Ied72d13953ebd765fc0ed8838b557487f5f74e2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140190 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-09-20reduce opencl copy&paste WRT simple loops with svDoubleVectorRefLuboš Luňák8-2899/+406
Change-Id: Id68808d5b390c0771e82bf391930a840f423c1e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140188 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-09-20reduce opencl copy&paste also when handling svDoubleVectorRefLuboš Luňák3-155/+106
This is for when a simple loop is enough to handle the ranges. Change-Id: Ia2fa3b6944573f30fafea614a9ec51a21c7e8226 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140187 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-09-20reduce opencl copy&paste and fix in op_statistical.cxxLuboš Luňák1-1118/+125
So far functions using svDoubleVectorRef are excluded. Change-Id: Ie8a72d7f72de34c422b23bcc526ac66f6b170b10 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140186 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-09-20reduce opencl copy&paste and fix in op_financial.cxxLuboš Luňák1-2479/+437
Change-Id: Ia1cd64f68b75f445c15ec5f8088e9202fa39768e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140185 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-09-20tdf#89928 pptx import: implement import of BiLevel thresholdSarper Akdemir5-0/+90
Implement import BiLevel effect's threshold value. If threshold isn't exactly 50%, we can't map it to the doc model. Therefore as a workaround apply the BiLevel (Black/White) effect with specified threshold directly to the graphic. Change-Id: Ib24d149d74b103d926560708c68bb937b02c4cfe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140136 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-09-20sw: document SwUndoInsDocMiklos Vajna1-0/+1
Also reachable via UNO in SwUnoCursorHelper::InsertFile(). Change-Id: I72564e62cfd9e9d7ebfbf23a55964885b0fe3ebf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140200 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-09-20tdf#151070 Leverage UI layout to show relation between buddy optionsAdolfo Jayme Barrientos1-8/+7
And this is why LibreOffice is found by users to be hard to use: because we suck at layouting. Just by swapping a checkbox and a combobox, the relation between the two magically becomes INTUITIVE. Change-Id: Id3801015a6e75d1372d46f1e2d99cfb3a662496d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140213 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-09-20tdf#94122 pptx export: fix automatic text color exportSarper Akdemir3-0/+59
MS Powerpoint doesn't have automatic colors unlike Word or Excel. Therefore on export the automatic text color should be first resolved and then exported. Change-Id: Ied2c3a4235da403350d8518a3414ff6a372b57a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140059 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-09-20Simplify a bit by using sal_uInt16 in vcl/BitmapPopArtFilterJulien Nabet2-13/+10
Since we're in the "if (bRet)" block, it means 22 bool bRet = isPalettePixelFormat(aBitmap.getPixelFormat()) 23 || aBitmap.Convert(BmpConversion::N8BitColors); is verified. isPalettePixelFormat implementation is: 29 constexpr bool isPalettePixelFormat(PixelFormat ePixelFormat) 30 { 31 assert(ePixelFormat != PixelFormat::INVALID); 32 return sal_uInt16(ePixelFormat) <= 8; 33 } So we know we're using 8 bits max and this line: pWriteAcc->GetBitCount() can't give more than 8 and we can safely declare nEntryCount as sal_uInt16 (idem for "n" just below) Since "nFirstEntry" and "nLastEntry" are related to "nEntryCount", idem for mnIndex they can also be sal_uInt16. Thanks to these, we can avoid all sal::static_int_cast<sal_uInt16> conversions. Change-Id: I8cac2d01f00be33c86058c7a6eb7b9e25fb2635e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140206 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-09-20tdf#151071 Revise Sifr to follow upstreamRizal Muttaqin4056-2932/+2028
Change-Id: Ie72cbfc50c323b4d44b08440945ea171b4a4330d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140212 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-09-20simplify usage of TempFile in sdNoel Grandin1-8/+4
TempFile already handles the stream. And not touching the URL means we stay on the fast path for temp files. Change-Id: I8672c5749f1e0dc95e59cd9d713015586301ae34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140202 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-20simplify usage of TempFile in scNoel Grandin4-25/+16
TempFile already handles the stream. And not touching the URL means we stay on the fast path for temp files. Change-Id: Icab41d12ab7846b8901a92c11fee05952b98fafc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140201 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-20tdf#112237 Show tooltips for Assigned Commands in Customize dialogJim Raykowski5-3/+39
Change-Id: Iff1946d5d6ac7f2046d36df8fbd76e32edf371c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140142 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-09-19Update git submodulesAdolfo Jayme Barrientos1-0/+0
* Update helpcontent2 from branch 'master' to 80034ff19535b6320a8ea113a9cf2f068e6aea31 - Wrong words Change-Id: I391a5fd97005fcffac324581856bbdb8a48f1ae9
2022-09-19tdf#132519: sc_ucalc_formula: Add unittestXisco Fauli1-0/+25
Change-Id: Ie2ff5a8961556cf21ca75a58d46f37754e0bb61b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140183 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-09-19tdf#151046: sc_subsequent_filters: Add unittestXisco Fauli2-0/+19
Change-Id: I552d53f511373b170985185361621d8e149e582b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140184 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-09-19loplugin:unreffun (clang-cl)Stephan Bergmann1-5/+3
...and with ScopedFontHDC::fsp gone, there appears to be no reason to keep ScopedFontHDC::m_aFSP alive for the whole lifetime of the ScopedFontHDC instance Change-Id: I1028bc24f49f3bbaf6e23c09aef4459418267154 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140100 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-09-19tdf#151052 set Windows darkmode "ToolTextColor" to same as "WindowTextColor"Caolán McNamara1-1/+2
they are the same in light mode, so do the same in darkmode Change-Id: Ib0186383fcd7f8d74c7ada6826c6955a747e4ecd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140195 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-19size this OUStringBuffer at initial constructionNoel Grandin1-1/+1
Change-Id: I6414281cef5eedf1e797139695bf05c72c300447 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140181 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-19crashtesting: "unknown cell text: element" assert for text:bookmark #2Justin Luth1-0/+2
since... commit 690a35680adad07c4ab79d82cd1531bb82fe4bc1 Date: Sat Sep 10 16:32:46 2022 -0400 tdf#103829 ods import: parse <text:tab/> From documentation, it looks like we can also have bookmark-start and bookmark-end, so adding these even though no examples found. I looked for how to insert bookmarks in calc - basically no UI or menu (except one notebookbar, no calc documentation, no abandoned bookmark code removal, no bookmark import code. IIUC, in writer a bookmark is basically a field. Perhaps it is similar in Calc? In any case, with this limited wealth of information, I don't plan on trying to fix the LO 4.1 loss of bookmark. Change-Id: I44708a5c7d69ce37f688ec7beb243e08844dbfa8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140197 Tested-by: Justin Luth <jluth@mail.com> Reviewed-by: Justin Luth <jluth@mail.com>
2022-09-19Fix typosAndrea Gelmini2-2/+2
Change-Id: If24b9756d7fd8f6346580b4da84fac4f5ab1d3ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140198 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-09-19Fix typosAndrea Gelmini2-3/+3
Change-Id: If33ae9acbc1ed17398584efa3574566b2d854b3e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140149 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-09-19sw HTML import: fix height of images when it is missing and width is relativeMiklos Vajna3-10/+71
This is similar to commit 456abae730a787693c3ad98f7e57eba5f6163a76 (sw HTML import: fix height of OLE objs when it is missing and width is relative, 2022-09-06), but this is for images, while that was for OLE objects. The idea is still that in case only axis is specified in the HTML and that's a relative percentage, then the ratio should be taken from the bitmap and it should be kept. Change-Id: I36184ff6531bff2775013462cd8cc711e1a249c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140178 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-09-19tdf#75702 sc: unit test for preserving text:line-breakJustin Luth2-1/+20
Change-Id: Id61e46ba4e0b3e2b534cf9f8bafe03fba10cd355 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140182 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2022-09-19Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' to 4b86dd440667832cd5510a1bd31ff35514532d06 - tdf#119421 Add sample files for conditional formatting Change-Id: Id5826f32bd2de2e286eecf57dc817f4b60a2599b Reviewed-on: https://gerrit.libreoffice.org/c/help/+/140196 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-09-19tdf#150650 Fix changing fill style to None via SidebarSamuel Mehrbrodt1-3/+13
Regression from 5491a82854e3e6dd2dbb4b0012cb4bbeb4ee22e0 Change-Id: I17cfb037f2064a508317090e6b66f20e253a9436 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140150 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2022-09-19no need to use an OUStringBuffer hereNoel Grandin1-13/+8
can just return the substring we need Change-Id: I9d605cb809f58fcf60c0ae2e29aaff17baa9faa0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140177 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-19use optional in processEntryNoel Grandin1-13/+6
which means we save the cost of initialising an OUString Change-Id: Ib139383b43f6d49303e20368ce4177b068c38ed9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140176 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-19Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' to 9abe3f66a8951fef89d79b5125931773778cda22 - tdf#119421 Enchancements to Conditional Format pages Add icons and how-to-get Change-Id: I1fb78ac737bc37745ee76d4508116edadd283938 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/140130 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2022-09-19try harder to remove "OSL_PIPE" pipe on SIGTERMCaolán McNamara2-3/+23
a) When oosplash got SIGTERM it used SIGKILL on soffice.bin, (concealed behind osl_terminateProcess) so soffice.bin has no chance to cleanup. Try SIGTERM, followed by SIGKILL if that doesn't work, to give soffice.bin a chance. b) java intercepts SIGTERM so if JNI_CreateJavaVM was called then our SIGTERM handler doesn't get called. Add -Xrs to jvm args to avoid this. Change-Id: I09f93d8093bc7c094482eda73b4eadc5a6cebb83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140152 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-09-19move code out of formulagroupcl.cxx to op_math* and opbase*Luboš Luňák5-908/+1008
formulagroupcl.cxx is already large enough, move away code that implements some operations and also move some type declarations to a header. Change-Id: I28fe59275f4fb89c3e530d77b08e7f2fcad02781 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139971 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-09-19tdf#150992: fix crash popart filter to an SVG imageJulien Nabet1-1/+1
part of bt: 6 0x00007f018c80186f in BitmapPalette::operator[](unsigned short) const (this=0x5576a198fe48, nIndex=176) at vcl/source/bitmap/bitmappalette.cxx:139 7 0x00007f018c3d1fce in BitmapInfoAccess::GetPaletteColor(unsigned short) const (this=0x5576a2bbc520, nColor=176) at include/vcl/BitmapInfoAccess.hxx:121 8 0x00007f018c85b63f in BitmapPopArtFilter::execute(BitmapEx const&) const (this=0x7fffb7394728, rBitmapEx=...) at vcl/source/bitmap/BitmapPopArtFilter.cxx:73 9 0x00007f018c83e66b in BitmapFilter::Filter(BitmapEx&, BitmapFilter const&) (rBmpEx=..., rFilter=...) at vcl/source/bitmap/bitmapfilter.cxx:22 10 0x00007f01905e5bd4 in SvxGraphicFilter::ExecuteGrfFilterSlot(SfxRequest const&, GraphicObject&) (rReq=..., rFilterObject=...) at svx/source/dialog/grfflt.cxx:202 some gdb info (gdb) p nIndex $1 = 176 (gdb) p mpImpl->GetBitmapData().size() $2 = 34 full bt here: https://bugs.documentfoundation.org/attachment.cgi?id=182499 See https://bugs.documentfoundation.org/show_bug.cgi?id=150992#c2 for some comments the main thing that makes me think that the order is reversed is the "nLastEntry" treatment. Indeed with the current sort, mnCount with 0 come first nLastEntry = nEntryCount - 1 (unless there's no color at all) Change-Id: I3b89f2f4d6f115ea9f6752c49bad776a33f0b020 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140153 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-09-19can return by const& in PopStringNoel Grandin2-2/+2
and avoid some ref-counting Change-Id: Id1e6fc09d1c517ce168cebb7a225aa6df48e72c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140138 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-19Update git submodulesAlain Romedenne1-0/+0
* Update helpcontent2 from branch 'master' to 30682f2fa484e9a831ac20c26bfd19aab6c42a82 - Reuse and sync help content Change-Id: Ia95c3da543efd8dddfdcfa635d316b3c10fa52eb Reviewed-on: https://gerrit.libreoffice.org/c/help/+/139569 Tested-by: Jenkins Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
2022-09-19tdf#150402 Correct wrong Bound of Shape in SlideshowArmin Le Grand (allotropia)2-3/+32
Added and use mbContainsPageField that gets set in prepareHyperlinkIndices() which has to be run anyways, so this will cause no change in execution speed. It lets us detect the potential error case that a PageField is contained in the Text of the Shape. That is a hint that maBounds contains the wrong Range and needs to be corrected. For more backgrund information please refer to tdf#150402, Comment 16. Change-Id: Ifee01fffdb6e2f5915aa705afc7b5842781aae91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140144 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2022-09-19tdf#150802 Fix setting gradient from SidebarSamuel Mehrbrodt1-14/+51
Regression from adc536e9efc77690df62177aa722f9252bdbf96b Change-Id: I37db76373a3b9b4a1084e830233561abc4b1e6d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140151 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2022-09-19Update language-subtag-registry to 2022-08-08Eike Rathke1-2/+2
Change-Id: I08609e88c1bdb62f778db25156363fbc6d2adff6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140148 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-25 16:52:12 +0000