summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2019-10-21jsdialogs: force resend UI descriptionSzymon Kłos1-1/+2
Change-Id: I8d3466df6f2ad75c33ce2f9a91da9e9361201c0b Reviewed-on: https://gerrit.libreoffice.org/81050 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-21size some stringbuffer to prevent re-allocNoel Grandin43-128/+131
found by the simple expidient of putting asserts in the resize routine. Where an explicit const size is used, I started with 32 and kept doubling until that site did not need resizing anymore. Change-Id: I998787edc940d0a3ba23b5ac37131ab9ecd300f4 Reviewed-on: https://gerrit.libreoffice.org/81138 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-21Don't create unnecessary tempfiles for opened docSamuel Mehrbrodt2-2/+2
A copy of the doc was created for each opened file as a temp file. Try to avoid that. Change-Id: I11db2a9c8d77b954de56a6e977b1555c8f876416 Reviewed-on: https://gerrit.libreoffice.org/81031 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-10-21loplugin:virtualdead unused param in ThumbnailViewItem::calculateItemsPositionNoel Grandin6-9/+6
Change-Id: I8db99a3672e3603a25ee1f6ca4741a02b73c9516 Reviewed-on: https://gerrit.libreoffice.org/81184 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-21loplugin:virtualdead unused param in FmXDisposeListener::disposingNoel Grandin4-7/+4
Change-Id: I2189f0a35b03bc8192ab91cd63b210f303f5d3e6 Reviewed-on: https://gerrit.libreoffice.org/81182 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-21loplugin:virtualdead unused param in SdrHdl::onHelpRequestNoel Grandin5-8/+5
Change-Id: I3d75755bd6fd7f3168725c53fd8ce571a938fa37 Reviewed-on: https://gerrit.libreoffice.org/81181 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-21loplugin:virtualdead unused param in GetSdrRepeatCommentNoel Grandin3-20/+17
Change-Id: I0a27d1a200e8af50adf98de2c5ba7d3c7e199b00 Reviewed-on: https://gerrit.libreoffice.org/81180 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-21loplugin:virtualdead unused param in CreateSvxFormatCellsDialogNoel Grandin6-9/+5
Change-Id: I8455c10d62ae8c3c3e6e543301f8c69a1189456a Reviewed-on: https://gerrit.libreoffice.org/81179 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-21tdf#127773 AutoCorrect Dialog Localized Tabandreas kainz1-14/+28
Change-Id: I7a54bd963447e98b13760b52938b0f46df5a90c1 Reviewed-on: https://gerrit.libreoffice.org/81188 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-10-21Column Dialog sort and sizegroup fixandreas kainz1-11/+17
Change-Id: Ia4ec437231506dba42cc8592259b2ad96b1b4866 Reviewed-on: https://gerrit.libreoffice.org/81190 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-10-21tdf#127773 AutoCorrect Dialog Wordcomplete Tab sizegroup fixandreas kainz1-1/+2
Change-Id: Iae6958172a5f7943cc5032845a29d258c3ffd79f Reviewed-on: https://gerrit.libreoffice.org/81189 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-10-21tdf#45904 Move XGluePointsSupplier Java test to C++Jens Carl2-1/+5
Move XGluePointsSupplier Java test to C++ for ScAnnotationShapeObj. Change-Id: I573f28f1b1bdf8e8fa41ef14cfd3d8ea4deaf751 Reviewed-on: https://gerrit.libreoffice.org/81150 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-10-20loplugin:virtualdead unused param in Task::UpdateMinPeriodNoel Grandin9-16/+9
Change-Id: Ie24f56fed811b3b317d6c20e15289e7cecfb738d Reviewed-on: https://gerrit.libreoffice.org/81157 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-20loplugin:virtualdead unused param in SvListView::ModelIsMovingNoel Grandin5-17/+6
Change-Id: I83af14bb3a29cb8a4a36f714ac2fb91687f13996 Reviewed-on: https://gerrit.libreoffice.org/81156 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-20Don't need an explicit width_request hereCaolán McNamara1-1/+0
I suspect the fix of autocorrect dialog width grows on change of new to replace commit f6a2b24ce17293043f7ddbed0bc218264be6487d Author: Caolán McNamara <caolanm@redhat.com> Date: Mon Sep 30 14:18:29 2019 +0100 negates the need for the explicit arbitrary width_request added in tdf#127773 AutoCorrect Dialog AutoCorrect Tab update commit f5bdc014192f92d06ad278ac4ccbdb52c4958b6a Author: andreas kainz <kainz.a@gmail.com> Date: Wed Oct 2 23:54:46 2019 +0200 Change-Id: I538e98928e50874e5d3c382e454f68c2ac61f0b0 Reviewed-on: https://gerrit.libreoffice.org/81174 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-20cid#1453991 Wrapper object use after freeCaolán McNamara6-12/+28
Change-Id: I6476c765589cbb3996ad8832a0e159aa4d965d32 Reviewed-on: https://gerrit.libreoffice.org/81173 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-20fix "invalid cast from 'GtkImage' to 'GtkLabel'" warningsCaolán McNamara1-0/+2
Change-Id: Ic7d0457102b4077dad49d56741ca04e9afe49e8d Reviewed-on: https://gerrit.libreoffice.org/81175 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-20loplugin:virtualdead unused param in RedlineAdjustStartNodeCursorNoel Grandin9-15/+11
Change-Id: Ic8eaad705b0cf8289035f7eee3ad01439fc24ee7 Reviewed-on: https://gerrit.libreoffice.org/81155 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-20loplugin:virtualdead unused param in XMLEventContextFactory::CreateContextNoel Grandin7-17/+6
Change-Id: I6fda2e04724d69fd218ffc85f9881b429714e63b Reviewed-on: https://gerrit.libreoffice.org/81154 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-20cid#1453991 Wrapper object use after freeCaolán McNamara4-7/+15
Change-Id: I4ea3ed40deaf20e91e1a0a42ee115cf761853875 Reviewed-on: https://gerrit.libreoffice.org/81170 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-20ofz#18301 Timeout in xlsfuzzerCaolán McNamara1-0/+4
Change-Id: I7e18899fe2c0ef2d1b553bbbaab383e7ea9f1451 Reviewed-on: https://gerrit.libreoffice.org/81171 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-20Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' - Reduce string repetition in XForm Help page Change-Id: I929b44f50e430a61262e570ac745818806e99b67 Reviewed-on: https://gerrit.libreoffice.org/81172 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-10-20cid#1441466 silence Untrusted loop boundCaolán McNamara1-5/+5
Change-Id: I692f591cb3bee63ec0a0a77b3d9a4a54973451ad Reviewed-on: https://gerrit.libreoffice.org/81169 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-20cid#1448338 Untrusted value as argumentCaolán McNamara1-8/+7
Change-Id: Ifba1ab62cb7681a5fba2e50fb74870e234f14769 Reviewed-on: https://gerrit.libreoffice.org/81161 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-20cid#1454871 uninitialized memberCaolán McNamara1-0/+4
Change-Id: Ice63beecf4adf0a0799efee09ffb77d85996345b Reviewed-on: https://gerrit.libreoffice.org/81160 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-20 tdf#127976, tdf#127977: Fix for navigator iconsRizal Muttaqin3413-1472/+1880
- Add SVG chart - Add more 32px icons (Writer) - etc Change-Id: I5b03300b9996589aa4bafdfd5d6473c9093509fe Reviewed-on: https://gerrit.libreoffice.org/81149 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2019-10-20ScRangeUtil is utility class; don't instantiate itMike Kaganski10-15/+5
Change-Id: Id5bf48b62c644fa3c37faf324b9f5b971ca18557 Reviewed-on: https://gerrit.libreoffice.org/81162 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-10-20Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' - Update icon replacement table Change-Id: I4a83337dea81a6bda5d464a305e02ad65ee5a97d Reviewed-on: https://gerrit.libreoffice.org/81159 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-10-20Avoid converting same string to uppercase twiceMike Kaganski1-2/+3
Change-Id: I8f6be79525f1383bc27eb799efbaa1009cbaed50 Reviewed-on: https://gerrit.libreoffice.org/81153 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-10-20Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' - Fix last D'oh! errors in Help page Change-Id: I2cbeac04cb0434292f32e981b92f58a6bd7a9560 Reviewed-on: https://gerrit.libreoffice.org/81152 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-10-20Replace some uses of OUStringChar with string literalsStephan Bergmann1-12/+6
(At least MSVC++ 14.14, aka Visual Studio 2017 version 15.7, apparently requires `"\xDFFF"` to be written with a `u` prefix in the concatenated string literal u"\xD800" "\U000103FF" "\xDFFF" "A" to avoid "error C2022: '57343': too big for character", so prefix all the individual string literals in such concatenations, even if that should be redundant.) Change-Id: Ief69e6c7ae71fe2c4c9c56c38fab0bc782ceb82c Reviewed-on: https://gerrit.libreoffice.org/81142 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-20Drop redundant conditionsArkadiy Illarionov1-9/+3
nMappingType is checked in lcl_getMappingTypeForToggleCase Change-Id: I5e13ffad9028ca40d23e5ca19d765b3ee43c5724 Reviewed-on: https://gerrit.libreoffice.org/81151 Tested-by: Jenkins Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-10-20Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' - Remove D'oh! errors in Help Page Change-Id: I8ab35df77621eae157ebb6a76f3ab6af6fa271a7 Reviewed-on: https://gerrit.libreoffice.org/81148 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-10-20readlicense_oo: Bump minimum GTK requirementAdolfo Jayme Barrientos1-1/+1
3.18 is required to build since commit 12b01c535a05516e1b7c75c316f0cde8e12e3e0b, and GTK 2 support was removed in commit 1ae450504cf57457f9702684b1517fda1dd3c481 Change-Id: I9143cdbf8447934bace2ca6aca06292f96755835
2019-10-20Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' - Fix a D'oh! error in Help page Plus update menus path for Customizing dialog Change-Id: I9cef13ca14dd0787c54c091b8ad0f8d8c18bd03f Reviewed-on: https://gerrit.libreoffice.org/81147 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-10-20Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' - Fix missing embed in comments Help page Change-Id: I9f38f2e9112052d817ece315d728d081676522b7 Reviewed-on: https://gerrit.libreoffice.org/81119 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-10-19MM dialogs: Simplify code for from/to range a little bitMichael Weghorn1-29/+16
Change-Id: I8a845e24d0ce5aec6b2edc70fef42c39109ab6a3 Reviewed-on: https://gerrit.libreoffice.org/81092 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-10-19SwMMResultSaveDialog: Move some common code one level upMichael Weghorn1-14/+8
The dialog is called in any case. Change-Id: I2cb14f227ad1e7417e2f44e4f0e357cb29d82fdc Reviewed-on: https://gerrit.libreoffice.org/81091 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-10-19sc: rowcol: tdf#50916 convert ucalc test, and docfunc.Michael Meeks5-178/+181
Change-Id: I692ecf758e06bf904a41b9316e32dff169408a05 Reviewed-on: https://gerrit.libreoffice.org/81140 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-10-19mariadb still uses char for my_boolCaolán McNamara1-1/+1
mariadb-devel-10.3.17-1.fc30.x86_64 still has typedef char my_bool; Change-Id: I3d1f5423c8750180bc28c56bc0ead4f746fd1c23 Reviewed-on: https://gerrit.libreoffice.org/81137 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-19Resolves: tdf#128241 reuse label to retain buildable_nameCaolán McNamara1-1/+15
Change-Id: Ib5cb31279fdf6e2fa83ea46625c320185992bca1 Reviewed-on: https://gerrit.libreoffice.org/81136 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-19strip Dialog ctor downCaolán McNamara4-6/+6
Change-Id: Ic00f5a5fe562022524c60a23509722f9e2406524 Reviewed-on: https://gerrit.libreoffice.org/81135 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-19tdf#128241: fix crash when opening print dialog (gtk3 only)Julien Nabet1-1/+1
See bt here: https://bugs.documentfoundation.org/attachment.cgi?id=155131 Change-Id: Ibd220f6f41b6cee6217465c534fac1af4bb2b51b Reviewed-on: https://gerrit.libreoffice.org/81123 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-19fix buildCaolán McNamara1-1/+1
Change-Id: I2d4fb034e72369dc051c4bc2f5a7598e1d58f9c1
2019-10-19fix buildCaolán McNamara1-1/+1
Change-Id: I04846dfa9156da4a00fde723640d400d10e2ed88
2019-10-19drop unused ModalDialog classCaolán McNamara4-23/+3
Change-Id: I3186b63d4c6c437ff0c0653a6b6c7fd61ae69304 Reviewed-on: https://gerrit.libreoffice.org/81069 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-19Drop ModalDialog middlemanCaolán McNamara4-9/+10
Change-Id: I8bc39e1a85045a6e6c15735b440ada8c3abc222b Reviewed-on: https://gerrit.libreoffice.org/81068 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-19only warn if it would make a differenceCaolán McNamara1-2/+1
Change-Id: I7ee9ccb2444fc63b2d32520907f502ae596c984d Reviewed-on: https://gerrit.libreoffice.org/81067 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-19drop unused ListControlCaolán McNamara5-248/+0
Change-Id: I19dd8907c36d016b939ed346a4308e5df2ebf93c Reviewed-on: https://gerrit.libreoffice.org/81060 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-19GetLegacyDialogParent is now unusedCaolán McNamara2-17/+0
Change-Id: I1619d3a5ccc2f97d1e22dadab6ce719c6daf3c56 Reviewed-on: https://gerrit.libreoffice.org/80995 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>