diff options
Diffstat (limited to 'sc')
-rw-r--r-- | sc/inc/SolverSettings.hxx | 4 | ||||
-rw-r--r-- | sc/inc/tablink.hxx | 2 | ||||
-rw-r--r-- | sc/qa/unit/helper/qahelper.hxx | 2 | ||||
-rw-r--r-- | sc/qa/unit/ucalc_copypaste.cxx | 4 | ||||
-rw-r--r-- | sc/source/core/data/SolverSettings.cxx | 5 | ||||
-rw-r--r-- | sc/source/filter/excel/xename.cxx | 4 | ||||
-rw-r--r-- | sc/source/filter/excel/xestream.cxx | 2 | ||||
-rw-r--r-- | sc/source/filter/inc/xestream.hxx | 2 | ||||
-rw-r--r-- | sc/source/ui/docshell/tablink.cxx | 2 | ||||
-rw-r--r-- | sc/source/ui/inc/dbfunc.hxx | 2 | ||||
-rw-r--r-- | sc/source/ui/view/dbfunc.cxx | 2 |
11 files changed, 16 insertions, 15 deletions
diff --git a/sc/inc/SolverSettings.hxx b/sc/inc/SolverSettings.hxx index 2916c6ad3519..58edd20f30f2 100644 --- a/sc/inc/SolverSettings.hxx +++ b/sc/inc/SolverSettings.hxx @@ -184,7 +184,7 @@ private: // Used to create or get a single constraint part bool ReadConstraintPart(ConstraintPart ePart, tools::Long nIndex, OUString& rValue); - void WriteConstraintPart(ConstraintPart ePart, tools::Long nIndex, OUString sValue); + void WriteConstraintPart(ConstraintPart ePart, tools::Long nIndex, const OUString& sValue); // Creates or reads all named ranges associated with solver engine options void ReadEngine(); @@ -289,7 +289,7 @@ public: SolverSettings(ScTable& pTable); SC_DLLPUBLIC OUString GetParameter(SolverParameter eParam); - SC_DLLPUBLIC void SetParameter(SolverParameter eParam, OUString sValue); + SC_DLLPUBLIC void SetParameter(SolverParameter eParam, const OUString& sValue); SC_DLLPUBLIC ObjectiveType GetObjectiveType() { return m_eObjType; } SC_DLLPUBLIC void SetObjectiveType(ObjectiveType eType); SC_DLLPUBLIC void GetEngineOptions(css::uno::Sequence<css::beans::PropertyValue>& aOptions); diff --git a/sc/inc/tablink.hxx b/sc/inc/tablink.hxx index 56bd64881835..dae9e3f37485 100644 --- a/sc/inc/tablink.hxx +++ b/sc/inc/tablink.hxx @@ -79,7 +79,7 @@ private: public: ScDocumentLoader(const OUString& rFileName, OUString& rFilterName, OUString& rOptions, sal_uInt32 nRekCnt = 0, weld::Window* pInteractionParent = nullptr, - css::uno::Reference<css::io::XInputStream> xInputStream + const css::uno::Reference<css::io::XInputStream>& xInputStream = css::uno::Reference<css::io::XInputStream>()); ~ScDocumentLoader(); ScDocument* GetDocument(); diff --git a/sc/qa/unit/helper/qahelper.hxx b/sc/qa/unit/helper/qahelper.hxx index 3bb12e701c70..6eeb111ad25b 100644 --- a/sc/qa/unit/helper/qahelper.hxx +++ b/sc/qa/unit/helper/qahelper.hxx @@ -149,7 +149,7 @@ protected: class SCQAHELPER_DLLPUBLIC ScModelTestBase : public UnoApiXmlTest { public: - ScModelTestBase(OUString path) + ScModelTestBase(const OUString& path) : UnoApiXmlTest(path) { } diff --git a/sc/qa/unit/ucalc_copypaste.cxx b/sc/qa/unit/ucalc_copypaste.cxx index 056d439d6691..373a1c458266 100644 --- a/sc/qa/unit/ucalc_copypaste.cxx +++ b/sc/qa/unit/ucalc_copypaste.cxx @@ -107,7 +107,7 @@ protected: void printValuesAndFormulasInRange(ScDocument* pDoc, const ScRange& rRange, const OString& rCaption); OUString getRangeByName(const OUString& aRangeName); - ScAddress setNote(SCCOL nCol, SCROW nRow, SCTAB nTab, const OUString noteText); + ScAddress setNote(SCCOL nCol, SCROW nRow, SCTAB nTab, const OUString& noteText); OUString getNote(SCCOL nCol, SCROW nRow, SCTAB nTab); }; @@ -137,7 +137,7 @@ OUString TestCopyPaste::getRangeByName(const OUString& aRangeName) return ScUcalcTestBase::getRangeByName(m_pDoc, aRangeName); } -ScAddress TestCopyPaste::setNote(SCCOL nCol, SCROW nRow, SCTAB nTab, OUString noteText) +ScAddress TestCopyPaste::setNote(SCCOL nCol, SCROW nRow, SCTAB nTab, const OUString& noteText) { ScAddress aAdr(nCol, nRow, nTab); ScPostIt* pNote = m_pDoc->GetOrCreateNote(aAdr); diff --git a/sc/source/core/data/SolverSettings.cxx b/sc/source/core/data/SolverSettings.cxx index 97103659b94c..c7413bcb943e 100644 --- a/sc/source/core/data/SolverSettings.cxx +++ b/sc/source/core/data/SolverSettings.cxx @@ -207,7 +207,7 @@ OUString SolverSettings::GetParameter(SolverParameter eParam) } // Sets the value of a single solver parameter in the object -void SolverSettings::SetParameter(SolverParameter eParam, OUString sValue) +void SolverSettings::SetParameter(SolverParameter eParam, const OUString& sValue) { switch (eParam) { @@ -393,7 +393,8 @@ void SolverSettings::WriteConstraints() } // Write a single constraint part to the file -void SolverSettings::WriteConstraintPart(ConstraintPart ePart, tools::Long nIndex, OUString sValue) +void SolverSettings::WriteConstraintPart(ConstraintPart ePart, tools::Long nIndex, + const OUString& sValue) { // Empty named ranges cannot be written to the file (this corrupts MS files) if (sValue.isEmpty()) diff --git a/sc/source/filter/excel/xename.cxx b/sc/source/filter/excel/xename.cxx index 8d97ffaadda9..5607a9068d4f 100644 --- a/sc/source/filter/excel/xename.cxx +++ b/sc/source/filter/excel/xename.cxx @@ -162,7 +162,7 @@ private: * * @return excel's name index. */ - sal_uInt16 FindNamedExp( SCTAB nTab, OUString sName ); + sal_uInt16 FindNamedExp( SCTAB nTab, const OUString& sName ); /** Returns the index of an existing built-in NAME record with the passed definition, otherwise 0. */ sal_uInt16 FindBuiltInNameIdx( const OUString& rName, @@ -548,7 +548,7 @@ void XclExpNameManagerImpl::SaveXml( XclExpXmlStream& rStrm ) // private -------------------------------------------------------------------- -sal_uInt16 XclExpNameManagerImpl::FindNamedExp( SCTAB nTab, OUString sName ) +sal_uInt16 XclExpNameManagerImpl::FindNamedExp( SCTAB nTab, const OUString& sName ) { NamedExpMap::key_type key(nTab, sName); NamedExpMap::const_iterator itr = maNamedExpMap.find(key); diff --git a/sc/source/filter/excel/xestream.cxx b/sc/source/filter/excel/xestream.cxx index b777d7771c23..d9e7a6cf57ea 100644 --- a/sc/source/filter/excel/xestream.cxx +++ b/sc/source/filter/excel/xestream.cxx @@ -1267,7 +1267,7 @@ void XclExpXmlStream::restoreTabNames(const std::vector<OUString>& aOriginalTabN } } -void XclExpXmlStream::renameTab(SCTAB aTab, OUString aNewName) +void XclExpXmlStream::renameTab(SCTAB aTab, const OUString& aNewName) { ScDocShell* pShell = getDocShell(); ScDocument& rDoc = pShell->GetDocument(); diff --git a/sc/source/filter/inc/xestream.hxx b/sc/source/filter/inc/xestream.hxx index 669dadaec014..202e70a0e65d 100644 --- a/sc/source/filter/inc/xestream.hxx +++ b/sc/source/filter/inc/xestream.hxx @@ -342,7 +342,7 @@ private: void validateTabNames(std::vector<OUString>& aOriginalTabNames); void restoreTabNames(const std::vector<OUString>& aOriginalTabNames); - void renameTab(SCTAB aTab, OUString aNewName); + void renameTab(SCTAB aTab, const OUString& aNewName); typedef std::map< OUString, std::pair< OUString, diff --git a/sc/source/ui/docshell/tablink.cxx b/sc/source/ui/docshell/tablink.cxx index f77c49e64677..09a5f674089e 100644 --- a/sc/source/ui/docshell/tablink.cxx +++ b/sc/source/ui/docshell/tablink.cxx @@ -489,7 +489,7 @@ SfxMedium* ScDocumentLoader::CreateMedium( const OUString& rFileName, std::share ScDocumentLoader::ScDocumentLoader(const OUString& rFileName, OUString& rFilterName, OUString& rOptions, sal_uInt32 nRekCnt, weld::Window* pInteractionParent, - css::uno::Reference<css::io::XInputStream> xInputStream) + const css::uno::Reference<css::io::XInputStream>& xInputStream) : pMedium(nullptr) { if ( rFilterName.isEmpty() ) diff --git a/sc/source/ui/inc/dbfunc.hxx b/sc/source/ui/inc/dbfunc.hxx index 0c2d77d38461..9d9f5481121d 100644 --- a/sc/source/ui/inc/dbfunc.hxx +++ b/sc/source/ui/inc/dbfunc.hxx @@ -37,7 +37,7 @@ private: void GetSelectedMemberList(ScDPUniqueStringSet& rEntries, tools::Long& rDimension); static void ModifiedAutoFilter(ScDocShell* pDocSh); static void ApplyAutoFilter(ScDocShell* pDocSh, ScViewData* pViewData, ScDBData* pDBData, - SCROW nRow, SCTAB nTab, ScQueryParam aParam); + SCROW nRow, SCTAB nTab, const ScQueryParam& aParam); DECL_STATIC_LINK(ScDBFunc, InstallLOKNotifierHdl, void*, vcl::ILibreOfficeKitNotifier*); diff --git a/sc/source/ui/view/dbfunc.cxx b/sc/source/ui/view/dbfunc.cxx index 9e2712fd2221..5f5a0621c9f6 100644 --- a/sc/source/ui/view/dbfunc.cxx +++ b/sc/source/ui/view/dbfunc.cxx @@ -381,7 +381,7 @@ IMPL_STATIC_LINK_NOARG(ScDBFunc, InstallLOKNotifierHdl, void*, vcl::ILibreOffice } void ScDBFunc::ApplyAutoFilter(ScDocShell* pDocSh, ScViewData* pViewData, ScDBData* pDBData, - SCROW nRow, SCTAB nTab, ScQueryParam aParam) + SCROW nRow, SCTAB nTab, const ScQueryParam& aParam) { ScDocument& rDoc = pViewData->GetDocument(); ScRange aRange; |