clang-tidy modernize-pass-by-value in xml*

Change-Id: I9bd5f6adfd138c391d76aebfe08ba01e6b3ab3bf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137550
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

4 files changed, 8 insertions, 7 deletions

diff --git a/xmlsecurity/inc/certificateviewer.hxx b/xmlsecurity/inc/certificateviewer.hxx
index ea47c41029a8..8aeb5f3368ff 100644
--- a/xmlsecurity/inc/certificateviewer.hxx
+++ b/xmlsecurity/inc/certificateviewer.hxx
@@ -19,6 +19,7 @@
 
 #pragma once
 
+#include <utility>
 #include <vcl/weld.hxx>
 
 namespace com::sun::star {
@@ -93,8 +94,8 @@ struct Details_UserDatat
     OUString const  maTxt;
     bool const      mbFixedWidthFont;
 
-    Details_UserDatat(const OUString& rTxt, bool bFixedWidthFont)
-        : maTxt(rTxt)
+    Details_UserDatat(OUString aTxt, bool bFixedWidthFont)
+        : maTxt(std::move(aTxt))
         , mbFixedWidthFont(bFixedWidthFont)
     {
     }
@@ -120,8 +121,8 @@ struct CertPath_UserData
     css::uno::Reference< css::security::XCertificate > mxCert;
     bool const mbValid;
 
-    CertPath_UserData(css::uno::Reference<css::security::XCertificate> const & xCert, bool bValid)
-        : mxCert(xCert)
+    CertPath_UserData(css::uno::Reference<css::security::XCertificate> xCert, bool bValid)
+        : mxCert(std::move(xCert))
         , mbValid(bValid)
     {
     }
diff --git a/xmlsecurity/inc/digitalsignaturesdialog.hxx b/xmlsecurity/inc/digitalsignaturesdialog.hxx
index 28ed32ccb098..218c3e99c8b3 100644
--- a/xmlsecurity/inc/digitalsignaturesdialog.hxx
+++ b/xmlsecurity/inc/digitalsignaturesdialog.hxx
@@ -105,7 +105,7 @@ private:
 public:
     DigitalSignaturesDialog(weld::Window* pParent, const css::uno::Reference<
         css::uno::XComponentContext >& rxCtx, DocumentSignatureMode eMode,
-        bool bReadOnly, const OUString& sODFVersion, bool bHasDocumentSignature);
+        bool bReadOnly, OUString sODFVersion, bool bHasDocumentSignature);
     virtual ~DigitalSignaturesDialog() override;
 
     // Initialize the dialog and the security environment, returns TRUE on success
diff --git a/xmlsecurity/inc/macrosecurity.hxx b/xmlsecurity/inc/macrosecurity.hxx
index 233ef2c1dca1..52c45ecb3743 100644
--- a/xmlsecurity/inc/macrosecurity.hxx
+++ b/xmlsecurity/inc/macrosecurity.hxx
@@ -44,7 +44,7 @@ private:
     DECL_LINK(OkBtnHdl, weld::Button&, void);
 public:
     MacroSecurity(weld::Window* pParent,
-        const css::uno::Reference<css::xml::crypto::XSecurityEnvironment>& rxSecurityEnvironment);
+        css::uno::Reference<css::xml::crypto::XSecurityEnvironment> xSecurityEnvironment);
 
     void EnableReset(bool bEnable = true)
     {
diff --git a/xmlsecurity/inc/xsecctl.hxx b/xmlsecurity/inc/xsecctl.hxx
index adfd251b172e..adefe7e087ae 100644
--- a/xmlsecurity/inc/xsecctl.hxx
+++ b/xmlsecurity/inc/xsecctl.hxx
@@ -291,7 +291,7 @@ private:
         sal_Int32 nSecurityId );
 
 public:
-    explicit XSecController(const css::uno::Reference<css::uno::XComponentContext>& rxCtx);
+    explicit XSecController(css::uno::Reference<css::uno::XComponentContext> xCtx);
     virtual ~XSecController() override;
 
     sal_Int32 getNewSecurityId(  );