diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-03-09 13:59:52 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-03-12 07:37:24 +0100 |
| commit | 2f5868c4309d49ad495e0763b5b57d1f7f98e377 (patch) | |
| tree | ba498138c67436ce30b5d9585353c50a1c5020bf /xmlhelp | |
| parent | cb34e6083cdc82333d64ad9224e0d25e895d1dae (diff) | |
loplugin:redundantfcast look for redundant copies in return statements
Change-Id: I5f416c865dfe1c36018784246a8007452eb42008
Reviewed-on: https://gerrit.libreoffice.org/50996
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'xmlhelp')
| -rw-r--r-- | xmlhelp/source/cxxhelp/provider/provider.cxx | 6 | ||||
| -rw-r--r-- | xmlhelp/source/cxxhelp/provider/resultsetbase.hxx | 2 | ||||
| -rw-r--r-- | xmlhelp/source/treeview/tvfactory.cxx | 5 |
3 files changed, 5 insertions, 8 deletions
diff --git a/xmlhelp/source/cxxhelp/provider/provider.cxx b/xmlhelp/source/cxxhelp/provider/provider.cxx index 78912d06b0c5..4c4532569848 100644 --- a/xmlhelp/source/cxxhelp/provider/provider.cxx +++ b/xmlhelp/source/cxxhelp/provider/provider.cxx @@ -152,13 +152,11 @@ css::uno::Reference< css::lang::XSingleServiceFactory > ContentProvider::createServiceFactory( const css::uno::Reference< css::lang::XMultiServiceFactory >& rxServiceMgr ) { - return css::uno::Reference< - css::lang::XSingleServiceFactory >( - cppu::createOneInstanceFactory( + return cppu::createOneInstanceFactory( rxServiceMgr, ContentProvider::getImplementationName_Static(), ContentProvider_CreateInstance, - ContentProvider::getSupportedServiceNames_Static() ) ); + ContentProvider::getSupportedServiceNames_Static() ); } // XContentProvider methods. diff --git a/xmlhelp/source/cxxhelp/provider/resultsetbase.hxx b/xmlhelp/source/cxxhelp/provider/resultsetbase.hxx index 9c1a016030dd..d684db8f5b66 100644 --- a/xmlhelp/source/cxxhelp/provider/resultsetbase.hxx +++ b/xmlhelp/source/cxxhelp/provider/resultsetbase.hxx @@ -133,7 +133,7 @@ namespace chelp { if( 0 <= m_nRow && sal::static_int_cast<sal_uInt32>( m_nRow ) < m_aItems.size() ) return m_aItems[m_nRow]->getInt( columnIndex ); else - return sal_Int32( 0 ); + return 0; } virtual sal_Int64 SAL_CALL diff --git a/xmlhelp/source/treeview/tvfactory.cxx b/xmlhelp/source/treeview/tvfactory.cxx index 9edb304cd791..30fcd22bff43 100644 --- a/xmlhelp/source/treeview/tvfactory.cxx +++ b/xmlhelp/source/treeview/tvfactory.cxx @@ -142,12 +142,11 @@ Reference< XSingleServiceFactory > TVFactory::createServiceFactory( const Reference< XMultiServiceFactory >& rxServiceMgr ) { - return Reference< XSingleServiceFactory > ( - cppu::createSingleFactory( + return cppu::createSingleFactory( rxServiceMgr, TVFactory::getImplementationName_static(), TVFactory::CreateInstance, - TVFactory::getSupportedServiceNames_static() ) ); + TVFactory::getSupportedServiceNames_static() ); } Reference< XInterface > SAL_CALL |