diff options
author | Caolán McNamara <caolanm@redhat.com> | 2015-03-31 08:45:24 +0100 |
---|---|---|
committer | Caolán McNamara <caolanm@redhat.com> | 2015-03-31 08:48:03 +0100 |
commit | b024e36ddb3b53163d7a01f6f7b5aadb7a858cd9 (patch) | |
tree | eb4393970396629a88ae40d4b48b2c02c8e1bca2 /vcl | |
parent | 2ecc29df60ae3ae98605d84dc212a69907d4bfbe (diff) |
cppcheck: can add explicit to ctor
Change-Id: I9b626a8c5674157033f62f5aff10259136d21a42
Diffstat (limited to 'vcl')
-rw-r--r-- | vcl/source/gdi/pdfwriter_impl.cxx | 2 | ||||
-rw-r--r-- | vcl/source/gdi/pdfwriter_impl.hxx | 8 | ||||
-rw-r--r-- | vcl/source/gdi/pngread.cxx | 4 |
3 files changed, 7 insertions, 7 deletions
diff --git a/vcl/source/gdi/pdfwriter_impl.cxx b/vcl/source/gdi/pdfwriter_impl.cxx index 5e3cc6fea52f..f62fa731ecb2 100644 --- a/vcl/source/gdi/pdfwriter_impl.cxx +++ b/vcl/source/gdi/pdfwriter_impl.cxx @@ -12608,7 +12608,7 @@ sal_Int32 PDFWriterImpl::beginStructureElement( PDFWriter::StructElement eType, { rEle.m_nObject = createObject(); // update parent's kids list - m_aStructure[ rEle.m_nParentElement ].m_aKids.push_back( rEle.m_nObject ); + m_aStructure[ rEle.m_nParentElement ].m_aKids.push_back(PDFStructureElementKid(rEle.m_nObject)); } return nNewId; } diff --git a/vcl/source/gdi/pdfwriter_impl.hxx b/vcl/source/gdi/pdfwriter_impl.hxx index 43bb0c5d5759..1f2ac6b1558a 100644 --- a/vcl/source/gdi/pdfwriter_impl.hxx +++ b/vcl/source/gdi/pdfwriter_impl.hxx @@ -333,7 +333,7 @@ public: sal_Int32 m_nFontID; FontEmitMapping m_aMapping; - FontEmit( sal_Int32 nID ) : m_nFontID( nID ) {} + explicit FontEmit( sal_Int32 nID ) : m_nFontID( nID ) {} }; typedef std::list< FontEmit > FontEmitList; struct Glyph @@ -494,12 +494,12 @@ public: nValue( 0 ) {} - PDFStructureAttribute( PDFWriter::StructAttributeValue eVal ) + explicit PDFStructureAttribute( PDFWriter::StructAttributeValue eVal ) : eValue( eVal ), nValue( 0 ) {} - PDFStructureAttribute( sal_Int32 nVal ) + explicit PDFStructureAttribute( sal_Int32 nVal ) : eValue( PDFWriter::Invalid ), nValue( nVal ) {} @@ -513,7 +513,7 @@ public: // else the page object relevant to MCID sal_Int32 nMCID; // an MCID if >= 0 - PDFStructureElementKid( sal_Int32 nObj ) : nObject( nObj ), nMCID( -1 ) {} + explicit PDFStructureElementKid( sal_Int32 nObj ) : nObject( nObj ), nMCID( -1 ) {} PDFStructureElementKid( sal_Int32 MCID, sal_Int32 nPage ) : nObject( nPage ), nMCID( MCID ) {} }; diff --git a/vcl/source/gdi/pngread.cxx b/vcl/source/gdi/pngread.cxx index b4b16f937093..519a27851099 100644 --- a/vcl/source/gdi/pngread.cxx +++ b/vcl/source/gdi/pngread.cxx @@ -155,8 +155,8 @@ private: public: - PNGReaderImpl( SvStream& ); - ~PNGReaderImpl(); + explicit PNGReaderImpl( SvStream& ); + ~PNGReaderImpl(); BitmapEx GetBitmapEx( const Size& rPreviewSizeHint ); const std::vector<vcl::PNGReader::ChunkData>& GetAllChunks(); |