Extend loplugin:external to warn about enums

To mitigate the dangers of silently breaking ADL when moving enums into unnamed
namespaces (see the commit message of 206b5b2661be37efdff3c6aedb6f248c4636be79
"New loplugin:external"), note all functions that are affected.  (The plan is to
extend loplugin:external further to also warn about classes and class templates,
and the code to identify affected functions already takes that into account, so
some parts of that code are not actually relevant for enums.)

But it appears that none of the functions that are actually affected by the
changes in this commit relied on being found through ADL, so no adaptions were
necessary for them.

(clang::DeclContext::collectAllContexts is non-const, which recursively means
that External's Visit... functions must take non-const Decl*.  Which required
compilerplugins/clang/sharedvisitor/analyzer.cxx to be generalized to support
such Visit... functions with non-const Decl* parameters.)

Change-Id: Ia215291402bf850d43defdab3cff4db5b270d1bd
Reviewed-on: https://gerrit.libreoffice.org/83001
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

1 files changed, 8 insertions, 0 deletions

diff --git a/vcl/source/fontsubset/sft.cxx b/vcl/source/fontsubset/sft.cxx
index fd6e6f96df10..7b905f558051 100644
--- a/vcl/source/fontsubset/sft.cxx
+++ b/vcl/source/fontsubset/sft.cxx
@@ -54,6 +54,8 @@ static const char * const modextra = "gelf";
 
 /*- private functions, constants and data types */
 
+namespace {
+
 enum PathSegmentType {
     PS_NOOP      = 0,
     PS_MOVETO    = 1,
@@ -62,6 +64,8 @@ enum PathSegmentType {
     PS_CLOSEPATH = 4
 };
 
+}
+
 struct PSPathElement
 {
     PathSegmentType type;
@@ -1013,6 +1017,8 @@ static void GetNames(TrueTypeFont *t)
     }
 }
 
+namespace {
+
 enum cmapType {
     CMAP_NOT_USABLE           = -1,
     CMAP_MS_Symbol            = 10,
@@ -1024,6 +1030,8 @@ enum cmapType {
     CMAP_MS_Johab             = 16
 };
 
+}
+
 #define MISSING_GLYPH_INDEX 0
 
 static sal_uInt32 getGlyph0(const sal_uInt8* cmap, sal_uInt32, sal_uInt32 c) {