summaryrefslogtreecommitdiff
path: root/vbahelper/source
diff options
context:
space:
mode:
authorNoel Grandin <noel.grandin@collabora.co.uk>2017-05-05 09:04:23 +0200
committerNoel Grandin <noel.grandin@collabora.co.uk>2017-05-05 11:11:41 +0200
commite3a44cbb1d01a1fe5e6321b29e215f4a13ddee6a (patch)
tree0db1e26d3d2f227ca2f29764202c05bad6bc63b9 /vbahelper/source
parent9ffba2ea6c6880bce955b53ab20b5d99e2709cd3 (diff)
loplugin:checkunusedparams in toolkit..vbahelper
the extra argument on the runtimeexception method was only ever passed an "OUString()" Change-Id: I0ea19ae9328760918f1267f27ba103432fff0b47 Reviewed-on: https://gerrit.libreoffice.org/37274 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'vbahelper/source')
-rw-r--r--vbahelper/source/vbahelper/vbahelper.cxx2
-rw-r--r--vbahelper/source/vbahelper/vbapagesetupbase.cxx2
-rw-r--r--vbahelper/source/vbahelper/vbashape.cxx4
-rw-r--r--vbahelper/source/vbahelper/vbashapes.cxx6
4 files changed, 7 insertions, 7 deletions
diff --git a/vbahelper/source/vbahelper/vbahelper.cxx b/vbahelper/source/vbahelper/vbahelper.cxx
index 09e2de5fd52a..eee12b2c15da 100644
--- a/vbahelper/source/vbahelper/vbahelper.cxx
+++ b/vbahelper/source/vbahelper/vbahelper.cxx
@@ -1061,7 +1061,7 @@ void DebugHelper::basicexception( const css::uno::Exception& ex )
basicexception( OUString(), ex, ERRCODE_BASIC_INTERNAL_ERROR, OUString() );
}
-void DebugHelper::runtimeexception( int err, const OUString& /*additionalArgument*/ )
+void DebugHelper::runtimeexception( int err )
{
// #TODO #FIXME ( do we want to support additionalArg here )
throw css::uno::RuntimeException( css::uno::Exception().Message + " " + OUString::number(err),
diff --git a/vbahelper/source/vbahelper/vbapagesetupbase.cxx b/vbahelper/source/vbahelper/vbapagesetupbase.cxx
index d689e003e043..4db70fba1875 100644
--- a/vbahelper/source/vbahelper/vbapagesetupbase.cxx
+++ b/vbahelper/source/vbahelper/vbapagesetupbase.cxx
@@ -275,7 +275,7 @@ void SAL_CALL VbaPageSetupBase::setOrientation( sal_Int32 orientation )
if( ( orientation != mnOrientPortrait ) &&
( orientation != mnOrientLandscape ) )
{
- DebugHelper::runtimeexception(ERRCODE_BASIC_BAD_PARAMETER, OUString() );
+ DebugHelper::runtimeexception(ERRCODE_BASIC_BAD_PARAMETER );
}
try
diff --git a/vbahelper/source/vbahelper/vbashape.cxx b/vbahelper/source/vbahelper/vbashape.cxx
index c83082f13500..486cc06d7b53 100644
--- a/vbahelper/source/vbahelper/vbashape.cxx
+++ b/vbahelper/source/vbahelper/vbashape.cxx
@@ -602,7 +602,7 @@ ScVbaShape::setRelativeHorizontalPosition(::sal_Int32 _relativehorizontalpositio
}
default:
{
- DebugHelper::runtimeexception(ERRCODE_BASIC_BAD_ARGUMENT, OUString());
+ DebugHelper::runtimeexception(ERRCODE_BASIC_BAD_ARGUMENT);
}
}
m_xPropertySet->setPropertyValue( "HoriOrientRelation" , uno::makeAny( nType ) );
@@ -673,7 +673,7 @@ ScVbaShape::setRelativeVerticalPosition(::sal_Int32 _relativeverticalposition)
}
default:
{
- DebugHelper::runtimeexception(ERRCODE_BASIC_BAD_ARGUMENT, OUString());
+ DebugHelper::runtimeexception(ERRCODE_BASIC_BAD_ARGUMENT);
}
}
m_xPropertySet->setPropertyValue( "VertOrientRelation" , uno::makeAny( nType ) );
diff --git a/vbahelper/source/vbahelper/vbashapes.cxx b/vbahelper/source/vbahelper/vbashapes.cxx
index 52da448da4c2..da6f0dddc261 100644
--- a/vbahelper/source/vbahelper/vbashapes.cxx
+++ b/vbahelper/source/vbahelper/vbashapes.cxx
@@ -343,18 +343,18 @@ ScVbaShapes::AddShape( sal_Int32 _nType, sal_Int32 _nLeft, sal_Int32 _nTop, sal_
}
uno::Any SAL_CALL
-ScVbaShapes::AddTextbox( sal_Int32 _nOrientation, sal_Int32 _nLeft, sal_Int32 _nTop, sal_Int32 _nWidth, sal_Int32 _nHeight )
+ScVbaShapes::AddTextbox( sal_Int32 /*_nOrientation*/, sal_Int32 _nLeft, sal_Int32 _nTop, sal_Int32 _nWidth, sal_Int32 _nHeight )
{
uno::Reference< lang::XServiceInfo > xServiceInfo( m_xModel, uno::UNO_QUERY_THROW );
if( xServiceInfo->supportsService( "com.sun.star.text.TextDocument" ) )
{
- return AddTextboxInWriter( _nOrientation, _nLeft, _nTop, _nWidth, _nHeight );
+ return AddTextboxInWriter( _nLeft, _nTop, _nWidth, _nHeight );
}
throw uno::RuntimeException( "Not implemented" );
}
uno::Any
-ScVbaShapes::AddTextboxInWriter( sal_Int32 /*_nOrientation*/, sal_Int32 _nLeft, sal_Int32 _nTop, sal_Int32 _nWidth, sal_Int32 _nHeight )
+ScVbaShapes::AddTextboxInWriter( sal_Int32 _nLeft, sal_Int32 _nTop, sal_Int32 _nWidth, sal_Int32 _nHeight )
{
OUString sCreateShapeName( "com.sun.star.drawing.TextShape" );
sal_Int32 nXPos = Millimeter::getInHundredthsOfOneMillimeter( _nLeft );