diff options
| author | Noel Grandin <noel@peralex.com> | 2014-05-14 09:58:40 +0200 |
|---|---|---|
| committer | Noel Grandin <noelgrandin@gmail.com> | 2014-05-14 08:10:22 +0000 |
| commit | 248145f99e95cc30bb6231a8e5ea4e294f147040 (patch) | |
| tree | c3b5c1e226cc631cde530f2cfb7df2d46f00b8c9 /unotools | |
| parent | 671eb12dee290607ed66f3b325f28e7bd4695cba (diff) | |
Find places where uno::Sequence is passed by value.
Implement a clang plugin to find them, and clean up existing code
to pass them by reference.
Change-Id: If642d87407c73346d9c0164b9fc77c5c3c4354b8
Reviewed-on: https://gerrit.libreoffice.org/9351
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
Diffstat (limited to 'unotools')
| -rw-r--r-- | unotools/source/config/configitem.cxx | 4 | ||||
| -rw-r--r-- | unotools/source/config/lingucfg.cxx | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/unotools/source/config/configitem.cxx b/unotools/source/config/configitem.cxx index 59c1207b80e1..931a9a189eca 100644 --- a/unotools/source/config/configitem.cxx +++ b/unotools/source/config/configitem.cxx @@ -801,7 +801,7 @@ Sequence< OUString > lcl_extractSetPropertyNames( const Sequence< PropertyValue // Add or change properties bool ConfigItem::SetSetProperties( - const OUString& rNode, Sequence< PropertyValue > rValues) + const OUString& rNode, const Sequence< PropertyValue >& rValues) { ValueCounter_Impl aCounter(m_nInValueChange); bool bRet = true; @@ -900,7 +900,7 @@ bool ConfigItem::SetSetProperties( } bool ConfigItem::ReplaceSetProperties( - const OUString& rNode, Sequence< PropertyValue > rValues) + const OUString& rNode, const Sequence< PropertyValue >& rValues) { ValueCounter_Impl aCounter(m_nInValueChange); bool bRet = true; diff --git a/unotools/source/config/lingucfg.cxx b/unotools/source/config/lingucfg.cxx index 781f16463b87..f02b52b89d80 100644 --- a/unotools/source/config/lingucfg.cxx +++ b/unotools/source/config/lingucfg.cxx @@ -846,7 +846,7 @@ uno::Sequence< uno::Any > SvtLinguConfig::GetProperties( const uno::Sequence< OU } bool SvtLinguConfig::ReplaceSetProperties( - const OUString &rNode, uno::Sequence< beans::PropertyValue > rValues ) + const OUString &rNode, const uno::Sequence< beans::PropertyValue >& rValues ) { return GetConfigItem().ReplaceSetProperties( rNode, rValues ); } |