diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2014-01-23 18:43:53 +0100 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2014-01-23 18:43:53 +0100 |
| commit | e3133ae2371b6e2d4b47daa6a3487ea4f2753315 (patch) | |
| tree | f9a000ee6542fb470733bfed28199092a36c26c5 /svx | |
| parent | 14f4e2fa22a0a2576808bab08edaf2e12f761cd8 (diff) | |
Let C++ inline functions return bool instead of sal_Bool
...to improve diagnosing misuses of boolean expressions in client code (cf.
compilerplugins/clang/implicitboolconversion.cxx). This change should be
transparent to client code.
Missing overloads of insert() for bool have been added to OStringBuffer and
OUStringBuffer (which required dropping one !VALID_CONVERSION check that would
now pick that overload, but would be flagged by
compilerplugins/clang/pointertobool.cxx).
Change-Id: I2d64cd923b8f47bfaa31e753def6515c29a3f8c9
Diffstat (limited to 'svx')
| -rw-r--r-- | svx/source/xml/xmleohlp.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/svx/source/xml/xmleohlp.cxx b/svx/source/xml/xmleohlp.cxx index 757adbb798ca..3740d786ba07 100644 --- a/svx/source/xml/xmleohlp.cxx +++ b/svx/source/xml/xmleohlp.cxx @@ -128,7 +128,7 @@ struct OUStringLess { bool operator() ( const OUString& r1, const OUString& r2 ) const { - return (r1 < r2) != sal_False; + return r1 < r2; } }; |