diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2024-02-21 19:23:29 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2024-02-22 06:59:12 +0100 |
| commit | 349af3ca598833b64db93bc1d32117431be992f2 (patch) | |
| tree | 1698ca8bd24819ec7b496c4f1d094ecba9c46ced /svx/source/sidebar | |
| parent | 8eee7eab8087590aa19bb9989c294e9be767f356 (diff) | |
fix ubsan use-after-free
caused by
commit 8cd4cd31e9cffb593ccfba765fa28c2494a2d6f7
Author: AkshayWarrier <aksmen121@gmail.com>
Date: Mon Jan 22 20:31:16 2024 +0530
tdf#157882 svx: Remove cap/corner styles and move arrowhead control
to new row
The ToolbarUnoDispatcher needs to destruct before the associated
Toolbar.
Shows up as
vcl/source/app/salvtables.cxx:1278:1:runtime error: member call on
address 0x51700010dc00 which does not point to an object of type
'SalInstanceToolbar'0x51700010dc00: note: object has invalid vptr
00 00 00 00 8c 03 03 00 00 00 00 00 80 43 4e 00 90 51 00 00 00 00 00
00 00 00 00 00 30 7e 9a 00
^~~~~~~~~~~~~~~~~~~~~~~
invalid vptr
SalInstanceToolbar::LinkStubMenuToggleListener(void*, VclWindowEvent&)
vcl/source/app/salvtables.cxx:1278:1
void>::Call(VclWindowEvent&) const include/tools/link.hxx:111:45
void*) vcl/source/window/event.cxx:262:23
vcl/source/window/window.cxx:158:5
vcl/source/window/dockwin.cxx:407:13
vcl/source/outdev/vclreferencebase.cxx:38:5
include/vcl/vclptr.hxx:207:19
vcl/source/window/builder.cxx:811:23
vcl/source/window/builder.cxx:803:5
Change-Id: Id890fe431ab724db4bdf7ad6622b933044bd6ade
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163706
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'svx/source/sidebar')
| -rw-r--r-- | svx/source/sidebar/line/LinePropertyPanelBase.cxx | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/svx/source/sidebar/line/LinePropertyPanelBase.cxx b/svx/source/sidebar/line/LinePropertyPanelBase.cxx index 6c9d5edf2be3..c68cbe3d8673 100644 --- a/svx/source/sidebar/line/LinePropertyPanelBase.cxx +++ b/svx/source/sidebar/line/LinePropertyPanelBase.cxx @@ -103,6 +103,7 @@ LinePropertyPanelBase::~LinePropertyPanelBase() mxMFTransparent.reset(); mxLineStyleDispatch.reset(); mxLineStyleTB.reset(); + mxArrowHeadStyleDispatch.reset(); mxArrowHeadStyleTB.reset(); mxArrowHeadStyleFT.reset(); } |