loplugin:constantparam

Change-Id: I270e068b3c83e966e741b0a072fecce9d92d53f5

3 files changed, 12 insertions, 13 deletions

diff --git a/svtools/source/contnr/fileview.cxx b/svtools/source/contnr/fileview.cxx
index 402577ffeb6e..8f0a58cbab48 100644
--- a/svtools/source/contnr/fileview.cxx
+++ b/svtools/source/contnr/fileview.cxx
@@ -400,7 +400,7 @@ public:
     void                    InitSelection();
     void                    ResetCursor();
 
-    inline void             EndEditing( bool _bCancel );
+    inline void             EndEditing();
 
     void                    onTimeout();
 
@@ -419,10 +419,10 @@ inline void SvtFileView_Impl::EnableDelete( bool bEnable )
         mbReplaceNames = false;
 }
 
-inline void SvtFileView_Impl::EndEditing( bool _bCancel )
+inline void SvtFileView_Impl::EndEditing()
 {
     if ( mpCurView->IsEditingActive() )
-        mpCurView->EndEditing(_bCancel);
+        mpCurView->EndEditing();
 }
 
 // functions -------------------------------------------------------------
@@ -1259,7 +1259,7 @@ void SvtFileView::EnableDelete( bool bEnable )
 
 void SvtFileView::EndInplaceEditing()
 {
-    return mpImp->EndEditing( false/*_bCancel*/ );
+    return mpImp->EndEditing();
 }
 
 IMPL_LINK_TYPED( SvtFileView, HeaderSelect_Impl, HeaderBar*, pBar, void )
diff --git a/svtools/source/contnr/imivctl1.cxx b/svtools/source/contnr/imivctl1.cxx
index 7c5887767ade..f0755ebecee4 100644
--- a/svtools/source/contnr/imivctl1.cxx
+++ b/svtools/source/contnr/imivctl1.cxx
@@ -82,7 +82,7 @@ public:
     virtual void    KeyInput( const KeyEvent& rKEvt ) override;
     virtual bool    PreNotify( NotifyEvent& rNEvt ) override;
     bool            EditingCanceled() const { return bCanceled; }
-    void            StopEditing( bool bCancel = false );
+    void            StopEditing();
     bool            IsGrabFocus() const { return bGrabFocus; }
 };
 
@@ -3003,7 +3003,7 @@ IMPL_LINK_NOARG_TYPED(SvxIconChoiceCtrl_Impl, TextEditEndedHdl, LinkParamNone*,
 void SvxIconChoiceCtrl_Impl::StopEntryEditing()
 {
     if( pEdit )
-        pEdit->StopEditing( true/*bCancel*/ );
+        pEdit->StopEditing();
 }
 
 SvxIconChoiceCtrlEntry* SvxIconChoiceCtrl_Impl::GetFirstSelectedEntry() const
@@ -3179,11 +3179,11 @@ bool IcnViewEdit_Impl::PreNotify( NotifyEvent& rNEvt )
     return false;
 }
 
-void IcnViewEdit_Impl::StopEditing( bool bCancel )
+void IcnViewEdit_Impl::StopEditing()
 {
     if ( !bAlreadyInCallback )
     {
-        bCanceled = bCancel;
+        bCanceled = true;
         CallCallBackHdl_Impl();
     }
 }
diff --git a/svtools/source/contnr/treelistbox.cxx b/svtools/source/contnr/treelistbox.cxx
index ec9831044721..833810ac3780 100644
--- a/svtools/source/contnr/treelistbox.cxx
+++ b/svtools/source/contnr/treelistbox.cxx
@@ -1416,7 +1416,7 @@ void SvTreeListBox::InitTreeView()
 
     SetSpaceBetweenEntries( 0 );
     SetLineColor();
-    InitSettings( true );
+    InitSettings();
     ImplInitStyle();
     SetTabs();
 }
@@ -3715,7 +3715,7 @@ void SvTreeListBox::DataChanged( const DataChangedEvent& rDCEvt )
     {
         nEntryHeight = 0;   // _together_ with true of 1. par (bFont) of InitSettings() a zero-height
                             //  forces complete recalc of heights!
-        InitSettings( true );
+        InitSettings();
         Invalidate();
     }
     else
@@ -3751,7 +3751,7 @@ void SvTreeListBox::ApplySettings(vcl::RenderContext& rRenderContext)
         pCheckButtonData->SetDefaultImages(this);
 }
 
-void SvTreeListBox::InitSettings(bool bBackground)
+void SvTreeListBox::InitSettings()
 {
     const StyleSettings& rStyleSettings = GetSettings().GetStyleSettings();
     vcl::Font aFont;
@@ -3763,8 +3763,7 @@ void SvTreeListBox::InitSettings(bool bBackground)
     SetTextColor(rStyleSettings.GetFieldTextColor());
     SetTextFillColor();
 
-    if (bBackground)
-        SetBackground(rStyleSettings.GetFieldColor());
+    SetBackground(rStyleSettings.GetFieldColor());
 
     // always try to re-create default-SvLBoxButtonData
     if( pCheckButtonData && pCheckButtonData->HasDefaultImages() )