improve loplugin passparamsbyref

I think I managed to disable this when I converted it to
use the shared plugin infrastructure.

So fix that, and then make it much smarter to avoid various
false positives.

Change-Id: I0a4657cff3b40a00434924bf764d024dbfd7d5b3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176646
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

1 files changed, 1 insertions, 1 deletions

diff --git a/svl/source/misc/sharedstringpool.cxx b/svl/source/misc/sharedstringpool.cxx
index 06cf8a5cef31..8cf20475bd5c 100644
--- a/svl/source/misc/sharedstringpool.cxx
+++ b/svl/source/misc/sharedstringpool.cxx
@@ -23,7 +23,7 @@ struct StringWithHash
     OUString str;
     sal_Int32 hashCode;
     StringWithHash(OUString s)
-        : str(s)
+        : str(std::move(s))
         , hashCode(s.hashCode())
     {
     }