diff options
| author | Luboš Luňák <l.lunak@collabora.com> | 2019-09-12 15:38:05 +0200 |
|---|---|---|
| committer | Luboš Luňák <l.lunak@collabora.com> | 2019-09-24 12:53:39 +0200 |
| commit | a7d40f575463467698df76f041e558cb3bea7c85 (patch) | |
| tree | 49f60f551e72c1a0a802ec40a39bd0543d654f33 /solenv | |
| parent | 417d993b8b8a86c019758ee0850e4b42967e2afa (diff) | |
compiler check for rtl::OUStringConcat instances
Something like auto str = "string" + OUString::number( 10 ); will
not be OUString but actually rtl::OUStringConcat (which gets implicitly
converted to OUString, but not with auto). Since those refer to temporaries
from the expression, they should not outlive the expression.
Change-Id: Ib4cde4b38befb3d49927d0cf01c52ebb2d36df89
Reviewed-on: https://gerrit.libreoffice.org/78830
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
Diffstat (limited to 'solenv')
| -rw-r--r-- | solenv/CompilerTest_compilerplugins_clang.mk | 3 | ||||
| -rw-r--r-- | solenv/clang-format/blacklist | 4 |
2 files changed, 5 insertions, 2 deletions
diff --git a/solenv/CompilerTest_compilerplugins_clang.mk b/solenv/CompilerTest_compilerplugins_clang.mk index 8308ee840008..b575074e184f 100644 --- a/solenv/CompilerTest_compilerplugins_clang.mk +++ b/solenv/CompilerTest_compilerplugins_clang.mk @@ -70,7 +70,8 @@ $(eval $(call gb_CompilerTest_add_exception_objects,compilerplugins_clang, \ compilerplugins/clang/test/staticvar \ compilerplugins/clang/test/stdfunction \ compilerplugins/clang/test/stringbuffer \ - compilerplugins/clang/test/stringconcat \ + compilerplugins/clang/test/stringconcatauto \ + compilerplugins/clang/test/stringconcatliterals \ compilerplugins/clang/test/stringconstant \ compilerplugins/clang/test/stringloop \ compilerplugins/clang/test/typedefparam \ diff --git a/solenv/clang-format/blacklist b/solenv/clang-format/blacklist index 14dcd2ae8fae..9d0ac1972cd5 100644 --- a/solenv/clang-format/blacklist +++ b/solenv/clang-format/blacklist @@ -1778,7 +1778,8 @@ compilerplugins/clang/store/tutorial/tutorial3.cxx compilerplugins/clang/store/tutorial/tutorial3.hxx compilerplugins/clang/store/unusedcode.cxx compilerplugins/clang/store/valueof.cxx -compilerplugins/clang/stringconcat.cxx +compilerplugins/clang/stringconcatauto.cxx +compilerplugins/clang/stringconcatliterals.cxx compilerplugins/clang/stringconstant.cxx compilerplugins/clang/stringstatic.cxx compilerplugins/clang/subtlezeroinit.cxx @@ -1815,6 +1816,7 @@ compilerplugins/clang/test/refcounting.cxx compilerplugins/clang/test/salbool.cxx compilerplugins/clang/test/salunicodeliteral.cxx compilerplugins/clang/test/salunicodeliteral.hxx +compilerplugins/clang/test/stringconcatauto.cxx compilerplugins/clang/test/stringconstant.cxx compilerplugins/clang/test/unnecessarycatchthrow.cxx compilerplugins/clang/test/unnecessaryoverride-dtor.cxx |