diff options
author | Caolán McNamara <caolanm@redhat.com> | 2015-09-27 21:03:59 +0100 |
---|---|---|
committer | Caolán McNamara <caolanm@redhat.com> | 2015-09-27 21:05:19 +0100 |
commit | 5c26f79467e4c5f920b77a058aa079654c322c25 (patch) | |
tree | ecc9d24bb4e0f583baceeb95b877ba9423ac1f06 /sdext | |
parent | b3cc2c6d234156e7d5be2c3f2cacd20ab44ce94f (diff) |
cppcheck: noExplicitConstructor
Change-Id: Ibb94d40706fced3c1c053fd58ef4e2af2d849587
Diffstat (limited to 'sdext')
21 files changed, 39 insertions, 39 deletions
diff --git a/sdext/source/minimizer/fileopendialog.hxx b/sdext/source/minimizer/fileopendialog.hxx index 78f835f5913e..4292d2ebb0e9 100644 --- a/sdext/source/minimizer/fileopendialog.hxx +++ b/sdext/source/minimizer/fileopendialog.hxx @@ -47,7 +47,7 @@ class FileOpenDialog std::vector< FilterEntry > aFilterEntryList; public: - FileOpenDialog( const css::uno::Reference< css::uno::XComponentContext >& rxContext ); + explicit FileOpenDialog( const css::uno::Reference< css::uno::XComponentContext >& rxContext ); ~FileOpenDialog(); sal_Int16 execute(); diff --git a/sdext/source/minimizer/graphiccollector.hxx b/sdext/source/minimizer/graphiccollector.hxx index 70dfcded9644..7293a5084e52 100644 --- a/sdext/source/minimizer/graphiccollector.hxx +++ b/sdext/source/minimizer/graphiccollector.hxx @@ -73,7 +73,7 @@ class GraphicCollector css::text::GraphicCrop maGraphicCropLogic; std::vector< GraphicUser > maUser; - GraphicEntity( const GraphicUser& rUser ) + explicit GraphicEntity( const GraphicUser& rUser ) : maLogicalSize( rUser.maLogicalSize ), mbRemoveCropArea( false ), maGraphicCropLogic( 0, 0, 0, 0 ) { maUser.push_back( rUser ); }; }; diff --git a/sdext/source/minimizer/informationdialog.hxx b/sdext/source/minimizer/informationdialog.hxx index 0e824f016c29..174b603cccee 100644 --- a/sdext/source/minimizer/informationdialog.hxx +++ b/sdext/source/minimizer/informationdialog.hxx @@ -73,7 +73,7 @@ private: class OKActionListener : public ::cppu::WeakImplHelper< css::awt::XActionListener > { public: - OKActionListener( InformationDialog& rInformationDialog ) : mrInformationDialog( rInformationDialog ){}; + explicit OKActionListener( InformationDialog& rInformationDialog ) : mrInformationDialog( rInformationDialog ){} virtual void SAL_CALL actionPerformed( const css::awt::ActionEvent& Event ) throw ( css::uno::RuntimeException, std::exception ) SAL_OVERRIDE; virtual void SAL_CALL disposing( const css::lang::EventObject& Source ) throw ( css::uno::RuntimeException, std::exception) SAL_OVERRIDE; diff --git a/sdext/source/minimizer/optimizerdialog.hxx b/sdext/source/minimizer/optimizerdialog.hxx index acd1b8a9414a..a88e0cc7f673 100644 --- a/sdext/source/minimizer/optimizerdialog.hxx +++ b/sdext/source/minimizer/optimizerdialog.hxx @@ -131,7 +131,7 @@ public: class ItemListener : public ::cppu::WeakImplHelper< css::awt::XItemListener > { public: - ItemListener( OptimizerDialog& rOptimizerDialog ) : mrOptimizerDialog( rOptimizerDialog ){}; + explicit ItemListener( OptimizerDialog& rOptimizerDialog ) : mrOptimizerDialog( rOptimizerDialog ){} virtual void SAL_CALL itemStateChanged( const css::awt::ItemEvent& Event ) throw ( css::uno::RuntimeException, std::exception ) SAL_OVERRIDE; virtual void SAL_CALL disposing( const css::lang::EventObject& Source ) throw ( css::uno::RuntimeException, std::exception) SAL_OVERRIDE; @@ -145,7 +145,7 @@ private: class ActionListener : public ::cppu::WeakImplHelper< css::awt::XActionListener > { public: - ActionListener( OptimizerDialog& rOptimizerDialog ) : mrOptimizerDialog( rOptimizerDialog ){}; + explicit ActionListener( OptimizerDialog& rOptimizerDialog ) : mrOptimizerDialog( rOptimizerDialog ){} virtual void SAL_CALL actionPerformed( const css::awt::ActionEvent& Event ) throw ( css::uno::RuntimeException, std::exception ) SAL_OVERRIDE; virtual void SAL_CALL disposing( const css::lang::EventObject& Source ) throw ( css::uno::RuntimeException, std::exception) SAL_OVERRIDE; @@ -159,7 +159,7 @@ private: class ActionListenerListBox0Pg0 : public ::cppu::WeakImplHelper< css::awt::XActionListener > { public: - ActionListenerListBox0Pg0( OptimizerDialog& rOptimizerDialog ) : mrOptimizerDialog( rOptimizerDialog ){}; + explicit ActionListenerListBox0Pg0( OptimizerDialog& rOptimizerDialog ) : mrOptimizerDialog( rOptimizerDialog ){} virtual void SAL_CALL actionPerformed( const css::awt::ActionEvent& Event ) throw ( css::uno::RuntimeException, std::exception ) SAL_OVERRIDE; virtual void SAL_CALL disposing( const css::lang::EventObject& Source ) throw ( css::uno::RuntimeException, std::exception) SAL_OVERRIDE; @@ -173,7 +173,7 @@ private: class TextListenerFormattedField0Pg1 : public ::cppu::WeakImplHelper< css::awt::XTextListener > { public: - TextListenerFormattedField0Pg1( OptimizerDialog& rOptimizerDialog ) : mrOptimizerDialog( rOptimizerDialog ){}; + explicit TextListenerFormattedField0Pg1( OptimizerDialog& rOptimizerDialog ) : mrOptimizerDialog( rOptimizerDialog ){} virtual void SAL_CALL textChanged( const css::awt::TextEvent& Event ) throw ( css::uno::RuntimeException, std::exception ) SAL_OVERRIDE; virtual void SAL_CALL disposing( const css::lang::EventObject& Source ) throw ( css::uno::RuntimeException, std::exception) SAL_OVERRIDE; @@ -187,7 +187,7 @@ private: class TextListenerComboBox0Pg1 : public ::cppu::WeakImplHelper< css::awt::XTextListener > { public: - TextListenerComboBox0Pg1( OptimizerDialog& rOptimizerDialog ) : mrOptimizerDialog( rOptimizerDialog ){}; + explicit TextListenerComboBox0Pg1( OptimizerDialog& rOptimizerDialog ) : mrOptimizerDialog( rOptimizerDialog ){} virtual void SAL_CALL textChanged( const css::awt::TextEvent& Event ) throw ( css::uno::RuntimeException, std::exception ) SAL_OVERRIDE; virtual void SAL_CALL disposing( const css::lang::EventObject& Source ) throw ( css::uno::RuntimeException, std::exception) SAL_OVERRIDE; @@ -201,7 +201,7 @@ private: class SpinListenerFormattedField0Pg1 : public ::cppu::WeakImplHelper< css::awt::XSpinListener > { public: - SpinListenerFormattedField0Pg1( OptimizerDialog& rOptimizerDialog ) : mrOptimizerDialog( rOptimizerDialog ){}; + explicit SpinListenerFormattedField0Pg1( OptimizerDialog& rOptimizerDialog ) : mrOptimizerDialog( rOptimizerDialog ){} virtual void SAL_CALL up( const css::awt::SpinEvent& Event ) throw ( css::uno::RuntimeException, std::exception ) SAL_OVERRIDE; virtual void SAL_CALL down( const css::awt::SpinEvent& Event ) throw ( css::uno::RuntimeException, std::exception ) SAL_OVERRIDE; diff --git a/sdext/source/minimizer/pppoptimizerdialog.hxx b/sdext/source/minimizer/pppoptimizerdialog.hxx index a4594b5949b1..e595dc962de0 100644 --- a/sdext/source/minimizer/pppoptimizerdialog.hxx +++ b/sdext/source/minimizer/pppoptimizerdialog.hxx @@ -53,7 +53,7 @@ class PPPOptimizerDialog : public ::cppu::WeakImplHelper< public: - PPPOptimizerDialog( const css::uno::Reference< css::uno::XComponentContext >& xContext ); + explicit PPPOptimizerDialog( const css::uno::Reference< css::uno::XComponentContext >& xContext ); virtual ~PPPOptimizerDialog(); // XInitialization diff --git a/sdext/source/pdfimport/inc/pdfparse.hxx b/sdext/source/pdfimport/inc/pdfparse.hxx index 192f606a7d3c..d1909e7e2294 100644 --- a/sdext/source/pdfimport/inc/pdfparse.hxx +++ b/sdext/source/pdfimport/inc/pdfparse.hxx @@ -40,7 +40,7 @@ public: virtual bool copyOrigBytes( unsigned int nOrigOffset, unsigned int nLen ) = 0; virtual unsigned int readOrigBytes( unsigned int nOrigOffset, unsigned int nLen, void* pBuf ) = 0; - EmitContext( const PDFContainer* pTop = NULL ); + explicit EmitContext( const PDFContainer* pTop = NULL ); virtual ~EmitContext(); // set this to deflate contained streams @@ -70,7 +70,7 @@ struct PDFComment : public PDFEntry { OString m_aComment; - PDFComment( const OString& rComment ) + explicit PDFComment( const OString& rComment ) : PDFEntry(), m_aComment( rComment ) {} virtual ~PDFComment(); virtual bool emit( EmitContext& rWriteContext ) const SAL_OVERRIDE; @@ -88,7 +88,7 @@ struct PDFName : public PDFValue { OString m_aName; - PDFName( const OString& rName ) + explicit PDFName( const OString& rName ) : PDFValue(), m_aName( rName ) {} virtual ~PDFName(); virtual bool emit( EmitContext& rWriteContext ) const SAL_OVERRIDE; @@ -101,7 +101,7 @@ struct PDFString : public PDFValue { OString m_aString; - PDFString( const OString& rString ) + explicit PDFString( const OString& rString ) : PDFValue(), m_aString( rString ) {} virtual ~PDFString(); virtual bool emit( EmitContext& rWriteContext ) const SAL_OVERRIDE; @@ -114,7 +114,7 @@ struct PDFNumber : public PDFValue { double m_fValue; - PDFNumber( double fVal ) + explicit PDFNumber( double fVal ) : PDFValue(), m_fValue( fVal ) {} virtual ~PDFNumber(); virtual bool emit( EmitContext& rWriteContext ) const SAL_OVERRIDE; @@ -125,7 +125,7 @@ struct PDFBool : public PDFValue { bool m_bValue; - PDFBool( bool bVal ) + explicit PDFBool( bool bVal ) : PDFValue(), m_bValue( bVal ) {} virtual ~PDFBool(); virtual bool emit( EmitContext& rWriteContext ) const SAL_OVERRIDE; diff --git a/sdext/source/pdfimport/pdfparse/pdfentries.cxx b/sdext/source/pdfimport/pdfparse/pdfentries.cxx index 1f8cf7e7a32c..98039e93a7b9 100644 --- a/sdext/source/pdfimport/pdfparse/pdfentries.cxx +++ b/sdext/source/pdfimport/pdfparse/pdfentries.cxx @@ -68,7 +68,7 @@ struct EmitImplData return false; } - EmitImplData( const PDFContainer* pTopContainer ) : + explicit EmitImplData( const PDFContainer* pTopContainer ) : m_pObjectContainer( pTopContainer ), m_nDecryptObject( 0 ), m_nDecryptGeneration( 0 ) diff --git a/sdext/source/pdfimport/pdfparse/pdfparse.cxx b/sdext/source/pdfimport/pdfparse/pdfparse.cxx index 7600d3c6a6d9..cacbab097e78 100644 --- a/sdext/source/pdfimport/pdfparse/pdfparse.cxx +++ b/sdext/source/pdfimport/pdfparse/pdfparse.cxx @@ -77,7 +77,7 @@ class PDFGrammar : public grammar< PDFGrammar<iteratorT> > { public: - PDFGrammar( const iteratorT& first ) + explicit PDFGrammar( const iteratorT& first ) : m_fDouble( 0.0 ), m_aGlobalBegin( first ) {} ~PDFGrammar() { @@ -130,7 +130,7 @@ public: template< typename ScannerT > struct definition { - definition( const PDFGrammar<iteratorT>& rSelf ) + explicit definition( const PDFGrammar<iteratorT>& rSelf ) { PDFGrammar<iteratorT>* pSelf = const_cast< PDFGrammar<iteratorT>* >( &rSelf ); diff --git a/sdext/source/pdfimport/sax/saxattrlist.hxx b/sdext/source/pdfimport/sax/saxattrlist.hxx index e46d7c49c34c..097a752afa07 100644 --- a/sdext/source/pdfimport/sax/saxattrlist.hxx +++ b/sdext/source/pdfimport/sax/saxattrlist.hxx @@ -48,7 +48,7 @@ namespace pdfi public: SaxAttrList() {} - SaxAttrList( const std::unordered_map< OUString, OUString, OUStringHash >& ); + explicit SaxAttrList( const std::unordered_map< OUString, OUString, OUStringHash >& ); SaxAttrList( const SaxAttrList& ); virtual ~SaxAttrList(); diff --git a/sdext/source/pdfimport/tree/genericelements.hxx b/sdext/source/pdfimport/tree/genericelements.hxx index b774ace53f1c..c8da275696df 100644 --- a/sdext/source/pdfimport/tree/genericelements.hxx +++ b/sdext/source/pdfimport/tree/genericelements.hxx @@ -73,7 +73,7 @@ namespace pdfi struct Element { protected: - Element( Element* pParent ) + explicit Element( Element* pParent ) : x( 0 ), y( 0 ), w( 0 ), h( 0 ), StyleId( -1 ), Parent( pParent ) { if( pParent ) @@ -187,7 +187,7 @@ namespace pdfi { friend class ElementFactory; protected: - ParagraphElement( Element* pParent ) : Element( pParent ), Type( Normal ), bRtl( false ) {} + explicit ParagraphElement( Element* pParent ) : Element( pParent ), Type( Normal ), bRtl( false ) {} public: virtual void visitedBy( ElementTreeVisitor&, const std::list< Element* >::const_iterator& rParentIt ) SAL_OVERRIDE; diff --git a/sdext/source/pdfimport/tree/style.hxx b/sdext/source/pdfimport/tree/style.hxx index 859f99879c37..22c3caf9d233 100644 --- a/sdext/source/pdfimport/tree/style.hxx +++ b/sdext/source/pdfimport/tree/style.hxx @@ -125,7 +125,7 @@ namespace pdfi { const std::unordered_map< sal_Int32, HashedStyle >* m_pMap; - StyleIdNameSort( const std::unordered_map< sal_Int32, HashedStyle >* pMap ) : + explicit StyleIdNameSort( const std::unordered_map< sal_Int32, HashedStyle >* pMap ) : m_pMap(pMap) {} bool operator()( sal_Int32 nLeft, sal_Int32 nRight ) diff --git a/sdext/source/pdfimport/wrapper/wrapper.cxx b/sdext/source/pdfimport/wrapper/wrapper.cxx index 4621be14b69e..998af4a419c1 100644 --- a/sdext/source/pdfimport/wrapper/wrapper.cxx +++ b/sdext/source/pdfimport/wrapper/wrapper.cxx @@ -990,7 +990,7 @@ class Buffering sal_uInt64 left; public: - Buffering(oslFileHandle& out) : aBuffer(new char[SIZE]), pOut(out), pos(0), left(0) {} + explicit Buffering(oslFileHandle& out) : aBuffer(new char[SIZE]), pOut(out), pos(0), left(0) {} oslFileError read(char *pChar, short count, sal_uInt64* pBytesRead) { diff --git a/sdext/source/presenter/PresenterAccessibility.cxx b/sdext/source/presenter/PresenterAccessibility.cxx index 9a4864ed3916..5d07ed808d55 100644 --- a/sdext/source/presenter/PresenterAccessibility.cxx +++ b/sdext/source/presenter/PresenterAccessibility.cxx @@ -236,7 +236,7 @@ class AccessibleStateSet public AccessibleStateSetInterfaceBase { public: - AccessibleStateSet (const sal_Int32 nStateSet); + explicit AccessibleStateSet (const sal_Int32 nStateSet); virtual ~AccessibleStateSet(); static sal_uInt32 GetStateMask (const sal_Int16 nType); diff --git a/sdext/source/presenter/PresenterBitmapContainer.hxx b/sdext/source/presenter/PresenterBitmapContainer.hxx index 38a06a91ed27..f199012fd55b 100644 --- a/sdext/source/presenter/PresenterBitmapContainer.hxx +++ b/sdext/source/presenter/PresenterBitmapContainer.hxx @@ -50,7 +50,7 @@ public: { public: BitmapDescriptor(); - BitmapDescriptor (const std::shared_ptr<BitmapDescriptor>& rpDefault); + explicit BitmapDescriptor (const std::shared_ptr<BitmapDescriptor>& rpDefault); enum Mode {Normal, MouseOver, ButtonDown, Disabled, Mask}; css::uno::Reference<css::rendering::XBitmap> GetNormalBitmap() const; diff --git a/sdext/source/presenter/PresenterPaneBorderPainter.hxx b/sdext/source/presenter/PresenterPaneBorderPainter.hxx index 603fc9cc76f5..7632fa80f115 100644 --- a/sdext/source/presenter/PresenterPaneBorderPainter.hxx +++ b/sdext/source/presenter/PresenterPaneBorderPainter.hxx @@ -52,7 +52,7 @@ class PresenterPaneBorderPainter public PresenterPaneBorderPainterInterfaceBase { public: - PresenterPaneBorderPainter ( + explicit PresenterPaneBorderPainter ( const css::uno::Reference<css::uno::XComponentContext>& rxContext); virtual ~PresenterPaneBorderPainter(); diff --git a/sdext/source/presenter/PresenterPaneContainer.hxx b/sdext/source/presenter/PresenterPaneContainer.hxx index 99b70e90b62b..18a7a1f8597c 100644 --- a/sdext/source/presenter/PresenterPaneContainer.hxx +++ b/sdext/source/presenter/PresenterPaneContainer.hxx @@ -61,7 +61,7 @@ class PresenterPaneContainer public PresenterPaneContainerInterfaceBase { public: - PresenterPaneContainer ( + explicit PresenterPaneContainer ( const css::uno::Reference<css::uno::XComponentContext>& rxContext); virtual ~PresenterPaneContainer(); diff --git a/sdext/source/presenter/PresenterProtocolHandler.cxx b/sdext/source/presenter/PresenterProtocolHandler.cxx index ddaa4a4cf788..9dbefb239ca3 100644 --- a/sdext/source/presenter/PresenterProtocolHandler.cxx +++ b/sdext/source/presenter/PresenterProtocolHandler.cxx @@ -58,7 +58,7 @@ namespace { class GotoPreviousSlideCommand : public Command { public: - GotoPreviousSlideCommand ( + explicit GotoPreviousSlideCommand ( const rtl::Reference<PresenterController>& rpPresenterController); virtual ~GotoPreviousSlideCommand() {} virtual void Execute() SAL_OVERRIDE; @@ -70,7 +70,7 @@ namespace { class GotoNextSlideCommand : public Command { public: - GotoNextSlideCommand ( + explicit GotoNextSlideCommand ( const rtl::Reference<PresenterController>& rpPresenterController); virtual ~GotoNextSlideCommand() {} virtual void Execute() SAL_OVERRIDE; @@ -85,7 +85,7 @@ namespace { class GotoNextEffectCommand : public Command { public: - GotoNextEffectCommand ( + explicit GotoNextEffectCommand ( const rtl::Reference<PresenterController>& rpPresenterController); virtual ~GotoNextEffectCommand() {} virtual void Execute() SAL_OVERRIDE; @@ -96,7 +96,7 @@ namespace { class SwitchMonitorCommand : public Command { public: - SwitchMonitorCommand ( + explicit SwitchMonitorCommand ( const rtl::Reference<PresenterController>& rpPresenterController); virtual ~SwitchMonitorCommand() {} virtual void Execute() SAL_OVERRIDE; diff --git a/sdext/source/presenter/PresenterProtocolHandler.hxx b/sdext/source/presenter/PresenterProtocolHandler.hxx index 81121fe6b10f..45bd9f946c37 100644 --- a/sdext/source/presenter/PresenterProtocolHandler.hxx +++ b/sdext/source/presenter/PresenterProtocolHandler.hxx @@ -46,7 +46,7 @@ class PresenterProtocolHandler public PresenterProtocolHandlerInterfaceBase { public: - PresenterProtocolHandler (const css::uno::Reference<css::uno::XComponentContext>& rxContext); + explicit PresenterProtocolHandler (const css::uno::Reference<css::uno::XComponentContext>& rxContext); virtual ~PresenterProtocolHandler(); void SAL_CALL disposing() SAL_OVERRIDE; diff --git a/sdext/source/presenter/PresenterScrollBar.cxx b/sdext/source/presenter/PresenterScrollBar.cxx index 2440e17f4659..b0dec0aa77be 100644 --- a/sdext/source/presenter/PresenterScrollBar.cxx +++ b/sdext/source/presenter/PresenterScrollBar.cxx @@ -48,7 +48,7 @@ class PresenterScrollBar::MousePressRepeater : public std::enable_shared_from_this<MousePressRepeater> { public: - MousePressRepeater (const ::rtl::Reference<PresenterScrollBar>& rpScrollBar); + explicit MousePressRepeater (const ::rtl::Reference<PresenterScrollBar>& rpScrollBar); void Dispose(); void Start (const PresenterScrollBar::Area& reArea); void Stop(); diff --git a/sdext/source/presenter/PresenterSlideSorter.cxx b/sdext/source/presenter/PresenterSlideSorter.cxx index 151395223378..ef45c7d97c4a 100644 --- a/sdext/source/presenter/PresenterSlideSorter.cxx +++ b/sdext/source/presenter/PresenterSlideSorter.cxx @@ -84,7 +84,7 @@ namespace { class PresenterSlideSorter::Layout { public: - Layout (const ::rtl::Reference<PresenterScrollBar>& rpVerticalScrollBar); + explicit Layout (const ::rtl::Reference<PresenterScrollBar>& rpVerticalScrollBar); void Update (const geometry::RealRectangle2D& rBoundingBox, const double nSlideAspectRatio); void SetupVisibleArea(); diff --git a/sdext/source/presenter/PresenterToolBar.cxx b/sdext/source/presenter/PresenterToolBar.cxx index 660e12df9caa..3b102475398d 100644 --- a/sdext/source/presenter/PresenterToolBar.cxx +++ b/sdext/source/presenter/PresenterToolBar.cxx @@ -132,7 +132,7 @@ namespace { public ElementInterfaceBase { public: - Element (const ::rtl::Reference<PresenterToolBar>& rpToolBar); + explicit Element (const ::rtl::Reference<PresenterToolBar>& rpToolBar); virtual ~Element(); virtual void SAL_CALL disposing() SAL_OVERRIDE; @@ -243,7 +243,7 @@ namespace { class Label : public Element { public: - Label (const ::rtl::Reference<PresenterToolBar>& rpToolBar); + explicit Label (const ::rtl::Reference<PresenterToolBar>& rpToolBar); void SetText (const OUString& rsText); virtual void Paint ( @@ -275,14 +275,14 @@ namespace { void ConnectToTimer(); virtual void TimeHasChanged (const oslDateTime& rCurrentTime) = 0; protected: - TimeLabel(const ::rtl::Reference<PresenterToolBar>& rpToolBar); + explicit TimeLabel(const ::rtl::Reference<PresenterToolBar>& rpToolBar); using Element::disposing; virtual void SAL_CALL disposing() SAL_OVERRIDE; private: class Listener : public PresenterClockTimer::Listener { public: - Listener (const ::rtl::Reference<TimeLabel>& rxLabel) + explicit Listener (const ::rtl::Reference<TimeLabel>& rxLabel) : mxLabel(rxLabel) {} virtual ~Listener() {} virtual void TimeHasChanged (const oslDateTime& rCurrentTime) SAL_OVERRIDE |