diff options
| author | Caolán McNamara <caolan.mcnamara@collabora.com> | 2023-12-10 15:55:31 +0000 |
|---|---|---|
| committer | Caolán McNamara <caolan.mcnamara@collabora.com> | 2023-12-10 20:27:43 +0100 |
| commit | 95e12eaebc00be5385e0abef2c5e70b7729af6f4 (patch) | |
| tree | 980b94df68d575bb27f3b28ae38723279b57c43a /sc | |
| parent | 9531f83cc73e26ce766713e575eb14152d118018 (diff) | |
cid#1545789 COPY_INSTEAD_OF_MOVE
and
cid#1545791 COPY_INSTEAD_OF_MOVE
cid#1545800 COPY_INSTEAD_OF_MOVE
cid#1545806 COPY_INSTEAD_OF_MOVE
cid#1545817 COPY_INSTEAD_OF_MOVE
cid#1545832 COPY_INSTEAD_OF_MOVE
cid#1545834 COPY_INSTEAD_OF_MOVE
cid#1545841 COPY_INSTEAD_OF_MOVE
cid#1545848 COPY_INSTEAD_OF_MOVE
cid#1545852 COPY_INSTEAD_OF_MOVE
cid#1545854 COPY_INSTEAD_OF_MOVE
cid#1545864 COPY_INSTEAD_OF_MOVE
cid#1545875 COPY_INSTEAD_OF_MOVE
cid#1545882 COPY_INSTEAD_OF_MOVE
cid#1545900 COPY_INSTEAD_OF_MOVE
cid#1545901 COPY_INSTEAD_OF_MOVE
cid#1545908 COPY_INSTEAD_OF_MOVE
cid#1545921 COPY_INSTEAD_OF_MOVE
cid#1546054 COPY_INSTEAD_OF_MOVE
cid#1546145 COPY_INSTEAD_OF_MOVE
cid#1546146 COPY_INSTEAD_OF_MOVE
Change-Id: I8b23d0457cb293aa0e33593131224c1cdd1d8eb1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160545
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Diffstat (limited to 'sc')
| -rw-r--r-- | sc/source/filter/oox/stylesbuffer.cxx | 9 | ||||
| -rw-r--r-- | sc/source/ui/docshell/docfunc.cxx | 2 | ||||
| -rw-r--r-- | sc/source/ui/inc/docfunc.hxx | 2 |
3 files changed, 5 insertions, 8 deletions
diff --git a/sc/source/filter/oox/stylesbuffer.cxx b/sc/source/filter/oox/stylesbuffer.cxx index 2310f324e27a..f31cde38bcff 100644 --- a/sc/source/filter/oox/stylesbuffer.cxx +++ b/sc/source/filter/oox/stylesbuffer.cxx @@ -1510,12 +1510,9 @@ void Border::importDxfBorder( sal_Int32 nElement, SequenceInputStream& rStrm ) void Border::finalizeImport( bool bRTL ) { - if ( bRTL ) - { - BorderLineModel aTmp = maModel.maLeft; - maModel.maLeft = maModel.maRight; - maModel.maRight = aTmp; - } + if (bRTL) + std::swap(maModel.maLeft, maModel.maRight); + maApiData.mbBorderUsed = maModel.maLeft.mbUsed || maModel.maRight.mbUsed || maModel.maTop.mbUsed || maModel.maBottom.mbUsed; maApiData.mbDiagUsed = maModel.maDiagonal.mbUsed; diff --git a/sc/source/ui/docshell/docfunc.cxx b/sc/source/ui/docshell/docfunc.cxx index 1a8d902bea19..50dc53ec546f 100644 --- a/sc/source/ui/docshell/docfunc.cxx +++ b/sc/source/ui/docshell/docfunc.cxx @@ -5773,7 +5773,7 @@ void ScDocFunc::EndListAction() } bool ScDocFunc::InsertSparklines(ScRange const& rDataRange, ScRange const& rSparklineRange, - std::shared_ptr<sc::SparklineGroup> pSparklineGroup) + const std::shared_ptr<sc::SparklineGroup>& pSparklineGroup) { std::vector<sc::SparklineData> aSparklineDataVector; diff --git a/sc/source/ui/inc/docfunc.hxx b/sc/source/ui/inc/docfunc.hxx index aa9755566ef3..e1f0bb9eaa34 100644 --- a/sc/source/ui/inc/docfunc.hxx +++ b/sc/source/ui/inc/docfunc.hxx @@ -245,7 +245,7 @@ public: void ConvertFormulaToValue( const ScRange& rRange, bool bInteraction ); SC_DLLPUBLIC bool InsertSparklines(ScRange const& rDataRange, ScRange const& rSparklineRange, - std::shared_ptr<sc::SparklineGroup> pSparklineGroup); + const std::shared_ptr<sc::SparklineGroup>& pSparklineGroup); SC_DLLPUBLIC bool DeleteSparkline(ScAddress const& rAddress); SC_DLLPUBLIC bool DeleteSparklineGroup(std::shared_ptr<sc::SparklineGroup> const& pSparklineGroup, SCTAB nTab); |