diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2023-10-06 16:51:17 +0200 |
|---|---|---|
| committer | Stephan Bergmann <stephan.bergmann@allotropia.de> | 2024-04-28 11:29:52 +0200 |
| commit | d98e014cf6d4cea7ebd7898cbc9124f6fba07684 (patch) | |
| tree | 195a5e99cea2c8ec6d9bae19cb56f488d75bb6fa /sal | |
| parent | 817d35eb829db00329ea5437d50e5c682139f505 (diff) | |
Extended loplugin:ostr manual changes
I had done these a while ago, when I looked into extending loplugin:ostr to do
more automatic rewriting, and these were places where I needed to do something
manually, for one reason or another, because the automatic rewriting would not
pick it up correctly.
However, I got distracted, and a wholesale automatic rewrite would still run
into cases where an _ostr/_ustr instance from a library's .rodata would still be
referenced after the library has already been dlcose'd. So I never came around
to finishing all that.
But there appears to be renewed interest in (automatic) rewritings here now, so
it probably makes sense if I share this part of my work anyway.
Change-Id: I3da9d38398e4bca373cb0000a9d34b49a36ad58a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166792
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
Tested-by: Jenkins
Diffstat (limited to 'sal')
| -rw-r--r-- | sal/qa/rtl/alloc/rtl_alloc.cxx | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/sal/qa/rtl/alloc/rtl_alloc.cxx b/sal/qa/rtl/alloc/rtl_alloc.cxx index cf4813ae16bf..2364f3fe56cf 100644 --- a/sal/qa/rtl/alloc/rtl_alloc.cxx +++ b/sal/qa/rtl/alloc/rtl_alloc.cxx @@ -17,6 +17,7 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ +#include <o3tl/nonstaticstring.hxx> #include <rtl/alloc.h> #include <rtl/ustrbuf.hxx> #include <sal/types.h> @@ -158,7 +159,7 @@ public: rtl_alloc_preInit(true); - OUString aFoo("foo"); // [-loplugin:ostr] + OUString aFoo(o3tl::nonStaticString(u"foo")); // fill some cache bits for (int iter = 0; iter < 4; iter++) |