diff options
| author | Noel Grandin <noel@peralex.com> | 2014-12-17 11:08:26 +0200 |
|---|---|---|
| committer | Noel Grandin <noel@peralex.com> | 2014-12-19 10:41:56 +0200 |
| commit | e747737ad36f4ed0f89d2f01b278e250daea1a04 (patch) | |
| tree | 4742f99e52c416410d7af06206eea4b26c2b18de /qadevOOo/runner/helper | |
| parent | 52d844485820c8bd1db8e15ce06ab6c76a8b6156 (diff) | |
java: synching on an interned String object not good
Just remove this field altogether, it was not being used for
anything other than synchronisation.
Change-Id: I982385f9eb7aed3fff0adf85d2a37bfe003d937b
Diffstat (limited to 'qadevOOo/runner/helper')
| -rw-r--r-- | qadevOOo/runner/helper/ProcessHandler.java | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/qadevOOo/runner/helper/ProcessHandler.java b/qadevOOo/runner/helper/ProcessHandler.java index 9105a86b673b..0057e8970713 100644 --- a/qadevOOo/runner/helper/ProcessHandler.java +++ b/qadevOOo/runner/helper/ProcessHandler.java @@ -120,7 +120,6 @@ public class ProcessHandler private boolean isFinished = false; private boolean isStarted = false; private long mTimeOut = 0; - private String stdInBuff = ""; private Pump stdout = null; private Pump stderr = null; private PrintStream stdIn = null; @@ -546,11 +545,9 @@ public class ProcessHandler return; } - synchronized(stdInBuff) + synchronized(this) { - stdIn.print(stdInBuff); stdIn.flush(); - stdInBuff = ""; } } |