summaryrefslogtreecommitdiff
path: root/oovbaapi/ooo/vba/excel/XWindows.idl
diff options
context:
space:
mode:
authorMichael Stahl <michael.stahl@allotropia.de>2022-06-12 21:48:58 +0200
committerMichael Stahl <michael.stahl@allotropia.de>2022-06-13 16:26:40 +0200
commit32dd76143bdf55ac73f03f705097453521b4bf2c (patch)
tree26c63d378836adf3b8651ea66f62b65aff5643af /oovbaapi/ooo/vba/excel/XWindows.idl
parentb7c260aee331474d993bf96a72bf31f5af350ef3 (diff)
sc: ODF export: fix style:font-name on EE text/paragraph styles
The problem is that sc contains its own duplicate export of EditEngine styles, where the SvxFontItem aFamilyName is exported directly to style:font-name. But style:font-name refers to a style:font-face, and for a given font family name there may be multiple font-face elements whose names have a counter appended, and they are written in some non-deterministic order, so effectively this picks font-face at random. In XMLTextExportPropertySetMapper::ContextFontFilter() there is already code to do the lookup, and also a fallback when the lookup fails to a set of individual attributes fo:font-family style:font-style-name style:font-family-generic etc., which is actually used for fonts in control shapes, which have "unknown" for one of the components, so there could be some other problem with them. It doesn't look possible for the lookup to fail for EditEngine items, as ScXMLFontAutoStylePool_Impl should have added all of them. This problem was detected by current ODFunDiff in 22 of 2000 ODS files; with this fix only other problems remain. Change-Id: I276f705296df628b0869526f4ea676c47a014328 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135684 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
Diffstat (limited to 'oovbaapi/ooo/vba/excel/XWindows.idl')
0 files changed, 0 insertions, 0 deletions