diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2022-01-22 22:14:43 +0100 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2022-01-23 12:28:20 +0100 |
| commit | 5462235f5611a784b60e5a0ab1fff6a1ea6ebc1d (patch) | |
| tree | 38c8fd6b9d4a7e1f00ce7f54d4578b490bd31ccd /jurt | |
| parent | e170d62b488117a09fe401a6ac63355a74347689 (diff) | |
Avoid loplugin:salcall
> In file included from jurt/source/pipe/staticsalhack.cxx:39:
> sal/osl/unx/module.cxx:212:6: error: SAL_CALL unnecessary here [loplugin:salcall]
> void SAL_CALL osl_unloadModule(oslModule hModule)
> ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
in an ASan+UBSan build with --enable-compiler-plugins, after
b5b1eae538a902fed165d5dd93ad6ddda3c5cb70 "Add HAVE_(UNIX_)DLAPI config header
define". DISABLE_DYNLOADING was defined there ever since
ddc7bb629ade15b3341f2e3c347652c7b8925037 "Poor hack for libjpipe.so under Clang
-fsanitize=*" but doesn't appear to be necessary. (Alternatively,
loplugin:salcall could be taught not to warn if the function definition involves
any #if'ery.)
Change-Id: I5786979eb944d59f969c9875d77b03f9b2432161
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128797
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'jurt')
| -rw-r--r-- | jurt/source/pipe/staticsalhack.cxx | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/jurt/source/pipe/staticsalhack.cxx b/jurt/source/pipe/staticsalhack.cxx index 4bba0c53ef33..78a44bba6bb1 100644 --- a/jurt/source/pipe/staticsalhack.cxx +++ b/jurt/source/pipe/staticsalhack.cxx @@ -7,7 +7,6 @@ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ -#define DISABLE_DYNLOADING #define NO_CHILD_PROCESSES #undef SAL_LOG_INFO #undef SAL_LOG_WARN |