diff options
author | Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk> | 2017-12-13 22:08:20 +0900 |
---|---|---|
committer | Tomaž Vajngerl <quikee@gmail.com> | 2017-12-18 12:38:04 +0100 |
commit | 55a7e836a2db662a53adc4f8b98d08b06790c758 (patch) | |
tree | 1453dceb8e253f700d895451d83b88b60948a1ff /include/svx | |
parent | e1697600253361a26d77a1ef61f8bde16af0ed2c (diff) |
chart2: When creating objects prevent setting object rects dirty
3D objects using a E3dScene are traversing all object in the tree
when setting rects dirty. When we are creating objects, setting
properties and adding them to the tree we trigger setting rects
dirty which slows down considerably - more are added objects,
bigger the slowdown gets. So the solution here is to temporary
disable setting object rects dirty during creation of objects.
Change-Id: Id068cda9cb798d49b75bf4228cf6460f7e98c033
Reviewed-on: https://gerrit.libreoffice.org/46446
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Diffstat (limited to 'include/svx')
-rw-r--r-- | include/svx/scene3d.hxx | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/include/svx/scene3d.hxx b/include/svx/scene3d.hxx index 81703f1d001f..2f76cec02a13 100644 --- a/include/svx/scene3d.hxx +++ b/include/svx/scene3d.hxx @@ -75,6 +75,8 @@ protected: // Flag to determine if only selected objects should be drawn bool bDrawOnlySelected : 1; + bool mbSkipSettingDirty : 1; + virtual void NewObjectInserted(const E3dObject* p3DObj) override; virtual void StructureChanged() override; @@ -161,6 +163,9 @@ public: virtual bool EndCreate(SdrDragStat& rStat, SdrCreateCmd eCmd) override; virtual bool BckCreate(SdrDragStat& rStat) override; virtual void BrkCreate(SdrDragStat& rStat) override; + + void EnterObjectSetupMode(); + void ExitObjectSetupMode(); }; #endif // INCLUDED_SVX_SCENE3D_HXX |