diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-07-18 11:33:26 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-07-18 13:27:45 +0200 |
commit | 41dc56df37596ff20c0476ae44fbd07b8b4678a1 (patch) | |
tree | 944bcf4a9f458e4ad1025651b7ac632e2d47c0dd /idlc | |
parent | 50985d9b60cc03954bbae3dc931abb6aa18c4c78 (diff) |
loplugin:constparams codemaker,idl,idlc
Change-Id: Ic72b7525cfbfbd3c5afb12fe9ea814176e6c8c9d
Reviewed-on: https://gerrit.libreoffice.org/40126
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'idlc')
-rw-r--r-- | idlc/inc/astscope.hxx | 2 | ||||
-rw-r--r-- | idlc/inc/errorhandler.hxx | 6 | ||||
-rw-r--r-- | idlc/inc/fehelper.hxx | 2 | ||||
-rw-r--r-- | idlc/source/astscope.cxx | 2 | ||||
-rw-r--r-- | idlc/source/errorhandler.cxx | 8 | ||||
-rw-r--r-- | idlc/source/fehelper.cxx | 2 | ||||
-rw-r--r-- | idlc/source/parser.y | 2 |
7 files changed, 12 insertions, 12 deletions
diff --git a/idlc/inc/astscope.hxx b/idlc/inc/astscope.hxx index e241f49407b9..3ce546a087ac 100644 --- a/idlc/inc/astscope.hxx +++ b/idlc/inc/astscope.hxx @@ -54,7 +54,7 @@ public: // Look up a predefined type by its ExprType AstDeclaration* lookupPrimitiveType(ExprType type); - AstDeclaration* lookupForAdd(AstDeclaration* pDecl); + AstDeclaration* lookupForAdd(AstDeclaration const * pDecl); protected: AstDeclaration const * getLast() const diff --git a/idlc/inc/errorhandler.hxx b/idlc/inc/errorhandler.hxx index f906ff7395e7..b2d8b94d8c5c 100644 --- a/idlc/inc/errorhandler.hxx +++ b/idlc/inc/errorhandler.hxx @@ -80,7 +80,7 @@ public: static void error1(ErrorCode e, AstDeclaration const * d); static void error2( ErrorCode e, AstDeclaration const * d1, AstDeclaration const * d2); - static void error3(ErrorCode e, AstDeclaration* d1, AstDeclaration* d2, AstDeclaration* d3); + static void error3(ErrorCode e, AstDeclaration const * d1, AstDeclaration const * d2, AstDeclaration const * d3); // Warning static void warning0(WarningCode e, const sal_Char* warningmsg); @@ -100,13 +100,13 @@ public: // Report a type error static void noTypeError(AstDeclaration const * pDecl); - static void inheritanceError(NodeType nodeType, const OString* name, AstDeclaration* pDecl); + static void inheritanceError(NodeType nodeType, const OString* name, AstDeclaration const * pDecl); static void flagError(ErrorCode e, sal_uInt32 flag); static void forwardLookupError(const AstDeclaration* pForward, const OString& name); - static void constantExpected(AstDeclaration* pDecl, const OString& name); + static void constantExpected(AstDeclaration const * pDecl, const OString& name); static void evalError(AstExpression* pExpr); diff --git a/idlc/inc/fehelper.hxx b/idlc/inc/fehelper.hxx index 9cec2f644e25..730aa05607a1 100644 --- a/idlc/inc/fehelper.hxx +++ b/idlc/inc/fehelper.hxx @@ -63,7 +63,7 @@ public: { return m_typeParameters; } private: - void initializeInherits(OString* pinherits); + void initializeInherits(OString const * pinherits); NodeType m_nodeType; OString* m_pName; diff --git a/idlc/source/astscope.cxx b/idlc/source/astscope.cxx index c999257e1eba..c90870ebeeff 100644 --- a/idlc/source/astscope.cxx +++ b/idlc/source/astscope.cxx @@ -319,7 +319,7 @@ AstDeclaration* AstScope::lookupPrimitiveType(ExprType type) return nullptr; } -AstDeclaration* AstScope::lookupForAdd(AstDeclaration* pDecl) +AstDeclaration* AstScope::lookupForAdd(AstDeclaration const * pDecl) { if ( !pDecl ) return nullptr; diff --git a/idlc/source/errorhandler.cxx b/idlc/source/errorhandler.cxx index ac3aeee77b8e..53339318ec91 100644 --- a/idlc/source/errorhandler.cxx +++ b/idlc/source/errorhandler.cxx @@ -444,7 +444,7 @@ void ErrorHandler::error2( idlc()->incErrorCount(); } -void ErrorHandler::error3(ErrorCode e, AstDeclaration* d1, AstDeclaration* d2, AstDeclaration* d3) +void ErrorHandler::error3(ErrorCode e, AstDeclaration const * d1, AstDeclaration const * d2, AstDeclaration const * d3) { errorHeader(e); fprintf(stderr, "'%s', '%s', '%s'\n", d1->getScopedName().getStr(), @@ -528,11 +528,11 @@ char const * nodeTypeName(NodeType nodeType) { } -void ErrorHandler::inheritanceError(NodeType nodeType, const OString* name, AstDeclaration* pDecl) +void ErrorHandler::inheritanceError(NodeType nodeType, const OString* name, AstDeclaration const * pDecl) { if ( nodeType == NT_interface && (pDecl->getNodeType() == NT_interface) && - !(static_cast<AstInterface*>(pDecl)->isDefined()) ) + !(static_cast<AstInterface const *>(pDecl)->isDefined()) ) { errorHeader(ErrorCode::CannotInheritFromForward); fprintf(stderr, "interface '%s' cannot inherit from forward declared interface '%s'\n", @@ -556,7 +556,7 @@ void ErrorHandler::forwardLookupError(const AstDeclaration* pForward, idlc()->incErrorCount(); } -void ErrorHandler::constantExpected(AstDeclaration* pDecl, +void ErrorHandler::constantExpected(AstDeclaration const * pDecl, const OString& name) { errorHeader(ErrorCode::ExpectedConstant); diff --git a/idlc/source/fehelper.cxx b/idlc/source/fehelper.cxx index 47cb63af32bd..1d3fc4154b1b 100644 --- a/idlc/source/fehelper.cxx +++ b/idlc/source/fehelper.cxx @@ -70,7 +70,7 @@ FeInheritanceHeader::FeInheritanceHeader( initializeInherits(pInherits); } -void FeInheritanceHeader::initializeInherits(OString* pInherits) +void FeInheritanceHeader::initializeInherits(OString const * pInherits) { if ( pInherits ) { diff --git a/idlc/source/parser.y b/idlc/source/parser.y index d7f63a55f152..af945f67a4c2 100644 --- a/idlc/source/parser.y +++ b/idlc/source/parser.y @@ -66,7 +66,7 @@ using ::rtl::OStringBuffer; extern int yylex(void); void yyerror(char const *); -void checkIdentifier(::rtl::OString* id) +void checkIdentifier(::rtl::OString const * id) { static short check = 0; if (check == 0) { |