clang-tidy:readability-redundant-member-init

Change-Id: I67edbea77b12940ac807ccbadfd74b250902809d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121378
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

19 files changed, 8 insertions, 55 deletions

diff --git a/framework/source/accelerators/presethandler.cxx b/framework/source/accelerators/presethandler.cxx
index e4ae9251ab84..44a6131a2951 100644
--- a/framework/source/accelerators/presethandler.cxx
+++ b/framework/source/accelerators/presethandler.cxx
@@ -57,8 +57,6 @@ struct TSharedStorages final
         StorageHolder m_lStoragesUser;
 
         TSharedStorages()
-            : m_lStoragesShare()
-            , m_lStoragesUser ()
         {};
 };
 
@@ -73,7 +71,6 @@ struct SharedStorages: public rtl::Static<TSharedStorages, SharedStorages> {};
 PresetHandler::PresetHandler(const css::uno::Reference< css::uno::XComponentContext >& xContext)
     : m_xContext(xContext)
     , m_eConfigType(E_GLOBAL)
-    , m_lDocumentStorages()
 {
 }
 
diff --git a/framework/source/fwe/classes/actiontriggercontainer.cxx b/framework/source/fwe/classes/actiontriggercontainer.cxx
index c21dbcbbd94d..e6675cf17c96 100644
--- a/framework/source/fwe/classes/actiontriggercontainer.cxx
+++ b/framework/source/fwe/classes/actiontriggercontainer.cxx
@@ -32,8 +32,7 @@ using namespace com::sun::star::container;
 namespace framework
 {
 
-ActionTriggerContainer::ActionTriggerContainer() :
-    PropertySetContainer()
+ActionTriggerContainer::ActionTriggerContainer()
 {
 }
 
diff --git a/framework/source/fwe/classes/actiontriggerpropertyset.cxx b/framework/source/fwe/classes/actiontriggerpropertyset.cxx
index 404e7f00a6bf..4592174df5ad 100644
--- a/framework/source/fwe/classes/actiontriggerpropertyset.cxx
+++ b/framework/source/fwe/classes/actiontriggerpropertyset.cxx
@@ -58,7 +58,6 @@ namespace framework
 ActionTriggerPropertySet::ActionTriggerPropertySet()
     : OBroadcastHelper         ( m_aMutex )
     , OPropertySetHelper       ( *static_cast< OBroadcastHelper * >(this) )
-    , OWeakObject              ()
 {
 }
 
diff --git a/framework/source/fwe/classes/actiontriggerseparatorpropertyset.cxx b/framework/source/fwe/classes/actiontriggerseparatorpropertyset.cxx
index 4d090384194c..104d765f5ca3 100644
--- a/framework/source/fwe/classes/actiontriggerseparatorpropertyset.cxx
+++ b/framework/source/fwe/classes/actiontriggerseparatorpropertyset.cxx
@@ -52,7 +52,6 @@ namespace framework
 ActionTriggerSeparatorPropertySet::ActionTriggerSeparatorPropertySet()
         :   OBroadcastHelper        ( m_aMutex )
         ,   OPropertySetHelper      ( *static_cast< OBroadcastHelper * >(this) )
-        ,   OWeakObject             ()
         ,   m_nSeparatorType( 0 )
 {
 }
diff --git a/framework/source/fwe/classes/rootactiontriggercontainer.cxx b/framework/source/fwe/classes/rootactiontriggercontainer.cxx
index 8a59027aae1b..0732959d1a80 100644
--- a/framework/source/fwe/classes/rootactiontriggercontainer.cxx
+++ b/framework/source/fwe/classes/rootactiontriggercontainer.cxx
@@ -44,8 +44,7 @@ static Sequence< sal_Int8 > const & impl_getStaticIdentifier()
 }
 
 RootActionTriggerContainer::RootActionTriggerContainer( const Menu* pMenu, const OUString* pMenuIdentifier ) :
-    PropertySetContainer()
-    ,   m_bContainerCreated( false )
+        m_bContainerCreated( false )
     ,   m_pMenu( pMenu )
     ,   m_pMenuIdentifier( pMenuIdentifier )
 {
diff --git a/framework/source/fwe/dispatch/interaction.cxx b/framework/source/fwe/dispatch/interaction.cxx
index 19793e8f98b9..73be5153c37c 100644
--- a/framework/source/fwe/dispatch/interaction.cxx
+++ b/framework/source/fwe/dispatch/interaction.cxx
@@ -70,7 +70,6 @@ class ContinuationFilterSelect : public comphelper::OInteraction< css::document:
 // initialize continuation with right start values
 
 ContinuationFilterSelect::ContinuationFilterSelect()
-    : m_sFilter( OUString() )
 {
 }
 
diff --git a/framework/source/fwe/helper/propertysetcontainer.cxx b/framework/source/fwe/helper/propertysetcontainer.cxx
index 9707b4fac4ae..ad7d639539b7 100644
--- a/framework/source/fwe/helper/propertysetcontainer.cxx
+++ b/framework/source/fwe/helper/propertysetcontainer.cxx
@@ -35,8 +35,6 @@ namespace framework
 {
 
 PropertySetContainer::PropertySetContainer()
-        :   OWeakObject()
-
 {
 }
 
diff --git a/framework/source/fwe/helper/titlehelper.cxx b/framework/source/fwe/helper/titlehelper.cxx
index 246032945512..a3854489d0f8 100644
--- a/framework/source/fwe/helper/titlehelper.cxx
+++ b/framework/source/fwe/helper/titlehelper.cxx
@@ -51,11 +51,7 @@ namespace framework{
 TitleHelper::TitleHelper(const css::uno::Reference< css::uno::XComponentContext >& rxContext)
     : ::cppu::BaseMutex ()
     , m_xContext        (rxContext)
-    , m_xOwner          ()
-    , m_xUntitledNumbers()
-    , m_xSubTitle       ()
     , m_bExternalTitle  (false)
-    , m_sTitle          ()
     , m_nLeasedNumber   (css::frame::UntitledNumbersConst::INVALID_NUMBER)
     , m_aListener       (m_aMutex)
 {
diff --git a/framework/source/fwe/helper/undomanagerhelper.cxx b/framework/source/fwe/helper/undomanagerhelper.cxx
index 33d1fade47c7..ef6a9da4a5b4 100644
--- a/framework/source/fwe/helper/undomanagerhelper.cxx
+++ b/framework/source/fwe/helper/undomanagerhelper.cxx
@@ -89,8 +89,7 @@ namespace framework
     }
 
     UndoActionWrapper::UndoActionWrapper( Reference< XUndoAction > const& i_undoAction )
-        :SfxUndoAction()
-        ,m_xUndoAction( i_undoAction )
+        : m_xUndoAction( i_undoAction )
     {
         ENSURE_OR_THROW( m_xUndoAction.is(), "illegal undo action" );
     }
@@ -147,8 +146,6 @@ namespace framework
     public:
         explicit UndoManagerRequest( ::std::function<void ()> const& i_request )
             :m_request( i_request )
-            ,m_caughtException()
-            ,m_finishCondition()
         {
             m_finishCondition.reset();
         }
@@ -221,9 +218,7 @@ namespace framework
 
     public:
         explicit UndoManagerHelper_Impl( IUndoManagerImplementation& i_undoManagerImpl )
-            :m_aMutex()
-            ,m_aQueueMutex()
-            ,m_bAPIActionRunning( false )
+            :m_bAPIActionRunning( false )
             ,m_bProcessingEvents( false )
             ,m_nLockCount( 0 )
             ,m_aUndoListeners( m_aMutex )
diff --git a/framework/source/helper/titlebarupdate.cxx b/framework/source/helper/titlebarupdate.cxx
index 0ca094c6d5b0..d74439758def 100644
--- a/framework/source/helper/titlebarupdate.cxx
+++ b/framework/source/helper/titlebarupdate.cxx
@@ -43,7 +43,6 @@ const ::sal_Int32 DEFAULT_ICON_ID =  0;
 
 TitleBarUpdate::TitleBarUpdate(const css::uno::Reference< css::uno::XComponentContext >& xContext)
     : m_xContext              (xContext                     )
-    , m_xFrame                (                             )
 {
 }
 
diff --git a/framework/source/interaction/quietinteraction.cxx b/framework/source/interaction/quietinteraction.cxx
index b6f3495fff09..e9dc218576e0 100644
--- a/framework/source/interaction/quietinteraction.cxx
+++ b/framework/source/interaction/quietinteraction.cxx
@@ -34,7 +34,6 @@
 namespace framework{
 
 QuietInteraction::QuietInteraction()
-    : m_aRequest         (                               )
 {
 }
 
diff --git a/framework/source/layoutmanager/layoutmanager.cxx b/framework/source/layoutmanager/layoutmanager.cxx
index 973ec6bbaf92..3b0de8bdca71 100644
--- a/framework/source/layoutmanager/layoutmanager.cxx
+++ b/framework/source/layoutmanager/layoutmanager.cxx
@@ -83,8 +83,8 @@ namespace framework
 IMPLEMENT_FORWARD_XTYPEPROVIDER2( LayoutManager, LayoutManager_Base, LayoutManager_PBase )
 IMPLEMENT_FORWARD_XINTERFACE2( LayoutManager, LayoutManager_Base, LayoutManager_PBase )
 
-LayoutManager::LayoutManager( const Reference< XComponentContext >& xContext ) : LayoutManager_Base()
-        , ::cppu::OBroadcastHelperVar< ::cppu::OMultiTypeInterfaceContainerHelper, ::cppu::OMultiTypeInterfaceContainerHelper::keyType >(m_aMutex)
+LayoutManager::LayoutManager( const Reference< XComponentContext >& xContext ) :
+         ::cppu::OBroadcastHelperVar< ::cppu::OMultiTypeInterfaceContainerHelper, ::cppu::OMultiTypeInterfaceContainerHelper::keyType >(m_aMutex)
         , LayoutManager_PBase( *static_cast< ::cppu::OBroadcastHelper* >(this) )
         , m_xContext( xContext )
         , m_xURLTransformer( URLTransformer::create(xContext) )
diff --git a/framework/source/services/ContextChangeEventMultiplexer.cxx b/framework/source/services/ContextChangeEventMultiplexer.cxx
index 3e647985cb40..0dea0823c52b 100644
--- a/framework/source/services/ContextChangeEventMultiplexer.cxx
+++ b/framework/source/services/ContextChangeEventMultiplexer.cxx
@@ -106,8 +106,7 @@ public:
 };
 
 ContextChangeEventMultiplexer::ContextChangeEventMultiplexer()
-    : ContextChangeEventMultiplexerInterfaceBase(m_aMutex),
-      maListeners()
+    : ContextChangeEventMultiplexerInterfaceBase(m_aMutex)
 {
 }
 
diff --git a/framework/source/services/desktop.cxx b/framework/source/services/desktop.cxx
index 55af0d9c109a..c3d2c79ecdbe 100644
--- a/framework/source/services/desktop.cxx
+++ b/framework/source/services/desktop.cxx
@@ -147,20 +147,9 @@ Desktop::Desktop( const css::uno::Reference< css::uno::XComponentContext >& xCon
     , m_bIsShutdown(false)   // see dispose() for further information!
         ,   m_bSession              ( false                                         )
         ,   m_xContext              ( xContext                                      )
-        ,   m_aChildTaskContainer   (                                               )
         ,   m_aListenerContainer    ( m_aMutex )
-        ,   m_xFramesHelper         (                                               )
-        ,   m_xDispatchHelper       (                                               )
         ,   m_eLoadState            ( E_NOTSET                                      )
         ,   m_bSuspendQuickstartVeto( false                                     )
-        ,   m_sName                 (                                               )
-        ,   m_sTitle                (                                               )
-        ,   m_xDispatchRecorderSupplier(                                            )
-        ,   m_xPipeTerminator       (                                               )
-        ,   m_xQuickLauncher        (                                               )
-        ,   m_xSWThreadManager      (                                               )
-        ,   m_xSfxTerminator        (                                               )
-        ,   m_xTitleNumberGenerator (                                               )
 {
 }
 
diff --git a/framework/source/services/frame.cxx b/framework/source/services/frame.cxx
index 56a1a7b1e623..db26f59aec0b 100644
--- a/framework/source/services/frame.cxx
+++ b/framework/source/services/frame.cxx
@@ -456,21 +456,14 @@ XFrameImpl::XFrameImpl( const css::uno::Reference< css::uno::XComponentContext >
         //  init member
         , m_xContext                  ( xContext )
         , m_aListenerContainer        ( m_aMutex )
-        , m_xParent                   ()
-        , m_xContainerWindow          ()
-        , m_xComponentWindow          ()
-        , m_xController               ()
         , m_eActiveState              ( E_INACTIVE )
-        , m_sName                     ()
         , m_bIsFrameTop               ( true ) // I think we are top without a parent ... and there is no parent yet!
         , m_bConnected                ( false ) // There exist no component inside of use => sal_False, we are not connected!
         , m_nExternalLockCount        ( 0 )
         , m_bSelfClose                ( false ) // Important!
         , m_bIsHidden                 ( true )
-        , m_xTitleHelper              ()
         , m_lSimpleChangeListener     ( m_aMutex )
         , m_lVetoChangeListener       ( m_aMutex )
-        , m_aChildFrameContainer      ()
 {
 }
 
diff --git a/framework/source/services/pathsettings.cxx b/framework/source/services/pathsettings.cxx
index 865028876400..2fedd2ac65fa 100644
--- a/framework/source/services/pathsettings.cxx
+++ b/framework/source/services/pathsettings.cxx
@@ -100,11 +100,7 @@ class PathSettings : private cppu::BaseMutex
         public:
 
             PathInfo()
-                : sPathName     ()
-                , lInternalPaths()
-                , lUserPaths    ()
-                , sWritePath    ()
-                , bIsSinglePath (false)
+                : bIsSinglePath (false)
                 , bIsReadonly   (false)
             {}
 
diff --git a/framework/source/uielement/buttontoolbarcontroller.cxx b/framework/source/uielement/buttontoolbarcontroller.cxx
index a3ccbc0cd38d..cfdcd23979db 100644
--- a/framework/source/uielement/buttontoolbarcontroller.cxx
+++ b/framework/source/uielement/buttontoolbarcontroller.cxx
@@ -45,7 +45,6 @@ ButtonToolbarController::ButtonToolbarController(
     const uno::Reference< uno::XComponentContext >& rxContext,
     ToolBox*                                            pToolBar,
     const OUString&                                aCommand ) :
-    cppu::OWeakObject(),
     m_bInitialized( false ),
     m_bDisposed( false ),
     m_aCommandURL( aCommand ),
diff --git a/framework/source/uielement/genericstatusbarcontroller.cxx b/framework/source/uielement/genericstatusbarcontroller.cxx
index 59515ce1422b..68d0f20b7f16 100644
--- a/framework/source/uielement/genericstatusbarcontroller.cxx
+++ b/framework/source/uielement/genericstatusbarcontroller.cxx
@@ -47,7 +47,6 @@ GenericStatusbarController::GenericStatusbarController(
     , m_bEnabled( false )
     , m_bOwnerDraw( false )
     , m_pItemData( pItemData )
-    , m_xGraphic()
 {
     m_xStatusbarItem = rxItem;
     if ( m_xStatusbarItem.is() )
diff --git a/framework/source/uifactory/uicontrollerfactory.cxx b/framework/source/uifactory/uicontrollerfactory.cxx
index 0566a90c1db8..0c013c9eb59d 100644
--- a/framework/source/uifactory/uicontrollerfactory.cxx
+++ b/framework/source/uifactory/uicontrollerfactory.cxx
@@ -77,7 +77,6 @@ UIControllerFactory::UIControllerFactory(
     : UIControllerFactory_BASE(m_aMutex)
     , m_bConfigRead( false )
     , m_xContext( xContext )
-    , m_pConfigAccess()
 {
     m_pConfigAccess = new ConfigurationAccess_ControllerFactory(m_xContext,
             OUString::Concat("/org.openoffice.Office.UI.Controller/Registered/")