diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2022-06-14 08:43:54 +0100 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2022-06-14 11:37:16 +0200 |
| commit | 8b6c8e624b1257a2221e8f98ba71112eae86c795 (patch) | |
| tree | 49b62809a3dc68307cc4ee16dfe497754bf93158 /editeng | |
| parent | 6de844c5da695bf4605bef5510d33e74a7ff04ee (diff) | |
cid#1504592 Big parameter passed by value
and
cid#1504665 Big parameter passed by value
cid#1505368 Big parameter passed by value
revert the clang-tidy modernize-pass-by-value changes that coverity
warns about
Change-Id: Id92fdc8d1caeed9eaf7ff1e9e745938e5a971a34
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135803
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Diffstat (limited to 'editeng')
| -rw-r--r-- | editeng/inc/editdoc.hxx | 2 | ||||
| -rw-r--r-- | editeng/source/editeng/editdoc.cxx | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/editeng/inc/editdoc.hxx b/editeng/inc/editdoc.hxx index 12532fde7e73..6ce00d05c40b 100644 --- a/editeng/inc/editdoc.hxx +++ b/editeng/inc/editdoc.hxx @@ -244,7 +244,7 @@ private: public: ContentNode( SfxItemPool& rItemPool ); - ContentNode( OUString aStr, ContentAttribs aContentAttribs ); + ContentNode( const OUString& rStr, const ContentAttribs& rContentAttribs ); ~ContentNode(); ContentNode(const ContentNode&) = delete; ContentNode& operator=(const ContentNode&) = delete; diff --git a/editeng/source/editeng/editdoc.cxx b/editeng/source/editeng/editdoc.cxx index 7621f7c0cd3f..41a8cf20f1b8 100644 --- a/editeng/source/editeng/editdoc.cxx +++ b/editeng/source/editeng/editdoc.cxx @@ -1193,8 +1193,8 @@ ContentNode::ContentNode( SfxItemPool& rPool ) : aContentAttribs( rPool ) { } -ContentNode::ContentNode( OUString aStr, ContentAttribs _aContentAttribs ) : - maString(std::move(aStr)), aContentAttribs(std::move(_aContentAttribs)) +ContentNode::ContentNode( const OUString& rStr, const ContentAttribs& rContentAttribs ) : + maString(rStr), aContentAttribs(rContentAttribs) { } |