clang-tidy:readability-redundant-member-init

Change-Id: I94f8272ffbdbf5bc7a4cc31433dc547231fd4392
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121361
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

23 files changed, 13 insertions, 69 deletions

diff --git a/dbaccess/source/core/api/FilteredContainer.cxx b/dbaccess/source/core/api/FilteredContainer.cxx
index 3c923a706b8b..4d4d367838a1 100644
--- a/dbaccess/source/core/api/FilteredContainer.cxx
+++ b/dbaccess/source/core/api/FilteredContainer.cxx
@@ -117,8 +117,7 @@ static sal_Int32 createWildCardVector(Sequence< OUString >& _rTableFilter, std::
 
         TableInfo( const OUString& _catalog, const OUString& _schema, const OUString& _name,
             const OUString& _type )
-            :sComposedName()
-            ,sType( _type )
+            :sType( _type )
             ,sCatalog( _catalog )
             ,sSchema( _schema )
             ,sName( _name )
diff --git a/dbaccess/source/core/api/datasettings.cxx b/dbaccess/source/core/api/datasettings.cxx
index 28167184442f..e845f11350f8 100644
--- a/dbaccess/source/core/api/datasettings.cxx
+++ b/dbaccess/source/core/api/datasettings.cxx
@@ -95,7 +95,6 @@ void ODataSettings::registerPropertiesFor(ODataSettings_Base* _pItem)
 
 ODataSettings::ODataSettings(OBroadcastHelper& _rBHelper,bool _bQuery)
     :OPropertyStateContainer(_rBHelper)
-    ,ODataSettings_Base()
     ,m_bQuery(_bQuery)
 {
 }
diff --git a/dbaccess/source/core/dataaccess/ModelImpl.cxx b/dbaccess/source/core/dataaccess/ModelImpl.cxx
index e41e847cc903..8f993096fe95 100644
--- a/dbaccess/source/core/dataaccess/ModelImpl.cxx
+++ b/dbaccess/source/core/dataaccess/ModelImpl.cxx
@@ -353,14 +353,11 @@ void SAL_CALL DocumentStorageAccess::disposing( const css::lang::EventObject& So
 // ODatabaseModelImpl
 
 ODatabaseModelImpl::ODatabaseModelImpl( const Reference< XComponentContext >& _rxContext, ODatabaseContext& _rDBContext )
-            :m_xModel()
-            ,m_xDataSource()
-            ,m_aContainer(4)
+            :m_aContainer(4)
             ,m_aMacroMode( *this )
             ,m_nImposedMacroExecMode( MacroExecMode::NEVER_EXECUTE )
             ,m_rDBContext( _rDBContext )
             ,m_refCount(0)
-            ,m_aEmbeddedMacros()
             ,m_bModificationLock( false )
             ,m_bDocumentInitialized( false )
             ,m_nScriptingSignatureState(SignatureState::UNKNOWN)
@@ -387,14 +384,11 @@ ODatabaseModelImpl::ODatabaseModelImpl(
                     const Reference< XComponentContext >& _rxContext,
                     ODatabaseContext& _rDBContext
                     )
-            :m_xModel()
-            ,m_xDataSource()
-            ,m_aContainer(4)
+            :m_aContainer(4)
             ,m_aMacroMode( *this )
             ,m_nImposedMacroExecMode( MacroExecMode::NEVER_EXECUTE )
             ,m_rDBContext( _rDBContext )
             ,m_refCount(0)
-            ,m_aEmbeddedMacros()
             ,m_bModificationLock( false )
             ,m_bDocumentInitialized( false )
             ,m_nScriptingSignatureState(SignatureState::UNKNOWN)
diff --git a/dbaccess/source/core/dataaccess/dataaccessdescriptor.cxx b/dbaccess/source/core/dataaccess/dataaccessdescriptor.cxx
index e66af7fb4036..8262f089c293 100644
--- a/dbaccess/source/core/dataaccess/dataaccessdescriptor.cxx
+++ b/dbaccess/source/core/dataaccess/dataaccessdescriptor.cxx
@@ -116,26 +116,10 @@ namespace
     registerProperty( PROPERTY_##propname, PROPERTY_ID_##propname, PropertyAttribute::BOUND, &member, cppu::UnoType<decltype(member)>::get() )
 
     DataAccessDescriptor::DataAccessDescriptor()
-        :DataAccessDescriptor_MutexBase()
-        ,DataAccessDescriptor_TypeBase()
-        ,DataAccessDescriptor_PropertyBase( m_aBHelper )
-        ,m_sDataSourceName()
-        ,m_sDatabaseLocation()
-        ,m_sConnectionResource()
-        ,m_aConnectionInfo()
-        ,m_xActiveConnection()
-        ,m_sCommand()
+        :DataAccessDescriptor_PropertyBase( m_aBHelper )
         ,m_nCommandType( CommandType::COMMAND )
-        ,m_sFilter()
-        ,m_sOrder()
-        ,m_sHavingClause()
-        ,m_sGroupBy()
         ,m_bEscapeProcessing( true )
-        ,m_xResultSet()
-        ,m_aSelection()
         ,m_bBookmarkSelection( true )
-        ,m_sColumnName()
-        ,m_xColumn()
     {
         REGISTER_PROPERTY( DATASOURCENAME,      m_sDataSourceName );
         REGISTER_PROPERTY( DATABASE_LOCATION,   m_sDatabaseLocation );
diff --git a/dbaccess/source/core/dataaccess/databaseregistrations.cxx b/dbaccess/source/core/dataaccess/databaseregistrations.cxx
index 6009653ce1a7..64477cd67dda 100644
--- a/dbaccess/source/core/dataaccess/databaseregistrations.cxx
+++ b/dbaccess/source/core/dataaccess/databaseregistrations.cxx
@@ -144,7 +144,6 @@ namespace dbaccess
     // DatabaseRegistrations - implementation
     DatabaseRegistrations::DatabaseRegistrations( const Reference<XComponentContext> & _rxContext )
         :m_aContext( _rxContext )
-        ,m_aConfigurationRoot()
         ,m_aRegistrationListeners( m_aMutex )
     {
         m_aConfigurationRoot = ::utl::OConfigurationTreeRoot::createWithComponentContext(
diff --git a/dbaccess/source/core/misc/DatabaseDataProvider.cxx b/dbaccess/source/core/misc/DatabaseDataProvider.cxx
index 6a050770d8a0..a7661385aea8 100644
--- a/dbaccess/source/core/misc/DatabaseDataProvider.cxx
+++ b/dbaccess/source/core/misc/DatabaseDataProvider.cxx
@@ -52,7 +52,6 @@ DatabaseDataProvider::DatabaseDataProvider(uno::Reference< uno::XComponentContex
     ::cppu::PropertySetMixin< chart2::data::XDatabaseDataProvider >(
         context, IMPLEMENTS_PROPERTY_SET, uno::Sequence< OUString >()),
     m_aParameterManager( m_aMutex, context ),
-    m_aFilterManager(),
     m_xContext(context),
     m_CommandType(sdb::CommandType::COMMAND), // #i94114
     m_RowLimit(0),
@@ -597,8 +596,7 @@ namespace
         sal_Int32       nDataType;
 
         ColumnDescription()
-            :sName()
-            ,nResultSetPosition( 0 )
+            :nResultSetPosition( 0 )
             ,nDataType( sdbc::DataType::VARCHAR )
         {
         }
diff --git a/dbaccess/source/ui/app/subcomponentmanager.cxx b/dbaccess/source/ui/app/subcomponentmanager.cxx
index 0fa0d3b45a0c..fc4cd1962a8a 100644
--- a/dbaccess/source/ui/app/subcomponentmanager.cxx
+++ b/dbaccess/source/ui/app/subcomponentmanager.cxx
@@ -88,12 +88,8 @@ namespace dbaui
             Reference< XPropertySet >       xDocumentDefinitionProperties;
 
             SubComponentDescriptor()
-                :sName()
-                ,nComponentType( -1 )
+                :nComponentType( -1 )
                 ,eOpenMode( E_OPEN_NORMAL )
-                ,xFrame()
-                ,xController()
-                ,xModel()
             {
             }
 
diff --git a/dbaccess/source/ui/browser/AsynchronousLink.cxx b/dbaccess/source/ui/browser/AsynchronousLink.cxx
index f42c00d9a944..e4dcdb2f9eeb 100644
--- a/dbaccess/source/ui/browser/AsynchronousLink.cxx
+++ b/dbaccess/source/ui/browser/AsynchronousLink.cxx
@@ -24,8 +24,6 @@
 using namespace dbaui;
 OAsynchronousLink::OAsynchronousLink(const Link<void*, void>& _rHandler)
     : m_aHandler(_rHandler)
-    , m_aEventSafety()
-    , m_aDestructionSafety()
     , m_nEventId(nullptr)
 {
 }
diff --git a/dbaccess/source/ui/control/FieldDescControl.cxx b/dbaccess/source/ui/control/FieldDescControl.cxx
index ef67b373e6d8..d62d9ea3e482 100644
--- a/dbaccess/source/ui/control/FieldDescControl.cxx
+++ b/dbaccess/source/ui/control/FieldDescControl.cxx
@@ -71,7 +71,6 @@ OFieldDescControl::OFieldDescControl(weld::Container* pPage, OTableDesignHelpBar
     , m_pHelp( pHelpBar )
     , m_pLastFocusWindow(nullptr)
     , m_pActFocusWindow(nullptr)
-    , m_pPreviousType()
     , m_nPos(-1)
     , aYes(DBA_RES(STR_VALUE_YES))
     , aNo(DBA_RES(STR_VALUE_NO))
diff --git a/dbaccess/source/ui/dlg/optionalboolitem.cxx b/dbaccess/source/ui/dlg/optionalboolitem.cxx
index 5eb4b1272a15..30d176391ba4 100644
--- a/dbaccess/source/ui/dlg/optionalboolitem.cxx
+++ b/dbaccess/source/ui/dlg/optionalboolitem.cxx
@@ -25,7 +25,6 @@ namespace dbaui
     // OptionalBoolItem
     OptionalBoolItem::OptionalBoolItem( sal_uInt16 _nWhich )
         :SfxPoolItem( _nWhich )
-        ,m_aValue()
     {
     }
 
diff --git a/dbaccess/source/ui/misc/DExport.cxx b/dbaccess/source/ui/misc/DExport.cxx
index 5a30538f641f..61a6481f1a11 100644
--- a/dbaccess/source/ui/misc/DExport.cxx
+++ b/dbaccess/source/ui/misc/DExport.cxx
@@ -82,7 +82,6 @@ ODatabaseExport::ODatabaseExport(sal_Int32 nRows,
     ,m_xContext(_rxContext)
     ,m_pFormatter(nullptr)
     ,m_rInputStream( _rInputStream )
-    ,m_pTypeInfo()
     ,m_pColumnList(pList)
     ,m_pInfoMap(_pInfoMap)
     ,m_nColumnPos(0)
@@ -133,7 +132,6 @@ ODatabaseExport::ODatabaseExport(const SharedConnection& _rxConnection,
     ,m_xContext(_rxContext)
     ,m_pFormatter(nullptr)
     ,m_rInputStream( _rInputStream )
-    ,m_pTypeInfo()
     ,m_pColumnList(nullptr)
     ,m_pInfoMap(nullptr)
     ,m_nColumnPos(0)
diff --git a/dbaccess/source/ui/misc/WCopyTable.cxx b/dbaccess/source/ui/misc/WCopyTable.cxx
index 6ef0819c4099..c2d3bab739dd 100644
--- a/dbaccess/source/ui/misc/WCopyTable.cxx
+++ b/dbaccess/source/ui/misc/WCopyTable.cxx
@@ -252,7 +252,6 @@ NamedTableCopySource::NamedTableCopySource( const Reference< XConnection >& _rxC
     :m_xConnection( _rxConnection, UNO_SET_THROW )
     ,m_xMetaData( _rxConnection->getMetaData(), UNO_SET_THROW )
     ,m_sTableName( _rTableName )
-    ,m_aColumnInfo()
 {
     ::dbtools::qualifiedNameComponents( m_xMetaData, m_sTableName, m_sTableCatalog, m_sTableSchema, m_sTableBareName, ::dbtools::EComposeRule::Complete );
     impl_ensureColumnInfo_throw();
diff --git a/dbaccess/source/ui/misc/charsets.cxx b/dbaccess/source/ui/misc/charsets.cxx
index 86e55b226df0..546d21cb0859 100644
--- a/dbaccess/source/ui/misc/charsets.cxx
+++ b/dbaccess/source/ui/misc/charsets.cxx
@@ -30,8 +30,7 @@ namespace dbaui
 
     // OCharsetDisplay
     OCharsetDisplay::OCharsetDisplay()
-        : OCharsetMap()
-        , m_aSystemDisplayName(DBA_RES( STR_RSC_CHARSETS ))
+        : m_aSystemDisplayName(DBA_RES( STR_RSC_CHARSETS ))
     {
     }
 
diff --git a/dbaccess/source/ui/misc/controllerframe.cxx b/dbaccess/source/ui/misc/controllerframe.cxx
index 599398e5d00f..3634a56eb7e3 100644
--- a/dbaccess/source/ui/misc/controllerframe.cxx
+++ b/dbaccess/source/ui/misc/controllerframe.cxx
@@ -104,9 +104,6 @@ namespace dbaui
     {
         explicit ControllerFrame_Data( IController& _rController )
             :m_rController( _rController )
-            ,m_xFrame()
-            ,m_xDocEventBroadcaster()
-            ,m_pListener()
             ,m_bActive( false )
             ,m_bIsTopLevelDocumentWindow( false )
         {
diff --git a/dbaccess/source/ui/misc/databaseobjectview.cxx b/dbaccess/source/ui/misc/databaseobjectview.cxx
index 49d3cfe5591a..7c47a8101bb6 100644
--- a/dbaccess/source/ui/misc/databaseobjectview.cxx
+++ b/dbaccess/source/ui/misc/databaseobjectview.cxx
@@ -54,7 +54,6 @@ namespace dbaui
             const OUString& _rComponentURL )
         :m_xORB             ( _rxORB            )
         ,m_xParentFrame     ( _rxParentFrame    )
-        ,m_xFrameLoader     (                   )
         ,m_xApplication     ( _rxApplication    )
         ,m_sComponentURL    ( _rComponentURL    )
     {
diff --git a/dbaccess/source/ui/misc/dbaundomanager.cxx b/dbaccess/source/ui/misc/dbaundomanager.cxx
index 4bf73c2b2e81..9ed72bbdf477 100644
--- a/dbaccess/source/ui/misc/dbaundomanager.cxx
+++ b/dbaccess/source/ui/misc/dbaundomanager.cxx
@@ -47,7 +47,6 @@ namespace dbaui
             ,rParent( i_parent )
             ,rMutex( i_mutex )
             ,bDisposed( false )
-            ,aUndoManager()
             ,aUndoHelper( *this )
         {
         }
diff --git a/dbaccess/source/ui/misc/dbsubcomponentcontroller.cxx b/dbaccess/source/ui/misc/dbsubcomponentcontroller.cxx
index 74983ef30bb6..6a6784e92dcc 100644
--- a/dbaccess/source/ui/misc/dbsubcomponentcontroller.cxx
+++ b/dbaccess/source/ui/misc/dbsubcomponentcontroller.cxx
@@ -141,8 +141,7 @@ namespace dbaui
         bool                            m_bNotAttached;
 
         explicit DBSubComponentController_Impl(osl::Mutex& i_rMutex)
-            :m_aDocScriptSupport()
-            ,m_aModifyListeners( i_rMutex )
+            :m_aModifyListeners( i_rMutex )
             ,m_nDocStartNumber(0)
             ,m_bSuspended( false )
             ,m_bEditable(true)
diff --git a/dbaccess/source/ui/querydesign/QTableConnectionData.cxx b/dbaccess/source/ui/querydesign/QTableConnectionData.cxx
index f96a5b1cd033..ce66828facb5 100644
--- a/dbaccess/source/ui/querydesign/QTableConnectionData.cxx
+++ b/dbaccess/source/ui/querydesign/QTableConnectionData.cxx
@@ -25,8 +25,7 @@
 using namespace dbaui;
 
 OQueryTableConnectionData::OQueryTableConnectionData()
-    : OTableConnectionData()
-    , m_nFromEntryIndex(0)
+    : m_nFromEntryIndex(0)
     , m_nDestEntryIndex(0)
     , m_eJoinType (INNER_JOIN)
     , m_bNatural(false)
diff --git a/dbaccess/source/ui/relationdesign/RTableConnectionData.cxx b/dbaccess/source/ui/relationdesign/RTableConnectionData.cxx
index 1e38bb2f7e03..c1c408ee8f1a 100644
--- a/dbaccess/source/ui/relationdesign/RTableConnectionData.cxx
+++ b/dbaccess/source/ui/relationdesign/RTableConnectionData.cxx
@@ -41,8 +41,7 @@ using namespace ::com::sun::star::container;
 using namespace ::com::sun::star::lang;
 
 ORelationTableConnectionData::ORelationTableConnectionData()
-    :OTableConnectionData()
-    ,m_nUpdateRules(KeyRule::NO_ACTION)
+    :m_nUpdateRules(KeyRule::NO_ACTION)
     ,m_nDeleteRules(KeyRule::NO_ACTION)
     ,m_nCardinality(Cardinality::Undefined)
 {
diff --git a/dbaccess/source/ui/tabledesign/FieldDescriptions.cxx b/dbaccess/source/ui/tabledesign/FieldDescriptions.cxx
index 067bc43d3de8..dc81cfa0ecad 100644
--- a/dbaccess/source/ui/tabledesign/FieldDescriptions.cxx
+++ b/dbaccess/source/ui/tabledesign/FieldDescriptions.cxx
@@ -38,8 +38,7 @@ using namespace ::com::sun::star::beans;
 using namespace ::com::sun::star::util;
 
 OFieldDescription::OFieldDescription()
-    :m_pType()
-    ,m_nType(DataType::VARCHAR)
+    :m_nType(DataType::VARCHAR)
     ,m_nPrecision(0)
     ,m_nScale(0)
     ,m_nIsNullable(ColumnValue::NULLABLE)
@@ -81,8 +80,7 @@ OFieldDescription::~OFieldDescription()
 }
 
 OFieldDescription::OFieldDescription(const Reference< XPropertySet >& xAffectedCol,bool _bUseAsDest)
-    :m_pType()
-    ,m_nType(DataType::VARCHAR)
+    :m_nType(DataType::VARCHAR)
     ,m_nPrecision(0)
     ,m_nScale(0)
     ,m_nIsNullable(ColumnValue::NULLABLE)
diff --git a/dbaccess/source/ui/tabledesign/TableController.cxx b/dbaccess/source/ui/tabledesign/TableController.cxx
index 27c9a3aab3bb..17ad5ed2f28d 100644
--- a/dbaccess/source/ui/tabledesign/TableController.cxx
+++ b/dbaccess/source/ui/tabledesign/TableController.cxx
@@ -110,7 +110,6 @@ Sequence< OUString> OTableController::getSupportedServiceNames()
 
 OTableController::OTableController(const Reference< XComponentContext >& _rM) : OTableController_BASE(_rM)
     ,m_sTypeNames(DBA_RES(STR_TABLEDESIGN_DBFIELDTYPES))
-    ,m_pTypeInfo()
     ,m_bAllowAutoIncrementValue(false)
     ,m_bNew(true)
 {
diff --git a/dbaccess/source/ui/uno/ColumnControl.cxx b/dbaccess/source/ui/uno/ColumnControl.cxx
index 51930de95119..19dddf59d8a4 100644
--- a/dbaccess/source/ui/uno/ColumnControl.cxx
+++ b/dbaccess/source/ui/uno/ColumnControl.cxx
@@ -39,7 +39,7 @@ using namespace ::com::sun::star::lang;
 using namespace ::com::sun::star::sdbc;
 
 OColumnControl::OColumnControl(const Reference<XComponentContext>& rxContext)
-    :UnoControl(), m_xContext(rxContext)
+    : m_xContext(rxContext)
 {
 }
 
diff --git a/dbaccess/source/ui/uno/copytablewizard.cxx b/dbaccess/source/ui/uno/copytablewizard.cxx
index 12e3575dbafd..a33d0607de83 100644
--- a/dbaccess/source/ui/uno/copytablewizard.cxx
+++ b/dbaccess/source/ui/uno/copytablewizard.cxx
@@ -370,16 +370,10 @@ CopyTableWizard::CopyTableWizard( const Reference< XComponentContext >& _rxORB )
     :CopyTableWizard_Base( _rxORB )
     ,m_xContext( _rxORB )
     ,m_nOperation( CopyTableOperation::CopyDefinitionAndData )
-    ,m_sDestinationTable()
     ,m_aPrimaryKeyName( false,  "ID" )
     ,m_bUseHeaderLineAsColumnNames( true )
-    ,m_xSourceConnection()
     ,m_nCommandType( CommandType::COMMAND )
-    ,m_pSourceObject()
-    ,m_xSourceResultSet()
-    ,m_aSourceSelection()
     ,m_bSourceSelectionBookmarks( true )
-    ,m_xDestConnection()
     ,m_aCopyTableListeners( m_aMutex )
     ,m_nOverrideExecutionResult( -1 )
 {