summaryrefslogtreecommitdiff
path: root/cui
diff options
context:
space:
mode:
authorNoel Grandin <noel.grandin@collabora.co.uk>2024-11-08 13:55:25 +0200
committerNoel Grandin <noel.grandin@collabora.co.uk>2024-11-08 17:33:10 +0100
commit3f691b4a160b2ed1bb503c5b52e925bfa974e1e5 (patch)
treee38732ba18c3f6d9d55b9a8e9a5f5d6d269d8d37 /cui
parent39b15dc8f0adec9e856a39cf319c7c8ae6750043 (diff)
loplugin:reftotemp in cppcanvas..cui
Change-Id: I6c9ded2252462bcdeee6520bb7b7fa1752aa583b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176276 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
Diffstat (limited to 'cui')
-rw-r--r--cui/source/options/connpooloptions.cxx4
-rw-r--r--cui/source/options/dbregister.cxx2
-rw-r--r--cui/source/options/fontsubs.cxx4
-rw-r--r--cui/source/options/optaccessibility.cxx4
-rw-r--r--cui/source/options/optasian.cxx4
-rw-r--r--cui/source/options/optbasic.cxx4
-rw-r--r--cui/source/options/optchart.cxx4
-rw-r--r--cui/source/options/optcolor.cxx4
-rw-r--r--cui/source/options/optctl.cxx6
-rw-r--r--cui/source/options/optdeepl.cxx4
-rw-r--r--cui/source/options/optdict.cxx4
-rw-r--r--cui/source/options/optfltr.cxx8
-rw-r--r--cui/source/options/optgdlg.cxx16
-rw-r--r--cui/source/options/optgenrl.cxx2
-rw-r--r--cui/source/options/opthtml.cxx10
-rw-r--r--cui/source/options/optinet2.cxx10
-rw-r--r--cui/source/options/optjava.cxx6
-rw-r--r--cui/source/options/optjsearch.cxx4
-rw-r--r--cui/source/options/optlanguagetool.cxx6
-rw-r--r--cui/source/options/optlingu.cxx2
-rw-r--r--cui/source/options/optopencl.cxx2
-rw-r--r--cui/source/options/optpath.cxx2
-rw-r--r--cui/source/options/optsave.cxx4
-rw-r--r--cui/source/options/optupdt.cxx6
-rw-r--r--cui/source/options/personalization.cxx4
-rw-r--r--cui/source/tabpages/autocdlg.cxx8
-rw-r--r--cui/source/tabpages/chardlg.cxx6
-rw-r--r--cui/source/tabpages/tparea.cxx2
28 files changed, 71 insertions, 71 deletions
diff --git a/cui/source/options/connpooloptions.cxx b/cui/source/options/connpooloptions.cxx
index 779adb27218f..557f6cae0fab 100644
--- a/cui/source/options/connpooloptions.cxx
+++ b/cui/source/options/connpooloptions.cxx
@@ -176,7 +176,7 @@ namespace offapp
for (const auto& label : labels)
{
- if (const auto& pString = m_xBuilder->weld_label(label))
+ if (const auto pString = m_xBuilder->weld_label(label))
sAllStrings += pString->get_label() + " ";
}
@@ -184,7 +184,7 @@ namespace offapp
for (const auto& check : checkButton)
{
- if (const auto& pString = m_xBuilder->weld_check_button(check))
+ if (const auto pString = m_xBuilder->weld_check_button(check))
sAllStrings += pString->get_label() + " ";
}
diff --git a/cui/source/options/dbregister.cxx b/cui/source/options/dbregister.cxx
index 91781be7f0df..b345614fa857 100644
--- a/cui/source/options/dbregister.cxx
+++ b/cui/source/options/dbregister.cxx
@@ -133,7 +133,7 @@ OUString DbRegistrationOptionsPage::GetAllStrings()
{
OUString sAllStrings;
- if (const auto& pString = m_xBuilder->weld_label(u"label1"_ustr))
+ if (const auto pString = m_xBuilder->weld_label(u"label1"_ustr))
sAllStrings += pString->get_label() + " ";
return sAllStrings.replaceAll("_", "");
diff --git a/cui/source/options/fontsubs.cxx b/cui/source/options/fontsubs.cxx
index 89b217fa8d6e..2f9d44c0b497 100644
--- a/cui/source/options/fontsubs.cxx
+++ b/cui/source/options/fontsubs.cxx
@@ -153,7 +153,7 @@ OUString SvxFontSubstTabPage::GetAllStrings()
for (const auto& label : labels)
{
- if (const auto& pString = m_xBuilder->weld_label(label))
+ if (const auto pString = m_xBuilder->weld_label(label))
sAllStrings += pString->get_label() + " ";
}
@@ -161,7 +161,7 @@ OUString SvxFontSubstTabPage::GetAllStrings()
for (const auto& check : checkButton)
{
- if (const auto& pString = m_xBuilder->weld_check_button(check))
+ if (const auto pString = m_xBuilder->weld_check_button(check))
sAllStrings += pString->get_label() + " ";
}
diff --git a/cui/source/options/optaccessibility.cxx b/cui/source/options/optaccessibility.cxx
index 69825d26f341..0e0e4bfb8b84 100644
--- a/cui/source/options/optaccessibility.cxx
+++ b/cui/source/options/optaccessibility.cxx
@@ -118,7 +118,7 @@ OUString SvxAccessibilityOptionsTabPage::GetAllStrings()
for (const auto& label : labels)
{
- if (const auto& pString = m_xBuilder->weld_label(label))
+ if (const auto pString = m_xBuilder->weld_label(label))
sAllStrings += pString->get_label() + " ";
}
@@ -127,7 +127,7 @@ OUString SvxAccessibilityOptionsTabPage::GetAllStrings()
for (const auto& check : checkButton)
{
- if (const auto& pString = m_xBuilder->weld_check_button(check))
+ if (const auto pString = m_xBuilder->weld_check_button(check))
sAllStrings += pString->get_label() + " ";
}
diff --git a/cui/source/options/optasian.cxx b/cui/source/options/optasian.cxx
index c7d219993ae1..e9fc8f0f13da 100644
--- a/cui/source/options/optasian.cxx
+++ b/cui/source/options/optasian.cxx
@@ -149,7 +149,7 @@ OUString SvxAsianLayoutPage::GetAllStrings()
for (const auto& label : labels)
{
- if (const auto& pString = m_xBuilder->weld_label(label))
+ if (const auto pString = m_xBuilder->weld_label(label))
sAllStrings += pString->get_label() + " ";
}
@@ -158,7 +158,7 @@ OUString SvxAsianLayoutPage::GetAllStrings()
for (const auto& radio : radioButton)
{
- if (const auto& pString = m_xBuilder->weld_radio_button(radio))
+ if (const auto pString = m_xBuilder->weld_radio_button(radio))
sAllStrings += pString->get_label() + " ";
}
diff --git a/cui/source/options/optbasic.cxx b/cui/source/options/optbasic.cxx
index d7bd06d94626..3b105f27d16d 100644
--- a/cui/source/options/optbasic.cxx
+++ b/cui/source/options/optbasic.cxx
@@ -60,7 +60,7 @@ OUString SvxBasicIDEOptionsPage::GetAllStrings()
for (const auto& label : labels)
{
- if (const auto& pString = m_xBuilder->weld_label(label))
+ if (const auto pString = m_xBuilder->weld_label(label))
sAllStrings += pString->get_label() + " ";
}
@@ -69,7 +69,7 @@ OUString SvxBasicIDEOptionsPage::GetAllStrings()
for (const auto& check : checkButton)
{
- if (const auto& pString = m_xBuilder->weld_check_button(check))
+ if (const auto pString = m_xBuilder->weld_check_button(check))
sAllStrings += pString->get_label() + " ";
}
diff --git a/cui/source/options/optchart.cxx b/cui/source/options/optchart.cxx
index ec5c92c4a1c8..4a457b167770 100644
--- a/cui/source/options/optchart.cxx
+++ b/cui/source/options/optchart.cxx
@@ -159,7 +159,7 @@ OUString SvxDefaultColorOptPage::GetAllStrings()
for (const auto& label : labels)
{
- if (const auto& pString = m_xBuilder->weld_label(label))
+ if (const auto pString = m_xBuilder->weld_label(label))
sAllStrings += pString->get_label() + " ";
}
@@ -167,7 +167,7 @@ OUString SvxDefaultColorOptPage::GetAllStrings()
for (const auto& btn : buttons)
{
- if (const auto& pString = m_xBuilder->weld_button(btn))
+ if (const auto pString = m_xBuilder->weld_button(btn))
sAllStrings += pString->get_label() + " ";
}
diff --git a/cui/source/options/optcolor.cxx b/cui/source/options/optcolor.cxx
index 9f5397411286..e9ef0c7800aa 100644
--- a/cui/source/options/optcolor.cxx
+++ b/cui/source/options/optcolor.cxx
@@ -744,7 +744,7 @@ ColorConfigCtrl_Impl::ColorConfigCtrl_Impl(weld::Window* pTopLevel, weld::Builde
Link<weld::Toggleable&,void> aCheckLink = LINK(this, ColorConfigCtrl_Impl, ClickHdl);
Link<ColorListBox&,void> aColorLink = LINK(this, ColorConfigCtrl_Impl, ColorHdl);
- Link<weld::Widget&,void> const& aGetFocusLink = LINK(this, ColorConfigCtrl_Impl, ControlFocusHdl);
+ Link<weld::Widget&,void> const aGetFocusLink = LINK(this, ColorConfigCtrl_Impl, ControlFocusHdl);
m_xScrollWindow->SetLinks(aCheckLink, aColorLink, aGetFocusLink, *m_xVScroll);
}
@@ -887,7 +887,7 @@ OUString SvxColorOptionsTabPage::GetAllStrings()
for (const auto& label : labels)
{
- if (const auto& pString = m_xBuilder->weld_label(label))
+ if (const auto pString = m_xBuilder->weld_label(label))
sAllStrings += pString->get_label() + " ";
}
diff --git a/cui/source/options/optctl.cxx b/cui/source/options/optctl.cxx
index df2cfbd3b538..fca642fdbb38 100644
--- a/cui/source/options/optctl.cxx
+++ b/cui/source/options/optctl.cxx
@@ -65,7 +65,7 @@ OUString SvxCTLOptionsPage::GetAllStrings()
for (const auto& label : labels)
{
- if (const auto& pString = m_xBuilder->weld_label(label))
+ if (const auto pString = m_xBuilder->weld_label(label))
sAllStrings += pString->get_label() + " ";
}
@@ -73,7 +73,7 @@ OUString SvxCTLOptionsPage::GetAllStrings()
for (const auto& check : checkButton)
{
- if (const auto& pString = m_xBuilder->weld_check_button(check))
+ if (const auto pString = m_xBuilder->weld_check_button(check))
sAllStrings += pString->get_label() + " ";
}
@@ -81,7 +81,7 @@ OUString SvxCTLOptionsPage::GetAllStrings()
for (const auto& radio : radioButton)
{
- if (const auto& pString = m_xBuilder->weld_radio_button(radio))
+ if (const auto pString = m_xBuilder->weld_radio_button(radio))
sAllStrings += pString->get_label() + " ";
}
diff --git a/cui/source/options/optdeepl.cxx b/cui/source/options/optdeepl.cxx
index 0028ab22d49e..5b51e556cc85 100644
--- a/cui/source/options/optdeepl.cxx
+++ b/cui/source/options/optdeepl.cxx
@@ -50,11 +50,11 @@ OUString OptDeeplTabPage::GetAllStrings()
for (const auto& label : labels)
{
- if (const auto& pString = m_xBuilder->weld_label(label))
+ if (const auto pString = m_xBuilder->weld_label(label))
sAllStrings += pString->get_label() + " ";
}
- if (const auto& pString = m_xBuilder->weld_link_button(u"privacy"_ustr))
+ if (const auto pString = m_xBuilder->weld_link_button(u"privacy"_ustr))
sAllStrings += pString->get_label() + " ";
return sAllStrings.replaceAll("_", "");
diff --git a/cui/source/options/optdict.cxx b/cui/source/options/optdict.cxx
index f190a587a170..2a3b089c8762 100644
--- a/cui/source/options/optdict.cxx
+++ b/cui/source/options/optdict.cxx
@@ -674,7 +674,7 @@ IMPL_LINK(SvxEditDictionaryDialog, ModifyHdl, weld::Entry&, rEdt, void)
OUString rEntry = rEdt.get_text();
sal_Int32 nWordLen = rEntry.getLength();
- const OUString& rRepString = fixSpace(m_xReplaceED->get_text());
+ const OUString aRepString = fixSpace(m_xReplaceED->get_text());
bool bEnableNewReplace = false;
bool bEnableDelete = false;
@@ -696,7 +696,7 @@ IMPL_LINK(SvxEditDictionaryDialog, ModifyHdl, weld::Entry&, rEdt, void)
eCmpRes = cmpDicEntry_Impl( rEntry, aTestStr );
if(CDE_DIFFERENT != eCmpRes)
{
- if(!rRepString.isEmpty())
+ if(!aRepString.isEmpty())
bFirstSelect = true;
bDoNothing=true;
m_pWordsLB->set_cursor(i);
diff --git a/cui/source/options/optfltr.cxx b/cui/source/options/optfltr.cxx
index 29d83596ab01..efda65e1ad26 100644
--- a/cui/source/options/optfltr.cxx
+++ b/cui/source/options/optfltr.cxx
@@ -90,7 +90,7 @@ OUString OfaMSFilterTabPage::GetAllStrings()
for (const auto& label : labels)
{
- if (const auto& pString = m_xBuilder->weld_label(label))
+ if (const auto pString = m_xBuilder->weld_label(label))
sAllStrings += pString->get_label() + " ";
}
@@ -99,7 +99,7 @@ OUString OfaMSFilterTabPage::GetAllStrings()
for (const auto& check : checkButton)
{
- if (const auto& pString = m_xBuilder->weld_check_button(check))
+ if (const auto pString = m_xBuilder->weld_check_button(check))
sAllStrings += pString->get_label() + " ";
}
@@ -216,7 +216,7 @@ OUString OfaMSFilterTabPage2::GetAllStrings()
for (const auto& label : labels)
{
- if (const auto& pString = m_xBuilder->weld_label(label))
+ if (const auto pString = m_xBuilder->weld_label(label))
sAllStrings += pString->get_label() + " ";
}
@@ -224,7 +224,7 @@ OUString OfaMSFilterTabPage2::GetAllStrings()
for (const auto& radio : radioButton)
{
- if (const auto& pString = m_xBuilder->weld_radio_button(radio))
+ if (const auto pString = m_xBuilder->weld_radio_button(radio))
sAllStrings += pString->get_label() + " ";
}
diff --git a/cui/source/options/optgdlg.cxx b/cui/source/options/optgdlg.cxx
index 6550b52fef66..6cfc67c9496b 100644
--- a/cui/source/options/optgdlg.cxx
+++ b/cui/source/options/optgdlg.cxx
@@ -229,7 +229,7 @@ OUString OfaMiscTabPage::GetAllStrings()
for (const auto& label : labels)
{
- if (const auto& pString = m_xBuilder->weld_label(label))
+ if (const auto pString = m_xBuilder->weld_label(label))
sAllStrings += pString->get_label() + " ";
}
@@ -239,11 +239,11 @@ OUString OfaMiscTabPage::GetAllStrings()
for (const auto& check : checkButton)
{
- if (const auto& pString = m_xBuilder->weld_check_button(check))
+ if (const auto pString = m_xBuilder->weld_check_button(check))
sAllStrings += pString->get_label() + " ";
}
- if (const auto& pString = m_xBuilder->weld_button(u"assocfiles"_ustr))
+ if (const auto pString = m_xBuilder->weld_button(u"assocfiles"_ustr))
sAllStrings += pString->get_label() + " ";
return sAllStrings.replaceAll("_", "");
@@ -768,7 +768,7 @@ OUString OfaViewTabPage::GetAllStrings()
for (const auto& label : labels)
{
- if (const auto& pString = m_xBuilder->weld_label(label))
+ if (const auto pString = m_xBuilder->weld_label(label))
sAllStrings += pString->get_label() + " ";
}
@@ -777,7 +777,7 @@ OUString OfaViewTabPage::GetAllStrings()
for (const auto& check : checkButton)
{
- if (const auto& pString = m_xBuilder->weld_check_button(check))
+ if (const auto pString = m_xBuilder->weld_check_button(check))
sAllStrings += pString->get_label() + " ";
}
@@ -1014,7 +1014,7 @@ void OfaViewTabPage::Reset( const SfxItemSet* )
nStyleLB_InitialSelection = 0;
}
else {
- const OUString& selected = SvtMiscOptions::GetIconTheme();
+ const OUString selected = SvtMiscOptions::GetIconTheme();
const vcl::IconThemeInfo& selectedInfo =
vcl::IconThemeInfo::FindIconThemeById(mInstalledIconThemes, selected);
nStyleLB_InitialSelection = m_xIconStyleLB->find_text(selectedInfo.GetDisplayName());
@@ -1374,7 +1374,7 @@ OUString OfaLanguagesTabPage::GetAllStrings()
for (const auto& label : labels)
{
- if (const auto& pString = m_xBuilder->weld_label(label))
+ if (const auto pString = m_xBuilder->weld_label(label))
sAllStrings += pString->get_label() + " ";
}
@@ -1383,7 +1383,7 @@ OUString OfaLanguagesTabPage::GetAllStrings()
for (const auto& check : checkButton)
{
- if (const auto& pString = m_xBuilder->weld_check_button(check))
+ if (const auto pString = m_xBuilder->weld_check_button(check))
sAllStrings += pString->get_label() + " ";
}
diff --git a/cui/source/options/optgenrl.cxx b/cui/source/options/optgenrl.cxx
index a9242cc40500..acecb3de9a3a 100644
--- a/cui/source/options/optgenrl.cxx
+++ b/cui/source/options/optgenrl.cxx
@@ -418,7 +418,7 @@ OUString SvxGeneralTabPage::GetAllStrings()
for (const auto& label : labels)
{
- if (const auto& pString = m_xBuilder->weld_label(label))
+ if (const auto pString = m_xBuilder->weld_label(label))
sAllStrings += pString->get_label() + " ";
}
diff --git a/cui/source/options/opthtml.cxx b/cui/source/options/opthtml.cxx
index f8d9619b1faf..619f46c0fc29 100644
--- a/cui/source/options/opthtml.cxx
+++ b/cui/source/options/opthtml.cxx
@@ -60,10 +60,10 @@ OfaHtmlTabPage::OfaHtmlTabPage(weld::Container* pPage, weld::DialogController* p
sal_Int32 nPos;
if ((nPos = aText.indexOf( aPlaceholder)) != -1)
{
- const OUString& rStr = SvtLanguageTable::GetLanguageString( LANGUAGE_ENGLISH_US);
- if (!rStr.isEmpty())
+ const OUString aStr = SvtLanguageTable::GetLanguageString( LANGUAGE_ENGLISH_US);
+ if (!aStr.isEmpty())
{
- aText = aText.replaceAt( nPos, aPlaceholder.getLength(), rStr);
+ aText = aText.replaceAt( nPos, aPlaceholder.getLength(), aStr);
m_xNumbersEnglishUSCB->set_label( aText);
}
}
@@ -89,7 +89,7 @@ OUString OfaHtmlTabPage::GetAllStrings()
for (const auto& label : labels)
{
- if (const auto& pString = m_xBuilder->weld_label(label))
+ if (const auto pString = m_xBuilder->weld_label(label))
sAllStrings += pString->get_label() + " ";
}
@@ -98,7 +98,7 @@ OUString OfaHtmlTabPage::GetAllStrings()
for (const auto& check : checkButton)
{
- if (const auto& pString = m_xBuilder->weld_check_button(check))
+ if (const auto pString = m_xBuilder->weld_check_button(check))
sAllStrings += pString->get_label() + " ";
}
diff --git a/cui/source/options/optinet2.cxx b/cui/source/options/optinet2.cxx
index 3d16985a8c40..d2196cd1b80d 100644
--- a/cui/source/options/optinet2.cxx
+++ b/cui/source/options/optinet2.cxx
@@ -316,7 +316,7 @@ OUString SvxProxyTabPage::GetAllStrings()
for (const auto& label : labels)
{
- if (const auto& pString = m_xBuilder->weld_label(label))
+ if (const auto pString = m_xBuilder->weld_label(label))
sAllStrings += pString->get_label() + " ";
}
@@ -843,7 +843,7 @@ OUString SvxSecurityTabPage::GetAllStrings()
for (const auto& label : labels)
{
- if (const auto& pString = m_xBuilder->weld_label(label))
+ if (const auto pString = m_xBuilder->weld_label(label))
sAllStrings += pString->get_label() + " ";
}
@@ -851,7 +851,7 @@ OUString SvxSecurityTabPage::GetAllStrings()
for (const auto& check : checkButton)
{
- if (const auto& pString = m_xBuilder->weld_check_button(check))
+ if (const auto pString = m_xBuilder->weld_check_button(check))
sAllStrings += pString->get_label() + " ";
}
@@ -861,7 +861,7 @@ OUString SvxSecurityTabPage::GetAllStrings()
for (const auto& btn : buttons)
{
- if (const auto& pString = m_xBuilder->weld_button(btn))
+ if (const auto pString = m_xBuilder->weld_button(btn))
sAllStrings += pString->get_label() + " ";
}
@@ -950,7 +950,7 @@ OUString SvxEMailTabPage::GetAllStrings()
for (const auto& label : labels)
{
- if (const auto& pString = m_xBuilder->weld_label(label))
+ if (const auto pString = m_xBuilder->weld_label(label))
sAllStrings += pString->get_label() + " ";
}
diff --git a/cui/source/options/optjava.cxx b/cui/source/options/optjava.cxx
index f8cb0657d393..e0124974ebfa 100644
--- a/cui/source/options/optjava.cxx
+++ b/cui/source/options/optjava.cxx
@@ -480,7 +480,7 @@ OUString SvxJavaOptionsPage::GetAllStrings()
for (const auto& label : labels)
{
- if (const auto& pString = m_xBuilder->weld_label(label))
+ if (const auto pString = m_xBuilder->weld_label(label))
sAllStrings += pString->get_label() + " ";
}
@@ -488,7 +488,7 @@ OUString SvxJavaOptionsPage::GetAllStrings()
for (const auto& check : checkButton)
{
- if (const auto& pString = m_xBuilder->weld_check_button(check))
+ if (const auto pString = m_xBuilder->weld_check_button(check))
sAllStrings += pString->get_label() + " ";
}
@@ -496,7 +496,7 @@ OUString SvxJavaOptionsPage::GetAllStrings()
for (const auto& btn : buttons)
{
- if (const auto& pString = m_xBuilder->weld_button(btn))
+ if (const auto pString = m_xBuilder->weld_button(btn))
sAllStrings += pString->get_label() + " ";
}
diff --git a/cui/source/options/optjsearch.cxx b/cui/source/options/optjsearch.cxx
index 34c4faf149c6..4d9048155c17 100644
--- a/cui/source/options/optjsearch.cxx
+++ b/cui/source/options/optjsearch.cxx
@@ -206,7 +206,7 @@ OUString SvxJSearchOptionsPage::GetAllStrings()
for (const auto& label : labels)
{
- if (const auto& pString = m_xBuilder->weld_label(label))
+ if (const auto pString = m_xBuilder->weld_label(label))
sAllStrings += pString->get_label() + " ";
}
@@ -232,7 +232,7 @@ OUString SvxJSearchOptionsPage::GetAllStrings()
for (const auto& check : checkButton)
{
- if (const auto& pString = m_xBuilder->weld_check_button(check))
+ if (const auto pString = m_xBuilder->weld_check_button(check))
sAllStrings += pString->get_label() + " ";
}
diff --git a/cui/source/options/optlanguagetool.cxx b/cui/source/options/optlanguagetool.cxx
index 0f3636ebec46..b7f6327324dc 100644
--- a/cui/source/options/optlanguagetool.cxx
+++ b/cui/source/options/optlanguagetool.cxx
@@ -121,7 +121,7 @@ OUString OptLanguageToolTabPage::GetAllStrings()
for (const auto& label : labels)
{
- if (const auto& pString = m_xBuilder->weld_label(label))
+ if (const auto pString = m_xBuilder->weld_label(label))
sAllStrings += pString->get_label() + " ";
}
@@ -129,11 +129,11 @@ OUString OptLanguageToolTabPage::GetAllStrings()
for (const auto& check : checkButton)
{
- if (const auto& pString = m_xBuilder->weld_check_button(check))
+ if (const auto pString = m_xBuilder->weld_check_button(check))
sAllStrings += pString->get_label() + " ";
}
- if (const auto& pString = m_xBuilder->weld_link_button(u"policy"_ustr))
+ if (const auto pString = m_xBuilder->weld_link_button(u"policy"_ustr))
sAllStrings += pString->get_label() + " ";
return sAllStrings.replaceAll("_", "");
diff --git a/cui/source/options/optlingu.cxx b/cui/source/options/optlingu.cxx
index 15a0842e386a..c07ab32a1d85 100644
--- a/cui/source/options/optlingu.cxx
+++ b/cui/source/options/optlingu.cxx
@@ -893,7 +893,7 @@ OUString SvxLinguTabPage::GetAllStrings()
for (const auto& label : labels)
{
- if (const auto& pString = m_xBuilder->weld_label(label))
+ if (const auto pString = m_xBuilder->weld_label(label))
sAllStrings += pString->get_label() + " ";
}
diff --git a/cui/source/options/optopencl.cxx b/cui/source/options/optopencl.cxx
index 207f2b924a0c..abc4784e4d7e 100644
--- a/cui/source/options/optopencl.cxx
+++ b/cui/source/options/optopencl.cxx
@@ -59,7 +59,7 @@ OUString SvxOpenCLTabPage::GetAllStrings()
for (const auto& label : labels)
{
- if (const auto& pString = m_xBuilder->weld_label(label))
+ if (const auto pString = m_xBuilder->weld_label(label))
sAllStrings += pString->get_label() + " ";
}
diff --git a/cui/source/options/optpath.cxx b/cui/source/options/optpath.cxx
index 949627151b8e..5eb31909fc22 100644
--- a/cui/source/options/optpath.cxx
+++ b/cui/source/options/optpath.cxx
@@ -220,7 +220,7 @@ std::unique_ptr<SfxTabPage> SvxPathTabPage::Create( weld::Container* pPage, weld
OUString SvxPathTabPage::GetAllStrings()
{
OUString sAllStrings;
- if (const auto& pString = m_xBuilder->weld_label(u"label1"_ustr))
+ if (const auto pString = m_xBuilder->weld_label(u"label1"_ustr))
sAllStrings += pString->get_label() + " ";
return sAllStrings.replaceAll("_", "");
}
diff --git a/cui/source/options/optsave.cxx b/cui/source/options/optsave.cxx
index 77397dcefc6b..907ece3e51bd 100644
--- a/cui/source/options/optsave.cxx
+++ b/cui/source/options/optsave.cxx
@@ -228,7 +228,7 @@ OUString SvxSaveTabPage::GetAllStrings()
for (const auto& label : labels)
{
- if (const auto& pString = m_xBuilder->weld_label(label))
+ if (const auto pString = m_xBuilder->weld_label(label))
sAllStrings += pString->get_label() + " ";
}
@@ -239,7 +239,7 @@ OUString SvxSaveTabPage::GetAllStrings()
for (const auto& check : checkButton)
{
- if (const auto& pString = m_xBuilder->weld_check_button(check))
+ if (const auto pString = m_xBuilder->weld_check_button(check))
sAllStrings += pString->get_label() + " ";
}
diff --git a/cui/source/options/optupdt.cxx b/cui/source/options/optupdt.cxx
index 2db1bcb52aaa..21fd59d7f712 100644
--- a/cui/source/options/optupdt.cxx
+++ b/cui/source/options/optupdt.cxx
@@ -250,7 +250,7 @@ OUString SvxOnlineUpdateTabPage::GetAllStrings()
for (const auto& label : labels)
{
- if (const auto& pString = m_xBuilder->weld_label(label))
+ if (const auto pString = m_xBuilder->weld_label(label))
sAllStrings += pString->get_label() + " ";
}
@@ -258,7 +258,7 @@ OUString SvxOnlineUpdateTabPage::GetAllStrings()
for (const auto& check : checkButton)
{
- if (const auto& pString = m_xBuilder->weld_check_button(check))
+ if (const auto pString = m_xBuilder->weld_check_button(check))
sAllStrings += pString->get_label() + " ";
}
@@ -266,7 +266,7 @@ OUString SvxOnlineUpdateTabPage::GetAllStrings()
for (const auto& radio : radioButton)
{
- if (const auto& pString = m_xBuilder->weld_radio_button(radio))
+ if (const auto pString = m_xBuilder->weld_radio_button(radio))
sAllStrings += pString->get_label() + " ";
}
diff --git a/cui/source/options/personalization.cxx b/cui/source/options/personalization.cxx
index a4223d73d7e8..51af4ec8e39c 100644
--- a/cui/source/options/personalization.cxx
+++ b/cui/source/options/personalization.cxx
@@ -66,11 +66,11 @@ OUString SvxPersonalizationTabPage::GetAllStrings()
for (const auto& radio : radioButton)
{
- if (const auto& pString = m_xBuilder->weld_radio_button(radio))
+ if (const auto pString = m_xBuilder->weld_radio_button(radio))
sAllStrings += pString->get_label() + " ";
}
- if (const auto& pString = m_xBuilder->weld_label(u"personas_label"_ustr))
+ if (const auto pString = m_xBuilder->weld_label(u"personas_label"_ustr))
sAllStrings += pString->get_label() + " ";
return sAllStrings.replaceAll("_", "");
diff --git a/cui/source/tabpages/autocdlg.cxx b/cui/source/tabpages/autocdlg.cxx
index 393f9f79d872..ba3998445cf5 100644
--- a/cui/source/tabpages/autocdlg.cxx
+++ b/cui/source/tabpages/autocdlg.cxx
@@ -1180,8 +1180,8 @@ IMPL_LINK(OfaAutocorrReplacePage, ModifyHdl, weld::Entry&, rEdt, void)
}
}
- const OUString& rShortTxt = m_xShortED->get_text();
- bool bEnableNew = !rShortTxt.isEmpty() &&
+ const OUString aShortTxt = m_xShortED->get_text();
+ bool bEnableNew = !aShortTxt.isEmpty() &&
( !rRepString.isEmpty() ||
( bHasSelectionText && bSWriter )) &&
( !bFirstSelIterSet || rRepString !=
@@ -1190,7 +1190,7 @@ IMPL_LINK(OfaAutocorrReplacePage, ModifyHdl, weld::Entry&, rEdt, void)
{
for (auto const& elem : aFormatText)
{
- if(elem == rShortTxt)
+ if(elem == aShortTxt)
{
bEnableNew = false;
break;
@@ -1529,7 +1529,7 @@ IMPL_LINK(OfaAutocorrExceptPage, SelectHdl, weld::TreeView&, rBox, void)
IMPL_LINK(OfaAutocorrExceptPage, ModifyHdl, weld::Entry&, rEdt, void)
{
- const OUString& sEntry = rEdt.get_text();
+ const OUString sEntry = rEdt.get_text();
bool bEntryLen = !sEntry.isEmpty();
if (&rEdt == m_xAbbrevED.get())
{
diff --git a/cui/source/tabpages/chardlg.cxx b/cui/source/tabpages/chardlg.cxx
index 62ed6940dd38..a8d4f716ca3b 100644
--- a/cui/source/tabpages/chardlg.cxx
+++ b/cui/source/tabpages/chardlg.cxx
@@ -867,13 +867,13 @@ bool SvxCharNamePage::FillItemSet_Impl( SfxItemSet& rSet, LanguageGroup eLangGrp
const SfxItemSet* pExampleSet = GetDialogExampleSet();
bool bChanged = true;
- const OUString& rFontName = pNameBox->get_active_text();
+ const OUString aFontName = pNameBox->get_active_text();
const FontList* pFontList = GetFontList();
OUString aStyleBoxText = pStyleBox->get_active_text();
int nEntryPos = pStyleBox->find_text(aStyleBoxText);
if (nEntryPos >= m_pImpl->m_nExtraEntryPos)
aStyleBoxText.clear();
- FontMetric aInfo( pFontList->Get( rFontName, aStyleBoxText ) );
+ FontMetric aInfo( pFontList->Get( aFontName, aStyleBoxText ) );
SvxFontItem aFontItem( aInfo.GetFamilyType(), aInfo.GetFamilyName(), aInfo.GetStyleName(),
aInfo.GetPitch(), aInfo.GetCharSet(), nWhich );
pOld = GetOldItem( rSet, nSlot );
@@ -894,7 +894,7 @@ bool SvxCharNamePage::FillItemSet_Impl( SfxItemSet& rSet, LanguageGroup eLangGrp
static_cast<const SvxFontItem*>(pItem)->GetFamilyName() != aFontItem.GetFamilyName() )
bChanged = true;
- if ( bChanged && !rFontName.isEmpty() )
+ if ( bChanged && !aFontName.isEmpty() )
{
rSet.Put( aFontItem );
bModified = true;
diff --git a/cui/source/tabpages/tparea.cxx b/cui/source/tabpages/tparea.cxx
index 202db8ce8526..dc9b0e4ea542 100644
--- a/cui/source/tabpages/tparea.cxx
+++ b/cui/source/tabpages/tparea.cxx
@@ -286,7 +286,7 @@ OUString SvxAreaTabPage::GetAllStrings()
for (const auto& toggle : toggleButton)
{
- if (const auto& pString = m_xBuilder->weld_toggle_button(toggle))
+ if (const auto pString = m_xBuilder->weld_toggle_button(toggle))
sAllStrings += pString->get_label() + " ";
}