diff options
| author | Luboš Luňák <l.lunak@centrum.cz> | 2022-01-26 13:34:08 +0100 |
|---|---|---|
| committer | Luboš Luňák <l.lunak@collabora.com> | 2022-02-10 17:32:04 +0100 |
| commit | 807a15bd64c1f2a57371d12e7684541293cd9791 (patch) | |
| tree | e576442da280955063e62d6073e18a16eb040a99 /configure.ac | |
| parent | 8232965cfb5f50bb2e01f7749d04c227a9622860 (diff) | |
MSVC -arch is independent from the ability to use CPU intrinsics
It's possible to write AVX512 intrinsics in code compile only with
-arch:AVX . So do not require -arch for being able to do so,
especially since there is no -arch option for only AVX512F without
other AVX512 subsets (the option enables also CD, BW, DQ and VL
https://docs.microsoft.com/en-us/cpp/build/reference/arch-x64).
https://crashreport.libreoffice.org/stats/crash_details/55ef825d-c323-4df9-95e2-76672c674e60
is presumably caused by this, I can see use of registers XMM0-15
in arraysumAVX512.cxx built with -arch:AVX2 but when built
with -arch:AVX512 registers XMM16-31 are used too (I'm not sure
if that's AVX512DQ or something else, I can't find info on it).
Change-Id: I74473333a17e618327d43b920b8929d1b0e733b8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129724
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
Tested-by: Jenkins
Diffstat (limited to 'configure.ac')
| -rw-r--r-- | configure.ac | 31 |
1 files changed, 18 insertions, 13 deletions
diff --git a/configure.ac b/configure.ac index cb296ab52dc7..3e33706646cf 100644 --- a/configure.ac +++ b/configure.ac @@ -7788,22 +7788,27 @@ if test "$GCC" = "yes" -o "$COM_IS_CLANG" = TRUE; then flag_f16c=-mf16c flag_fma=-mfma else - # https://docs.microsoft.com/en-us/cpp/build/reference/arch-x86 - # MSVC seems to differentiate only between SSE and SSE2, where in fact - # SSE2 seems to be SSE2+. - # Even if -arch:SSE2 is the default, set it explicitly, so that the variable - # is not empty (and can be tested in gbuild). - flag_sse2=-arch:SSE2 - flag_ssse3=-arch:SSE2 - flag_sse41=-arch:SSE2 - flag_sse42=-arch:SSE2 + # With MSVC using -arch is in fact not necessary for being able + # to use CPU intrinsics, code using AVX512F intrinsics will compile + # even if compiled with -arch:AVX, the -arch option really only affects + # instructions generated for C/C++ code. + # So use the matching same (or lower) -arch options, but only in order + # to generate the best matching instructions for the C++ code surrounding + # the intrinsics. + # SSE2 is the default for x86/x64, so no need to specify the option. + flag_sse2= + # No specific options for these, use the next lower. + flag_ssse3="$flag_sse2" + flag_sse41="$flag_sse2" + flag_sse42="$flag_sse2" flag_avx=-arch:AVX flag_avx2=-arch:AVX2 flag_avx512=-arch:AVX512 - flag_avx512f=-arch:AVX512 - # These are part of -arch:AVX2 - flag_f16c=-arch:AVX2 - flag_fma=-arch:AVX2 + # Using -arch:AVX512 would enable more than just AVX512F, so use only AVX2. + flag_avx512f=-arch:AVX2 + # No MSVC options for these. + flag_f16c="$flag_sse2" + flag_fma="$flag_sse2" fi AC_MSG_CHECKING([whether $CXX can compile SSE2 intrinsics]) |