diff options
author | Stephan Bergmann <sbergman@redhat.com> | 2023-07-21 22:42:35 +0200 |
---|---|---|
committer | Stephan Bergmann <sbergman@redhat.com> | 2023-07-31 23:24:52 +0200 |
commit | 5d80385fd167e5e88bb0ce959c78568d7d817842 (patch) | |
tree | bd71c541fc226f1b8a6986ba45148762f9e079ca /chart2 | |
parent | f0b8ad888aff453e1a765611dceb6bc1cf970780 (diff) |
loplugin:stringconstant: Catch some O[U]String::getStr anti-patterns
Change-Id: I36bc86fcffc3c10fe44e60d779c9aa48eeed00f2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154749
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'chart2')
-rw-r--r-- | chart2/qa/extras/chart2dump/chart2dump.cxx | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/chart2/qa/extras/chart2dump/chart2dump.cxx b/chart2/qa/extras/chart2dump/chart2dump.cxx index 030a536f320a..339a69bb80bd 100644 --- a/chart2/qa/extras/chart2dump/chart2dump.cxx +++ b/chart2/qa/extras/chart2dump/chart2dump.cxx @@ -1100,7 +1100,7 @@ DECLARE_DUMP_TEST( PivotChartDataButtonTest, Chart2DumpTest, false ) { return xShapeNode->getShapeType() == "com.sun.star.drawing.TextShape"; } ); - CPPUNIT_ASSERT_MESSAGE( OString( "Cannot find Data button shape" ).getStr(), xButton.is() ); + CPPUNIT_ASSERT_MESSAGE( "Cannot find Data button shape", xButton.is() ); // Make sure that there is no arrow shape with the Data button uno::Reference<drawing::XShape> xArrow = getShapeByName( xShapes, "FieldButton.Row.8", @@ -1108,7 +1108,7 @@ DECLARE_DUMP_TEST( PivotChartDataButtonTest, Chart2DumpTest, false ) { return xShapeNode->getShapeType() == "com.sun.star.drawing.PolyPolygonShape"; } ); - CPPUNIT_ASSERT_MESSAGE( OString( "Arrow shape should not be present for the Data button" ).getStr(), !xArrow.is() ); + CPPUNIT_ASSERT_MESSAGE( "Arrow shape should not be present for the Data button", !xArrow.is() ); // Assert the background color of the Data button util::Color aButtonFillColor = 0; |