diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2018-07-26 12:22:16 +0100 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2018-07-27 09:32:19 +0200 |
| commit | ba1e1727c238210b022741a710486964f28bb065 (patch) | |
| tree | 8b8a5afbc4a16eef7dc95b144937fa57cf6c9abd /bridges | |
| parent | 877dd9e9d1c1774817fa96f62adda98d5bce0ce8 (diff) | |
Related: rhbz#1602589 add comments to coverity annotations
Change-Id: I88c941832a0d682ea4b6028c28edd48cf5df38f7
Reviewed-on: https://gerrit.libreoffice.org/58093
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Diffstat (limited to 'bridges')
| -rw-r--r-- | bridges/source/cpp_uno/shared/bridge.cxx | 2 | ||||
| -rw-r--r-- | bridges/source/jni_uno/jni_bridge.cxx | 4 | ||||
| -rw-r--r-- | bridges/source/jni_uno/jni_info.cxx | 6 |
3 files changed, 6 insertions, 6 deletions
diff --git a/bridges/source/cpp_uno/shared/bridge.cxx b/bridges/source/cpp_uno/shared/bridge.cxx index 556350022e48..186d89aa1956 100644 --- a/bridges/source/cpp_uno/shared/bridge.cxx +++ b/bridges/source/cpp_uno/shared/bridge.cxx @@ -144,7 +144,7 @@ uno_Mapping * Bridge::createMapping( bool bExportCpp2Uno) { Bridge * bridge = new Bridge(pCppEnv, pUnoEnv, bExportCpp2Uno); - //coverity[leaked_storage] + // coverity[leaked_storage] - on purpose return bExportCpp2Uno ? &bridge->aCpp2Uno : &bridge->aUno2Cpp; } diff --git a/bridges/source/jni_uno/jni_bridge.cxx b/bridges/source/jni_uno/jni_bridge.cxx index 4a0d4b30af53..7f38d3221420 100644 --- a/bridges/source/jni_uno/jni_bridge.cxx +++ b/bridges/source/jni_uno/jni_bridge.cxx @@ -552,7 +552,7 @@ SAL_DLLPUBLIC_EXPORT void uno_ext_getMapping( uno_registerMapping( &mapping, Bridge_free, pFrom, &pTo->pExtEnv->aBase, nullptr ); - // coverity[leaked_storage] + // coverity[leaked_storage] - on purpose } else if ( from_env_typename == UNO_LB_UNO && to_env_typename == UNO_LB_JAVA ) { @@ -562,7 +562,7 @@ SAL_DLLPUBLIC_EXPORT void uno_ext_getMapping( uno_registerMapping( &mapping, Bridge_free, &pFrom->pExtEnv->aBase, pTo, nullptr ); - // coverity[leaked_storage] + // coverity[leaked_storage] - on purpose } } catch (const BridgeRuntimeError & err) diff --git a/bridges/source/jni_uno/jni_info.cxx b/bridges/source/jni_uno/jni_info.cxx index 9b43356856af..045ac44ee6be 100644 --- a/bridges/source/jni_uno/jni_info.cxx +++ b/bridges/source/jni_uno/jni_info.cxx @@ -103,7 +103,7 @@ JNI_interface_type_info::JNI_interface_type_info( typelib_InterfaceTypeDescription * td = reinterpret_cast< typelib_InterfaceTypeDescription * >( m_td.get() ); - // coverity [ctor_dtor_leak] + // coverity[ctor_dtor_leak] - on purpose m_methods.reset(new jmethodID[ td->nMapFunctionIndexToMemberIndex ]); sal_Int32 nMethodIndex = 0; typelib_TypeDescriptionReference ** ppMembers = td->ppMembers; @@ -288,7 +288,7 @@ JNI_compound_type_info::JNI_compound_type_info( td->aBase.pWeakRef, jni_info->m_RuntimeException_type.getTypeLibType() )) { - // coverity [ctor_dtor_leak] + // coverity[ctor_dtor_leak] - on purpose m_fields.reset(new jfieldID[ 2 ]); m_fields[ 0 ] = nullptr; // special Throwable.getMessage() // field Context @@ -860,7 +860,7 @@ JNI_info::JNI_info( { css::uno::TypeDescription XInterface_td( cppu::UnoType<css::uno::XInterface>::get()); - // coverity [ctor_dtor_leak] + // coverity[ctor_dtor_leak] - on purpose m_XInterface_type_info = new JNI_interface_type_info( jni, XInterface_td.get() ); } |