diff options
author | Michael Weghorn <m.weghorn@posteo.de> | 2024-12-17 13:58:03 +0100 |
---|---|---|
committer | Michael Weghorn <m.weghorn@posteo.de> | 2024-12-17 22:57:26 +0100 |
commit | 7503bb286ff6bc15c1682d47b188fc37f3beff31 (patch) | |
tree | 437a40bada522b4652e09ace0738bbc1e1307000 /bin | |
parent | 4c35e9beedc9ba89b20e7ce48cc04c800ee2fa6a (diff) |
[API CHANGE] a11y: Drop UNO service to create a11y contexts
Drop the com.sun.star.accessibility.GetStandardAccessibleFactoryService
UNO service that was used to create instances of
the a11y classes for (mainly vcl) widgets.
The service was needed to break a dependency cycle.
However, with
Change-Id: Ib46c87446dc9121d3b8e735e0e5a40594da73cc5
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Tue Dec 17 12:04:04 2024 +0100
a11y: Merge accessibility module into vcl
and all the preparatory commits in place, there
is no more dependency cycle, as the a11y classes
for vcl widgets no longer depend on any modules
"above" vcl.
Therefore, drop the UNO service and the abstract
vcl::IAccessibleFactory class and other related
classes.
Make all methods in the AccessibleFactory class
(that was previously subclassing the abstract
IAccessibleFactory) static helper methods,
and call them directly.
The UNO service dropped in this commit was
introduced in
commit 1af510e95147374e5289ae1c12f1f280931919f4
Date: Wed Feb 21 11:30:47 2024 +0200
Create an UNO service to do the symbol lookup in toolkit::AccessibilityClient
and its documentation was already clearly stating
that it's only meant for LibreOffice internal use:
> /**
> The toolkit module uses this to get a pointer to the AccessibleFactory from the acc module.
> Because we have a dependency in our modules that goes the "wrong" way.
>
> @since LibreOffice 24.8
>
> @internal
>
> ATTENTION: This is marked <em>internal</em> and does not
> have the <em>published</em> flag, which means it is subject to
> change without notice and should not be used outside the LibreOffice core.
> */
Change-Id: Ib97396a4bad486d9530361dd851ad3ee0f9681b8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/178689
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Diffstat (limited to 'bin')
-rw-r--r-- | bin/find-can-be-private-symbols.functions.results | 2 | ||||
-rw-r--r-- | bin/find-mergedlib-can-be-private-symbols.functions.results | 2 |
2 files changed, 0 insertions, 4 deletions
diff --git a/bin/find-can-be-private-symbols.functions.results b/bin/find-can-be-private-symbols.functions.results index 732a616b5953..ed4b5100cec2 100644 --- a/bin/find-can-be-private-symbols.functions.results +++ b/bin/find-can-be-private-symbols.functions.results @@ -9436,7 +9436,6 @@ VCLXWindow::IsSynthesizingVCLEvent() const VCLXWindow::PushPropertyIds(std::__debug::vector<unsigned short, std::allocator<unsigned short> >&, int, ...) VCLXWindow::SetSynthesizingVCLEvent(bool) VCLXWindow::SetSystemParent_Impl(com::sun::star::uno::Any const&) -VCLXWindow::getAccessibleFactory() VCLXWindow::notifyWindowRemoved(vcl::Window const&) VCLXWindow::resumeVclEventListening() VCLXWindow::suspendVclEventListening() @@ -15664,7 +15663,6 @@ vcl::AbstractTrueTypeFont::glyphOffset(unsigned int) const vcl::AbstractTrueTypeFont::indexGlyphData() vcl::AbstractTrueTypeFont::initialize() vcl::AbstractTrueTypeFont::~AbstractTrueTypeFont() -vcl::AccessibleFactoryAccess::ensureInitialized() vcl::BufferDevice::Dispose() vcl::BufferDevice::operator*() vcl::CloseTTFont(vcl::TrueTypeFont*) diff --git a/bin/find-mergedlib-can-be-private-symbols.functions.results b/bin/find-mergedlib-can-be-private-symbols.functions.results index 5a3724db6792..51f40068f0f0 100644 --- a/bin/find-mergedlib-can-be-private-symbols.functions.results +++ b/bin/find-mergedlib-can-be-private-symbols.functions.results @@ -151,7 +151,6 @@ BrowseBox::ToggleSelectedColumn() BrowseBox::commitBrowseBoxEvent(short, com::sun::star::uno::Any const&, com::sun::star::uno::Any const&) BrowseBox::commitHeaderBarEvent(short, com::sun::star::uno::Any const&, com::sun::star::uno::Any const&, bool) BrowseBox::commitTableEvent(short, com::sun::star::uno::Any const&, com::sun::star::uno::Any const&) -BrowseBox::getAccessibleFactory() BrowseBox::isAccessibleAlive() const Button::GetImageAlign() const Button::SetImageAlign(ImageAlign) @@ -9947,7 +9946,6 @@ VCLXWindow::IsSynthesizingVCLEvent() const VCLXWindow::PushPropertyIds(std::vector<unsigned short, std::allocator<unsigned short> >&, int, ...) VCLXWindow::SetSynthesizingVCLEvent(bool) VCLXWindow::SetSystemParent_Impl(com::sun::star::uno::Any const&) -VCLXWindow::getAccessibleFactory() VCLXWindow::notifyWindowRemoved(vcl::Window const&) VCLXWindow::resumeVclEventListening() VCLXWindow::suspendVclEventListening() |