diff options
| author | Markus Mohrhard <markus.mohrhard@collabora.co.uk> | 2015-02-18 19:53:36 +0100 |
|---|---|---|
| committer | Markus Mohrhard <markus.mohrhard@googlemail.com> | 2015-02-19 01:06:10 +0100 |
| commit | ffc0391e2e9d797ef8ce3d1089e8d9d2b11a5ead (patch) | |
| tree | 6640bdfafbe9c8b927e1ab08dbd9d303ef179020 | |
| parent | 3488d0a42f6a09723f5fd3fb972b0e778b26f8b3 (diff) | |
start documenting problems around OOXML spec
We implement in many places wrong default values based on how MSO 2007
behaves. Newer MSO versions produce correct files so our import is
wrong. Instead of changing the default value we need to be able to use
default values based on the document producer.
Change-Id: I6a2a0b30885ebccc384d17f896709ecdd475d786
| -rw-r--r-- | oox/README | 9 | ||||
| -rw-r--r-- | oox/source/drawingml/chart/chartspacemodel.cxx | 2 |
2 files changed, 10 insertions, 1 deletions
diff --git a/oox/README b/oox/README index 6d01ca56771b..2d1878695154 100644 --- a/oox/README +++ b/oox/README @@ -3,6 +3,15 @@ Support for Office Open XML, the office XML-format designed by Microsoft. See also: [http://wiki.openoffice.org/wiki/OOX] + +The "TODO: OOXML_spec" comments are related to wrong implementation of the spec. The oox code was +written against the OOXML dialect produced by MSO 2007, +which is not standard compliant. Newer MSO version use the correct +default values as desribed in the spec. We need a way to handle both in the future. +The first step is to mark these places when you see them. Many of them +already have a comment that the implemented default value is not +in line with the spec. + == DrawingML Custom shapes and presets == custom shapes are part of DrawingML and are different to binary ppt diff --git a/oox/source/drawingml/chart/chartspacemodel.cxx b/oox/source/drawingml/chart/chartspacemodel.cxx index a1c107e28c48..ea14c3c38438 100644 --- a/oox/source/drawingml/chart/chartspacemodel.cxx +++ b/oox/source/drawingml/chart/chartspacemodel.cxx @@ -25,7 +25,7 @@ namespace drawingml { namespace chart { ChartSpaceModel::ChartSpaceModel() : - mnDispBlanksAs( XML_gap ), // not zero as specified + mnDispBlanksAs( XML_gap ), // not zero as specified, TODO: OOXML_spec mnStyle( 2 ), mbAutoTitleDel( true ), mbPlotVisOnly( false ), |