clang-tidy modernize-pass-by-value in accessibility

Change-Id: Ib0658b5a0bb33e5f990b8ce4bf25b2d9cef32505
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135445
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

14 files changed, 48 insertions, 41 deletions

diff --git a/accessibility/inc/extended/AccessibleBrowseBox.hxx b/accessibility/inc/extended/AccessibleBrowseBox.hxx
index e2d5de3f2600..ba00e00d6c91 100644
--- a/accessibility/inc/extended/AccessibleBrowseBox.hxx
+++ b/accessibility/inc/extended/AccessibleBrowseBox.hxx
@@ -206,7 +206,7 @@ private:
 
 public:
     AccessibleBrowseBoxAccess(
-        const css::uno::Reference< css::accessibility::XAccessible >& _rxParent,
+        css::uno::Reference< css::accessibility::XAccessible > _xParent,
         ::vcl::IAccessibleTableProvider& _rBrowseBox
     );
 
diff --git a/accessibility/inc/extended/AccessibleBrowseBoxBase.hxx b/accessibility/inc/extended/AccessibleBrowseBoxBase.hxx
index 71cde0280ad2..7e9ada30ab86 100644
--- a/accessibility/inc/extended/AccessibleBrowseBoxBase.hxx
+++ b/accessibility/inc/extended/AccessibleBrowseBoxBase.hxx
@@ -80,9 +80,9 @@ public:
         @param _xFocusWindow    The window that gets all the focus events.
         @param eObjType         Object type */
     AccessibleBrowseBoxBase(
-        const css::uno::Reference< css::accessibility::XAccessible >& rxParent,
+        css::uno::Reference< css::accessibility::XAccessible > xParent,
         ::vcl::IAccessibleTableProvider& rBrowseBox,
-        const css::uno::Reference< css::awt::XWindow >& _xFocusWindow,
+        css::uno::Reference< css::awt::XWindow >  _xFocusWindow,
         AccessibleBrowseBoxObjType eObjType );
 
     /** Constructor sets specified name and description.
@@ -93,12 +93,12 @@ public:
         @param rName            The name of this object.
         @param rDescription     The description text of this object. */
     AccessibleBrowseBoxBase(
-        const css::uno::Reference< css::accessibility::XAccessible >& rxParent,
+        css::uno::Reference< css::accessibility::XAccessible > xParent,
         ::vcl::IAccessibleTableProvider& rBrowseBox,
-        const css::uno::Reference< css::awt::XWindow >& _xFocusWindow,
+        css::uno::Reference< css::awt::XWindow >  _xFocusWindow,
         AccessibleBrowseBoxObjType eObjType,
-        const OUString& rName,
-        const OUString& rDescription );
+        OUString  rName,
+        OUString  rDescription );
 
 protected:
     virtual ~AccessibleBrowseBoxBase() override;
diff --git a/accessibility/inc/extended/AccessibleGridControl.hxx b/accessibility/inc/extended/AccessibleGridControl.hxx
index 79b4e19e47b1..302f240ee65f 100644
--- a/accessibility/inc/extended/AccessibleGridControl.hxx
+++ b/accessibility/inc/extended/AccessibleGridControl.hxx
@@ -171,7 +171,7 @@ private:
 
 public:
     AccessibleGridControlAccess(
-        const css::uno::Reference< css::accessibility::XAccessible >& _rxParent,
+        css::uno::Reference< css::accessibility::XAccessible > _xParent,
         ::vcl::table::IAccessibleTable& _rTable
     );
 
diff --git a/accessibility/inc/extended/AccessibleGridControlBase.hxx b/accessibility/inc/extended/AccessibleGridControlBase.hxx
index f1b2d4b1c85f..8523b78926d6 100644
--- a/accessibility/inc/extended/AccessibleGridControlBase.hxx
+++ b/accessibility/inc/extended/AccessibleGridControlBase.hxx
@@ -66,7 +66,7 @@ public:
         @param rTable    The Table control.
         @param eObjType  Type of accessible table control. */
     AccessibleGridControlBase(
-        const css::uno::Reference< css::accessibility::XAccessible >& rxParent,
+        css::uno::Reference< css::accessibility::XAccessible > xParent,
         ::vcl::table::IAccessibleTable& rTable,
         ::vcl::table::AccessibleTableControlObjType  eObjType );
 
diff --git a/accessibility/inc/extended/accessibleeditbrowseboxcell.hxx b/accessibility/inc/extended/accessibleeditbrowseboxcell.hxx
index ea42155fd0eb..093a3ade4587 100644
--- a/accessibility/inc/extended/accessibleeditbrowseboxcell.hxx
+++ b/accessibility/inc/extended/accessibleeditbrowseboxcell.hxx
@@ -105,9 +105,9 @@ namespace accessibility
 
     public:
         EditBrowseBoxTableCellAccess(
-            const css::uno::Reference< css::accessibility::XAccessible >& _rxParent,
-            const css::uno::Reference< css::accessibility::XAccessible >& _rxControlAccessible,
-            const css::uno::Reference< css::awt::XWindow >& _rxFocusWindow,
+            css::uno::Reference< css::accessibility::XAccessible > _xParent,
+            css::uno::Reference< css::accessibility::XAccessible > _xControlAccessible,
+            css::uno::Reference< css::awt::XWindow > _xFocusWindow,
             ::vcl::IAccessibleTableProvider& _rBrowseBox,
             sal_Int32 _nRowPos,
             sal_uInt16 _nColPos
diff --git a/accessibility/inc/extended/textwindowaccessibility.hxx b/accessibility/inc/extended/textwindowaccessibility.hxx
index 43e52384a536..f5696d8bfb61 100644
--- a/accessibility/inc/extended/textwindowaccessibility.hxx
+++ b/accessibility/inc/extended/textwindowaccessibility.hxx
@@ -132,7 +132,7 @@ class Paragraph final:
     private cppu::BaseMutex, public ParagraphBase, private ::comphelper::OCommonAccessibleText
 {
 public:
-    Paragraph(::rtl::Reference< Document > const & rDocument,
+    Paragraph(::rtl::Reference< Document > xDocument,
                   Paragraphs::size_type nNumber);
 
     // Not thread-safe.
diff --git a/accessibility/inc/standard/vclxaccessiblelistitem.hxx b/accessibility/inc/standard/vclxaccessiblelistitem.hxx
index 4af3c5afd65e..6542d7b43425 100644
--- a/accessibility/inc/standard/vclxaccessiblelistitem.hxx
+++ b/accessibility/inc/standard/vclxaccessiblelistitem.hxx
@@ -85,7 +85,7 @@ public:
             is our parent accessible object
     */
     VCLXAccessibleListItem(sal_Int32 _nIndexInParent,
-                           const rtl::Reference< VCLXAccessibleList >& _xParent);
+                           rtl::Reference< VCLXAccessibleList > _xParent);
 
     void                    NotifyAccessibleEvent(  sal_Int16 _nEventId, const css::uno::Any& _aOldValue, const css::uno::Any& _aNewValue );
 
diff --git a/accessibility/source/extended/AccessibleBrowseBox.cxx b/accessibility/source/extended/AccessibleBrowseBox.cxx
index 8c620b98260b..6bc4865c6d4d 100644
--- a/accessibility/source/extended/AccessibleBrowseBox.cxx
+++ b/accessibility/source/extended/AccessibleBrowseBox.cxx
@@ -21,6 +21,7 @@
 #include <extended/AccessibleBrowseBoxTable.hxx>
 #include <extended/AccessibleBrowseBoxHeaderBar.hxx>
 #include <com/sun/star/lang/IndexOutOfBoundsException.hpp>
+#include <utility>
 #include <vcl/accessibletableprovider.hxx>
 #include <toolkit/helper/convert.hxx>
 #include <toolkit/helper/vclunohelper.hxx>
@@ -267,8 +268,8 @@ void AccessibleBrowseBox::commitHeaderBarEvent( sal_Int16 _nEventId,
 
 // = AccessibleBrowseBoxAccess
 
-AccessibleBrowseBoxAccess::AccessibleBrowseBoxAccess( const css::uno::Reference< css::accessibility::XAccessible >& _rxParent, ::vcl::IAccessibleTableProvider& _rBrowseBox )
-        :m_xParent( _rxParent )
+AccessibleBrowseBoxAccess::AccessibleBrowseBoxAccess( css::uno::Reference< css::accessibility::XAccessible > _xParent, ::vcl::IAccessibleTableProvider& _rBrowseBox )
+        :m_xParent(std::move( _xParent ))
         ,m_rBrowseBox( _rBrowseBox )
 {
 }
diff --git a/accessibility/source/extended/AccessibleBrowseBoxBase.cxx b/accessibility/source/extended/AccessibleBrowseBoxBase.cxx
index ee64200065d1..4b16293e5083 100644
--- a/accessibility/source/extended/AccessibleBrowseBoxBase.cxx
+++ b/accessibility/source/extended/AccessibleBrowseBoxBase.cxx
@@ -19,6 +19,7 @@
 
 #include <extended/AccessibleBrowseBoxBase.hxx>
 #include <toolkit/helper/convert.hxx>
+#include <utility>
 #include <vcl/accessibletableprovider.hxx>
 #include <cppuhelper/supportsservice.hxx>
 
@@ -49,14 +50,14 @@ using namespace com::sun::star::accessibility::AccessibleStateType;
 // Ctor/Dtor/disposing
 
 AccessibleBrowseBoxBase::AccessibleBrowseBoxBase(
-        const css::uno::Reference< css::accessibility::XAccessible >& rxParent,
+        css::uno::Reference< css::accessibility::XAccessible > xParent,
         ::vcl::IAccessibleTableProvider&                      rBrowseBox,
-        const css::uno::Reference< css::awt::XWindow >& _xFocusWindow,
+        css::uno::Reference< css::awt::XWindow > _xFocusWindow,
         AccessibleBrowseBoxObjType      eObjType ) :
     AccessibleBrowseBoxImplHelper( m_aMutex ),
-    mxParent( rxParent ),
+    mxParent(std::move( xParent )),
     mpBrowseBox( &rBrowseBox ),
-    m_xFocusWindow(_xFocusWindow),
+    m_xFocusWindow(std::move(_xFocusWindow)),
     maName( rBrowseBox.GetAccessibleObjectName( eObjType ) ),
     maDescription( rBrowseBox.GetAccessibleObjectDescription( eObjType ) ),
     meObjType( eObjType ),
@@ -67,18 +68,18 @@ AccessibleBrowseBoxBase::AccessibleBrowseBoxBase(
 }
 
 AccessibleBrowseBoxBase::AccessibleBrowseBoxBase(
-        const css::uno::Reference< css::accessibility::XAccessible >& rxParent,
+        css::uno::Reference< css::accessibility::XAccessible >  rxParent,
         ::vcl::IAccessibleTableProvider&                      rBrowseBox,
-        const css::uno::Reference< css::awt::XWindow >& _xFocusWindow,
+        css::uno::Reference< css::awt::XWindow >  _xFocusWindow,
         AccessibleBrowseBoxObjType      eObjType,
-        const OUString&          rName,
-        const OUString&          rDescription ) :
+        OUString           rName,
+        OUString           rDescription ) :
     AccessibleBrowseBoxImplHelper( m_aMutex ),
-    mxParent( rxParent ),
+    mxParent(std::move( rxParent )),
     mpBrowseBox( &rBrowseBox ),
-    m_xFocusWindow(_xFocusWindow),
-    maName( rName ),
-    maDescription( rDescription ),
+    m_xFocusWindow(std::move(_xFocusWindow)),
+    maName(std::move( rName )),
+    maDescription(std::move( rDescription )),
     meObjType( eObjType ),
     m_aClientId(0)
 {
diff --git a/accessibility/source/extended/AccessibleGridControl.cxx b/accessibility/source/extended/AccessibleGridControl.cxx
index 474945817603..a3d016194a27 100644
--- a/accessibility/source/extended/AccessibleGridControl.cxx
+++ b/accessibility/source/extended/AccessibleGridControl.cxx
@@ -24,6 +24,7 @@
 #include <com/sun/star/accessibility/AccessibleRole.hpp>
 #include <com/sun/star/lang/IndexOutOfBoundsException.hpp>
 #include <toolkit/helper/convert.hxx>
+#include <utility>
 #include <vcl/accessibletable.hxx>
 #include <vcl/svapp.hxx>
 
@@ -307,8 +308,8 @@ void AccessibleGridControl::commitTableEvent(sal_Int16 _nEventId,const Any& _rNe
 
 
 AccessibleGridControlAccess::AccessibleGridControlAccess(
-        const css::uno::Reference< css::accessibility::XAccessible >& rxParent, ::vcl::table::IAccessibleTable& rTable )
-    : m_xParent( rxParent )
+        css::uno::Reference< css::accessibility::XAccessible > xParent, ::vcl::table::IAccessibleTable& rTable )
+    : m_xParent(std::move( xParent ))
     , m_pTable( & rTable )
 {
 }
diff --git a/accessibility/source/extended/AccessibleGridControlBase.cxx b/accessibility/source/extended/AccessibleGridControlBase.cxx
index 915aeb7e373e..6b7ce3fad417 100644
--- a/accessibility/source/extended/AccessibleGridControlBase.cxx
+++ b/accessibility/source/extended/AccessibleGridControlBase.cxx
@@ -19,6 +19,7 @@
 
 #include <extended/AccessibleGridControlBase.hxx>
 #include <toolkit/helper/convert.hxx>
+#include <utility>
 #include <vcl/accessibletable.hxx>
 #include <vcl/svapp.hxx>
 #include <vcl/window.hxx>
@@ -47,11 +48,11 @@ using namespace com::sun::star::accessibility::AccessibleStateType;
 
 
 AccessibleGridControlBase::AccessibleGridControlBase(
-        const css::uno::Reference< css::accessibility::XAccessible >& rxParent,
+        css::uno::Reference< css::accessibility::XAccessible > xParent,
         ::vcl::table::IAccessibleTable& rTable,
         ::vcl::table::AccessibleTableControlObjType      eObjType ) :
     AccessibleGridControlImplHelper( m_aMutex ),
-    m_xParent( rxParent ),
+    m_xParent(std::move( xParent )),
     m_aTable( rTable),
     m_eObjType( eObjType ),
     m_aClientId(0)
diff --git a/accessibility/source/extended/accessibleeditbrowseboxcell.cxx b/accessibility/source/extended/accessibleeditbrowseboxcell.cxx
index a582defcadd6..54f0696735f5 100644
--- a/accessibility/source/extended/accessibleeditbrowseboxcell.cxx
+++ b/accessibility/source/extended/accessibleeditbrowseboxcell.cxx
@@ -22,6 +22,7 @@
 
 #include <extended/accessibleeditbrowseboxcell.hxx>
 #include <comphelper/processfactory.hxx>
+#include <utility>
 #include <tools/diagnose_ex.h>
 
 namespace accessibility
@@ -180,12 +181,12 @@ namespace accessibility
 
     // EditBrowseBoxTableCell
     EditBrowseBoxTableCellAccess::EditBrowseBoxTableCellAccess(
-            const css::uno::Reference< css::accessibility::XAccessible >& _rxParent, const css::uno::Reference< css::accessibility::XAccessible >& _rxControlAccessible,
-            const css::uno::Reference< css::awt::XWindow >& _rxFocusWindow,
+            css::uno::Reference< css::accessibility::XAccessible > _xParent, css::uno::Reference< css::accessibility::XAccessible > _xControlAccessible,
+            css::uno::Reference< css::awt::XWindow > _xFocusWindow,
             ::vcl::IAccessibleTableProvider& _rBrowseBox, sal_Int32 _nRowPos, sal_uInt16 _nColPos )
-        :m_xParent( _rxParent )
-        ,m_xControlAccessible( _rxControlAccessible )
-        ,m_xFocusWindow( _rxFocusWindow )
+        :m_xParent(std::move( _xParent ))
+        ,m_xControlAccessible(std::move( _xControlAccessible ))
+        ,m_xFocusWindow(std::move( _xFocusWindow ))
         ,m_pBrowseBox( &_rBrowseBox )
         ,m_nRowPos( _nRowPos )
         ,m_nColPos( _nColPos )
diff --git a/accessibility/source/extended/textwindowaccessibility.cxx b/accessibility/source/extended/textwindowaccessibility.cxx
index 26186c44ae89..218ba33e6bae 100644
--- a/accessibility/source/extended/textwindowaccessibility.cxx
+++ b/accessibility/source/extended/textwindowaccessibility.cxx
@@ -33,6 +33,7 @@
 #include <comphelper/accessibleeventnotifier.hxx>
 #include <unotools/accessiblerelationsethelper.hxx>
 #include <unotools/accessiblestatesethelper.hxx>
+#include <utility>
 #include <vcl/svapp.hxx>
 #include <vcl/txtattr.hxx>
 #include <vcl/window.hxx>
@@ -79,10 +80,10 @@ void WindowListenerGuard::endListening()
     }
 }
 
-Paragraph::Paragraph(::rtl::Reference< Document > const & rDocument,
+Paragraph::Paragraph(::rtl::Reference< Document > xDocument,
                              Paragraphs::size_type nNumber):
     ParagraphBase(m_aMutex),
-    m_xDocument(rDocument),
+    m_xDocument(std::move(xDocument)),
     m_nNumber(nNumber),
     m_nClientId(0)
 {
diff --git a/accessibility/source/standard/vclxaccessiblelistitem.cxx b/accessibility/source/standard/vclxaccessiblelistitem.cxx
index dea8682c127e..81a5cd1a2fcc 100644
--- a/accessibility/source/standard/vclxaccessiblelistitem.cxx
+++ b/accessibility/source/standard/vclxaccessiblelistitem.cxx
@@ -29,6 +29,7 @@
 #include <com/sun/star/datatransfer/clipboard/XFlushableClipboard.hpp>
 #include <com/sun/star/lang/IndexOutOfBoundsException.hpp>
 #include <cppuhelper/supportsservice.hxx>
+#include <utility>
 #include <vcl/svapp.hxx>
 #include <vcl/toolkit/lstbox.hxx>
 #include <vcl/unohelp2.hxx>
@@ -59,13 +60,13 @@ using namespace ::com::sun::star;
 
 // Ctor() and Dtor()
 
-VCLXAccessibleListItem::VCLXAccessibleListItem(sal_Int32 _nIndexInParent, const rtl::Reference< VCLXAccessibleList >& _xParent)
+VCLXAccessibleListItem::VCLXAccessibleListItem(sal_Int32 _nIndexInParent, rtl::Reference< VCLXAccessibleList > _xParent)
     : VCLXAccessibleListItem_BASE(m_aMutex)
     , m_nIndexInParent(_nIndexInParent)
     , m_bSelected(false)
     , m_bVisible(false)
     , m_nClientId(0)
-    , m_xParent(_xParent)
+    , m_xParent(std::move(_xParent))
 {
     assert(m_xParent.is());
     ::accessibility::IComboListBoxHelper* pListBoxHelper = m_xParent->getListBoxHelper();