diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2022-04-20 13:00:07 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2022-04-20 15:24:34 +0200 |
commit | 9f958c076a86e80a48fcd7bbca65a834568e94ea (patch) | |
tree | cfa0b4f55a6b6717e5a359357fd20779e9d98b00 | |
parent | a40558be785756929f606ab0798a026b985e0ffb (diff) |
loplugin:passstuffbyref
Change-Id: I336fd329b577b6fa141265d8bc7ce67784bd7306
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133210
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
98 files changed, 101 insertions, 101 deletions
diff --git a/accessibility/source/standard/vclxaccessibletoolbox.cxx b/accessibility/source/standard/vclxaccessibletoolbox.cxx index 50a600e3cbef..4e2059b61280 100644 --- a/accessibility/source/standard/vclxaccessibletoolbox.cxx +++ b/accessibility/source/standard/vclxaccessibletoolbox.cxx @@ -94,7 +94,7 @@ namespace sal_Int32 getIndexInParent() const { return m_nIndexInParent; } void setIndexInParent( sal_Int32 _nNewIndex ) { m_nIndexInParent = _nNewIndex; } - static Sequence< sal_Int8 > getUnoTunnelId(); + static const Sequence< sal_Int8 > & getUnoTunnelId(); public: OToolBoxWindowItem(sal_Int32 _nIndexInParent, @@ -132,7 +132,7 @@ namespace return new OToolBoxWindowItemContext( m_nIndexInParent, getComponentContext(), _rxInnerContext, this, getParent() ); } - Sequence< sal_Int8 > OToolBoxWindowItem::getUnoTunnelId() + const Sequence< sal_Int8 > & OToolBoxWindowItem::getUnoTunnelId() { static const comphelper::UnoIdInit implId; return implId.getSeq(); diff --git a/chart2/source/inc/BaseCoordinateSystem.hxx b/chart2/source/inc/BaseCoordinateSystem.hxx index afb02c07f1f4..85739dc11a3a 100644 --- a/chart2/source/inc/BaseCoordinateSystem.hxx +++ b/chart2/source/inc/BaseCoordinateSystem.hxx @@ -98,7 +98,7 @@ public: const css::uno::Reference< css::util::XModifyListener >& aListener ) override; void setAxisByDimension( sal_Int32 nDimension, const rtl::Reference< ::chart::Axis >& xAxis, sal_Int32 nIndex ); - rtl::Reference< ::chart::Axis > getAxisByDimension2(sal_Int32 nDimension, sal_Int32 nIndex ) const; + const rtl::Reference< ::chart::Axis > & getAxisByDimension2(sal_Int32 nDimension, sal_Int32 nIndex ) const; void setChartTypes( const std::vector< rtl::Reference< ::chart::ChartType > >& aChartTypes ); const std::vector< rtl::Reference<::chart::ChartType > > & getChartTypes2() const { return m_aChartTypes; } diff --git a/chart2/source/model/main/BaseCoordinateSystem.cxx b/chart2/source/model/main/BaseCoordinateSystem.cxx index 52ef7ffde0d7..95faaed01bfd 100644 --- a/chart2/source/model/main/BaseCoordinateSystem.cxx +++ b/chart2/source/model/main/BaseCoordinateSystem.cxx @@ -256,7 +256,7 @@ Reference< chart2::XAxis > SAL_CALL BaseCoordinateSystem::getAxisByDimension( return m_aAllAxis[ nDimensionIndex ][nAxisIndex]; } -rtl::Reference< Axis > BaseCoordinateSystem::getAxisByDimension2( +const rtl::Reference< Axis > & BaseCoordinateSystem::getAxisByDimension2( sal_Int32 nDimensionIndex, sal_Int32 nAxisIndex ) const { if( nDimensionIndex < 0 || nDimensionIndex >= m_nDimensionCount ) diff --git a/chart2/source/view/inc/VDataSeries.hxx b/chart2/source/view/inc/VDataSeries.hxx index bfe85435cc02..089c4a1ae887 100644 --- a/chart2/source/view/inc/VDataSeries.hxx +++ b/chart2/source/view/inc/VDataSeries.hxx @@ -117,7 +117,7 @@ public: css::uno::Reference<css::beans::XPropertySet> getPropertiesOfPoint( sal_Int32 index ) const; - css::uno::Reference<css::beans::XPropertySet> getPropertiesOfSeries() const; + const css::uno::Reference<css::beans::XPropertySet> & getPropertiesOfSeries() const; css::chart2::Symbol* getSymbolProperties( sal_Int32 index ) const; diff --git a/chart2/source/view/main/VDataSeries.cxx b/chart2/source/view/main/VDataSeries.cxx index 9054899485f4..81b3758293fa 100644 --- a/chart2/source/view/main/VDataSeries.cxx +++ b/chart2/source/view/main/VDataSeries.cxx @@ -910,7 +910,7 @@ uno::Reference< beans::XPropertySet > VDataSeries::getPropertiesOfPoint( sal_Int return getPropertiesOfSeries(); } -uno::Reference<beans::XPropertySet> VDataSeries::getPropertiesOfSeries() const +const uno::Reference<beans::XPropertySet> & VDataSeries::getPropertiesOfSeries() const { return m_xDataSeriesProps; } diff --git a/comphelper/source/misc/accimplaccess.cxx b/comphelper/source/misc/accimplaccess.cxx index 4c66d03ffd08..bcf05c926810 100644 --- a/comphelper/source/misc/accimplaccess.cxx +++ b/comphelper/source/misc/accimplaccess.cxx @@ -36,7 +36,7 @@ namespace comphelper { } - Sequence<sal_Int8> OAccessibleImplementationAccess::getUnoTunnelId() + const Sequence<sal_Int8> & OAccessibleImplementationAccess::getUnoTunnelId() { static const comphelper::UnoIdInit implID; return implID.getSeq(); diff --git a/connectivity/source/commontools/ConnectionWrapper.cxx b/connectivity/source/commontools/ConnectionWrapper.cxx index 9ed4f394b5ee..df5ef04ee523 100644 --- a/connectivity/source/commontools/ConnectionWrapper.cxx +++ b/connectivity/source/commontools/ConnectionWrapper.cxx @@ -162,7 +162,7 @@ sal_Int64 SAL_CALL OConnectionWrapper::getSomething( const Sequence< sal_Int8 >& } -Sequence< sal_Int8 > OConnectionWrapper::getUnoTunnelId() +const Sequence< sal_Int8 > & OConnectionWrapper::getUnoTunnelId() { static const comphelper::UnoIdInit implId; return implId.getSeq(); diff --git a/connectivity/source/commontools/TConnection.cxx b/connectivity/source/commontools/TConnection.cxx index 25997b512a3e..f35e8ca194ba 100644 --- a/connectivity/source/commontools/TConnection.cxx +++ b/connectivity/source/commontools/TConnection.cxx @@ -59,7 +59,7 @@ sal_Int64 SAL_CALL OMetaConnection::getSomething( const css::uno::Sequence< sal_ return comphelper::getSomethingImpl(rId, this); } -Sequence< sal_Int8 > OMetaConnection::getUnoTunnelId() +const Sequence< sal_Int8 > & OMetaConnection::getUnoTunnelId() { static const comphelper::UnoIdInit implId; return implId.getSeq(); diff --git a/connectivity/source/commontools/TTableHelper.cxx b/connectivity/source/commontools/TTableHelper.cxx index 2436776fb177..31e240469402 100644 --- a/connectivity/source/commontools/TTableHelper.cxx +++ b/connectivity/source/commontools/TTableHelper.cxx @@ -549,7 +549,7 @@ OUString SAL_CALL OTableHelper::getName() return sComposedName; } -OUString OTableHelper::getTableName() +const OUString & OTableHelper::getTableName() { return m_Name; } diff --git a/connectivity/source/drivers/calc/CTable.cxx b/connectivity/source/drivers/calc/CTable.cxx index 90e7c4e08bed..53a8c8eeb855 100644 --- a/connectivity/source/drivers/calc/CTable.cxx +++ b/connectivity/source/drivers/calc/CTable.cxx @@ -608,7 +608,7 @@ void SAL_CALL OCalcTable::disposing() } -Sequence< sal_Int8 > OCalcTable::getUnoTunnelId() +const Sequence< sal_Int8 > & OCalcTable::getUnoTunnelId() { static const comphelper::UnoIdInit implId; return implId.getSeq(); diff --git a/connectivity/source/drivers/dbase/DIndex.cxx b/connectivity/source/drivers/dbase/DIndex.cxx index 245c49b58e2f..4ac8b1a41722 100644 --- a/connectivity/source/drivers/dbase/DIndex.cxx +++ b/connectivity/source/drivers/dbase/DIndex.cxx @@ -99,7 +99,7 @@ void ODbaseIndex::refreshColumns() m_pColumns.reset(new ODbaseIndexColumns(this,m_aMutex,aVector)); } -Sequence< sal_Int8 > ODbaseIndex::getUnoTunnelId() +const Sequence< sal_Int8 > & ODbaseIndex::getUnoTunnelId() { static const comphelper::UnoIdInit implId; return implId.getSeq(); diff --git a/connectivity/source/drivers/dbase/DTable.cxx b/connectivity/source/drivers/dbase/DTable.cxx index fd4b5ea85cc2..eedba74a57cd 100644 --- a/connectivity/source/drivers/dbase/DTable.cxx +++ b/connectivity/source/drivers/dbase/DTable.cxx @@ -765,7 +765,7 @@ Any SAL_CALL ODbaseTable::queryInterface( const Type & rType ) } -Sequence< sal_Int8 > ODbaseTable::getUnoTunnelId() +const Sequence< sal_Int8 > & ODbaseTable::getUnoTunnelId() { static const comphelper::UnoIdInit implId; return implId.getSeq(); diff --git a/connectivity/source/drivers/file/FConnection.cxx b/connectivity/source/drivers/file/FConnection.cxx index 283bee8fee45..90030abb51db 100644 --- a/connectivity/source/drivers/file/FConnection.cxx +++ b/connectivity/source/drivers/file/FConnection.cxx @@ -405,7 +405,7 @@ sal_Int64 SAL_CALL OConnection::getSomething( const Sequence< sal_Int8 >& rId ) return comphelper::getSomethingImpl(rId, this); } -Sequence< sal_Int8 > OConnection::getUnoTunnelId() +const Sequence< sal_Int8 > & OConnection::getUnoTunnelId() { static const comphelper::UnoIdInit implId; return implId.getSeq(); diff --git a/connectivity/source/drivers/file/FResultSet.cxx b/connectivity/source/drivers/file/FResultSet.cxx index fdf3a4e47d84..43ad38739d5b 100644 --- a/connectivity/source/drivers/file/FResultSet.cxx +++ b/connectivity/source/drivers/file/FResultSet.cxx @@ -1380,7 +1380,7 @@ void OResultSet::OpenImpl() m_nFilePos = 0; } -Sequence< sal_Int8 > OResultSet::getUnoTunnelId() +const Sequence< sal_Int8 > & OResultSet::getUnoTunnelId() { static const comphelper::UnoIdInit implId; return implId.getSeq(); diff --git a/connectivity/source/drivers/file/FTable.cxx b/connectivity/source/drivers/file/FTable.cxx index af2d6de226f8..6ec776452d8a 100644 --- a/connectivity/source/drivers/file/FTable.cxx +++ b/connectivity/source/drivers/file/FTable.cxx @@ -118,7 +118,7 @@ void SAL_CALL OFileTable::disposing() FileClose(); } -Sequence< sal_Int8 > OFileTable::getUnoTunnelId() +const Sequence< sal_Int8 > & OFileTable::getUnoTunnelId() { static const comphelper::UnoIdInit s_Id; return s_Id.getSeq(); diff --git a/connectivity/source/drivers/firebird/Connection.cxx b/connectivity/source/drivers/firebird/Connection.cxx index 64a8495bfc3c..9230eb22f13b 100644 --- a/connectivity/source/drivers/firebird/Connection.cxx +++ b/connectivity/source/drivers/firebird/Connection.cxx @@ -383,7 +383,7 @@ sal_Int64 SAL_CALL Connection::getSomething(const css::uno::Sequence<sal_Int8>& } // static -css::uno::Sequence<sal_Int8> Connection::getUnoTunnelId() +const css::uno::Sequence<sal_Int8> & Connection::getUnoTunnelId() { static const comphelper::UnoIdInit implId; return implId.getSeq(); diff --git a/connectivity/source/drivers/firebird/Connection.hxx b/connectivity/source/drivers/firebird/Connection.hxx index caf091146ae6..9fdb0d4d3320 100644 --- a/connectivity/source/drivers/firebird/Connection.hxx +++ b/connectivity/source/drivers/firebird/Connection.hxx @@ -210,7 +210,7 @@ namespace connectivity::firebird DECLARE_SERVICE_INFO(); // XUnoTunnel virtual sal_Int64 SAL_CALL getSomething(const css::uno::Sequence<sal_Int8>& rId) override; - static css::uno::Sequence<sal_Int8> getUnoTunnelId(); + static const css::uno::Sequence<sal_Int8> & getUnoTunnelId(); // XConnection virtual css::uno::Reference< css::sdbc::XStatement > SAL_CALL createStatement( ) override; virtual css::uno::Reference< css::sdbc::XPreparedStatement > SAL_CALL prepareStatement( const OUString& sql ) override; diff --git a/connectivity/source/drivers/flat/ETable.cxx b/connectivity/source/drivers/flat/ETable.cxx index 4c8c446dfeaa..dd7342419d61 100644 --- a/connectivity/source/drivers/flat/ETable.cxx +++ b/connectivity/source/drivers/flat/ETable.cxx @@ -549,7 +549,7 @@ Any SAL_CALL OFlatTable::queryInterface( const Type & rType ) } -Sequence< sal_Int8 > OFlatTable::getUnoTunnelId() +const Sequence< sal_Int8 > & OFlatTable::getUnoTunnelId() { static const comphelper::UnoIdInit implId; return implId.getSeq(); diff --git a/connectivity/source/drivers/hsqldb/HTable.cxx b/connectivity/source/drivers/hsqldb/HTable.cxx index 9a23b6052468..fcc50bba4bc5 100644 --- a/connectivity/source/drivers/hsqldb/HTable.cxx +++ b/connectivity/source/drivers/hsqldb/HTable.cxx @@ -115,7 +115,7 @@ sdbcx::OCollection* OHSQLTable::createIndexes(const ::std::vector< OUString>& _r return new OIndexesHelper(this,m_aMutex,_rNames); } -Sequence< sal_Int8 > OHSQLTable::getUnoTunnelId() +const Sequence< sal_Int8 > & OHSQLTable::getUnoTunnelId() { static const comphelper::UnoIdInit implId; return implId.getSeq(); diff --git a/connectivity/source/drivers/mysql_jdbc/YTable.cxx b/connectivity/source/drivers/mysql_jdbc/YTable.cxx index b5b02fefc1bc..f769089482a1 100644 --- a/connectivity/source/drivers/mysql_jdbc/YTable.cxx +++ b/connectivity/source/drivers/mysql_jdbc/YTable.cxx @@ -116,7 +116,7 @@ sdbcx::OCollection* OMySQLTable::createIndexes(const ::std::vector<OUString>& _r return new OIndexesHelper(this, m_aMutex, _rNames); } -Sequence<sal_Int8> OMySQLTable::getUnoTunnelId() +const Sequence<sal_Int8>& OMySQLTable::getUnoTunnelId() { static const comphelper::UnoIdInit implId; return implId.getSeq(); diff --git a/connectivity/source/drivers/mysqlc/mysqlc_connection.cxx b/connectivity/source/drivers/mysqlc/mysqlc_connection.cxx index 22e5c0ad0c41..dd2f9e5dd20c 100644 --- a/connectivity/source/drivers/mysqlc/mysqlc_connection.cxx +++ b/connectivity/source/drivers/mysqlc/mysqlc_connection.cxx @@ -497,7 +497,7 @@ sal_Int64 SAL_CALL OConnection::getSomething(const css::uno::Sequence<sal_Int8>& } // static -Sequence<sal_Int8> OConnection::getUnoTunnelId() +const Sequence<sal_Int8>& OConnection::getUnoTunnelId() { static const comphelper::UnoIdInit implId; return implId.getSeq(); diff --git a/connectivity/source/drivers/mysqlc/mysqlc_connection.hxx b/connectivity/source/drivers/mysqlc/mysqlc_connection.hxx index d6040ec65b7f..3a0ccf36b4ed 100644 --- a/connectivity/source/drivers/mysqlc/mysqlc_connection.hxx +++ b/connectivity/source/drivers/mysqlc/mysqlc_connection.hxx @@ -127,7 +127,7 @@ public: // XUnoTunnel virtual sal_Int64 SAL_CALL getSomething(const css::uno::Sequence<sal_Int8>& rId) override; - static css::uno::Sequence<sal_Int8> getUnoTunnelId(); + static const css::uno::Sequence<sal_Int8>& getUnoTunnelId(); // XConnection css::uno::Reference<css::sdbc::XStatement> SAL_CALL createStatement() override; diff --git a/connectivity/source/drivers/writer/WTable.cxx b/connectivity/source/drivers/writer/WTable.cxx index 2f76fc4a09d0..42b65173e09c 100644 --- a/connectivity/source/drivers/writer/WTable.cxx +++ b/connectivity/source/drivers/writer/WTable.cxx @@ -210,7 +210,7 @@ void SAL_CALL OWriterTable::disposing() m_pWriterConnection = nullptr; } -uno::Sequence<sal_Int8> OWriterTable::getUnoTunnelId() +const uno::Sequence<sal_Int8>& OWriterTable::getUnoTunnelId() { static const comphelper::UnoIdInit implId; return implId.getSeq(); diff --git a/connectivity/source/inc/TConnection.hxx b/connectivity/source/inc/TConnection.hxx index 246e968b8a32..2dbe2ef6a756 100644 --- a/connectivity/source/inc/TConnection.hxx +++ b/connectivity/source/inc/TConnection.hxx @@ -73,7 +73,7 @@ namespace connectivity //XUnoTunnel virtual sal_Int64 SAL_CALL getSomething( const css::uno::Sequence< sal_Int8 >& aIdentifier ) override; - static css::uno::Sequence< sal_Int8 > getUnoTunnelId(); + static const css::uno::Sequence< sal_Int8 > & getUnoTunnelId(); }; } diff --git a/connectivity/source/inc/calc/CTable.hxx b/connectivity/source/inc/calc/CTable.hxx index a8f49b661bc4..2c0e1d0e8d5c 100644 --- a/connectivity/source/inc/calc/CTable.hxx +++ b/connectivity/source/inc/calc/CTable.hxx @@ -66,7 +66,7 @@ namespace connectivity::calc // css::lang::XUnoTunnel virtual sal_Int64 SAL_CALL getSomething( const css::uno::Sequence< sal_Int8 >& aIdentifier ) override; - static css::uno::Sequence< sal_Int8 > getUnoTunnelId(); + static const css::uno::Sequence< sal_Int8 > & getUnoTunnelId(); void construct() override; }; diff --git a/connectivity/source/inc/dbase/DIndex.hxx b/connectivity/source/inc/dbase/DIndex.hxx index a75ce918ff6c..cd18ded0cbb1 100644 --- a/connectivity/source/inc/dbase/DIndex.hxx +++ b/connectivity/source/inc/dbase/DIndex.hxx @@ -93,7 +93,7 @@ namespace connectivity::dbase // css::lang::XUnoTunnel virtual sal_Int64 SAL_CALL getSomething( const css::uno::Sequence< sal_Int8 >& aIdentifier ) override; - static css::uno::Sequence< sal_Int8 > getUnoTunnelId(); + static const css::uno::Sequence< sal_Int8 > & getUnoTunnelId(); const ODbaseTable* getTable() const { return m_pTable; } const NDXHeader& getHeader() const { return m_aHeader; } diff --git a/connectivity/source/inc/dbase/DTable.hxx b/connectivity/source/inc/dbase/DTable.hxx index 6e7b2e184c32..1ac5eccbb9cf 100644 --- a/connectivity/source/inc/dbase/DTable.hxx +++ b/connectivity/source/inc/dbase/DTable.hxx @@ -163,7 +163,7 @@ namespace connectivity::dbase // css::lang::XUnoTunnel virtual sal_Int64 SAL_CALL getSomething( const css::uno::Sequence< sal_Int8 >& aIdentifier ) override; - static css::uno::Sequence< sal_Int8 > getUnoTunnelId(); + static const css::uno::Sequence< sal_Int8 > & getUnoTunnelId(); // XAlterTable virtual void SAL_CALL alterColumnByName( const OUString& colName, const css::uno::Reference< css::beans::XPropertySet >& descriptor ) override; virtual void SAL_CALL alterColumnByIndex( sal_Int32 index, const css::uno::Reference< css::beans::XPropertySet >& descriptor ) override; diff --git a/connectivity/source/inc/file/FConnection.hxx b/connectivity/source/inc/file/FConnection.hxx index 36b095e70427..e6412992ab77 100644 --- a/connectivity/source/inc/file/FConnection.hxx +++ b/connectivity/source/inc/file/FConnection.hxx @@ -98,7 +98,7 @@ namespace connectivity::file virtual void SAL_CALL clearWarnings( ) override; //XUnoTunnel virtual sal_Int64 SAL_CALL getSomething( const css::uno::Sequence< sal_Int8 >& aIdentifier ) override; - static css::uno::Sequence< sal_Int8 > getUnoTunnelId(); + static const css::uno::Sequence< sal_Int8 > & getUnoTunnelId(); // no interface methods css::uno::Reference< css::ucb::XDynamicResultSet > getDir() const; diff --git a/connectivity/source/inc/file/FResultSet.hxx b/connectivity/source/inc/file/FResultSet.hxx index 71d222d82030..a7aa77ff2576 100644 --- a/connectivity/source/inc/file/FResultSet.hxx +++ b/connectivity/source/inc/file/FResultSet.hxx @@ -247,7 +247,7 @@ namespace connectivity::file virtual sal_Int32 SAL_CALL findColumn( const OUString& columnName ) override; // css::lang::XUnoTunnel virtual sal_Int64 SAL_CALL getSomething( const css::uno::Sequence< sal_Int8 >& aIdentifier ) override; - static css::uno::Sequence< sal_Int8 > getUnoTunnelId(); + static const css::uno::Sequence< sal_Int8 > & getUnoTunnelId(); //XEventlistener virtual void SAL_CALL disposing( const css::lang::EventObject& Source ) override; diff --git a/connectivity/source/inc/file/FTable.hxx b/connectivity/source/inc/file/FTable.hxx index 80c662ba4d38..4f925f799ca5 100644 --- a/connectivity/source/inc/file/FTable.hxx +++ b/connectivity/source/inc/file/FTable.hxx @@ -85,7 +85,7 @@ namespace connectivity::file // m_pFileStream && !m_pFileStream->IsWritable(); } // css::lang::XUnoTunnel virtual sal_Int64 SAL_CALL getSomething( const css::uno::Sequence< sal_Int8 >& aIdentifier ) override; - static css::uno::Sequence< sal_Int8 > getUnoTunnelId(); + static const css::uno::Sequence< sal_Int8 > & getUnoTunnelId(); sal_Int32 getFilePos() const { return m_nFilePos; } diff --git a/connectivity/source/inc/flat/ETable.hxx b/connectivity/source/inc/flat/ETable.hxx index 2e15040d74d1..ae283c10bcb0 100644 --- a/connectivity/source/inc/flat/ETable.hxx +++ b/connectivity/source/inc/flat/ETable.hxx @@ -94,7 +94,7 @@ namespace connectivity::flat // css::lang::XUnoTunnel virtual sal_Int64 SAL_CALL getSomething( const css::uno::Sequence< sal_Int8 >& aIdentifier ) override; - static css::uno::Sequence< sal_Int8 > getUnoTunnelId(); + static const css::uno::Sequence< sal_Int8 > & getUnoTunnelId(); OUString getEntry() const; }; diff --git a/connectivity/source/inc/hsqldb/HTable.hxx b/connectivity/source/inc/hsqldb/HTable.hxx index bc345d775c28..060784115507 100644 --- a/connectivity/source/inc/hsqldb/HTable.hxx +++ b/connectivity/source/inc/hsqldb/HTable.hxx @@ -87,7 +87,7 @@ namespace connectivity::hsqldb virtual void construct() override; // css::lang::XUnoTunnel virtual sal_Int64 SAL_CALL getSomething( const css::uno::Sequence< sal_Int8 >& aIdentifier ) override; - static css::uno::Sequence< sal_Int8 > getUnoTunnelId(); + static const css::uno::Sequence< sal_Int8 > & getUnoTunnelId(); virtual css::uno::Any SAL_CALL queryInterface( const css::uno::Type & rType ) override; //XTypeProvider diff --git a/connectivity/source/inc/mysql/YTable.hxx b/connectivity/source/inc/mysql/YTable.hxx index 534c2319accb..1cb89b4c8859 100644 --- a/connectivity/source/inc/mysql/YTable.hxx +++ b/connectivity/source/inc/mysql/YTable.hxx @@ -94,7 +94,7 @@ namespace connectivity::mysql virtual void construct() override; // css::lang::XUnoTunnel virtual sal_Int64 SAL_CALL getSomething( const css::uno::Sequence< sal_Int8 >& aIdentifier ) override; - static css::uno::Sequence< sal_Int8 > getUnoTunnelId(); + static const css::uno::Sequence< sal_Int8 > & getUnoTunnelId(); // XAlterTable virtual void SAL_CALL alterColumnByName( const OUString& colName, const css::uno::Reference< css::beans::XPropertySet >& descriptor ) override; diff --git a/connectivity/source/inc/writer/WTable.hxx b/connectivity/source/inc/writer/WTable.hxx index e19872df531d..90cdc2494411 100644 --- a/connectivity/source/inc/writer/WTable.hxx +++ b/connectivity/source/inc/writer/WTable.hxx @@ -56,7 +56,7 @@ public: // css::lang::XUnoTunnel sal_Int64 SAL_CALL getSomething(const css::uno::Sequence<sal_Int8>& rId) override; - static css::uno::Sequence<sal_Int8> getUnoTunnelId(); + static const css::uno::Sequence<sal_Int8>& getUnoTunnelId(); void construct() override; }; diff --git a/connectivity/source/sdbcx/VDescriptor.cxx b/connectivity/source/sdbcx/VDescriptor.cxx index 7800aaf075be..ce3b437d95f3 100644 --- a/connectivity/source/sdbcx/VDescriptor.cxx +++ b/connectivity/source/sdbcx/VDescriptor.cxx @@ -91,7 +91,7 @@ namespace connectivity::sdbcx } - Sequence< sal_Int8 > ODescriptor::getUnoTunnelId() + const Sequence< sal_Int8 > & ODescriptor::getUnoTunnelId() { static const comphelper::UnoIdInit implId; return implId.getSeq(); diff --git a/cui/source/dialogs/QrCodeGenDialog.cxx b/cui/source/dialogs/QrCodeGenDialog.cxx index 0e24ded70cd1..3e7b48e7af86 100644 --- a/cui/source/dialogs/QrCodeGenDialog.cxx +++ b/cui/source/dialogs/QrCodeGenDialog.cxx @@ -100,7 +100,7 @@ OString ConvertToSVGFormat(const ZXing::BitMatrix& bitmatrix) return sb.toString(); } -std::string GetBarCodeType(const int& type) +std::string GetBarCodeType(int type) { switch (type) { diff --git a/dbaccess/source/core/api/RowSet.cxx b/dbaccess/source/core/api/RowSet.cxx index 9de8f00537c3..1cf4a8f37751 100644 --- a/dbaccess/source/core/api/RowSet.cxx +++ b/dbaccess/source/core/api/RowSet.cxx @@ -425,7 +425,7 @@ sal_Int64 SAL_CALL ORowSet::getSomething( const Sequence< sal_Int8 >& rId ) return comphelper::getSomethingImpl(rId, this); } -Sequence< sal_Int8 > ORowSet::getUnoTunnelId() +const Sequence< sal_Int8 > & ORowSet::getUnoTunnelId() { static const comphelper::UnoIdInit s_Id; return s_Id.getSeq(); @@ -2903,7 +2903,7 @@ void ORowSetClone::close() return *::comphelper::OPropertyArrayUsageHelper<ORowSetClone>::getArrayHelper(); } -Sequence< sal_Int8 > ORowSetClone::getUnoTunnelId() +const Sequence< sal_Int8 > & ORowSetClone::getUnoTunnelId() { static const comphelper::UnoIdInit implId; return implId.getSeq(); diff --git a/dbaccess/source/core/api/RowSet.hxx b/dbaccess/source/core/api/RowSet.hxx index da4da6c24e01..afe49a923c26 100644 --- a/dbaccess/source/core/api/RowSet.hxx +++ b/dbaccess/source/core/api/RowSet.hxx @@ -257,7 +257,7 @@ namespace dbaccess // css::lang::XUnoTunnel virtual sal_Int64 SAL_CALL getSomething( const css::uno::Sequence< sal_Int8 >& aIdentifier ) override; - static css::uno::Sequence< sal_Int8 > getUnoTunnelId(); + static const css::uno::Sequence< sal_Int8 > & getUnoTunnelId(); // css::uno::XAggregation virtual css::uno::Any SAL_CALL queryAggregation( const css::uno::Type& aType ) override; @@ -489,7 +489,7 @@ namespace dbaccess // css::lang::XUnoTunnel virtual sal_Int64 SAL_CALL getSomething( const css::uno::Sequence< sal_Int8 >& aIdentifier ) override; - static css::uno::Sequence< sal_Int8 > getUnoTunnelId(); + static const css::uno::Sequence< sal_Int8 > & getUnoTunnelId(); // OComponentHelper virtual void SAL_CALL disposing() override; diff --git a/dbaccess/source/core/api/TableDeco.cxx b/dbaccess/source/core/api/TableDeco.cxx index abd206b6e147..92821750f9dc 100644 --- a/dbaccess/source/core/api/TableDeco.cxx +++ b/dbaccess/source/core/api/TableDeco.cxx @@ -477,7 +477,7 @@ sal_Int64 SAL_CALL ODBTableDecorator::getSomething( const Sequence< sal_Int8 >& return nRet; } -Sequence< sal_Int8 > ODBTableDecorator::getUnoTunnelId() +const Sequence< sal_Int8 > & ODBTableDecorator::getUnoTunnelId() { static const comphelper::UnoIdInit implId; return implId.getSeq(); diff --git a/dbaccess/source/core/api/querydescriptor.cxx b/dbaccess/source/core/api/querydescriptor.cxx index b9e7a0debca4..0ac6d76e3077 100644 --- a/dbaccess/source/core/api/querydescriptor.cxx +++ b/dbaccess/source/core/api/querydescriptor.cxx @@ -149,7 +149,7 @@ sal_Int64 SAL_CALL OQueryDescriptor_Base::getSomething( const Sequence< sal_Int8 return comphelper::getSomethingImpl(_rIdentifier, this); } -css::uno::Sequence<sal_Int8> OQueryDescriptor_Base::getUnoTunnelId() +const css::uno::Sequence<sal_Int8> & OQueryDescriptor_Base::getUnoTunnelId() { static const comphelper::UnoIdInit aId; return aId.getSeq(); diff --git a/dbaccess/source/core/api/querydescriptor.hxx b/dbaccess/source/core/api/querydescriptor.hxx index e0930c8335a3..e78b035dace0 100644 --- a/dbaccess/source/core/api/querydescriptor.hxx +++ b/dbaccess/source/core/api/querydescriptor.hxx @@ -78,7 +78,7 @@ public: // css::lang::XUnoTunnel virtual sal_Int64 SAL_CALL getSomething( const css::uno::Sequence< sal_Int8 >& aIdentifier ) override; virtual css::uno::Sequence<sal_Int8> SAL_CALL getImplementationId( ) override; - static css::uno::Sequence< sal_Int8 > getUnoTunnelId(); + static const css::uno::Sequence< sal_Int8 > & getUnoTunnelId(); // css::lang::XServiceInfo diff --git a/dbaccess/source/core/api/table.cxx b/dbaccess/source/core/api/table.cxx index 50467cfa0c2e..f9a1dffb956a 100644 --- a/dbaccess/source/core/api/table.cxx +++ b/dbaccess/source/core/api/table.cxx @@ -315,7 +315,7 @@ sal_Int64 SAL_CALL ODBTable::getSomething( const Sequence< sal_Int8 >& rId ) comphelper::FallbackToGetSomethingOf<OTable_Base>{}); } -Sequence< sal_Int8 > ODBTable::getUnoTunnelId() +const Sequence< sal_Int8 > & ODBTable::getUnoTunnelId() { static const comphelper::UnoIdInit s_Id; return s_Id.getSeq(); diff --git a/dbaccess/source/core/dataaccess/ContentHelper.cxx b/dbaccess/source/core/dataaccess/ContentHelper.cxx index 1623a579471b..a297abf66ecc 100644 --- a/dbaccess/source/core/dataaccess/ContentHelper.cxx +++ b/dbaccess/source/core/dataaccess/ContentHelper.cxx @@ -104,7 +104,7 @@ css::uno::Sequence< OUString > SAL_CALL OContentHelper::getSupportedServiceNames } -css::uno::Sequence<sal_Int8> OContentHelper::getUnoTunnelId() +const css::uno::Sequence<sal_Int8> & OContentHelper::getUnoTunnelId() { static const comphelper::UnoIdInit aId; return aId.getSeq(); diff --git a/dbaccess/source/core/dataaccess/databasecontext.cxx b/dbaccess/source/core/dataaccess/databasecontext.cxx index 703553913fcc..471bdd8ad399 100644 --- a/dbaccess/source/core/dataaccess/databasecontext.cxx +++ b/dbaccess/source/core/dataaccess/databasecontext.cxx @@ -712,7 +712,7 @@ sal_Int64 SAL_CALL ODatabaseContext::getSomething( const Sequence< sal_Int8 >& r return comphelper::getSomethingImpl(rId, this); } -Sequence< sal_Int8 > ODatabaseContext::getUnoTunnelId() +const Sequence< sal_Int8 > & ODatabaseContext::getUnoTunnelId() { static const comphelper::UnoIdInit implId; return implId.getSeq(); diff --git a/dbaccess/source/core/inc/ContentHelper.hxx b/dbaccess/source/core/inc/ContentHelper.hxx index 5168f1307824..004b785ef185 100644 --- a/dbaccess/source/core/inc/ContentHelper.hxx +++ b/dbaccess/source/core/inc/ContentHelper.hxx @@ -157,7 +157,7 @@ namespace dbaccess // css::lang::XUnoTunnel virtual sal_Int64 SAL_CALL getSomething( const css::uno::Sequence< sal_Int8 >& aIdentifier ) override; - static css::uno::Sequence< sal_Int8 > getUnoTunnelId(); + static const css::uno::Sequence< sal_Int8 > & getUnoTunnelId(); // css::container::XChild virtual css::uno::Reference< css::uno::XInterface > SAL_CALL getParent( ) override; diff --git a/dbaccess/source/core/inc/TableDeco.hxx b/dbaccess/source/core/inc/TableDeco.hxx index 5e2cb214fb8a..e40fac80290c 100644 --- a/dbaccess/source/core/inc/TableDeco.hxx +++ b/dbaccess/source/core/inc/TableDeco.hxx @@ -145,7 +145,7 @@ namespace dbaccess virtual void SAL_CALL setName( const OUString& aName ) override; // css::lang::XUnoTunnel virtual sal_Int64 SAL_CALL getSomething( const css::uno::Sequence< sal_Int8 >& aIdentifier ) override; - static css::uno::Sequence< sal_Int8 > getUnoTunnelId(); + static const css::uno::Sequence< sal_Int8 > & getUnoTunnelId(); // XColumnsSupplier virtual css::uno::Reference< css::container::XNameAccess > SAL_CALL getColumns( ) override; diff --git a/dbaccess/source/core/inc/databasecontext.hxx b/dbaccess/source/core/inc/databasecontext.hxx index 2f8924f9f837..e15585c819d1 100644 --- a/dbaccess/source/core/inc/databasecontext.hxx +++ b/dbaccess/source/core/inc/databasecontext.hxx @@ -158,7 +158,7 @@ public: // css::lang::XUnoTunnel virtual sal_Int64 SAL_CALL getSomething( const css::uno::Sequence< sal_Int8 >& aIdentifier ) override; - static css::uno::Sequence< sal_Int8 > getUnoTunnelId(); + static const css::uno::Sequence< sal_Int8 > & getUnoTunnelId(); void registerDatabaseDocument( ODatabaseModelImpl& _rModelImpl); void revokeDatabaseDocument( const ODatabaseModelImpl& _rModelImpl); diff --git a/dbaccess/source/core/inc/table.hxx b/dbaccess/source/core/inc/table.hxx index 069579c632e3..8c29bff44772 100644 --- a/dbaccess/source/core/inc/table.hxx +++ b/dbaccess/source/core/inc/table.hxx @@ -114,7 +114,7 @@ namespace dbaccess //XTypeProvider virtual css::uno::Sequence< css::uno::Type > SAL_CALL getTypes( ) override; virtual css::uno::Sequence< sal_Int8 > SAL_CALL getImplementationId() override; - static css::uno::Sequence< sal_Int8 > getUnoTunnelId(); + static const css::uno::Sequence< sal_Int8 > & getUnoTunnelId(); // css::lang::XServiceInfo DECLARE_SERVICE_INFO(); diff --git a/dbaccess/source/ui/inc/JoinExchange.hxx b/dbaccess/source/ui/inc/JoinExchange.hxx index 73f9ea884540..7401ec886e44 100644 --- a/dbaccess/source/ui/inc/JoinExchange.hxx +++ b/dbaccess/source/ui/inc/JoinExchange.hxx @@ -47,7 +47,7 @@ namespace dbaui virtual void SAL_CALL release( ) noexcept override; // XUnoTunnel - static css::uno::Sequence< sal_Int8 > getUnoTunnelId(); + static const css::uno::Sequence< sal_Int8 > & getUnoTunnelId(); virtual sal_Int64 SAL_CALL getSomething( const css::uno::Sequence< sal_Int8 >& _rIdentifier ) override; static OJoinExchangeData GetSourceDescription(const css::uno::Reference< css::datatransfer::XTransferable >& _rxObject); diff --git a/dbaccess/source/ui/querydesign/JoinExchange.cxx b/dbaccess/source/ui/querydesign/JoinExchange.cxx index 9a06fa7ab488..0dc88e2cc794 100644 --- a/dbaccess/source/ui/querydesign/JoinExchange.cxx +++ b/dbaccess/source/ui/querydesign/JoinExchange.cxx @@ -61,7 +61,7 @@ namespace dbaui return aReturn; } - Sequence< sal_Int8 > OJoinExchObj::getUnoTunnelId() + const Sequence< sal_Int8 > & OJoinExchObj::getUnoTunnelId() { static const comphelper::UnoIdInit implId; return implId.getSeq(); diff --git a/forms/source/richtext/richtextmodel.cxx b/forms/source/richtext/richtextmodel.cxx index 1f5037b62d71..9f4266be1710 100644 --- a/forms/source/richtext/richtextmodel.cxx +++ b/forms/source/richtext/richtextmodel.cxx @@ -559,7 +559,7 @@ namespace frm } - Sequence<sal_Int8> ORichTextModel::getUnoTunnelId() + const Sequence<sal_Int8> & ORichTextModel::getUnoTunnelId() { static const comphelper::UnoIdInit aId; return aId.getSeq(); diff --git a/forms/source/richtext/richtextmodel.hxx b/forms/source/richtext/richtextmodel.hxx index 3dc0987b33b3..cf0bae7db435 100644 --- a/forms/source/richtext/richtextmodel.hxx +++ b/forms/source/richtext/richtextmodel.hxx @@ -126,7 +126,7 @@ namespace frm // XUnoTunnel virtual sal_Int64 SAL_CALL getSomething( const css::uno::Sequence< sal_Int8 >& aIdentifier ) override; - static css::uno::Sequence<sal_Int8> getUnoTunnelId(); + static const css::uno::Sequence<sal_Int8> & getUnoTunnelId(); // XModifyBroadcaster virtual void SAL_CALL addModifyListener( const css::uno::Reference< css::util::XModifyListener >& aListener ) override; diff --git a/include/comphelper/accimplaccess.hxx b/include/comphelper/accimplaccess.hxx index 4aec719eac8b..e716d4d18905 100644 --- a/include/comphelper/accimplaccess.hxx +++ b/include/comphelper/accimplaccess.hxx @@ -63,7 +63,7 @@ namespace comphelper virtual sal_Int64 SAL_CALL getSomething( const css::uno::Sequence< sal_Int8 >& _rIdentifier ) override; public: - COMPHELPER_DLLPRIVATE static css::uno::Sequence<sal_Int8> getUnoTunnelId(); + COMPHELPER_DLLPRIVATE static const css::uno::Sequence<sal_Int8> & getUnoTunnelId(); }; } // namespace comphelper diff --git a/include/connectivity/ConnectionWrapper.hxx b/include/connectivity/ConnectionWrapper.hxx index b621cd041b51..8eac6a7b96a2 100644 --- a/include/connectivity/ConnectionWrapper.hxx +++ b/include/connectivity/ConnectionWrapper.hxx @@ -67,7 +67,7 @@ namespace connectivity // css::lang::XUnoTunnel virtual sal_Int64 SAL_CALL getSomething( const css::uno::Sequence< sal_Int8 >& aIdentifier ) override; - static css::uno::Sequence< sal_Int8 > getUnoTunnelId(); + static const css::uno::Sequence< sal_Int8 > & getUnoTunnelId(); /** method to create unique ids @param _rURL The URL. diff --git a/include/connectivity/TTableHelper.hxx b/include/connectivity/TTableHelper.hxx index a322964bb795..e987241a6847 100644 --- a/include/connectivity/TTableHelper.hxx +++ b/include/connectivity/TTableHelper.hxx @@ -149,7 +149,7 @@ namespace connectivity virtual OUString SAL_CALL getName() override; // To retrieve the table name only without the schema - OUString getTableName(); + const OUString & getTableName(); // helper method to get key properties std::shared_ptr<sdbcx::KeyProperties> getKeyProperties(const OUString& _sName) const; diff --git a/include/connectivity/sdbcx/VDescriptor.hxx b/include/connectivity/sdbcx/VDescriptor.hxx index 4127a423615a..3147a5187fa7 100644 --- a/include/connectivity/sdbcx/VDescriptor.hxx +++ b/include/connectivity/sdbcx/VDescriptor.hxx @@ -70,7 +70,7 @@ namespace connectivity::sdbcx // css::lang::XUnoTunnel virtual sal_Int64 SAL_CALL getSomething( const css::uno::Sequence< sal_Int8 >& aIdentifier ) override; - static css::uno::Sequence< sal_Int8 > getUnoTunnelId(); + static const css::uno::Sequence< sal_Int8 > & getUnoTunnelId(); // retrieves the ODescriptor implementation of a given UNO component, and returns its ->isNew flag static bool isNew( const css::uno::Reference< css::uno::XInterface >& _rxDescriptor ); diff --git a/include/oox/export/chartexport.hxx b/include/oox/export/chartexport.hxx index 3e12e5de725a..6a40254f6491 100644 --- a/include/oox/export/chartexport.hxx +++ b/include/oox/export/chartexport.hxx @@ -112,7 +112,7 @@ public: /// Indicates whether the container has a label with index specified by nIndex. bool hasLabel(sal_Int32 nIndex) const; /// Returns the address of the cell[range] from which label contents are sourced. - OUString getRange() const; + const OUString & getRange() const; /// Sets the address of the cell[range] from which label contents are sourced. void setRange(const OUString& rRange); diff --git a/include/oox/shape/ShapeContextHandler.hxx b/include/oox/shape/ShapeContextHandler.hxx index d79ae4d17a1f..2e108d8cd4f2 100644 --- a/include/oox/shape/ShapeContextHandler.hxx +++ b/include/oox/shape/ShapeContextHandler.hxx @@ -97,7 +97,7 @@ public: void setPosition(const css::awt::Point& rPosition); const bool& getFullWPGSupport() { return m_bFullWPGSUpport; } - void setFullWPGSupport(const bool& rbUse) { m_bFullWPGSUpport = rbUse; } + void setFullWPGSupport(bool bUse) { m_bFullWPGSUpport = bUse; } bool isWordProcessingGroupShape() const { return mxWpgContext ? true : false; } diff --git a/include/sfx2/thumbnailview.hxx b/include/sfx2/thumbnailview.hxx index bbdee870ac52..453f3c9c5b9b 100644 --- a/include/sfx2/thumbnailview.hxx +++ b/include/sfx2/thumbnailview.hxx @@ -254,7 +254,7 @@ protected: virtual css::uno::Reference< css::accessibility::XAccessible > CreateAccessible() override; - css::uno::Reference<css::accessibility::XAccessible> getAccessible() const; + const css::uno::Reference<css::accessibility::XAccessible> & getAccessible() const; protected: diff --git a/include/sfx2/weldutils.hxx b/include/sfx2/weldutils.hxx index aaa2fe08a2e3..8f230cee5283 100644 --- a/include/sfx2/weldutils.hxx +++ b/include/sfx2/weldutils.hxx @@ -56,7 +56,7 @@ public: css::uno::Reference<css::frame::XToolbarController> GetControllerForCommand(const OUString& rCommand) const; - css::uno::Reference<css::frame::XFrame> GetFrame() const { return m_xFrame; } + const css::uno::Reference<css::frame::XFrame>& GetFrame() const { return m_xFrame; } void dispose(); ~ToolbarUnoDispatcher(); diff --git a/include/svtools/embedhlp.hxx b/include/svtools/embedhlp.hxx index 9ba2a0166c2b..9d4cb8e85c39 100644 --- a/include/svtools/embedhlp.hxx +++ b/include/svtools/embedhlp.hxx @@ -110,7 +110,7 @@ public: bool IsLocked() const; void SetIsProtectedHdl(const Link<LinkParamNone*, bool>& rProtectedHdl); - Link<LinkParamNone*, bool> GetIsProtectedHdl() const; + const Link<LinkParamNone*, bool> & GetIsProtectedHdl() const; bool IsChart() const; diff --git a/include/svx/colorbox.hxx b/include/svx/colorbox.hxx index 0dc858d1e67d..3775fc187fd2 100644 --- a/include/svx/colorbox.hxx +++ b/include/svx/colorbox.hxx @@ -62,7 +62,7 @@ public: Color const& GetSelectEntryColor() const { return m_aSelectedColor.m_aColor; } NamedColor GetSelectedEntry() const { return m_aSelectedColor.ToNamedColor(); } - svx::NamedThemedColor GetSelectedEntryThemedColor() const { return m_aSelectedColor; } + const svx::NamedThemedColor& GetSelectedEntryThemedColor() const { return m_aSelectedColor; } void SelectEntry(const NamedColor& rColor); void SelectEntry(const Color& rColor); diff --git a/include/svx/sxmtpitm.hxx b/include/svx/sxmtpitm.hxx index 2445909e2fd4..60e17d445d61 100644 --- a/include/svx/sxmtpitm.hxx +++ b/include/svx/sxmtpitm.hxx @@ -37,7 +37,7 @@ public: virtual bool QueryValue( css::uno::Any& rVal, sal_uInt8 nMemberId = 0 ) const override; virtual bool PutValue( const css::uno::Any& rVal, sal_uInt8 nMemberId ) override; - static OUString GetValueTextByPos(sal_uInt16 nPos); + static const OUString & GetValueTextByPos(sal_uInt16 nPos); virtual bool GetPresentation(SfxItemPresentation ePres, MapUnit eCoreMetric, MapUnit ePresMetric, OUString& rText, const IntlWrapper&) const override; }; diff --git a/include/vcl/graph.hxx b/include/vcl/graph.hxx index abff7521381f..c97ee23d41c1 100644 --- a/include/vcl/graph.hxx +++ b/include/vcl/graph.hxx @@ -189,7 +189,7 @@ public: /// Get the page number of the multi-page source this Graphic is rendered from. sal_Int32 getPageNumber() const; - static css::uno::Sequence<sal_Int8> getUnoTunnelId(); + static const css::uno::Sequence<sal_Int8> & getUnoTunnelId(); }; namespace std { diff --git a/oox/source/export/chartexport.cxx b/oox/source/export/chartexport.cxx index dde654497cf8..1d6dfec23f71 100644 --- a/oox/source/export/chartexport.cxx +++ b/oox/source/export/chartexport.cxx @@ -503,7 +503,7 @@ bool DataLabelsRange::hasLabel(sal_Int32 nIndex) const return maLabels.find(nIndex) != maLabels.end(); } -OUString DataLabelsRange::getRange() const +const OUString & DataLabelsRange::getRange() const { return maRange; } diff --git a/oox/source/shape/WpgContext.hxx b/oox/source/shape/WpgContext.hxx index 414e5f819bfe..643a2a49357b 100644 --- a/oox/source/shape/WpgContext.hxx +++ b/oox/source/shape/WpgContext.hxx @@ -29,7 +29,7 @@ public: const oox::drawingml::ShapePtr& getShape() const { return mpShape; } const bool& isFullWPGSupport() const { return m_bFullWPGSupport; }; - void setFullWPGSupport(const bool& rbUse) { m_bFullWPGSupport = rbUse; }; + void setFullWPGSupport(bool bUse) { m_bFullWPGSupport = bUse; }; private: oox::drawingml::ShapePtr mpShape; diff --git a/package/inc/ZipPackage.hxx b/package/inc/ZipPackage.hxx index 729d025e089d..e6cf614ad503 100644 --- a/package/inc/ZipPackage.hxx +++ b/package/inc/ZipPackage.hxx @@ -147,7 +147,7 @@ public: // XUnoTunnel virtual sal_Int64 SAL_CALL getSomething( const css::uno::Sequence< sal_Int8 >& aIdentifier ) override; /// @throws css::uno::RuntimeException - static css::uno::Sequence < sal_Int8 > getUnoTunnelId(); + static const css::uno::Sequence < sal_Int8 > & getUnoTunnelId(); // XPropertySet virtual css::uno::Reference< css::beans::XPropertySetInfo > SAL_CALL getPropertySetInfo( ) override; virtual void SAL_CALL setPropertyValue( const OUString& aPropertyName, const css::uno::Any& aValue ) override; diff --git a/package/inc/ZipPackageFolder.hxx b/package/inc/ZipPackageFolder.hxx index 21ff8343c252..82582293158f 100644 --- a/package/inc/ZipPackageFolder.hxx +++ b/package/inc/ZipPackageFolder.hxx @@ -91,7 +91,7 @@ public: ZipContentInfo& doGetByName( const OUString& aName ); - static css::uno::Sequence < sal_Int8 > getUnoTunnelId(); + static const css::uno::Sequence < sal_Int8 > & getUnoTunnelId(); void setPackageFormat_Impl( sal_Int32 nFormat ) { m_nFormat = nFormat; } void setRemoveOnInsertMode_Impl( bool bRemove ) { mbAllowRemoveOnInsert = bRemove; } diff --git a/package/inc/ZipPackageStream.hxx b/package/inc/ZipPackageStream.hxx index 20ee2cab7275..aa150717474d 100644 --- a/package/inc/ZipPackageStream.hxx +++ b/package/inc/ZipPackageStream.hxx @@ -137,7 +137,7 @@ public: void setZipEntryOnLoading( const ZipEntry &rInEntry); void successfullyWritten( ZipEntry const *pEntry ); - static css::uno::Sequence < sal_Int8 > getUnoTunnelId(); + static const css::uno::Sequence < sal_Int8 > & getUnoTunnelId(); // XActiveDataSink virtual void SAL_CALL setInputStream( const css::uno::Reference< css::io::XInputStream >& aStream ) override; diff --git a/package/source/zippackage/ZipPackage.cxx b/package/source/zippackage/ZipPackage.cxx index e00c47d10a5f..c134a9d94c5d 100644 --- a/package/source/zippackage/ZipPackage.cxx +++ b/package/source/zippackage/ZipPackage.cxx @@ -1661,7 +1661,7 @@ sal_Bool SAL_CALL ZipPackage::supportsService( OUString const & rServiceName ) return cppu::supportsService(this, rServiceName); } -Sequence< sal_Int8 > ZipPackage::getUnoTunnelId() +const Sequence< sal_Int8 > & ZipPackage::getUnoTunnelId() { static const comphelper::UnoIdInit implId; return implId.getSeq(); diff --git a/package/source/zippackage/ZipPackageFolder.cxx b/package/source/zippackage/ZipPackageFolder.cxx index b65c9c697788..118ec39923c0 100644 --- a/package/source/zippackage/ZipPackageFolder.cxx +++ b/package/source/zippackage/ZipPackageFolder.cxx @@ -143,7 +143,7 @@ void ZipPackageFolder::setChildStreamsTypeByExtension( const beans::StringPair& } } -css::uno::Sequence < sal_Int8 > ZipPackageFolder::getUnoTunnelId() +const css::uno::Sequence < sal_Int8 > & ZipPackageFolder::getUnoTunnelId() { static const comphelper::UnoIdInit lcl_CachedImplId; return lcl_CachedImplId.getSeq(); diff --git a/package/source/zippackage/ZipPackageStream.cxx b/package/source/zippackage/ZipPackageStream.cxx index b8157839bbba..f2ec696b5cc8 100644 --- a/package/source/zippackage/ZipPackageStream.cxx +++ b/package/source/zippackage/ZipPackageStream.cxx @@ -71,7 +71,7 @@ using namespace cppu; #define THROW_WHERE "" #endif -css::uno::Sequence < sal_Int8 > ZipPackageStream::getUnoTunnelId() +const css::uno::Sequence < sal_Int8 > & ZipPackageStream::getUnoTunnelId() { static const comphelper::UnoIdInit lcl_CachedImplId; return lcl_CachedImplId.getSeq(); diff --git a/reportdesign/inc/ReportDefinition.hxx b/reportdesign/inc/ReportDefinition.hxx index 50973000d493..33d7cd2d8dee 100644 --- a/reportdesign/inc/ReportDefinition.hxx +++ b/reportdesign/inc/ReportDefinition.hxx @@ -188,7 +188,7 @@ namespace reportdesign public: //TTTT Needed? Or same as above? - static css::uno::Sequence< sal_Int8 > getUnoTunnelId(); + static const css::uno::Sequence< sal_Int8 > & getUnoTunnelId(); static std::shared_ptr<rptui::OReportModel> getSdrModel(const css::uno::Reference< css::report::XReportDefinition >& _xReportDefinition); private: diff --git a/reportdesign/source/core/api/ReportDefinition.cxx b/reportdesign/source/core/api/ReportDefinition.cxx index 9954b50c359e..b74ded0d9b32 100644 --- a/reportdesign/source/core/api/ReportDefinition.cxx +++ b/reportdesign/source/core/api/ReportDefinition.cxx @@ -1959,7 +1959,7 @@ uno::Sequence< sal_Int8 > SAL_CALL OReportDefinition::getImplementationId( ) return css::uno::Sequence<sal_Int8>(); } -uno::Sequence< sal_Int8 > OReportDefinition::getUnoTunnelId() +const uno::Sequence< sal_Int8 > & OReportDefinition::getUnoTunnelId() { static const comphelper::UnoIdInit implId; return implId.getSeq(); diff --git a/reportdesign/source/core/api/Section.cxx b/reportdesign/source/core/api/Section.cxx index 62795c756ab2..d0e40aff411b 100644 --- a/reportdesign/source/core/api/Section.cxx +++ b/reportdesign/source/core/api/Section.cxx @@ -570,7 +570,7 @@ sal_Int64 OSection::getSomething( const uno::Sequence< sal_Int8 > & rId ) return (m_xDrawPage_Tunnel.is()) ? m_xDrawPage_Tunnel->getSomething(rId) : 0; } -uno::Sequence< sal_Int8 > OSection::getUnoTunnelId() +const uno::Sequence< sal_Int8 > & OSection::getUnoTunnelId() { static const comphelper::UnoIdInit implId; return implId.getSeq(); diff --git a/reportdesign/source/core/inc/Section.hxx b/reportdesign/source/core/inc/Section.hxx index b5a18dfdf3e5..7afbf9e91d0f 100644 --- a/reportdesign/source/core/inc/Section.hxx +++ b/reportdesign/source/core/inc/Section.hxx @@ -221,7 +221,7 @@ namespace reportdesign // css::lang::XUnoTunnel virtual sal_Int64 SAL_CALL getSomething( const css::uno::Sequence< sal_Int8 >& aIdentifier ) override; - static css::uno::Sequence< sal_Int8 > getUnoTunnelId(); + static const css::uno::Sequence< sal_Int8 > & getUnoTunnelId(); void notifyElementAdded(const css::uno::Reference< css::drawing::XShape >& xShape); void notifyElementRemoved(const css::uno::Reference< css::drawing::XShape >& xShape); diff --git a/sc/source/filter/inc/SparklineFragment.hxx b/sc/source/filter/inc/SparklineFragment.hxx index d6e123036816..6ed4bad49bc5 100644 --- a/sc/source/filter/inc/SparklineFragment.hxx +++ b/sc/source/filter/inc/SparklineFragment.hxx @@ -44,7 +44,7 @@ public: { } - std::shared_ptr<sc::SparklineGroup> getSparklineGroup() { return m_pSparklineGroup; } + const std::shared_ptr<sc::SparklineGroup>& getSparklineGroup() { return m_pSparklineGroup; } std::vector<Sparkline>& getSparklines() { return m_aSparklines; } }; diff --git a/sd/source/ui/inc/tools/GraphicSizeCheck.hxx b/sd/source/ui/inc/tools/GraphicSizeCheck.hxx index ea0faf0178d0..44f78e4eb159 100644 --- a/sd/source/ui/inc/tools/GraphicSizeCheck.hxx +++ b/sd/source/ui/inc/tools/GraphicSizeCheck.hxx @@ -36,7 +36,7 @@ public: GraphicSizeViolation(sal_Int32 nDPI, SdrGrafObj* pGraphicObject); bool check(); - OUString getGraphicName(); + const OUString& getGraphicName(); SdrGrafObj* getObject() const { return m_pGraphicObject; } diff --git a/sd/source/ui/tools/GraphicSizeCheck.cxx b/sd/source/ui/tools/GraphicSizeCheck.cxx index b9456d7c28a7..492a2d70b23e 100644 --- a/sd/source/ui/tools/GraphicSizeCheck.cxx +++ b/sd/source/ui/tools/GraphicSizeCheck.cxx @@ -111,7 +111,7 @@ bool GraphicSizeViolation::check() return isDPITooLow() || isDPITooHigh(); } -OUString GraphicSizeViolation::getGraphicName() { return m_pGraphicObject->GetName(); } +const OUString& GraphicSizeViolation::getGraphicName() { return m_pGraphicObject->GetName(); } namespace { diff --git a/sfx2/source/control/thumbnailview.cxx b/sfx2/source/control/thumbnailview.cxx index 3e85c4c911fc..a678df5b18ac 100644 --- a/sfx2/source/control/thumbnailview.cxx +++ b/sfx2/source/control/thumbnailview.cxx @@ -328,7 +328,7 @@ css::uno::Reference< css::accessibility::XAccessible > ThumbnailView::CreateAcce return mxAccessible; } -css::uno::Reference< css::accessibility::XAccessible > ThumbnailView::getAccessible() const +const css::uno::Reference< css::accessibility::XAccessible > & ThumbnailView::getAccessible() const { return mxAccessible; } diff --git a/svtools/source/misc/embedhlp.cxx b/svtools/source/misc/embedhlp.cxx index 6e56dc3137e8..f384eb352f90 100644 --- a/svtools/source/misc/embedhlp.cxx +++ b/svtools/source/misc/embedhlp.cxx @@ -440,7 +440,7 @@ void EmbeddedObjectRef::SetIsProtectedHdl(const Link<LinkParamNone*, bool>& rPro mpImpl->m_aIsProtectedHdl = rProtectedHdl; } -Link<LinkParamNone*, bool> EmbeddedObjectRef::GetIsProtectedHdl() const +const Link<LinkParamNone*, bool> & EmbeddedObjectRef::GetIsProtectedHdl() const { return mpImpl->m_aIsProtectedHdl; } diff --git a/svx/source/svdraw/svdattr.cxx b/svx/source/svdraw/svdattr.cxx index da041583f4c9..920b38882024 100644 --- a/svx/source/svdraw/svdattr.cxx +++ b/svx/source/svdraw/svdattr.cxx @@ -1601,7 +1601,7 @@ SdrMeasureTextHPosItem* SdrMeasureTextHPosItem::Clone(SfxItemPool* /*pPool*/) co sal_uInt16 SdrMeasureTextHPosItem::GetValueCount() const { return 4; } -OUString SdrMeasureTextHPosItem::GetValueTextByPos(sal_uInt16 nPos) +const OUString & SdrMeasureTextHPosItem::GetValueTextByPos(sal_uInt16 nPos) { static std::array<OUString, 4> aMeasureTextHPosItem { diff --git a/sw/inc/expfld.hxx b/sw/inc/expfld.hxx index d241c9adb665..92ef8136dcde 100644 --- a/sw/inc/expfld.hxx +++ b/sw/inc/expfld.hxx @@ -319,7 +319,7 @@ public: void applyFieldContent( const OUString& rNewFieldContent ); bool isFormField() const; - css::uno::Sequence<css::beans::PropertyValue> getGrabBagParams() const { return maGrabBag; } + const css::uno::Sequence<css::beans::PropertyValue> & getGrabBagParams() const { return maGrabBag; } virtual OUString GetFieldName() const override; diff --git a/sw/inc/fldbas.hxx b/sw/inc/fldbas.hxx index 5a256cb1884d..21a2c1000c0c 100644 --- a/sw/inc/fldbas.hxx +++ b/sw/inc/fldbas.hxx @@ -391,7 +391,7 @@ public: /// Is this field clickable? bool IsClickable() const; virtual void dumpAsXml(xmlTextWriterPtr pWriter) const; - OUString GetTitle() const { return m_aTitle; } + const OUString & GetTitle() const { return m_aTitle; } void SetTitle(const OUString& rTitle) { m_aTitle = rTitle; } }; diff --git a/sw/inc/formatcontentcontrol.hxx b/sw/inc/formatcontentcontrol.hxx index ba29a6825523..bb92454ffd09 100644 --- a/sw/inc/formatcontentcontrol.hxx +++ b/sw/inc/formatcontentcontrol.hxx @@ -91,7 +91,7 @@ public: void NotifyChangeTextNode(SwTextNode* pTextNode); - css::uno::WeakReference<css::text::XTextContent> GetXContentControl() const + const css::uno::WeakReference<css::text::XTextContent>& GetXContentControl() const { return m_wXContentControl; } diff --git a/sw/inc/frmfmt.hxx b/sw/inc/frmfmt.hxx index 4a5f2f1e8e87..bc0944fa39fe 100644 --- a/sw/inc/frmfmt.hxx +++ b/sw/inc/frmfmt.hxx @@ -223,7 +223,7 @@ public: OUString GetObjTitle() const; void SetObjTitle( const OUString& rTitle, bool bBroadcast = false ); - OUString GetObjTooltip() const; + const OUString & GetObjTooltip() const; void SetObjTooltip(const OUString& rTooltip); OUString GetObjDescription() const; diff --git a/sw/source/core/graphic/GraphicSizeCheck.cxx b/sw/source/core/graphic/GraphicSizeCheck.cxx index d01436e3fb6b..9fe2de879777 100644 --- a/sw/source/core/graphic/GraphicSizeCheck.cxx +++ b/sw/source/core/graphic/GraphicSizeCheck.cxx @@ -54,7 +54,7 @@ bool GraphicSizeViolation::check() return isDPITooLow() || isDPITooHigh(); } -OUString GraphicSizeViolation::getGraphicName() +const OUString& GraphicSizeViolation::getGraphicName() { return m_pGraphicNode->GetFlyFormat()->GetName(); } diff --git a/sw/source/core/inc/GraphicSizeCheck.hxx b/sw/source/core/inc/GraphicSizeCheck.hxx index 983d549734fe..a70b1c756d66 100644 --- a/sw/source/core/inc/GraphicSizeCheck.hxx +++ b/sw/source/core/inc/GraphicSizeCheck.hxx @@ -34,7 +34,7 @@ public: GraphicSizeViolation(sal_Int32 nDPI, const SwGrfNode* pGraphicNode); bool check(); - OUString getGraphicName(); + const OUString& getGraphicName(); bool isDPITooLow() { return m_nDPIX < m_nLowDPILimit || m_nDPIY < m_nLowDPILimit; } diff --git a/sw/source/core/inc/unocontentcontrol.hxx b/sw/source/core/inc/unocontentcontrol.hxx index 631ccdaf02d3..29f9d5168ba5 100644 --- a/sw/source/core/inc/unocontentcontrol.hxx +++ b/sw/source/core/inc/unocontentcontrol.hxx @@ -81,7 +81,7 @@ public: /// Initializes params with position of the attribute content (without CH_TXTATR). bool SetContentRange(SwTextNode*& rpNode, sal_Int32& rStart, sal_Int32& rEnd) const; - css::uno::Reference<css::text::XText> GetParentText() const; + const css::uno::Reference<css::text::XText>& GetParentText() const; bool CheckForOwnMemberContentControl(const SwPaM& rPam, const bool bAbsorb); diff --git a/sw/source/core/layout/atrfrm.cxx b/sw/source/core/layout/atrfrm.cxx index 7db55da058d0..cf8d93ac3acf 100644 --- a/sw/source/core/layout/atrfrm.cxx +++ b/sw/source/core/layout/atrfrm.cxx @@ -3195,7 +3195,7 @@ void SwFlyFrameFormat::SetObjTooltip(const OUString& rTooltip) msTooltip = rTooltip; } -OUString SwFlyFrameFormat::GetObjTooltip() const +const OUString & SwFlyFrameFormat::GetObjTooltip() const { return msTooltip; } diff --git a/sw/source/core/unocore/unocontentcontrol.cxx b/sw/source/core/unocore/unocontentcontrol.cxx index bcd3be6de895..93b7c976ae0d 100644 --- a/sw/source/core/unocore/unocontentcontrol.cxx +++ b/sw/source/core/unocore/unocontentcontrol.cxx @@ -208,7 +208,7 @@ void SwXContentControl::Impl::Notify(const SfxHint& rHint) m_EventListeners.disposeAndClear(aGuard, aEvent); } -uno::Reference<text::XText> SwXContentControl::GetParentText() const +const uno::Reference<text::XText>& SwXContentControl::GetParentText() const { return m_pImpl->m_xParentText; } diff --git a/sw/source/uibase/inc/break.hxx b/sw/source/uibase/inc/break.hxx index 3dbb4c681039..79cf295eb353 100644 --- a/sw/source/uibase/inc/break.hxx +++ b/sw/source/uibase/inc/break.hxx @@ -61,7 +61,7 @@ public: const OUString& GetTemplateName() const { return m_aTemplate; } sal_uInt16 GetKind() const { return nKind; } const ::std::optional<sal_uInt16>& GetPageNumber() const { return oPgNum; } - std::optional<SwLineBreakClear> GetClear() const { return m_eClear; } + const std::optional<SwLineBreakClear>& GetClear() const { return m_eClear; } }; #endif diff --git a/toolkit/source/controls/grid/gridcolumn.cxx b/toolkit/source/controls/grid/gridcolumn.cxx index 0db9b50a5d75..11a03e647236 100644 --- a/toolkit/source/controls/grid/gridcolumn.cxx +++ b/toolkit/source/controls/grid/gridcolumn.cxx @@ -282,7 +282,7 @@ namespace toolkit } - Sequence< sal_Int8 > GridColumn::getUnoTunnelId() noexcept + const Sequence< sal_Int8 > & GridColumn::getUnoTunnelId() noexcept { static const comphelper::UnoIdInit aId; return aId.getSeq(); diff --git a/toolkit/source/controls/grid/gridcolumn.hxx b/toolkit/source/controls/grid/gridcolumn.hxx index cd3a8c5cd531..3f082f63c9c5 100644 --- a/toolkit/source/controls/grid/gridcolumn.hxx +++ b/toolkit/source/controls/grid/gridcolumn.hxx @@ -80,7 +80,7 @@ public: // XUnoTunnel and friends virtual sal_Int64 SAL_CALL getSomething( const css::uno::Sequence< sal_Int8 >& i_identifier ) override; - static css::uno::Sequence< sal_Int8 > getUnoTunnelId() noexcept; + static const css::uno::Sequence< sal_Int8 > & getUnoTunnelId() noexcept; // attribute access void setIndex( sal_Int32 const i_index ); diff --git a/ucb/source/ucp/webdav-curl/DAVResourceAccess.hxx b/ucb/source/ucp/webdav-curl/DAVResourceAccess.hxx index df27713a936d..0e5231934e5d 100644 --- a/ucb/source/ucp/webdav-curl/DAVResourceAccess.hxx +++ b/ucb/source/ucp/webdav-curl/DAVResourceAccess.hxx @@ -73,7 +73,7 @@ public: const OUString & getURL() const { return m_aURL; } - rtl::Reference< DAVSessionFactory > getSessionFactory() const + const rtl::Reference< DAVSessionFactory > & getSessionFactory() const { return m_xSessionFactory; } // DAV methods diff --git a/vcl/source/gdi/graph.cxx b/vcl/source/gdi/graph.cxx index 7141e2e2cb4f..c56ddb7204eb 100644 --- a/vcl/source/gdi/graph.cxx +++ b/vcl/source/gdi/graph.cxx @@ -556,7 +556,7 @@ OString Graphic::getUniqueID() const return aUniqueString; } -css::uno::Sequence<sal_Int8> Graphic::getUnoTunnelId() { +const css::uno::Sequence<sal_Int8> & Graphic::getUnoTunnelId() { static const comphelper::UnoIdInit gId; return gId.getSeq(); } diff --git a/xmlsecurity/source/xmlsec/xmlelementwrapper_xmlsecimpl.cxx b/xmlsecurity/source/xmlsec/xmlelementwrapper_xmlsecimpl.cxx index 9de3930731ab..9104966185ea 100644 --- a/xmlsecurity/source/xmlsec/xmlelementwrapper_xmlsecimpl.cxx +++ b/xmlsecurity/source/xmlsec/xmlelementwrapper_xmlsecimpl.cxx @@ -33,7 +33,7 @@ XMLElementWrapper_XmlSecImpl::XMLElementWrapper_XmlSecImpl(const xmlNodePtr pNod } /* XUnoTunnel */ -uno::Sequence< sal_Int8 > XMLElementWrapper_XmlSecImpl::getUnoTunnelId() +const uno::Sequence< sal_Int8 > & XMLElementWrapper_XmlSecImpl::getUnoTunnelId() { static const comphelper::UnoIdInit implId; return implId.getSeq(); diff --git a/xmlsecurity/source/xmlsec/xmlelementwrapper_xmlsecimpl.hxx b/xmlsecurity/source/xmlsec/xmlelementwrapper_xmlsecimpl.hxx index 4e3f44527d62..de833d25a139 100644 --- a/xmlsecurity/source/xmlsec/xmlelementwrapper_xmlsecimpl.hxx +++ b/xmlsecurity/source/xmlsec/xmlelementwrapper_xmlsecimpl.hxx @@ -55,7 +55,7 @@ public: /* css::lang::XUnoTunnel */ virtual sal_Int64 SAL_CALL getSomething( const css::uno::Sequence< sal_Int8 >& aIdentifier ) override; /// @throws css::uno::RuntimeException - static css::uno::Sequence < sal_Int8 > getUnoTunnelId(); + static const css::uno::Sequence < sal_Int8 > & getUnoTunnelId(); /* css::lang::XServiceInfo */ virtual OUString SAL_CALL getImplementationName( ) override; |