loplugin:passstuffbyref in avmedia..canvas

Change-Id: I916a6431eb0720af16dcb5aa46b758f92dbe4ec4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176179
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

6 files changed, 7 insertions, 7 deletions

diff --git a/avmedia/source/framework/mediaitem.cxx b/avmedia/source/framework/mediaitem.cxx
index f587ced4241a..c2ecaa29d9bf 100644
--- a/avmedia/source/framework/mediaitem.cxx
+++ b/avmedia/source/framework/mediaitem.cxx
@@ -285,7 +285,7 @@ bool MediaItem::setMimeType(const OUString& rMimeType)
     return bChanged;
 }
 
-OUString MediaItem::getMimeType() const
+const OUString & MediaItem::getMimeType() const
 {
     return !m_pImpl->m_sMimeType.isEmpty() ? m_pImpl->m_sMimeType : AVMEDIA_MIMETYPE_COMMON;
 }
diff --git a/basctl/source/basicide/baside2.hxx b/basctl/source/basicide/baside2.hxx
index 37d7d75754a7..3006b5a76bd8 100644
--- a/basctl/source/basicide/baside2.hxx
+++ b/basctl/source/basicide/baside2.hxx
@@ -402,7 +402,7 @@ public:
     virtual bool HasActiveEditor () const override;
 
     void UpdateModule ();
-    OUString GetEditorColorScheme() { return m_sWinColorScheme; }
+    const OUString & GetEditorColorScheme() { return m_sWinColorScheme; }
     void SetEditorColorScheme(const OUString& rColorScheme);
 };
 
@@ -428,7 +428,7 @@ public:
     Color const & GetSyntaxBackgroundColor () const { return aSyntaxColors.GetBackgroundColor(); }
     Color const & GetFontColor () const { return aSyntaxColors.GetFontColor(); }
     Color const & GetSyntaxColor (TokenType eType) const { return aSyntaxColors.GetColor(eType); }
-    OUString GetActiveColorSchemeId() { return m_sColorSchemeId; }
+    const OUString & GetActiveColorSchemeId() { return m_sColorSchemeId; }
     void ApplyColorSchemeToCurrentWindow(const OUString& rSchemeId);
 
 protected:
diff --git a/basctl/source/inc/BasicColorConfig.hxx b/basctl/source/inc/BasicColorConfig.hxx
index 15b2f3faf78f..88be8a7662d8 100644
--- a/basctl/source/inc/BasicColorConfig.hxx
+++ b/basctl/source/inc/BasicColorConfig.hxx
@@ -73,7 +73,7 @@ public:
     virtual void Notify(const css::uno::Sequence<OUString>& aPropertyNames) override;
 
     ColorScheme GetColorScheme(const OUString& rScheme);
-    css::uno::Sequence<OUString> GetColorSchemeNames() { return m_aSchemeNames; }
+    const css::uno::Sequence<OUString>& GetColorSchemeNames() { return m_aSchemeNames; }
 
     // Returns the color scheme defined by the current Application Colors
     ColorScheme GetAutomaticColorScheme();
diff --git a/canvas/inc/parametricpolypolygon.hxx b/canvas/inc/parametricpolypolygon.hxx
index 474bd5da247a..511ff2baff91 100644
--- a/canvas/inc/parametricpolypolygon.hxx
+++ b/canvas/inc/parametricpolypolygon.hxx
@@ -105,7 +105,7 @@ namespace canvas
         virtual css::uno::Sequence< OUString > SAL_CALL getSupportedServiceNames(  ) override;
 
         /// Query all defining values of this object atomically
-        Values getValues() const;
+        const Values & getValues() const;
 
     private:
         virtual ~ParametricPolyPolygon() override; // we're a ref-counted UNO class. _We_ destroy ourselves.
diff --git a/canvas/source/tools/parametricpolypolygon.cxx b/canvas/source/tools/parametricpolypolygon.cxx
index d4d0a524e0e3..cb948e095277 100644
--- a/canvas/source/tools/parametricpolypolygon.cxx
+++ b/canvas/source/tools/parametricpolypolygon.cxx
@@ -226,7 +226,7 @@ namespace canvas
     {
     }
 
-    ParametricPolyPolygon::Values ParametricPolyPolygon::getValues() const
+    const ParametricPolyPolygon::Values & ParametricPolyPolygon::getValues() const
     {
         return maValues;
     }
diff --git a/include/avmedia/mediaitem.hxx b/include/avmedia/mediaitem.hxx
index 7d75b7ab4350..9836346c2159 100644
--- a/include/avmedia/mediaitem.hxx
+++ b/include/avmedia/mediaitem.hxx
@@ -121,7 +121,7 @@ public:
     const OUString&         getFallbackURL() const;
 
     bool                    setMimeType(const OUString& rMimeType);
-    OUString                getMimeType() const;
+    const OUString&         getMimeType() const;
     bool setGraphic(const Graphic& rGraphic);
     const Graphic & getGraphic() const;
     bool setCrop(const css::text::GraphicCrop& rCrop);