diff options
| author | Tor Lillqvist <tml@collabora.com> | 2020-06-04 15:06:24 +0300 |
|---|---|---|
| committer | Tor Lillqvist <tml@collabora.com> | 2020-06-16 10:06:10 +0200 |
| commit | 2db82d345145b0e568e1d0ac141849ef4246533f (patch) | |
| tree | 7c70fbc5c3fe60c11c46faba48fa4bdf5714e246 | |
| parent | e59ec35e750561a5a7b75d2b2b52e46c6ade3090 (diff) | |
tdf#128502: Add a FIXME comment
The view id concept is badly broken. Way too many wild assumptions
that the "current" view is the one we expect here and there. For
instance here.
Change-Id: Icf36808b2c09f0b3fd8070deecf175ba7f52b5f7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95508
Tested-by: Tor Lillqvist <tml@collabora.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96363
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
| -rw-r--r-- | libreofficekit/source/gtk/lokdocview.cxx | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/libreofficekit/source/gtk/lokdocview.cxx b/libreofficekit/source/gtk/lokdocview.cxx index 867166585b12..e77e0ddc8e9d 100644 --- a/libreofficekit/source/gtk/lokdocview.cxx +++ b/libreofficekit/source/gtk/lokdocview.cxx @@ -1,4 +1,4 @@ -/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */ /* * This file is part of the LibreOffice project. * @@ -878,6 +878,8 @@ static gboolean postDocumentLoad(gpointer pData) std::unique_lock<std::mutex> aGuard(g_aLOKMutex); priv->m_pDocument->pClass->initializeForRendering(priv->m_pDocument, priv->m_aRenderingArguments.c_str()); + // FIXME: This returns the view id of the "current" view, but sadly if you load multiple + // documents that is apparently not a view showing the most recently loaded document. priv->m_nViewId = priv->m_pDocument->pClass->getView(priv->m_pDocument); g_aAuthorViews[getAuthorRenderingArgument(priv)] = priv->m_nViewId; priv->m_pDocument->pClass->registerCallback(priv->m_pDocument, callbackWorker, pLOKDocView); |