diff options
author | Caolán McNamara <caolan.mcnamara@collabora.com> | 2024-10-26 19:01:01 +0100 |
---|---|---|
committer | Caolán McNamara <caolan.mcnamara@collabora.com> | 2024-10-26 21:54:56 +0200 |
commit | 0c6e26890a822c5891056f83690a477622b85c8a (patch) | |
tree | df311368ee051cc03cccc34891f65645434164e3 | |
parent | 40468f0eb08ea8f83b23cceeeaf7f4beb3ba15ed (diff) |
cid#1556875 COPY_INSTEAD_OF_MOVE
and
cid#1556891 COPY_INSTEAD_OF_MOVE
cid#1556903 COPY_INSTEAD_OF_MOVE
cid#1556917 COPY_INSTEAD_OF_MOVE
cid#1556925 COPY_INSTEAD_OF_MOVE
cid#1557021 COPY_INSTEAD_OF_MOVE
cid#1557092 COPY_INSTEAD_OF_MOVE
cid#1557119 COPY_INSTEAD_OF_MOVE
cid#1557218 COPY_INSTEAD_OF_MOVE
cid#1557342 COPY_INSTEAD_OF_MOVE
cid#1557727 COPY_INSTEAD_OF_MOVE
cid#1557800 COPY_INSTEAD_OF_MOVE
cid#1557821 COPY_INSTEAD_OF_MOVE
cid#1557830 COPY_INSTEAD_OF_MOVE
cid#1557677 COPY_INSTEAD_OF_MOVE
cid#1557674 COPY_INSTEAD_OF_MOVE
Change-Id: I20dab0c49a17c28b4feaf97440a36d4962310b29
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175686
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
-rw-r--r-- | accessibility/source/extended/AccessibleGridControl.cxx | 2 | ||||
-rw-r--r-- | chart2/source/tools/StatisticsHelper.cxx | 2 | ||||
-rw-r--r-- | comphelper/source/container/container.cxx | 2 | ||||
-rw-r--r-- | cppuhelper/source/component_context.cxx | 4 | ||||
-rw-r--r-- | framework/source/uiconfiguration/moduleuiconfigurationmanager.cxx | 2 | ||||
-rw-r--r-- | framework/source/uielement/complextoolbarcontroller.cxx | 2 | ||||
-rw-r--r-- | io/source/stm/odata.cxx | 2 | ||||
-rw-r--r-- | sc/source/filter/excel/excimp8.cxx | 2 | ||||
-rw-r--r-- | sd/source/ui/animations/CustomAnimationList.cxx | 2 | ||||
-rw-r--r-- | sfx2/source/doc/docfile.cxx | 2 | ||||
-rw-r--r-- | svx/source/form/fmpgeimp.cxx | 2 | ||||
-rw-r--r-- | testtools/source/bridgetest/bridgetest.cxx | 2 | ||||
-rw-r--r-- | unotools/source/misc/eventlisteneradapter.cxx | 2 | ||||
-rw-r--r-- | unoxml/source/dom/saxbuilder.cxx | 2 | ||||
-rw-r--r-- | unoxml/source/rdf/CLiteral.cxx | 2 | ||||
-rw-r--r-- | vcl/source/app/weldutils.cxx | 2 |
16 files changed, 17 insertions, 17 deletions
diff --git a/accessibility/source/extended/AccessibleGridControl.cxx b/accessibility/source/extended/AccessibleGridControl.cxx index 46d04780285b..483b75ed4c8f 100644 --- a/accessibility/source/extended/AccessibleGridControl.cxx +++ b/accessibility/source/extended/AccessibleGridControl.cxx @@ -163,7 +163,7 @@ AccessibleGridControl::getAccessibleAtPoint( const awt::Point& rPoint ) if (xCurrChildComp.is() && VCLUnoHelper::ConvertToVCLRect(xCurrChildComp->getBounds()).Contains(aPoint)) - xChild = xCurrChild; + xChild = std::move(xCurrChild); } } return xChild; diff --git a/chart2/source/tools/StatisticsHelper.cxx b/chart2/source/tools/StatisticsHelper.cxx index 618236d7efbd..b29e54b80122 100644 --- a/chart2/source/tools/StatisticsHelper.cxx +++ b/chart2/source/tools/StatisticsHelper.cxx @@ -200,7 +200,7 @@ uno::Reference< chart2::data::XLabeledDataSequence > StatisticsHelper::getErrorL uno::Reference< chart2::data::XLabeledDataSequence > xLSeq = lcl_getErrorBarLabeledSequence( xDataSource, bPositiveValue, bYError, aRole ); if( xLSeq.is()) - xResult = xLSeq; + xResult = std::move(xLSeq); return xResult; } diff --git a/comphelper/source/container/container.cxx b/comphelper/source/container/container.cxx index 7b2432723360..78d3d1879639 100644 --- a/comphelper/source/container/container.cxx +++ b/comphelper/source/container/container.cxx @@ -99,7 +99,7 @@ css::uno::Reference< css::uno::XInterface> const & IndexAccessIterator::Next() break; } // Finally, if there's nothing more to do in this row (to the right), we'll move on to the next row. - xSearchLoop = xParent; + xSearchLoop = std::move(xParent); bCheckingStartingPoint = false; } diff --git a/cppuhelper/source/component_context.cxx b/cppuhelper/source/component_context.cxx index 0ec1fd291de2..227affa9a619 100644 --- a/cppuhelper/source/component_context.cxx +++ b/cppuhelper/source/component_context.cxx @@ -410,11 +410,11 @@ void ComponentContext::disposing(std::unique_lock<std::mutex>& rGuard) { if ( rName == TDMGR_SINGLETON ) { - xTDMgr = xComp; + xTDMgr = std::move(xComp); } else if ( rName == AC_SINGLETON ) { - xAC = xComp; + xAC = std::move(xComp); } else // dispose immediately { diff --git a/framework/source/uiconfiguration/moduleuiconfigurationmanager.cxx b/framework/source/uiconfiguration/moduleuiconfigurationmanager.cxx index 2c8376f06cd4..155334b72ed1 100644 --- a/framework/source/uiconfiguration/moduleuiconfigurationmanager.cxx +++ b/framework/source/uiconfiguration/moduleuiconfigurationmanager.cxx @@ -821,7 +821,7 @@ void ModuleUIConfigurationManager::impl_Initialize() m_aUIElements[LAYER_DEFAULT][i].nElementType = i; m_aUIElements[LAYER_DEFAULT][i].bModified = false; - m_aUIElements[LAYER_DEFAULT][i].xStorage = xElementTypeStorage; + m_aUIElements[LAYER_DEFAULT][i].xStorage = std::move(xElementTypeStorage); } } diff --git a/framework/source/uielement/complextoolbarcontroller.cxx b/framework/source/uielement/complextoolbarcontroller.cxx index dc6868843fd8..f3a00b305701 100644 --- a/framework/source/uielement/complextoolbarcontroller.cxx +++ b/framework/source/uielement/complextoolbarcontroller.cxx @@ -110,7 +110,7 @@ void SAL_CALL ComplexToolbarController::execute( sal_Int16 KeyModifier ) { // Execute dispatch asynchronously ExecuteInfo* pExecuteInfo = new ExecuteInfo; - pExecuteInfo->xDispatch = xDispatch; + pExecuteInfo->xDispatch = std::move(xDispatch); pExecuteInfo->aTargetURL = std::move(aTargetURL); pExecuteInfo->aArgs = aArgs; Application::PostUserEvent( LINK(nullptr, ComplexToolbarController , ExecuteHdl_Impl), pExecuteInfo ); diff --git a/io/source/stm/odata.cxx b/io/source/stm/odata.cxx index 55af87271e4a..f55be79dc4c0 100644 --- a/io/source/stm/odata.cxx +++ b/io/source/stm/odata.cxx @@ -888,7 +888,7 @@ void OObjectOutputStream::connectToMarkable() Reference < XMarkableStream > markable( rTry , UNO_QUERY ); if( markable.is() ) { - m_rMarkable = markable; + m_rMarkable = std::move(markable); break; } Reference < XActiveDataSource > source( rTry , UNO_QUERY ); diff --git a/sc/source/filter/excel/excimp8.cxx b/sc/source/filter/excel/excimp8.cxx index d94e722d139e..9330189c5de9 100644 --- a/sc/source/filter/excel/excimp8.cxx +++ b/sc/source/filter/excel/excimp8.cxx @@ -130,7 +130,7 @@ public: uno::Reference< container::XIndexContainer > xElement; if ( ! ( aElement >>= xElement ) ) throw lang::IllegalArgumentException(); - it->second = xElement; + it->second = std::move(xElement); } }; diff --git a/sd/source/ui/animations/CustomAnimationList.cxx b/sd/source/ui/animations/CustomAnimationList.cxx index 3d233e39322d..99ce44b5cf50 100644 --- a/sd/source/ui/animations/CustomAnimationList.cxx +++ b/sd/source/ui/animations/CustomAnimationList.cxx @@ -928,7 +928,7 @@ void CustomAnimationList::append( CustomAnimationEffectPtr pEffect ) mxTreeView->insert(nullptr, -1, &aDescription, &sId, nullptr, nullptr, false, xEntry.get()); // and the new root entry becomes the possible next group header - mxLastTargetShape = xTargetShape; + mxLastTargetShape = std::move(xTargetShape); mnLastGroupId = nGroupId; mxLastParentEntry = std::move(xEntry); } diff --git a/sfx2/source/doc/docfile.cxx b/sfx2/source/doc/docfile.cxx index ab1900d39da2..2619b58cb48e 100644 --- a/sfx2/source/doc/docfile.cxx +++ b/sfx2/source/doc/docfile.cxx @@ -2408,7 +2408,7 @@ bool SfxMedium::TryDirectTransfer( const OUString& aURL, SfxItemSet const & aTar ::ucbhelper::Content aTargetContent( aURL, xEnv, comphelper::getProcessComponentContext() ); InsertCommandArgument aInsertArg; - aInsertArg.Data = xInStream; + aInsertArg.Data = std::move(xInStream); const SfxBoolItem* pOverWrite = aTargetSet.GetItem<SfxBoolItem>(SID_OVERWRITE, false); if ( pOverWrite && !pOverWrite->GetValue() ) // argument says: never overwrite aInsertArg.ReplaceExisting = false; diff --git a/svx/source/form/fmpgeimp.cxx b/svx/source/form/fmpgeimp.cxx index eb6414e8e7de..bc0e8e604389 100644 --- a/svx/source/form/fmpgeimp.cxx +++ b/svx/source/form/fmpgeimp.cxx @@ -135,7 +135,7 @@ namespace throw RuntimeException( u"Found inconsistent form component hierarchies (2)!"_ustr ); if ( lhsControlModel.is() ) - m_rControlModelMap[ lhsControlModel ] = rhsControlModel; + m_rControlModelMap[ lhsControlModel ] = std::move(rhsControlModel); } private: diff --git a/testtools/source/bridgetest/bridgetest.cxx b/testtools/source/bridgetest/bridgetest.cxx index 316b92c92dbd..09b2f1e9d81d 100644 --- a/testtools/source/bridgetest/bridgetest.cxx +++ b/testtools/source/bridgetest/bridgetest.cxx @@ -1245,7 +1245,7 @@ sal_Int32 TestBridgeImpl::run( const Sequence< OUString > & rArgs ) rArgs[0], m_xContext); } if (!stress) { - xOriginal = o; + xOriginal = std::move(o); break; } } diff --git a/unotools/source/misc/eventlisteneradapter.cxx b/unotools/source/misc/eventlisteneradapter.cxx index b899db5c0723..0c1cfdac5577 100644 --- a/unotools/source/misc/eventlisteneradapter.cxx +++ b/unotools/source/misc/eventlisteneradapter.cxx @@ -67,7 +67,7 @@ namespace utl _rxComp->addEventListener(xMeMyselfAndI); m_xComponent = _rxComp; - m_xKeepMeAlive = xMeMyselfAndI; + m_xKeepMeAlive = std::move(xMeMyselfAndI); } void OEventListenerImpl::dispose() diff --git a/unoxml/source/dom/saxbuilder.cxx b/unoxml/source/dom/saxbuilder.cxx index 018d2b23734b..72a75b452be2 100644 --- a/unoxml/source/dom/saxbuilder.cxx +++ b/unoxml/source/dom/saxbuilder.cxx @@ -100,7 +100,7 @@ namespace DOM m_aDocument = ownerDoc; Reference< XDocumentFragment > aFragment = m_aDocument->createDocumentFragment(); m_aNodeStack.push(aFragment); - m_aFragment = aFragment; + m_aFragment = std::move(aFragment); m_aState = SAXDocumentBuilderState_BUILDING_FRAGMENT; } diff --git a/unoxml/source/rdf/CLiteral.cxx b/unoxml/source/rdf/CLiteral.cxx index bab788093f76..b3733ff164f6 100644 --- a/unoxml/source/rdf/CLiteral.cxx +++ b/unoxml/source/rdf/CLiteral.cxx @@ -120,7 +120,7 @@ void SAL_CALL CLiteral::initialize(const css::uno::Sequence< css::uno::Any > & a throw css::lang::IllegalArgumentException( u"CLiteral::initialize: argument is null"_ustr, *this, 1); } - m_xDatatype = xURI; + m_xDatatype = std::move(xURI); } else { throw css::lang::IllegalArgumentException( u"CLiteral::initialize: argument must be string or URI"_ustr, *this, 1); diff --git a/vcl/source/app/weldutils.cxx b/vcl/source/app/weldutils.cxx index 96d08f38a600..2bd03eaead81 100644 --- a/vcl/source/app/weldutils.cxx +++ b/vcl/source/app/weldutils.cxx @@ -500,7 +500,7 @@ WidgetStatusListener::WidgetStatusListener(weld::Widget* widget, const OUString& if (!xFrame.is()) xFrame = xDesktop; - mxFrame = xFrame; + mxFrame = std::move(xFrame); maCommandURL.Complete = aCommand; css::uno::Reference<css::util::XURLTransformer> xParser |