diff options
| author | Tim-Philipp Müller <tim@centricular.com> | 2015-02-26 20:14:31 +0000 |
|---|---|---|
| committer | Tim-Philipp Müller <tim@centricular.com> | 2015-02-26 20:14:31 +0000 |
| commit | 80909fb99adee19af7de2170091f96d3f47cf3b0 (patch) | |
| tree | 6c697cb8fd0300481719e6667641dfcd44fc18b9 /ges | |
| parent | 462727d6d825b6e67119e6b8ea47d9e18cc22bdf (diff) | |
ges-base-xml-formatter: fix property setting
GstStructureForeachFunc has a gboolean return value,
and the foreach function will stop unless we return
TRUE here. This meant it was potluck whether all
properties in the structure got set or not.
Fixes setting of text overlay clip text property
in particular.
https://bugzilla.gnome.org/show_bug.cgi?id=743874
Diffstat (limited to 'ges')
| -rw-r--r-- | ges/ges-base-xml-formatter.c | 3 | ||||
| -rw-r--r-- | ges/ges-internal.h | 2 |
2 files changed, 3 insertions, 2 deletions
diff --git a/ges/ges-base-xml-formatter.c b/ges/ges-base-xml-formatter.c index 3741c41e..6f81f948 100644 --- a/ges/ges-base-xml-formatter.c +++ b/ges/ges-base-xml-formatter.c @@ -495,10 +495,11 @@ _set_child_property (GQuark field_id, const GValue * value, gst_object_unref (element); } -void +gboolean set_property_foreach (GQuark field_id, const GValue * value, GObject * object) { g_object_set_property (object, g_quark_to_string (field_id), value); + return TRUE; } static inline GESClip * diff --git a/ges/ges-internal.h b/ges/ges-internal.h index 119a58da..d5efad8b 100644 --- a/ges/ges-internal.h +++ b/ges/ges-internal.h @@ -267,7 +267,7 @@ G_GNUC_INTERNAL void ges_base_xml_formatter_add_control_binding (GESBaseXmlForma const gchar *track_id, GSList * timed_values); -G_GNUC_INTERNAL void set_property_foreach (GQuark field_id, +G_GNUC_INTERNAL gboolean set_property_foreach (GQuark field_id, const GValue * value, GObject * object);; |