summaryrefslogtreecommitdiff
path: root/drivers
diff options
context:
space:
mode:
authorPhillip Potter <phil@philpotter.co.uk>2021-07-31 01:39:26 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2021-07-31 09:21:42 +0200
commitc32641183bbcf6c000f114c010085c72b15a8796 (patch)
tree4bcd4eb429a41ade1ccbf08058a32aaf8154fb8e /drivers
parent6a6580673e0b65c45b1bf1e0c866be5de998e1dc (diff)
staging: r8188eu: remove ODM_RT_ASSERT macro definition and caller
Remove ODM_RT_ASSERT macro definition from include/odm_debug.h and its one caller in hal/odm.c, as this debug code is against best practice. Signed-off-by: Phillip Potter <phil@philpotter.co.uk> Link: https://lore.kernel.org/r/20210731003937.68615-4-phil@philpotter.co.uk Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/staging/r8188eu/hal/odm.c1
-rw-r--r--drivers/staging/r8188eu/include/odm_debug.h9
2 files changed, 0 insertions, 10 deletions
diff --git a/drivers/staging/r8188eu/hal/odm.c b/drivers/staging/r8188eu/hal/odm.c
index 49e4c8bfc6ef..9ddd8c94cc98 100644
--- a/drivers/staging/r8188eu/hal/odm.c
+++ b/drivers/staging/r8188eu/hal/odm.c
@@ -1373,7 +1373,6 @@ bool ODM_RAStateCheck(struct odm_dm_struct *pDM_Odm, s32 RSSI, bool bForceUpdate
LowRSSIThreshForRA += GoUpGap;
break;
default:
- ODM_RT_ASSERT(pDM_Odm, false, ("wrong rssi level setting %d !", *pRATRState));
break;
}
diff --git a/drivers/staging/r8188eu/include/odm_debug.h b/drivers/staging/r8188eu/include/odm_debug.h
index 73fdea598707..c11d8925952c 100644
--- a/drivers/staging/r8188eu/include/odm_debug.h
+++ b/drivers/staging/r8188eu/include/odm_debug.h
@@ -96,15 +96,6 @@
RT_PRINTK fmt; \
}
-#define ODM_RT_ASSERT(pDM_Odm, expr, fmt) \
- if (!(expr)) { \
- DbgPrint( "Assertion failed! %s at ......\n", #expr); \
- DbgPrint( " ......%s,%s,line=%d\n", __FILE__, \
- __func__, __LINE__); \
- RT_PRINTK fmt; \
- ASSERT(false); \
- }
-
void ODM_InitDebugSetting(struct odm_dm_struct *pDM_Odm);
#endif /* __ODM_DBG_H__ */