diff options
author | Bolarinwa Olayemi Saheed <refactormyself@gmail.com> | 2020-07-13 19:55:26 +0200 |
---|---|---|
committer | Kalle Valo <kvalo@codeaurora.org> | 2020-07-20 20:09:36 +0300 |
commit | 9a8ab2bfb678193f326239143290691c965faede (patch) | |
tree | 91edc7118854c355bc2813fec4d82bdb5c9b7401 /drivers/net/wireless/mediatek/mt76/mt76x02_mcu.c | |
parent | a9bf090932032bd259672814670df701ecb3ff51 (diff) |
ath9k: Check the return value of pcie_capability_read_*()
On failure pcie_capability_read_dword() sets it's last parameter, val
to 0. However, with Patch 14/14, it is possible that val is set to ~0 on
failure. This would introduce a bug because (x & x) == (~0 & x).
This bug can be avoided without changing the function's behaviour if the
return value of pcie_capability_read_dword is checked to confirm success.
Check the return value of pcie_capability_read_dword() to ensure success.
Suggested-by: Bjorn Helgaas <bjorn@helgaas.com>
Signed-off-by: Bolarinwa Olayemi Saheed <refactormyself@gmail.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200713175529.29715-2-refactormyself@gmail.com
Diffstat (limited to 'drivers/net/wireless/mediatek/mt76/mt76x02_mcu.c')
0 files changed, 0 insertions, 0 deletions