diff options
| author | Christoph Hellwig <hch@lst.de> | 2024-06-13 10:48:18 +0200 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2024-06-14 10:20:06 -0600 |
| commit | 1d59857ed2ec4d506e346859713c4325b5053da3 (patch) | |
| tree | db2c798225848d5fb12bbf64686c13ffbb4ec48d | |
| parent | 1366251a794b149a132ef8423c8946b6e565a923 (diff) | |
block: use kstrtoul in flag_store
Use the text to integer helper that has error handling and doesn't modify
the input pointer.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Kanchan Joshi <joshi.k@samsung.com>
Link: https://lore.kernel.org/r/20240613084839.1044015-9-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
| -rw-r--r-- | block/blk-integrity.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/block/blk-integrity.c b/block/blk-integrity.c index 24671d9f90a1..58760a6d6b22 100644 --- a/block/blk-integrity.c +++ b/block/blk-integrity.c @@ -247,8 +247,12 @@ static ssize_t flag_store(struct device *dev, struct device_attribute *attr, const char *page, size_t count, unsigned char flag) { struct blk_integrity *bi = dev_to_bi(dev); - char *p = (char *) page; - unsigned long val = simple_strtoul(p, &p, 10); + unsigned long val; + int err; + + err = kstrtoul(page, 10, &val); + if (err) + return err; if (val) bi->flags |= flag; |